From unknown Sun Aug 17 10:19:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 68367@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170489508713216 (code B ref -1); Wed, 10 Jan 2024 13:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jan 2024 13:58:07 +0000 Received: from localhost ([127.0.0.1]:39319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ5r-0003R5-6D for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:58:07 -0500 Received: from lists.gnu.org ([2001:470:142::17]:44900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ5n-0003Py-KQ for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:58:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYgF-0000Ck-Nw for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:31:39 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYgC-0004AY-Sa for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1704893493; x=1705498293; i=stephen.berman@gmx.net; bh=pO7P0FzEU6FHVADXKLmMePmeOhcsaD8X1RhGPFTn+do=; h=X-UI-Sender-Class:From:To:Subject:Date; b=KsvEM0T28DZMQzrhAgEulwQrR/J23X4MySLYoHACLMKbPUOLpvMU8q2mUT/LynhW 2WsM/Adpkv6Px/4cp3UyZH1HM47XwWD/Hq021TbPOdf9zUBiSlLcI91DzE7DphYov pQE5AczHHi9Y7YWjCIOrTm+GZJTU+YInQKaaY4hsyD5gAu4+n59efjWe9lWE2VgBU HXp6rxi55CegXIcZwglUH9JUIyPDNPUEBKE3nY7HeJ945D55StVKgpzESvdNqlUFp hIk71ZyI0u0k09UBV+FXEtTdhpPe+hsRIbKTWn2i98BU9qSwovtycmB0dIkqG/495 LHSNYMwbkMMEExVPoQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([89.246.37.31]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJVDM-1rd1AL0wky-00Jpmi for ; Wed, 10 Jan 2024 14:31:33 +0100 From: Stephen Berman Date: Wed, 10 Jan 2024 14:31:32 +0100 Message-ID: <87o7dtmi17.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:nc7QurvtF6d+aD/sMjcLYY2D0s3kuUGgEGgOOmwcomGhZSMibPw EzuDHijXkfLiknEIaMw/puZ9ZxIMXfMR2SINnx78ntyxmLpEEtaw+DhguwwSeRqql0I96HF ABQHXTh0P8XhEMUAZMshY1/tJr+BP71R1BjbBXiYXKcyPpiy7U/oaKCu+50fmssS+yv+dk0 rxuxQb9jKRlyt6zDg8cmQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:mDSumuet3ng=;xQcqIaCi8Ymb3beNxOiL10mNA0C c26ubQZc0ZCZ3IizYgqMJYr2LMCIe4y/zl20DbKb3e5wARswGx+fU4ELUUm21g3Ufx0D1ozo2 /2LpyvzRdgYxq49GcbOBrKmpw6DJsxl50hNoyxJDeGp6HLfTLrzTASDa11on3rUMjqS69CNlu DRv6hXabGkBI02xI4Bej7zRH3+oAkhyManfhlfuwj8R2+vAu/xfDlc+6IlT+zFNNSneGG4Hp5 qTayDbRxQlGDFwcWoeGmHbwzqKZXVEdfzLwvF2V4q+Z7jBzMGhRNVipYziYAlDRrejKYr51qr iJ1EZY1ECPMxP4GV2BE91M22yZ5FgRq63aProHHOTg/eaE2gVqteMwaqWev+s0270nVUNdIz0 i8tmJB8BNr9BHyNL3dFdatQhH5PYoaUdIu22O38jbvvNjZiXQjYVFc4Yg6NGLpWeq8D9ARZTF tw7udt22HbU/dtxOoElsu1pO8HeISXjrpSiWwYuS/e8q/am37XjudguJvwaEdePCYEE8Hm7Uz ampUE2Q9bIMmGB/zTP2YauzXexjehOkRRBvwzV0F0TvamweASf2YAKCbl48nvoqXLA4yX8pej F853+L+TeblQKj+MY4dF0GE7MyMRmQKvjYrQqD/XKrmAaZ4fNTBd0vPFh8/BfYY1ZYzRZnz+j xqqT2AYMVi6xIWCSdzlOzZ/qskYKn3xml7d33k9CgfN+ta6WThTrkHS0p1oDKTAH479EpUol3 fWW/ykf/4WZL90lR2DoojRPywXtriUHCwBaMni7pQFxVu7KGTaUfb2o4Qh0bZ8+aQkKwpiaJt OrY+z16p+yWkQILBQza9gWRkLXYmAvAc6i4/PjYmU9xx8pyh34Vw9erUjwFa1I4t1O+o3adU2 2zYqPglpwg1ZRxVkViG7rx+E/pNOy5iMt1xa7PefyXnxp3lGIPmkhnmnn+uhTP0a2mjC21eNl YotV9A== Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain My /etc/fstab file contains a line for the file system cgroup2 (i.e. for cgroup v2 instead of cgroup for cgroup v1). I just learned about etc-fstab-generic-mode and after loading generic-x and visiting /etc/fstab, I saw that in the line for cgroup2, the entry in the type column is fontified in the default face, not in font-lock-keyword-face, unlike all other file system types in my /etc/fstab file. This patch fixes the misfontification: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: etc-fstab-generic-mode patch diff --git a/lisp/generic-x.el b/lisp/generic-x.el index b4ae0225943..373bfad92dd 100644 --- a/lisp/generic-x.el +++ b/lisp/generic-x.el @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode "cd9660" "cfs" "cgroup" + "cgroup2" "cifs" "coda" "coherent" --=-=-= Content-Type: text/plain While the misfontification isn't a regression -- the support for cgroups (but only for cgroup v1) in etc-fstab-generic-mode was added in January 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e., omitting cgroup2 was presumably an oversight in that commit. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.18.0) of 2024-01-09 built on strobelfs2 Repository revision: fccaeabc959f5403ce49744030bd2620352b59f8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101009 System Description: Linux From Scratch r12.0-112 --=-=-=-- From unknown Sun Aug 17 10:19:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman , 68367@debbugs.gnu.org Cc: Eli Zaretskii Received: via spool by 68367-submit@debbugs.gnu.org id=B68367.170489853829063 (code B ref 68367); Wed, 10 Jan 2024 14:56:02 +0000 Received: (at 68367) by debbugs.gnu.org; 10 Jan 2024 14:55:38 +0000 Received: from localhost ([127.0.0.1]:39888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZzW-0007Yg-Df for submit@debbugs.gnu.org; Wed, 10 Jan 2024 09:55:38 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:45459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZzT-0007YR-M0 for 68367@debbugs.gnu.org; Wed, 10 Jan 2024 09:55:36 -0500 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50ea9e189ebso4409806e87.3 for <68367@debbugs.gnu.org>; Wed, 10 Jan 2024 06:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704898531; x=1705503331; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ODZyM2izkMUcZg/3n/DggVBkIitU+glZc25KzSqb2dA=; b=SCA2MPYypsqo3MQUogj1gubCzFpoEhXotMoNtYj7UXp6013S1CtD3e1xOWz3I692fB 1ddkI4oFVmupV4+AW+OjoojlnPcyv3Bcmrui+YQEhKigib71SIHKnYNVe9erzHNbp307 H42snCjW4BvP4rgcnBS0J0srw4wYTlYmC++J2qJZp34++vHby0Qx4FEHTschjam22dRV Lil1y32HzqfHhtHm2weQYJHej64L0tp3Z7870TJkQjgQDRz+8OZy1QX+6OamiaEYmsIu r/ldSG8hKwOzJiqGOsu06Qcm7BjclWTqssPfxfSZRCIHtTnNu5PsOOobyu/OC2OQc61w 6OJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704898531; x=1705503331; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ODZyM2izkMUcZg/3n/DggVBkIitU+glZc25KzSqb2dA=; b=ZMkYqs3R1CZlMMBN6ODNbZlZUsOaIEvIuFekwwYYQF9qXyyFlo+F/l78Zk7GgwXor5 9guds2zEKIfeed9iCvcXmLYBUex7XJjOc2Q5sUT5lqgaggMtW3MmT8/7uC+aEYD1Mf1F 4tPZrGSDeZNgDQsQjn4qCG2BdN/4t+vAbtoWRW8yqCzdJ37YOeyoVMcuWtYEBmKW4yQk wQBstxc2CTChLgQmF99gg0KDssDdPQ3EzWDz44CuECqDuoqA7Ik7eBZ9DXmqlifmURTB NATHSKWGOaWpEFTDtNXshPQEorNImAiEsZOk1Z5TwtuEYafCc678M2OrmKv13LEHE6/A ecVg== X-Gm-Message-State: AOJu0Yy9BwXjWPlRYfQFZ3yW76SEV3XH/E2wSPE04nUMN3mr7Z5hD52p DDjlp50IEf6tRTPZI9xKHfm6zRtsAo3t4WYmoP4= X-Google-Smtp-Source: AGHT+IFHibqa53wfIbh5w07B1bPT44RfQTKKVsgErICEGkl+D4XxXR0ijhjhJe0dTuYQ5fTk4wH0lQFOXxiyfWtGYwg= X-Received: by 2002:ac2:4959:0:b0:50e:6bf0:49c9 with SMTP id o25-20020ac24959000000b0050e6bf049c9mr438710lfi.53.1704898530778; Wed, 10 Jan 2024 06:55:30 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 06:55:30 -0800 From: Stefan Kangas In-Reply-To: <87o7dtmi17.fsf@gmx.net> References: <87o7dtmi17.fsf@gmx.net> MIME-Version: 1.0 Date: Wed, 10 Jan 2024 06:55:30 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > My /etc/fstab file contains a line for the file system cgroup2 (i.e. for > cgroup v2 instead of cgroup for cgroup v1). I just learned about > etc-fstab-generic-mode and after loading generic-x and visiting > /etc/fstab, I saw that in the line for cgroup2, the entry in the type > column is fontified in the default face, not in font-lock-keyword-face, > unlike all other file system types in my /etc/fstab file. This patch > fixes the misfontification: > > diff --git a/lisp/generic-x.el b/lisp/generic-x.el > index b4ae0225943..373bfad92dd 100644 > --- a/lisp/generic-x.el > +++ b/lisp/generic-x.el > @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode > "cd9660" > "cfs" > "cgroup" > + "cgroup2" > "cifs" > "coda" > "coherent" Thanks, but could you please reformat this using `git format-patch -1`? > While the misfontification isn't a regression -- the support for cgroups > (but only for cgroup v1) in etc-fstab-generic-mode was added in January > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e., > omitting cgroup2 was presumably an oversight in that commit. I don't really have an opinion, but sounds good to me. Eli? From unknown Sun Aug 17 10:19:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 68367@debbugs.gnu.org, stephen.berman@gmx.net Received: via spool by 68367-submit@debbugs.gnu.org id=B68367.170489927910408 (code B ref 68367); Wed, 10 Jan 2024 15:08:01 +0000 Received: (at 68367) by debbugs.gnu.org; 10 Jan 2024 15:07:59 +0000 Received: from localhost ([127.0.0.1]:42471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaBT-0002ho-2A for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:07:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaBR-0002hc-1Y for 68367@debbugs.gnu.org; Wed, 10 Jan 2024 10:07:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNaBK-0007hH-Va; Wed, 10 Jan 2024 10:07:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uph0fVrbsUARvws47NPIHw0gLH+CO7jdOwtrtJYFPNQ=; b=VWzOtKlcwCVL 8mG/eHZGzclLL11OeUSBlKY0k/qAnzy4FaIIQuedJmwC6vHkwSyN+iGRcBsvU4jGcHKnbYlNsYKy+ kZonsi2YxY1u1g7iqBLF4W0EjLJOQjCa/bluTJctAv5lpRyP3MzWWjSky5tBOK5BwszYyzUrX+Y0C hfUJBGQ/F4W3ZHaYIUYcPPZqgEtS3LnJ5Pgqsa2auOvHhYpsp4NbmF9C8jUVf796XPlgeF32IvXhM mHOB84RHJBPovJbmI3ShOqOkoHilzwu5VFvUla+uQnmuuehIStfOxaFslGr/C8KWlexqrNYBoK7nJ BMyO4RXFQL/ul6buvMSabg==; Date: Wed, 10 Jan 2024 17:07:26 +0200 Message-Id: <83v881mdld.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Wed, 10 Jan 2024 06:55:30 -0800) References: <87o7dtmi17.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 10 Jan 2024 06:55:30 -0800 > Cc: Eli Zaretskii > > Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > While the misfontification isn't a regression -- the support for cgroups > > (but only for cgroup v1) in etc-fstab-generic-mode was added in January > > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup > > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e., > > omitting cgroup2 was presumably an oversight in that commit. > > I don't really have an opinion, but sounds good to me. Eli? I don't mind adding this to emacs-29. Thanks. From unknown Sun Aug 17 10:19:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: Eli Zaretskii , 68367@debbugs.gnu.org Received: via spool by 68367-submit@debbugs.gnu.org id=B68367.170490039122266 (code B ref 68367); Wed, 10 Jan 2024 15:27:02 +0000 Received: (at 68367) by debbugs.gnu.org; 10 Jan 2024 15:26:31 +0000 Received: from localhost ([127.0.0.1]:42498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaTO-0005n4-P0 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:26:31 -0500 Received: from mout.gmx.net ([212.227.15.19]:39019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaTL-0005mc-Up for 68367@debbugs.gnu.org; Wed, 10 Jan 2024 10:26:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1704900382; x=1705505182; i=stephen.berman@gmx.net; bh=ccEZEULkX1GVpOYKoYGlxhz7fr08I13l2ofIl5ARkkw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=rwINlL9E151iECpv++VeI8hSgKQu1Hq4usNuim2rKy/8pOHWX4zNlq24rZtDXVFe jakL+G5AL2tNhHuBOPyYvmGv/2rTq2T+npB1peoQRyAVu+0N1ryw2Qb1RBV/Xkjy3 BXyPy4riB9ryPUVmSfl+xQo9jqxVlh9W/MTD4fDzuAjhqeA7R7g3i5zmvFAeTn21Q gREKefQ0f2tObjj9vI1UFjhzmyfdDr8uTmYKRoHzJpJuYCaalNMGE4jgz3s7a8Us4 nGVABw1r76XSBdKzTuSOIj0LGV/2OKungn4F9OkI0lnATnEdpHcr5crnfhRsk7zsd 5+dRPG+q19ZA9bmuCQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([89.246.37.31]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MN5eR-1reQOp1xQL-00J3nc; Wed, 10 Jan 2024 16:26:22 +0100 From: Stephen Berman In-Reply-To: (Stefan Kangas's message of "Wed, 10 Jan 2024 06:55:30 -0800") References: <87o7dtmi17.fsf@gmx.net> Date: Wed, 10 Jan 2024 16:26:21 +0100 Message-ID: <87jzohmcpu.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:4a1xFaCDIdK6FTtIv4E/iNUOZIKwjo172zub8/nWmqg7zulxm8d wFPjip8n+VyNpRYWGoS65gUQOeYYhqRpE3sVfYc6RrgTUIVNmGDvyPpl/kcQb/AW/gVZKhV qehk5zb6ptV4h9it94Bne5lgWbLO1I8dyIKPbDs7cV4pdDg42c1rHyT+hD1ar27Io8anmMq MtM9E7fXZ2lAykIBW0wfA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ArZ4exDyHGo=;Lat+R13A/BhP6kgz/EZ7QZZro2R yvzqsJZR1KmsSkG6Hk5qcwDV0AK7AyiiCZNruyvLj7Tk7f9yA9h4Ceow/rFEqYbLLtxm4RIWE MxTLeRL8yBRyVSn80onMETxsp8freqni5RpvJBTR6WQiRryec8KLsbzJIZ0C5qhOXGfyFBMCU VhVrNADea/i5lugJqIbppPcPhhVFV4JZXmbDHMt3ScNSINck2DUwAiBU34FeUX8YfI7SAdVlb XXs44eKGJcFWOxhYQ8JnO6O4e50g65uJbhnvTWJJ/fJtrp3aEfzI2ijYQXtcJeN7g1RiB5yzH QOqNrBuZA7iHYK7+tPZ0BRh0kJJpDGDo1QAnLRwlHlJ0Z0Tpicwh7hmgyE+BJR6TjmRMpzRGg T1GHe8q7WoKlYiGsbYAMwsrXxQ9GHM6PcHWPx4+LruBlQtpkdVq8SGv5/jNUbNNsDDHYlF5Qn eAmbnqkZ7ztuAH68PEiOsfhSCNm6ixMiKH2znXZO8x3KpGeaStaIwglBEZ4bgj0vP1NuLAneU s2hSQlHxBeuLsmoqfFdfJh+LgJxvrHHratQE9qvjtsDBfu5ERswrsaPoyzJfPx51BTMcoYGus S7zwxjFqONnG529cEmYdpBVxC8CyK1/urB1CV3lRlOQetYzJUd8ZX/7hB9INMKZUqz4q14l9f iBJcNpGFHMvrWeL4Ltd8ZmEpRIjbOGW6toPJ+yzXnpXKZS7PVY2VBabcHwW0YHUoh2qqFXM1k 8HmMrr6+cXMcdobBkP0gIeFmJ+TFShoMvBchijRvFJfrM3YrZuBG+TpmAcqFyCXvxAEj5FRvu aiL4pFCAYa/M5eZqZXduZRIfyeHWw+XXRGIlyjPkLc4qWpD/1UHGm26W3QN5ycwwrxVFlGVWI GMJ8mdMzvKJbekKRLzQ9VXXsyawdEKLYkk5RbTq2FcpzkCr5nFuJfa+wJioldLLeLgnsF8ctF zbW+VA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas = wrote: > Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >> My /etc/fstab file contains a line for the file system cgroup2 (i.e. fo= r >> cgroup v2 instead of cgroup for cgroup v1). I just learned about >> etc-fstab-generic-mode and after loading generic-x and visiting >> /etc/fstab, I saw that in the line for cgroup2, the entry in the type >> column is fontified in the default face, not in font-lock-keyword-face, >> unlike all other file system types in my /etc/fstab file. This patch >> fixes the misfontification: >> >> diff --git a/lisp/generic-x.el b/lisp/generic-x.el >> index b4ae0225943..373bfad92dd 100644 >> --- a/lisp/generic-x.el >> +++ b/lisp/generic-x.el >> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode >> "cd9660" >> "cfs" >> "cgroup" >> + "cgroup2" >> "cifs" >> "coda" >> "coherent" > > Thanks, but could you please reformat this using `git format-patch -1`? On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii wrote: >> From: Stefan Kangas >> Date: Wed, 10 Jan 2024 06:55:30 -0800 >> Cc: Eli Zaretskii >> >> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" writes: >> >> > While the misfontification isn't a regression -- the support for cgro= ups >> > (but only for cgroup v1) in etc-fstab-generic-mode was added in Janua= ry >> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgr= oup >> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.= e., >> > omitting cgroup2 was presumably an oversight in that commit. >> >> I don't really have an opinion, but sounds good to me. Eli? > > I don't mind adding this to emacs-29. > > Thanks. Instead of resending the patch I just went ahead and installed it to emacs-29. Steve Berman From unknown Sun Aug 17 10:19:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman , 68367@debbugs.gnu.org Cc: Eli Zaretskii Received: via spool by 68367-submit@debbugs.gnu.org id=B68367.170490044622372 (code B ref 68367); Wed, 10 Jan 2024 15:28:02 +0000 Received: (at 68367) by debbugs.gnu.org; 10 Jan 2024 15:27:26 +0000 Received: from localhost ([127.0.0.1]:42503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUI-0005ol-52 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:26 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:56808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUF-0005oX-Oj for 68367@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:24 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-55642663ac4so4851125a12.1 for <68367@debbugs.gnu.org>; Wed, 10 Jan 2024 07:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704900439; x=1705505239; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=NbMNMU8yKucjCQJIepP6WDJwzigWPDdg9r9Jm/L3jFE=; b=Ecid2os/FT3TS0LBFCRdGkbaSBPP/gG2BFzyQOHc6Ltu5z/P434kxoOEhHM0Pto2Bj MKOVNey0uSDdH/2Li8Q551jel2/wZY7oxw6cyLUfJb9jacPMQai07hlXLu6n757DTR/4 EbtyJUYjvgCYaowQoJCwcRZwa2XyDUCH+G78rPNjj3Il8MiqZyucDlytspGDFfkEkCLD 57IniQ7Z1EthrWOthrJ0itrKtAXu+fu8spOGx0qs7kXtPDJwI4pf3TuauJxV+w4Z9Th+ 96E5ly0eB7hMGfyex9Om0/1TnGyd0rPplYt+O1D6HItyzr8PmorgdJA0tlPU6WvutGSj hPpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704900439; x=1705505239; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NbMNMU8yKucjCQJIepP6WDJwzigWPDdg9r9Jm/L3jFE=; b=uPX2mqkHPpCRfCHUtgaKDYyHVTpD2yO83mH0Hk3TonnD5scaALmP6lQAOFLyrSSt+D 5oDBu2XKUUSzg2l9wI9/M6quqRLlsDIH1xCcImgYnz5c6v9wbM11HK2LfulC+48hHgDS il49XdWPdzmmgjfoggbOmqBddtecNW8oq5LtnDr1IrZyw1G9VCBPqmBD2iyH59lEIt05 DolmbFPLXzBfZ4XqpltbQq2KaFSGtr+FBk7UPljRucVHwGKBkX8Fwo3z4BVVSBKmoIc6 xi4IT0GbVU5gCwKfTae4DOCRtCNPfuOB4oKOp5CTuBEX4vWr9QV/4osABDEvZhYG/Rbo RNrQ== X-Gm-Message-State: AOJu0YyJttX4Qi3ffMJIfCOYN3ffx6bkgl6uT1/fnT09ClZR0ZPyvqCR k9x+7gWDzGtLSu2ysNN0YPGbLoPkxur2ChU8Hig= X-Google-Smtp-Source: AGHT+IFM17LMWurrnm4URlXVmk0KAL7V4cJoF6HtZeJd6HQpiQVtEZ9lB5kOooIB/1syDsNtJy3Gm08wrGxTwht4RIg= X-Received: by 2002:a50:cd41:0:b0:557:aff:2de8 with SMTP id d1-20020a50cd41000000b005570aff2de8mr592682edj.19.1704900439349; Wed, 10 Jan 2024 07:27:19 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 07:27:19 -0800 From: Stefan Kangas In-Reply-To: References: <87o7dtmi17.fsf@gmx.net> MIME-Version: 1.0 Date: Wed, 10 Jan 2024 07:27:19 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Thanks, but could you please reformat this using `git format-patch -1`? Ah, I forgot you have commit access. My bad. So please just install this on emacs-29. Thanks in advance. From unknown Sun Aug 17 10:19:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 15:28:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Eli Zaretskii , 68367@debbugs.gnu.org Received: via spool by 68367-submit@debbugs.gnu.org id=B68367.170490047722447 (code B ref 68367); Wed, 10 Jan 2024 15:28:03 +0000 Received: (at 68367) by debbugs.gnu.org; 10 Jan 2024 15:27:57 +0000 Received: from localhost ([127.0.0.1]:42514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUn-0005pz-67 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:57 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:57403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUl-0005pl-5t for 68367@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:55 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-557dcb0f870so3154706a12.2 for <68367@debbugs.gnu.org>; Wed, 10 Jan 2024 07:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704900470; x=1705505270; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=D91umWHk4tSNY8PQ3vyW2lxzyEEEeQO2v0ZKefjEzEU=; b=HNaN69vNAvLZWYcnB/Hv6QweapKqntw3tCQw2chtf21nrOU3MlrJC7yA02zMvPoX98 10SctyU9uwxmKD5CZC57R1vHOErDAnrX6vrPHaDecovlkjiyePH1XJF9VEouQjrWQIDf dOnl9KCacx1vyppFg+jXtQT/PAfk+YvICz4Y6Zsw0rLFmXm2FDMjH9Xc4mrf9Jq+0b5D PRvG/d+v1Ky4JIk4iBbRw1TKAAbXHtBu/vOhzI/JLiKd9oHGU/kM1jNNptkQfPnLZbwE XD6EbDI5afEC2cvPCpJqhAmWXu4tUCvmU/HWhLDmynp2v8lIPJlIoPbMO+FN7Tm9ilud FHDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704900470; x=1705505270; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D91umWHk4tSNY8PQ3vyW2lxzyEEEeQO2v0ZKefjEzEU=; b=jU9PgO/mqTwsVgrR/WPMhfdad5/XU3zLhm3h4Qf9UnF3Ew1gxREufI5lvElND8DDbB KF1BJth5p24cQKSa74u+tFRCW/ntQdtXBuIRSkMnGHKG+IprBtrAC6bgUbHd+XB/d7rO PZiKemN+j+i+dSssBrE2/TEIIadcFd2jV/YXa14PJyuzkyPfdMl9QgTc7/g2aNcqJ1k9 uu6rqdhM5Jxd586UsA3oQ/2kCpyww0IdYvXILxJX1B7knygO5NyRo2pctPuznrm4GZ+Q uFQCgJSA1NnOa1Suw3lT6SQGLZtEbxPXwZeKhSvOvizbDU4dIym3Effci5O9krv8uoQu y+MQ== X-Gm-Message-State: AOJu0Yz+7JtZsC/wCr2RbaetgzcEv6bsdBmKI9KTrMwDmJcpFMgqwJMS TExi2KelNH0rs3b3D9LXH2cMwwuNg745QObUXi8= X-Google-Smtp-Source: AGHT+IHKck5ssIG2D6NPAyCqOWUJM3qwKIifTAvT5MSmdwMWepxDVXlix39h7lQ0YE0Gaz4HZWyTYFEA2gJq6D2bk5k= X-Received: by 2002:aa7:c691:0:b0:557:c93a:d726 with SMTP id n17-20020aa7c691000000b00557c93ad726mr555795edq.53.1704900470607; Wed, 10 Jan 2024 07:27:50 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 07:27:50 -0800 From: Stefan Kangas In-Reply-To: <87jzohmcpu.fsf@gmx.net> References: <87o7dtmi17.fsf@gmx.net> <87jzohmcpu.fsf@gmx.net> MIME-Version: 1.0 Date: Wed, 10 Jan 2024 07:27:50 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > Instead of resending the patch I just went ahead and installed it to > emacs-29. Thanks! From unknown Sun Aug 17 10:19:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephen Berman Subject: bug#68367: closed (Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2) Message-ID: References: <87cyu9mco6.fsf@gmx.net> <87o7dtmi17.fsf@gmx.net> X-Gnu-PR-Message: they-closed 68367 X-Gnu-PR-Package: emacs Reply-To: 68367@debbugs.gnu.org Date: Wed, 10 Jan 2024 15:28:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1704900483-22482-1" This is a multi-part message in MIME format... ------------=_1704900483-22482-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 68367@debbugs.gnu.org. --=20 68367: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68367 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1704900483-22482-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 68367-done) by debbugs.gnu.org; 10 Jan 2024 15:27:27 +0000 Received: from localhost ([127.0.0.1]:42506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUJ-0005oy-Gj for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:27 -0500 Received: from mout.gmx.net ([212.227.15.19]:55371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUI-0005ob-Aa for 68367-done@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1704900441; x=1705505241; i=stephen.berman@gmx.net; bh=GxXQR5RS9dbVD1NTV+nhsS8BLFtQPLvzm0J+dBcwCUs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=SLGrynuluAPOWla46r6OjEVi5TbcPRHrpljEKncNWbPjF2DHIWcb+/0NES8Iax4d z7xF796rj/Szs6VDZuVQVKop6sfRjJmbto2Pc2J8+R7qwbuxg5sZFVZ+Oyo0RBY0X O/5SSITWvV5MfZw+uROo3KV49WJD+2HvcZDdQsXxnrPj+i+/qpJATQ/Vz47PaeUhF L9Ls51pDwWijkoMCDFKadZCAnbQzlLeor1kxzz68hOPn+Tqpw4FyWoGV1Ch6u+2n3 NVVhyb+GSyc2hilwOqD5/3PA2Wg3MLPpokst5dP70lK8eN/hPFxE48LnW5Tg9bfk4 78FBEBnpzh9P8aAr/w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([89.246.37.31]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mq2j2-1qs35v2YPi-00n9tT; Wed, 10 Jan 2024 16:27:21 +0100 From: Stephen Berman To: Stefan Kangas Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 In-Reply-To: <87jzohmcpu.fsf@gmx.net> (Stephen Berman's message of "Wed, 10 Jan 2024 16:26:21 +0100") References: <87o7dtmi17.fsf@gmx.net> <87jzohmcpu.fsf@gmx.net> Date: Wed, 10 Jan 2024 16:27:21 +0100 Message-ID: <87cyu9mco6.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:jUKigX9gBFu/EbiSJ06DKrF+6S7+7+NgDb9ssL6Cia/mXwdx8iS ddvF7zEi5yqMoNh8qBdRa9IC055mS5gyndfStNr6qRKRRvy3wrqGbBjeecEPDbtQZNn5sOn LSexe8KsENpNB43qRquHPMS9SJUOSSOyxp6Z7P7FybNsja7ZepVEB4+UIV/7RIX3vLVzC8+ G4IXWL/ZAEPWMXGHM268Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tUxv6RyM76U=;L/5No8XNwA/hpSQ+jKi229wTFDp IwWOeeEkYbD5drKNcSoySU0nSiimFEH8kDWPqLmuHGbvMc+1EZJXZaFLooMX9TSFIyf007PHI cZAwOLXNnYOuESwrIoSLPVzVgj8unz1PptbQLpdzvFDlAPemAgItpxvWEpOc2WV06muRAWw4B bXbN380YoatXuI1dyCijUY8Hw+Hwy8RQypD546HJNM/1cBu/vqeXJ9FYz/jhFbV/AkVOWx35o GvCaeTNVecKJCUQEToB+rExPIqb81VXYJUH5xY2h2ublshoZQsGkDC3hcUGNUlv+O9F0eMVkn 59aX5RYxe1KT2aNpam8X86GtEZL584OmVq2+r/1YLb2FZaEcMiF0sKM+I1QddSlgUavfu2H7g XSZj1XkGJxrQKwav6jz5JwGNwNU8K+gxCc+oebbppxix7r+Bq5FX4W3rRaN82zoIVaoHGVkEK e+1XAi5tpGFM7DlR7tFHTKtdwsQeBZ8wT1BRx5Iz19XSFRzpUFpUQ19H3ecfkFHM9xZ0jJ6e4 RlE3KfVDhZWjR+UZfHONwBufPYKLkBqQRdYOEYryXkpysfeyy6D3EzaHwNS6/6PrTRwP082bs nbcpiUFNwxC3userj/KL0GPQPLYPMfGhzyteFo3462icB3qnQnHyBoIf5+xOqw0crye7R6bld 7zF1+AH54Nufvn7MGKPd+bQCiWvuGMnCZC/itBV4pNv4nWt9nRkf9/MOH5LFIQEti6fKGRGL6 /OoThp/xSJbwoDhtMb3yfli+BG1J3aNgML7wrNbec1rbG7Yr4LmzkGnY1eeQCcGwH7EOKNwWl gmNb4R8r+SX0OetwHZVlIw0qe6MYHrFW7cihLyJUbzlYz3MHXpAWkwp0mODNtzLKcAca15Yek p7DTNBTTuwNdZNxJyk/422kknVfDP7Sy2lyPBCaXNb6Tsf+f/8pAJIOmGc9+j08/N3UvNhWDt fsokcA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68367-done Cc: Eli Zaretskii , 68367-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 10 Jan 2024 16:26:21 +0100 Stephen Berman = wrote: > On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas wrote: > >> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" writes: >> >>> My /etc/fstab file contains a line for the file system cgroup2 (i.e. f= or >>> cgroup v2 instead of cgroup for cgroup v1). I just learned about >>> etc-fstab-generic-mode and after loading generic-x and visiting >>> /etc/fstab, I saw that in the line for cgroup2, the entry in the type >>> column is fontified in the default face, not in font-lock-keyword-face= , >>> unlike all other file system types in my /etc/fstab file. This patch >>> fixes the misfontification: >>> >>> diff --git a/lisp/generic-x.el b/lisp/generic-x.el >>> index b4ae0225943..373bfad92dd 100644 >>> --- a/lisp/generic-x.el >>> +++ b/lisp/generic-x.el >>> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode >>> "cd9660" >>> "cfs" >>> "cgroup" >>> + "cgroup2" >>> "cifs" >>> "coda" >>> "coherent" >> >> Thanks, but could you please reformat this using `git format-patch -1`? > > On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii wrote: > >>> From: Stefan Kangas >>> Date: Wed, 10 Jan 2024 06:55:30 -0800 >>> Cc: Eli Zaretskii >>> >>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of >>> text editors" writes: >>> >>> > While the misfontification isn't a regression -- the support for cgr= oups >>> > (but only for cgroup v1) in etc-fstab-generic-mode was added in Janu= ary >>> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cg= roup >>> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i= .e., >>> > omitting cgroup2 was presumably an oversight in that commit. >>> >>> I don't really have an opinion, but sounds good to me. Eli? >> >> I don't mind adding this to emacs-29. >> >> Thanks. > > Instead of resending the patch I just went ahead and installed it to > emacs-29. And now closed the bug. Steve Berman ------------=_1704900483-22482-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Jan 2024 13:58:07 +0000 Received: from localhost ([127.0.0.1]:39319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ5r-0003R5-6D for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:58:07 -0500 Received: from lists.gnu.org ([2001:470:142::17]:44900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ5n-0003Py-KQ for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:58:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYgF-0000Ck-Nw for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:31:39 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYgC-0004AY-Sa for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1704893493; x=1705498293; i=stephen.berman@gmx.net; bh=pO7P0FzEU6FHVADXKLmMePmeOhcsaD8X1RhGPFTn+do=; h=X-UI-Sender-Class:From:To:Subject:Date; b=KsvEM0T28DZMQzrhAgEulwQrR/J23X4MySLYoHACLMKbPUOLpvMU8q2mUT/LynhW 2WsM/Adpkv6Px/4cp3UyZH1HM47XwWD/Hq021TbPOdf9zUBiSlLcI91DzE7DphYov pQE5AczHHi9Y7YWjCIOrTm+GZJTU+YInQKaaY4hsyD5gAu4+n59efjWe9lWE2VgBU HXp6rxi55CegXIcZwglUH9JUIyPDNPUEBKE3nY7HeJ945D55StVKgpzESvdNqlUFp hIk71ZyI0u0k09UBV+FXEtTdhpPe+hsRIbKTWn2i98BU9qSwovtycmB0dIkqG/495 LHSNYMwbkMMEExVPoQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([89.246.37.31]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJVDM-1rd1AL0wky-00Jpmi for ; Wed, 10 Jan 2024 14:31:33 +0100 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 30.0.50; etc-fstab-generic-mode is missing cgroup2 X-Debbugs-Cc: Date: Wed, 10 Jan 2024 14:31:32 +0100 Message-ID: <87o7dtmi17.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:nc7QurvtF6d+aD/sMjcLYY2D0s3kuUGgEGgOOmwcomGhZSMibPw EzuDHijXkfLiknEIaMw/puZ9ZxIMXfMR2SINnx78ntyxmLpEEtaw+DhguwwSeRqql0I96HF ABQHXTh0P8XhEMUAZMshY1/tJr+BP71R1BjbBXiYXKcyPpiy7U/oaKCu+50fmssS+yv+dk0 rxuxQb9jKRlyt6zDg8cmQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:mDSumuet3ng=;xQcqIaCi8Ymb3beNxOiL10mNA0C c26ubQZc0ZCZ3IizYgqMJYr2LMCIe4y/zl20DbKb3e5wARswGx+fU4ELUUm21g3Ufx0D1ozo2 /2LpyvzRdgYxq49GcbOBrKmpw6DJsxl50hNoyxJDeGp6HLfTLrzTASDa11on3rUMjqS69CNlu DRv6hXabGkBI02xI4Bej7zRH3+oAkhyManfhlfuwj8R2+vAu/xfDlc+6IlT+zFNNSneGG4Hp5 qTayDbRxQlGDFwcWoeGmHbwzqKZXVEdfzLwvF2V4q+Z7jBzMGhRNVipYziYAlDRrejKYr51qr iJ1EZY1ECPMxP4GV2BE91M22yZ5FgRq63aProHHOTg/eaE2gVqteMwaqWev+s0270nVUNdIz0 i8tmJB8BNr9BHyNL3dFdatQhH5PYoaUdIu22O38jbvvNjZiXQjYVFc4Yg6NGLpWeq8D9ARZTF tw7udt22HbU/dtxOoElsu1pO8HeISXjrpSiWwYuS/e8q/am37XjudguJvwaEdePCYEE8Hm7Uz ampUE2Q9bIMmGB/zTP2YauzXexjehOkRRBvwzV0F0TvamweASf2YAKCbl48nvoqXLA4yX8pej F853+L+TeblQKj+MY4dF0GE7MyMRmQKvjYrQqD/XKrmAaZ4fNTBd0vPFh8/BfYY1ZYzRZnz+j xqqT2AYMVi6xIWCSdzlOzZ/qskYKn3xml7d33k9CgfN+ta6WThTrkHS0p1oDKTAH479EpUol3 fWW/ykf/4WZL90lR2DoojRPywXtriUHCwBaMni7pQFxVu7KGTaUfb2o4Qh0bZ8+aQkKwpiaJt OrY+z16p+yWkQILBQza9gWRkLXYmAvAc6i4/PjYmU9xx8pyh34Vw9erUjwFa1I4t1O+o3adU2 2zYqPglpwg1ZRxVkViG7rx+E/pNOy5iMt1xa7PefyXnxp3lGIPmkhnmnn+uhTP0a2mjC21eNl YotV9A== Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain My /etc/fstab file contains a line for the file system cgroup2 (i.e. for cgroup v2 instead of cgroup for cgroup v1). I just learned about etc-fstab-generic-mode and after loading generic-x and visiting /etc/fstab, I saw that in the line for cgroup2, the entry in the type column is fontified in the default face, not in font-lock-keyword-face, unlike all other file system types in my /etc/fstab file. This patch fixes the misfontification: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: etc-fstab-generic-mode patch diff --git a/lisp/generic-x.el b/lisp/generic-x.el index b4ae0225943..373bfad92dd 100644 --- a/lisp/generic-x.el +++ b/lisp/generic-x.el @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode "cd9660" "cfs" "cgroup" + "cgroup2" "cifs" "coda" "coherent" --=-=-= Content-Type: text/plain While the misfontification isn't a regression -- the support for cgroups (but only for cgroup v1) in etc-fstab-generic-mode was added in January 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e., omitting cgroup2 was presumably an oversight in that commit. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.18.0) of 2024-01-09 built on strobelfs2 Repository revision: fccaeabc959f5403ce49744030bd2620352b59f8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101009 System Description: Linux From Scratch r12.0-112 --=-=-=-- ------------=_1704900483-22482-1--