From unknown Sat Jun 21 03:27:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#68364 <68364@debbugs.gnu.org> To: bug#68364 <68364@debbugs.gnu.org> Subject: Status: Print log buttons fail with vc-log-mergebase Reply-To: bug#68364 <68364@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:27:13 +0000 retitle 68364 Print log buttons fail with vc-log-mergebase reassign 68364 emacs submitter 68364 Juri Linkov severity 68364 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 02:32:52 2024 Received: (at submit) by debbugs.gnu.org; 10 Jan 2024 07:32:52 +0000 Received: from localhost ([127.0.0.1]:41627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNT51-0007gc-TV for submit@debbugs.gnu.org; Wed, 10 Jan 2024 02:32:52 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNT4z-0007gK-EO for submit@debbugs.gnu.org; Wed, 10 Jan 2024 02:32:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNT4m-0005gL-0B for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 02:32:36 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNT4h-0006oC-M6 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 02:32:34 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 160C720002 for ; Wed, 10 Jan 2024 07:32:26 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Print log buttons fail with vc-log-mergebase Organization: LINKOV.NET X-Debbugs-Cc: Dmitry Gutov Date: Wed, 10 Jan 2024 09:28:13 +0200 Message-ID: <86h6jlog76.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Buttons to show more log entries is a nice feature, but after the recent change this doesn't work with 'C-x v M L' (vc-log-mergebase): Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p "branch-2") vc-print-log-setup-buttons("branch-1" t "branch-2" nil) Probably it requires a special handling for 'C-x v M L'. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 08:56:13 2024 Received: (at 68364) by debbugs.gnu.org; 10 Jan 2024 13:56:13 +0000 Received: from localhost ([127.0.0.1]:39302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ40-0003Mw-Nc for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:56:13 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:34313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ3y-0003MY-H7 for 68364@debbugs.gnu.org; Wed, 10 Jan 2024 08:56:11 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 2B79F3200A04; Wed, 10 Jan 2024 08:18:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 10 Jan 2024 08:18:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1704892709; x=1704979109; bh=kJ1OyGNbERRnrwJ6KUl82sZKltWd9t3SgVgKHhiGCpE=; b= FylFW6eTF4W3cvU1XAyioJ8pTyyLE5Iey+Pck3PyKctWjhlVBqD7GNQeuYbw36+B GegZMkwWiavrqATVNDWOtfRD/wyIg6UmMSfdXiIxi9aVMsySIbO7Fme2Cy86Q1SX 987siBvuuEcit2GLfavfGAI6N6XD/P/EGVtOSX9hHTx0DgPXcKisZ5G6JD6wEf27 Dj2mXX2r50XkZx1Jf7CLOg3hzqJGmRbt9QIznClMmKPJlEH7Ix1MRkY9V9ZEolur 7+StAfIMtTCfGdo9detdi+RQxutlirvPWGGNeq1hBsLaJo2b7aqFPsM+QZM531H3 Vj7i0ljHnt3v+9So+uV3eA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704892709; x= 1704979109; bh=kJ1OyGNbERRnrwJ6KUl82sZKltWd9t3SgVgKHhiGCpE=; b=0 r7+7o13uSYyeI/R7+Xd2BlXL276+uvjqvZGALCwa929cs0wb822oFohpkuWNDorc 46uWLDiwbQ83hRB4HUU4MTIdjI2h9b91X3H2Fku1Y+xtB9V66AC6EwyXdZZWwX5f B3xaWd50sOVchKMmGbDRhhpkJbGDyJCkhOCqAGK8KeybcnliUb8JNvEtXt9TOA8P BNaJn0cMjiCmII6nCvl4rBFqKRAAVW2w2Hep52n8NWqNnj1bg7WkXzSnAt6acRHB DQ8fOl7am1jREMStHO1Bv9FKJUvrzqb1JHoRZ45QE3Cr24KRBzf9dwY2S7MAgynC Wt/7d+1Z8SesK7aalWU2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeiuddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpedthfeuvddtveelgeeuleevvdejveehffevveehvdeuffdtfefhvdeugefgtefg tdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Jan 2024 08:18:28 -0500 (EST) Message-ID: <94864f5e-9e3a-44dd-a7d7-31c93d2d09c9@gutov.dev> Date: Wed, 10 Jan 2024 15:18:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#68364: Print log buttons fail with vc-log-mergebase Content-Language: en-US To: Juri Linkov , 68364@debbugs.gnu.org References: <86h6jlog76.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86h6jlog76.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68364 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Juri, On 10/01/2024 09:28, Juri Linkov wrote: > Buttons to show more log entries is a nice feature, > but after the recent change this doesn't work with > 'C-x v M L' (vc-log-mergebase): > > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p "branch-2") > vc-print-log-setup-buttons("branch-1" t "branch-2" nil) > > Probably it requires a special handling for 'C-x v M L'. Does this help? Looks like the description of the LIMIT argument wasn't updated in the vc-print-log-internal's docstring, when it started to be a string sometimes. diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index b8cc44fc3dc..7d5a5486250 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2711,7 +2711,7 @@ vc-print-log-setup-buttons ;; In either case only one revision is wanted, no buttons. (when (and limit (not (eq 'limit-unsupported pl-return)) (not (and is-start-revision - (= limit 1)))) + (eql limit 1)))) (let ((entries 0)) (goto-char (point-min)) (while (re-search-forward log-view-message-re nil t) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 12:21:55 2024 Received: (at 68364) by debbugs.gnu.org; 10 Jan 2024 17:21:55 +0000 Received: from localhost ([127.0.0.1]:42726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcH5-0004tQ-BB for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:21:55 -0500 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:48281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcH2-0004so-VM for 68364@debbugs.gnu.org; Wed, 10 Jan 2024 12:21:53 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id CBEBBFF806; Wed, 10 Jan 2024 17:21:47 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#68364: Print log buttons fail with vc-log-mergebase In-Reply-To: <94864f5e-9e3a-44dd-a7d7-31c93d2d09c9@gutov.dev> (Dmitry Gutov's message of "Wed, 10 Jan 2024 15:18:26 +0200") Organization: LINKOV.NET References: <86h6jlog76.fsf@mail.linkov.net> <94864f5e-9e3a-44dd-a7d7-31c93d2d09c9@gutov.dev> Date: Wed, 10 Jan 2024 19:20:05 +0200 Message-ID: <86jzohp0ti.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68364 Cc: 68364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Buttons to show more log entries is a nice feature, >> but after the recent change this doesn't work with >> 'C-x v M L' (vc-log-mergebase): >> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p >> "branch-2") >> vc-print-log-setup-buttons("branch-1" t "branch-2" nil) >> Probably it requires a special handling for 'C-x v M L'. > > Does this help? > > Looks like the description of the LIMIT argument wasn't updated in the > vc-print-log-internal's docstring, when it started to be a string > sometimes. The description of the LIMIT argument in vc-print-log-internal looks strange: "Show up to LIMIT entries (non-nil means unlimited)." Maybe it should be "(nil means unlimited)"? > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index b8cc44fc3dc..7d5a5486250 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -2711,7 +2711,7 @@ vc-print-log-setup-buttons > ;; In either case only one revision is wanted, no buttons. > (when (and limit (not (eq 'limit-unsupported pl-return)) > (not (and is-start-revision > - (= limit 1)))) > + (eql limit 1)))) > (let ((entries 0)) > (goto-char (point-min)) > (while (re-search-forward log-view-message-re nil t) Sorry, still fails on another line: (if (< entries limit) But this works: diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index b8cc44fc3dc..d284b19fcf0 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2709,7 +2709,8 @@ vc-print-log-setup-buttons ;; LIMIT=1 is set by vc-annotate-show-log-revision-at-line ;; or by vc-print-root-log with current-prefix-arg=1. ;; In either case only one revision is wanted, no buttons. - (when (and limit (not (eq 'limit-unsupported pl-return)) + (when (and limit (not (stringp limit)) + (not (eq 'limit-unsupported pl-return)) (not (and is-start-revision (= limit 1)))) (let ((entries 0)) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 18:23:20 2024 Received: (at 68364) by debbugs.gnu.org; 10 Jan 2024 23:23:20 +0000 Received: from localhost ([127.0.0.1]:43560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhup-0003LQ-OR for submit@debbugs.gnu.org; Wed, 10 Jan 2024 18:23:20 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:49259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhun-0003LD-Lm for 68364@debbugs.gnu.org; Wed, 10 Jan 2024 18:23:18 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 7D9E13200A89; Wed, 10 Jan 2024 18:23:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 10 Jan 2024 18:23:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1704928991; x=1705015391; bh=sKWS52v5MCZVKp+cEQ7FvO8aAEU6AlnMy0qwlDkbFh8=; b= hGkwyPNB8RsM+jouY5EdvHW1A277LjCzqP/700PkfNTDRRcENAx6kTKSU1ufczS/ uG0aVf3uX68etvVYyPny5j8ClwlNNpC9A7p+NS0X3R0Z38g/oZChq81CBJvwDUt3 a1HlFPwYjgHfanti1Cd5zzOxZb4yB2GKU8csLG1K72d3n3Na2VopjCZiofbtA8WB 4DqJUhOwU6rbLsf1kTyzTpal7HoIuhzm6MQSsVuoDt58R5O0/JSRBXgZXk6yXUxs FQVl11TVs3dkz39oC5gVLpzFcxTREKrZV17Fbnkg12bqeFg5Usu1B+z1BHScE9Qu zVru56RA3Gm4IAjq2RMzew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704928991; x= 1705015391; bh=sKWS52v5MCZVKp+cEQ7FvO8aAEU6AlnMy0qwlDkbFh8=; b=6 8q1h3pFiCELbjp0ekVPnwyZlwqkkfVdqHAyyNrVBB1SxolKBxYZeqmeznPbbCGB5 NMNcTidcSeij3do8eF+FJZCKXULdvODxGDzCkn5fyUOPkNJ769WDkwknanpIkcY4 ldshxZZ6z2EO1yMb9hy5dY3TGq7sgnU/z/IZvF+3r7vpklNuxFUGH9EZXDjKNn5n dg87caw0EVVhsPiUkAEuZMr1KRAC22KwX3if/REc8qzsZVy7etGGw4OMXSKehBkh I14Z8pYN+WiqHbmfED8gNjK4e/73tzfnuk8m55M4KkkgKlkgoLuhVTVgiCYoQpVk c95CDMyXIlJ1NZL6cMHNQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeivddgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Jan 2024 18:23:10 -0500 (EST) Message-ID: <815226a2-55ab-4b03-998e-90545f460d14@gutov.dev> Date: Thu, 11 Jan 2024 01:23:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#68364: Print log buttons fail with vc-log-mergebase Content-Language: en-US To: Juri Linkov References: <86h6jlog76.fsf@mail.linkov.net> <94864f5e-9e3a-44dd-a7d7-31c93d2d09c9@gutov.dev> <86jzohp0ti.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86jzohp0ti.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68364 Cc: 68364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 10/01/2024 19:20, Juri Linkov wrote: >>> Buttons to show more log entries is a nice feature, >>> but after the recent change this doesn't work with >>> 'C-x v M L' (vc-log-mergebase): >>> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p >>> "branch-2") >>> vc-print-log-setup-buttons("branch-1" t "branch-2" nil) >>> Probably it requires a special handling for 'C-x v M L'. >> >> Does this help? >> >> Looks like the description of the LIMIT argument wasn't updated in the >> vc-print-log-internal's docstring, when it started to be a string >> sometimes. > > The description of the LIMIT argument in vc-print-log-internal looks strange: > > "Show up to LIMIT entries (non-nil means unlimited)." > > Maybe it should be "(nil means unlimited)"? Probably. And a mention of allowed string values. >> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el >> index b8cc44fc3dc..7d5a5486250 100644 >> --- a/lisp/vc/vc.el >> +++ b/lisp/vc/vc.el >> @@ -2711,7 +2711,7 @@ vc-print-log-setup-buttons >> ;; In either case only one revision is wanted, no buttons. >> (when (and limit (not (eq 'limit-unsupported pl-return)) >> (not (and is-start-revision >> - (= limit 1)))) >> + (eql limit 1)))) >> (let ((entries 0)) >> (goto-char (point-min)) >> (while (re-search-forward log-view-message-re nil t) > > Sorry, still fails on another line: > > (if (< entries limit) > > But this works: > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index b8cc44fc3dc..d284b19fcf0 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -2709,7 +2709,8 @@ vc-print-log-setup-buttons > ;; LIMIT=1 is set by vc-annotate-show-log-revision-at-line > ;; or by vc-print-root-log with current-prefix-arg=1. > ;; In either case only one revision is wanted, no buttons. > - (when (and limit (not (eq 'limit-unsupported pl-return)) > + (when (and limit (not (stringp limit)) > + (not (eq 'limit-unsupported pl-return)) > (not (and is-start-revision > (= limit 1)))) > (let ((entries 0)) That would mean the "follow renames" button is never shown in vc-log-mergebase outputs. I've pushed commit 1ecb53ad2fc, check it out. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 02:11:07 2024 Received: (at 68364) by debbugs.gnu.org; 11 Jan 2024 07:11:07 +0000 Received: from localhost ([127.0.0.1]:58563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNpDX-0003TJ-C9 for submit@debbugs.gnu.org; Thu, 11 Jan 2024 02:11:07 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNpDV-0003Sk-NW; Thu, 11 Jan 2024 02:11:06 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 493FEE0002; Thu, 11 Jan 2024 07:11:00 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#68364: Print log buttons fail with vc-log-mergebase In-Reply-To: <815226a2-55ab-4b03-998e-90545f460d14@gutov.dev> (Dmitry Gutov's message of "Thu, 11 Jan 2024 01:23:08 +0200") Organization: LINKOV.NET References: <86h6jlog76.fsf@mail.linkov.net> <94864f5e-9e3a-44dd-a7d7-31c93d2d09c9@gutov.dev> <86jzohp0ti.fsf@mail.linkov.net> <815226a2-55ab-4b03-998e-90545f460d14@gutov.dev> Date: Thu, 11 Jan 2024 09:06:39 +0200 Message-ID: <86sf34nzxw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68364 Cc: 68364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 68364 30.0.50 thanks > That would mean the "follow renames" button is never shown in > vc-log-mergebase outputs. I don't know if this button makes sense in vc-log-mergebase outputs. But in file logs it works nicely, much better than using vc-git-print-log-follow. > I've pushed commit 1ecb53ad2fc, check it out. Thanks for taking care of this. I confirm there are no problems anymore. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 08:10:45 2024 Received: (at 68364) by debbugs.gnu.org; 11 Jan 2024 13:10:45 +0000 Received: from localhost ([127.0.0.1]:59032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNupZ-00025N-Eu for submit@debbugs.gnu.org; Thu, 11 Jan 2024 08:10:45 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNupX-00025A-VK for 68364@debbugs.gnu.org; Thu, 11 Jan 2024 08:10:44 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 744155C0108; Thu, 11 Jan 2024 08:10:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 11 Jan 2024 08:10:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1704978639; x=1705065039; bh=9fdBLiOgsp/n86Q6nXNSeWX8m8LRGg0bF3UmpRvVKtI=; b= kWd2PEuW7NwM1u6lOrB+6xy3jU6goanQCs0sV3Q2dAot0NNoamQ7WXDOgdz8KZqV RzqzVcUpZ5ojj2LFGS3xr5AVo6oB1S/U8fNjYiuNfUJQ1JbzwxgV4QdAY9/LTc5k m7+6NOLCJzz4IFQ6H39UbEs2plW9TbWNxhFBB96hb57rKjbfwL+OQ242HB8RNena FglpALCipE0F/tOckySPTAjjVaT0W+qC/CICNpsHCXZ24+7qaPoLHK3vxBStezYz 3HbJ8tZTlORAzNXCE3/qtwMi0e4HmvlZSWYzbm5YGhpFvRSJ49MgmKipS3YTcMF4 R9thUwI8cWd3s3jKnzRhsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704978639; x= 1705065039; bh=9fdBLiOgsp/n86Q6nXNSeWX8m8LRGg0bF3UmpRvVKtI=; b=F lRbJ7QNbMrnfe/ZehEF7fmNET/X0UIaU2CBRMXqA0sCHnKZYzXU+b3BtmfeMYMOD tQ+Lp6OtV4qjh4YHk/LxP/h9ArSmkAAbOZUw9VSTMe1z5/z7Eo7JPZe6D9Mr9ing boaMK+5xwc1hfX6f41DBldlXrhUKG7v3dTjycVHfEcy6qsQujfE+/aEw0JEEAJH7 JJwuBLofWm8Zt6sRp8ug+n2X9KrJVy7cVZZ/hptGJezk5fwGFI1s2FSN2m5sihyF L25pOE4Fi8SepYef94y77jqT9pHh1h5XfjIuwKvT62uiE/yBZFzSsEml9aN6XMa5 2pkJb5HBbUO/NbXmzdb3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeifedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Jan 2024 08:10:37 -0500 (EST) Message-ID: Date: Thu, 11 Jan 2024 15:10:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#68364: Print log buttons fail with vc-log-mergebase Content-Language: en-US To: Juri Linkov References: <86h6jlog76.fsf@mail.linkov.net> <94864f5e-9e3a-44dd-a7d7-31c93d2d09c9@gutov.dev> <86jzohp0ti.fsf@mail.linkov.net> <815226a2-55ab-4b03-998e-90545f460d14@gutov.dev> <86sf34nzxw.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86sf34nzxw.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68364 Cc: 68364@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 11/01/2024 09:06, Juri Linkov wrote: > close 68364 30.0.50 > thanks > >> That would mean the "follow renames" button is never shown in >> vc-log-mergebase outputs. > > I don't know if this button makes sense in vc-log-mergebase outputs. It's probably less important than in the full log, but the mergebase log interval might contain renames too, I think. > But in file logs it works nicely, much better than using > vc-git-print-log-follow. Good to hear! >> I've pushed commit 1ecb53ad2fc, check it out. > > Thanks for taking care of this. I confirm there are no problems anymore. Thanks. From unknown Sat Jun 21 03:27:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Feb 2024 12:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator