GNU bug report logs - #68355
[PATCH 0/8] guix: Add or1k-elf platform.

Previous Next

Full log

Message #41 received at 68355 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 68355 <at> debbugs.gnu.org,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#68355] [PATCH 7/8] gnu: Add make-crust-tools.
Date: Fri, 12 Jan 2024 21:30:35 +0100

>  
> +                 (replace 'configure
> +                   (lambda* (#:key inputs native-inputs #:allow-other-keys)
> +                     (copy-file (search-input-file inputs "/libexec/.config")
> +                                ".config")))
> +                 (replace 'build
> +                   (lambda* (#:key make-flags parallel-build? #:allow-other-keys)
> +                     (apply invoke "make" "tools"
> +                            `(,@(if parallel-build?
> +                                    `("-j" ,(number->string (parallel-job-count)))
> +                                     '())
> +                              ,@make-flags))))

Please wrap everything above the 78 columns limit.

> +                 (replace 'install
> +                   (lambda _
> +                     (install-file "build/tools/load"
> +                                   (string-append #$output "/bin")))))))
> +      (synopsis "System control processor firmware for Allwinner sunxi boards (tools)")

This synopsis is too long (>= 80 characters). Fixing it implies to fix
the one of make-crust-firmware I guess.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.