From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 08 21:55:26 2024 Received: (at submit) by debbugs.gnu.org; 9 Jan 2024 02:55:26 +0000 Received: from localhost ([127.0.0.1]:37970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN2Gz-0005zs-HT for submit@debbugs.gnu.org; Mon, 08 Jan 2024 21:55:26 -0500 Received: from lists.gnu.org ([2001:470:142::17]:45790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN2Gu-0005zX-9S for submit@debbugs.gnu.org; Mon, 08 Jan 2024 21:55:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN2Gi-0000Rt-B5 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 21:55:08 -0500 Received: from smtp-2.orcon.net.nz ([60.234.4.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN2Gf-0006pY-Q2 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 21:55:08 -0500 Received: from [10.253.37.70] (port=34221 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1rN2GV-0007u6-Bk for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 15:54:58 +1300 Received: from ip-203-94-50-131.kinect.net.nz ([203.94.50.131]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 09 Jan 2024 15:54:55 +1300 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 09 Jan 2024 15:54:55 +1300 From: Phil Sainty To: bug-gnu-emacs@gnu.org Subject: 29.1.90; eww: error when eww-retrieve-command is set to 'sync Message-ID: <08d22baef8df6eee40c00ae3d14d7c49@webmail.orcon.net.nz> X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.43; envelope-from=psainty@orcon.net.nz; helo=smtp-2.orcon.net.nz X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Customize `eww-retrieve-command' to `sync' -- the customize label is "Use `url-retrieve-synchronously'" -- or simply: (setq eww-retrieve-command 'sync) Now any `eww' invocation fails with: apply: Wrong type argument: stringp, nil I see the error in my builds of 29 and 30, but not in 28.2. My 30.0.50 build dated back to 2023-09-21, so I've just compiled a fresh build of 30 and no longer see the *error*, but it still doesn't work -- the page is never rendered. Example in Emacs 29: (setq eww-retrieve-command 'sync) (eww "http://example.com") Debugger entered--Lisp error: (wrong-type-argument stringp nil) eww-render(nil "http://example.com/" "http://example.com/" nil #) apply(eww-render nil "http://example.com/" ("http://example.com/" nil #)) eww-retrieve("http://example.com/" eww-render ("http://example.com/" nil #)) eww("http://example.com") Or after loading the uncompiled eww.el: Debugger entered--Lisp error: (wrong-type-argument stringp nil) set-buffer(nil) (save-current-buffer (set-buffer buffer) (plist-put eww-data :peer (plist-get status :peer)) (setq list-buffers-directory url) (setq url-current-lastloc (url-generic-parse-url url))) ... eww-render(nil "http://example.com/" "http://example.com/" nil #) That BUFFER arg to `set-buffer' looks like it's nil on account of an additional duplicate argument passed to `eww-render': eww-render(nil "http://example.com/" "http://example.com/" nil #) should have been: eww-render(nil "http://example.com/" nil #) So I think the bug is the last line here: (defun eww-retrieve (url callback cbargs) (cond ((null eww-retrieve-command) (url-retrieve url #'eww-render cbargs)) ((eq eww-retrieve-command 'sync) (let ((data-buffer (url-retrieve-synchronously url))) (with-current-buffer data-buffer (apply #'eww-render nil url cbargs)))) Where cbargs evidentially contains the URL already, so it should presumably be: (apply #'eww-render nil cbargs) I can confirm that this change fixes my example case (but I haven't tried to find out if the situation is more complicated than that). -Phil In GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2023-10-24 built on phil-lp Repository revision: cc3e436c822343f72f3ede6b638e1b68cd434583 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/home/phil/emacs/29.x.nc/usr/local --with-native-compilation=aot --with-x-toolkit=lucid --without-sound '--program-transform-name=s/^ctags$/ctags_emacs/'' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_NZ.UTF-8 value of $LC_NUMERIC: en_NZ.UTF-8 value of $LC_TIME: en_NZ.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: savehist-mode: t windmove-mode: t winner-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile savehist windmove winner ring dired-aux cl-loaddefs cl-lib dired dired-loaddefs advice rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 84935 7813) (symbols 48 7538 0) (strings 32 22145 2035) (string-bytes 1 667777) (vectors 16 16684) (vector-slots 8 344081 16889) (floats 8 35 41) (intervals 56 440 0) (buffers 984 14)) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 11:43:11 2024 Received: (at 68336) by debbugs.gnu.org; 16 Jan 2024 16:43:11 +0000 Received: from localhost ([127.0.0.1]:49563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPmWs-0000j1-NM for submit@debbugs.gnu.org; Tue, 16 Jan 2024 11:43:10 -0500 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:49717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPmWn-0000iC-65 for 68336@debbugs.gnu.org; Tue, 16 Jan 2024 11:43:05 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 33BCF1BF20C; Tue, 16 Jan 2024 16:42:56 +0000 (UTC) From: Juri Linkov To: Phil Sainty Subject: Re: bug#68336: 29.1.90; eww: error when eww-retrieve-command is set to 'sync In-Reply-To: <08d22baef8df6eee40c00ae3d14d7c49@webmail.orcon.net.nz> (Phil Sainty's message of "Tue, 09 Jan 2024 15:54:55 +1300") Organization: LINKOV.NET References: <08d22baef8df6eee40c00ae3d14d7c49@webmail.orcon.net.nz> Date: Tue, 16 Jan 2024 18:32:02 +0200 Message-ID: <86sf2xp7ct.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68336 Cc: Eli Zaretskii , 68336@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I see the error in my builds of 29 and 30, but not in 28.2. > > Example in Emacs 29: > > (setq eww-retrieve-command 'sync) > (eww "http://example.com") > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > So I think the bug is the last line here: > > (apply #'eww-render nil url cbargs)))) > > Where cbargs evidentially contains the URL already, so it > should presumably be: > > (apply #'eww-render nil cbargs) Thanks, I confirm this is the right fix. Eli, is it ok to fix eww.el on the emacs-29 branch? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 12:03:02 2024 Received: (at 68336) by debbugs.gnu.org; 16 Jan 2024 17:03:02 +0000 Received: from localhost ([127.0.0.1]:49605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPmq6-0006g7-EX for submit@debbugs.gnu.org; Tue, 16 Jan 2024 12:03:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPmq3-0006fk-Q1 for 68336@debbugs.gnu.org; Tue, 16 Jan 2024 12:03:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPmpw-0000lR-8l; Tue, 16 Jan 2024 12:02:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yVgEZzKgz4s9VPq2r+dBj9+9vu4JW+KGMmpLXnAonAU=; b=hYQ4i9TuAcX3 uYNLRkhuJHiMStQ0dBHUVf0X5jsXB35esbb29JXLY+VeAUiuh4H/TFNuFuMix5qvcRZwT5t8WeB8u 0vp1N3Mh0WAMJtxr1FAoB9vpQlK3V4cnTpOTVW0z/8E8l536TgKEHmCnIApbqsemHTmG19mK7D0Ss 1yyPZDr50MAC7eMeI+0gxQgiD7QOxcwGOfSr4un8PlWY4ySvlj8b1+M0NLocFYcui89H2jdn2sa6w Pt5c7/adgXtUx8lMH7ZY9ieNrdg+9FuxMHjGLeuY0rI5oHC/hGe1ENMTQggzD29G8OqelUz4fmP1T XwwGSV2iWmbBh6j1WUJQDw==; Date: Tue, 16 Jan 2024 19:02:40 +0200 Message-Id: <831qahcitr.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86sf2xp7ct.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 16 Jan 2024 18:32:02 +0200) Subject: Re: bug#68336: 29.1.90; eww: error when eww-retrieve-command is set to 'sync References: <08d22baef8df6eee40c00ae3d14d7c49@webmail.orcon.net.nz> <86sf2xp7ct.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68336 Cc: psainty@orcon.net.nz, 68336@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , 68336@debbugs.gnu.org > Date: Tue, 16 Jan 2024 18:32:02 +0200 > > > I see the error in my builds of 29 and 30, but not in 28.2. > > > > Example in Emacs 29: > > > > (setq eww-retrieve-command 'sync) > > (eww "http://example.com") > > > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > > So I think the bug is the last line here: > > > > (apply #'eww-render nil url cbargs)))) > > > > Where cbargs evidentially contains the URL already, so it > > should presumably be: > > > > (apply #'eww-render nil cbargs) > > Thanks, I confirm this is the right fix. > > Eli, is it ok to fix eww.el on the emacs-29 branch? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 16 12:53:06 2024 Received: (at 68336) by debbugs.gnu.org; 16 Jan 2024 17:53:06 +0000 Received: from localhost ([127.0.0.1]:49716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPncY-0007ai-47 for submit@debbugs.gnu.org; Tue, 16 Jan 2024 12:53:06 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:47041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPncV-0007a8-S9; Tue, 16 Jan 2024 12:53:04 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 968201C0002; Tue, 16 Jan 2024 17:52:56 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#68336: 29.1.90; eww: error when eww-retrieve-command is set to 'sync In-Reply-To: <831qahcitr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Jan 2024 19:02:40 +0200") Organization: LINKOV.NET References: <08d22baef8df6eee40c00ae3d14d7c49@webmail.orcon.net.nz> <86sf2xp7ct.fsf@mail.linkov.net> <831qahcitr.fsf@gnu.org> Date: Tue, 16 Jan 2024 19:52:27 +0200 Message-ID: <86wms9mahw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68336 Cc: psainty@orcon.net.nz, 68336@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 68336 29.1.90 thanks >> > I see the error in my builds of 29 and 30, but not in 28.2. >> >> Thanks, I confirm this is the right fix. >> >> Eli, is it ok to fix eww.el on the emacs-29 branch? > > Yes, thanks. So now pushed to emacs-29. From unknown Sat Aug 16 16:12:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 14 Feb 2024 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator