GNU bug report logs - #68334
29.1; tool-bar-make-keymap-1 does not work on terminals

Previous Next

Full log

Message #52 received at 68334-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jared Finder <jared <at> finder.org>
Cc: 68334-done <at> debbugs.gnu.org
Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals
Date: Thu, 11 Jan 2024 12:51:06 +0200

> Date: Wed, 10 Jan 2024 14:59:25 -0800
> From: Jared Finder <jared <at> finder.org>
> Cc: 68334 <at> debbugs.gnu.org
> 
> > I don't see any problems with the change, but please add comments
> > there explaining that some parts of the code are supposed to work on
> > frames where images cannot be displayed, because it is very easy to
> > mistakenly assume this only needs to work on GUI frames.
> 
> New patch attached with comment added.

Thanks, installed on master.

> For the other discussions about making per-window tool bars part of 
> core, I expect a handful of additional patches so I can file a separate 
> bug report if that makes tracking things easier.

OK, so I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.