GNU bug report logs - #68334
29.1; tool-bar-make-keymap-1 does not work on terminals

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jared Finder <jared <at> finder.org>
Cc: 68334 <at> debbugs.gnu.org
Subject: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals
Date: Tue, 09 Jan 2024 14:40:11 +0200

> Date: Mon, 08 Jan 2024 13:39:25 -0800
> From:  Jared Finder via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> I'd like tool-bar-make-keymap-1 to return a sensible keymap on 
> terminals.  This is only a small change from current code, patch 
> attached.

I don't see any problems with the change, but please add comments
there explaining that some parts of the code are supposed to work on
frames where images cannot be displayed, because it is very easy to
mistakenly assume this only needs to work on GUI frames.

Btw, what happens if display-images-p returns non-nil, but the session
doesn't support images of the type used for tool-bar icons?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.