From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 08 16:39:50 2024 Received: (at submit) by debbugs.gnu.org; 8 Jan 2024 21:39:50 +0000 Received: from localhost ([127.0.0.1]:37781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMxLY-0001vE-Kl for submit@debbugs.gnu.org; Mon, 08 Jan 2024 16:39:50 -0500 Received: from lists.gnu.org ([2001:470:142::17]:49514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMxLT-0001ux-DV for submit@debbugs.gnu.org; Mon, 08 Jan 2024 16:39:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMxLH-0001Io-NN for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 16:39:31 -0500 Received: from greenhill.hpalace.com ([192.155.80.58]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMxLF-0006IP-CX for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 16:39:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1704749965; bh=f3WCYIXJK5e7tB6dmB+bZf8b5Jbk6a9+9CmKB/8+pN8=; h=Date:From:To:Subject:From; b=pkow+firPiZibmxmN2F1EvhOZ4oKqawsmJKabZVAu3eoNaN5pKPAsbH70k3x29aJq lPYpHo5G83yEF7aXvXFz/OTgEeKvsXVhBFiC+T+xRrlB/FqRmxm/53EvsU6jdkxMT3 NxBrM7UNwAfq1Eh6MdCsYaWmB0WhTW/6xqEobK6hyJxjZBElmxdNk/YEno11/NhBDu 7qOFqw57Oko9If3sNLDO0iFfszJyqCOBuKQgvN3CZQ85lI8mdsnfA70amo4pwQe7L7 Dgko3+L2uXbb9lm/HEAonxHTPpRSpauy9ckEUX8T/qRCvmN9Qx4NCOIiqRkqMrmRRr V4yd/XgWAvgAw== Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 87FBA9A2 for ; Mon, 8 Jan 2024 21:39:25 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 08 Jan 2024 13:39:25 -0800 From: Jared Finder To: Bug-gnu Emacs Subject: 29.1; tool-bar-make-keymap-1 does not work on terminals Message-ID: X-Sender: jared@finder.org Content-Type: multipart/mixed; boundary="=_0accceb5b644028fea89c9a75c65089f" Received-SPF: pass client-ip=192.155.80.58; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=_0accceb5b644028fea89c9a75c65089f Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed I'd like tool-bar-make-keymap-1 to return a sensible keymap on terminals. This is only a small change from current code, patch attached. Context: I am writing a package that displays toolbars attached to an Emacs window instead of attached to the frame. You can see the package at . There's no intrinsic reason toolbars can't be useful in terminals and adding additional (usually ignored) keymap entries seems very safe. -- MJF In GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-09-11, modified by Debian built on melete System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/libexec --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-native-compilation --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/libexec --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-native-compilation --with-pgtk 'CFLAGS=-g -O2 -ffile-prefix-map=/build/emacs-N816CI/emacs-29.1+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: global-window-tool-bar-mode: t window-tool-bar-mode: t pixel-scroll-precision-mode: t recentf-mode: t global-subword-mode: t subword-mode: t global-form-feed-st-mode: t form-feed-st-mode: t icomplete-mode: t fido-mode: t electric-pair-mode: t delete-selection-mode: t cua-mode: t bar-cursor-mode: t url-handler-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr smerge-mode diff pulse jka-compr help-fns radix-tree find-func xref project misearch multi-isearch mm-archive gnutls network-stream url-cache url-http url-auth url-gw nsm emacsbug ediff-vers ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util vc-hg vc-svn vc-dir ewoc vc checkdoc lisp-mnt vc-git diff-mode vc-dispatcher cursor-sensor finder-inf comp comp-cstr cl-extra help-mode markdown-mode rx color thingatpt noutline outline cus-edit pp cus-start cus-load window-tool-bar easy-mmode tab-line pixel-scroll recentf tree-widget wid-edit cap-words superword subword form-feed-st icomplete elec-pair delsel cua-base bar-cursor ls-lisp advice log-edit message sendmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log warnings icons compile text-property-search comint ansi-osc ansi-color ring init-dir bar-cursor-autoloads benchmark-init-autoloads dired-icon-autoloads form-feed-st-autoloads init-dir-autoloads markdown-mode-autoloads modus-themes-autoloads package-lint-autoloads compat-autoloads info slime-autoloads window-tool-bar-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core password-cache json map byte-opt bytecomp byte-compile url-vars modus-vivendi-theme modus-themes cl-macs pcase subr-x cl-loaddefs cl-lib gv rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 604030 131636) (symbols 48 25469 2) (strings 32 156826 21765) (string-bytes 1 7239778) (vectors 16 41746) (vector-slots 8 769733 48672) (floats 8 276 1190) (intervals 56 4786 466) (buffers 984 33)) --=_0accceb5b644028fea89c9a75c65089f Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-lisp-tool-bar.el-tool-bar-make-keymap-1-Populate-on-.patch Content-Disposition: attachment; filename=0001-lisp-tool-bar.el-tool-bar-make-keymap-1-Populate-on-.patch; size=1333 RnJvbSBiMDFjZGY1M2E0NWE2MDMzMmRlNDgyODVkNTEwNzkwOTA3MTUyZWE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXJlZCBGaW5kZXIgPGphcmVkQGZpbmRlci5vcmc+CkRhdGU6 IE1vbiwgOCBKYW4gMjAyNCAxMzoyMDoyNSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdICogbGlzcC90 b29sLWJhci5lbCAodG9vbC1iYXItbWFrZS1rZXltYXAtMSk6IFBvcHVsYXRlIG9uCiB0ZXJtaW5h bHMKCi0tLQogbGlzcC90b29sLWJhci5lbCB8IDE3ICsrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvdG9vbC1iYXIuZWwgYi9saXNwL3Rvb2wtYmFyLmVsCmluZGV4IDRjYTgxZmIwMWUwLi4zNmE4 MDUyMmM4MyAxMDA2NDQKLS0tIGEvbGlzcC90b29sLWJhci5lbAorKysgYi9saXNwL3Rvb2wtYmFy LmVsCkBAIC0xODAsMTUgKzE4MCwxNCBAQCB0b29sLWJhci1tYWtlLWtleW1hcC0xCiAJCQkgKGNv bnNwIGltYWdlLWV4cCkKIAkJCSAobm90IChlcSAoY2FyIGltYWdlLWV4cCkgJ2ltYWdlKSkKIAkJ CSAoZmJvdW5kcCAoY2FyIGltYWdlLWV4cCkpKQotCQkoaWYgKG5vdCAoZGlzcGxheS1pbWFnZXMt cCkpCi0JCSAgICAoc2V0cSBiaW5kIG5pbCkKLQkJICAobGV0ICgoaW1hZ2UgKGV2YWwgaW1hZ2Ut ZXhwKSkpCi0JCSAgICAodW5sZXNzIChhbmQgaW1hZ2UgKGltYWdlLW1hc2stcCBpbWFnZSkpCi0J CSAgICAgIChzZXRxIGltYWdlIChhcHBlbmQgaW1hZ2UgJyg6bWFzayBoZXVyaXN0aWMpKSkpCi0J CSAgICAoc2V0cSBiaW5kIChjb3B5LXNlcXVlbmNlIGJpbmQpCi0JCQkgIHBsaXN0IChudGhjZHIg KGlmIChjb25zcCAobnRoIDQgYmluZCkpIDUgNCkKLQkJCQkJYmluZCkpCi0JCSAgICAocGxpc3Qt cHV0IHBsaXN0IDppbWFnZSBpbWFnZSkpKSkKKwkJKGxldCAoKGltYWdlIChhbmQgKGRpc3BsYXkt aW1hZ2VzLXApCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGV2YWwgaW1hZ2Ut ZXhwKSkpKQorCQkgICh1bmxlc3MgKGFuZCBpbWFnZSAoaW1hZ2UtbWFzay1wIGltYWdlKSkKKwkJ ICAgIChzZXRxIGltYWdlIChhcHBlbmQgaW1hZ2UgJyg6bWFzayBoZXVyaXN0aWMpKSkpCisJCSAg KHNldHEgYmluZCAoY29weS1zZXF1ZW5jZSBiaW5kKQorCQkJcGxpc3QgKG50aGNkciAoaWYgKGNv bnNwIChudGggNCBiaW5kKSkgNSA0KQorCQkJCSAgICAgIGJpbmQpKQorCQkgIChwbGlzdC1wdXQg cGxpc3QgOmltYWdlIGltYWdlKSkpCiAJICAgICAgYmluZCkpCiAJICAob3IgbWFwIHRvb2wtYmFy LW1hcCkpKQogCi0tIAoyLjM5LjIKCg== --=_0accceb5b644028fea89c9a75c65089f-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 08 18:04:38 2024 Received: (at 68334) by debbugs.gnu.org; 8 Jan 2024 23:04:38 +0000 Received: from localhost ([127.0.0.1]:37834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMyfd-0002mS-SF for submit@debbugs.gnu.org; Mon, 08 Jan 2024 18:04:38 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:55141 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMyfa-0002mB-NE for 68334@debbugs.gnu.org; Mon, 08 Jan 2024 18:04:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k9yAZB0hjoWqt2NnPSKUqIMFONCM+h1h0a8AdKsmHmk=; b=NzMHRJUZrQaDcBs5QaneKQks3J /9UzT0xBLMwNnqRoLEx5PdE7zgJ6KIa80I3eLoYCyBe8+TQDHedKcigzGnGdc9HQNW0IX3WS3nHRu 9h4KgVQxWcIer9Hq4rf5Ya/TEkm8jLeTA0LX10mjEo7QHZ5pentbcwRC+kAU1CACEqbc=; From: Daniel Mendler To: Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: window-tool-bar (bug#68334) In-Reply-To: (Jared Finder via's message of "Mon, 08 Jan 2024 13:39:25 -0800") References: Date: Tue, 09 Jan 2024 00:04:20 +0100 Message-ID: <874jfnig0b.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68334 Cc: emacs-devel@gnu.org, Jared Finder , 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > I'd like tool-bar-make-keymap-1 to return a sensible keymap on terminals. This > is only a small change from current code, patch attached. > > Context: I am writing a package that displays toolbars attached to an Emacs > window instead of attached to the frame. You can see the package at > . Your idea of attaching toolbars to windows instead of frames sounds interesting, e.g., in the context of touch screens. Would it make sense to add this feature or your package to Emacs directly? Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 08 23:58:03 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 04:58:03 +0000 Received: from localhost ([127.0.0.1]:38068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN4Bf-0004zG-Gn for submit@debbugs.gnu.org; Mon, 08 Jan 2024 23:58:03 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:43458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN4Bc-0004yg-Bs for 68334@debbugs.gnu.org; Mon, 08 Jan 2024 23:58:02 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5572a9b3420so6014643a12.1 for <68334@debbugs.gnu.org>; Mon, 08 Jan 2024 20:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704776268; x=1705381068; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=gGdl5nOWdgTff8BCkiMP0L/vneCh1gVqxwRZJPSXKAA=; b=e00cD5ytQxRWW0P49diVPBxd8wsrF0DFu103Fy0QwULucpOablal083mRZNKCNx/XF S//4Gw8XiuuOLhtWZXPGWVKchshh+BLroBJqVzpPOcedRYRQUxkd7HCIzaqovvrXD8gb twCz1ZVhnCBIiKbU0xAOdDi5qzI/083remGUXsapzhwbmaVG2c61IZo9i1touJrdclm7 jQC1bLhvIEUiCXf3wDwZdvQI9irpQ6P6r8nU2uvy34ypgC7f1bZg9OX04IfNzSP2F0Ba v/SVWF4bHzq08PdTojt1QAt/pia7P5PwoYDb7qyA/PTgLT8NapALh9c2fhE7/cSEVw2D H4Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704776268; x=1705381068; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gGdl5nOWdgTff8BCkiMP0L/vneCh1gVqxwRZJPSXKAA=; b=Xm6QDyOzn2axw5+R7RPSzvz4f8AXxSvaXuwuclc7NvfblzjdtLfN/pdbMS8hJ/npjp JstKa1ShlSc1o5j+TzIAiVAVbPMjoi9NCKovpzUZ0lAZ9GjIe55rM176wEowGsQXxnoH mJRg5/xDV6aCYzhePedX6blwr2nQmnwP6SGkV4hLiXAc6f2wPt6QePZkyQ0Ni7dzT954 zh5Rw7sa8wq4z+efFNTFpXVTvKCxpDxuu6533ycnshJrZczYs59XxT0nKY/bjv0cOgUh iwb/hV0lX3hcYWxOz6EGrYrtaArQNzjQVurQgsxdVqe6FPAnppl/4AoJeZSsUdfOa3Gg UOSA== X-Gm-Message-State: AOJu0YzLU3GL1zkoXvNEO9/TPluit1c+8HRrgZMXW0vDXDAKXEiL7b/+ XThGLmCKejC6JG8Kt9BZRERdw4xUaqI327WqFgf7EAXz X-Google-Smtp-Source: AGHT+IHZYLp+6+gGTYHRbOpmgL6e+hHfmEuHucJcsShR8r4qSmA/rkTdqNE20G7hCQulPaNnfQBU5hQpxq6cgfkb/9c= X-Received: by 2002:a50:c307:0:b0:54d:8e5b:565b with SMTP id a7-20020a50c307000000b0054d8e5b565bmr182741edb.22.1704776267807; Mon, 08 Jan 2024 20:57:47 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 8 Jan 2024 20:57:47 -0800 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Mon, 8 Jan 2024 20:57:47 -0800 Message-ID: Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals To: Jared Finder , 68334@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68334 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Context: I am writing a package that displays toolbars attached to an > Emacs window instead of attached to the frame. You can see the package > at . Shouldn't this be a feature in core Emacs? I believe that we have discussed that in the past. Eli, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 03:00:21 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 08:00:22 +0000 Received: from localhost ([127.0.0.1]:38223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN725-0008Qc-N6 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 03:00:21 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN722-0007wf-0x for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 03:00:20 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 96D751C000D; Tue, 9 Jan 2024 08:00:03 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals In-Reply-To: (Stefan Kangas's message of "Mon, 8 Jan 2024 20:57:47 -0800") Organization: LINKOV.NET References: Date: Tue, 09 Jan 2024 09:58:28 +0200 Message-ID: <86le8zos9b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68334 Cc: Eli Zaretskii , Jared Finder , 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Context: I am writing a package that displays toolbars attached to an >> Emacs window instead of attached to the frame. You can see the package >> at . > > Shouldn't this be a feature in core Emacs? I believe that we have > discussed that in the past. This would be a nice feature, but I think whether to include it in core Emacs depends on the implementation. If it overwrites the tab line, then this might be disappointing for users of tab-line-mode. The README mentions adding (:eval (window-tool-bar-string)) to tab-line-format, but I don't understand how this could solve the problem. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 07:40:48 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 12:40:48 +0000 Received: from localhost ([127.0.0.1]:38613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBPU-0005ic-48 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 07:40:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBPS-0005iQ-Qn for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 07:40:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNBPG-0007OX-El; Tue, 09 Jan 2024 07:40:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aeWI0Zb24aqeztvBMtOhhHhLTF4eL/b/rSbN1Y2hvLw=; b=NFDajHCiBJXT +dxnBYL/der40cfqV5Igztu0PsKwVIBliHFCeg0GO8TTh7PRKRqqXaBnkLUzbZIP4Q+ZUQ9z2QNJx e1ncngJc85rAcJpdjRcbTP1xTQNMdjuaJXnulwOHdgZKIpaLaM9oX87Xu9wh9G5wkr0G2Uksfv39g oI1cZkYemeVt6bkV7MMULENgsZ/Xk5lK87cFhYf0B9jh1hRraO+UgMYPUhYajQ9Q3x/NUTJ6Wr4iU cV0moUsn0rjkishqnDXuuc6FdX27jW0Kzwvt6fWyK0dUwamjEnW2R7RItJgTP8lofj7C5S4sVzf1I HuZiGWP4MIMBhazmqD5TjQ==; Date: Tue, 09 Jan 2024 14:40:11 +0200 Message-Id: <83plyaptn8.fsf@gnu.org> From: Eli Zaretskii To: Jared Finder In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68334 Cc: 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 08 Jan 2024 13:39:25 -0800 > From: Jared Finder via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I'd like tool-bar-make-keymap-1 to return a sensible keymap on > terminals. This is only a small change from current code, patch > attached. I don't see any problems with the change, but please add comments there explaining that some parts of the code are supposed to work on frames where images cannot be displayed, because it is very easy to mistakenly assume this only needs to work on GUI frames. Btw, what happens if display-images-p returns non-nil, but the session doesn't support images of the type used for tool-bar icons? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 08:06:49 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 13:06:49 +0000 Received: from localhost ([127.0.0.1]:38650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBof-0003Es-E2 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 08:06:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBod-0003Eg-Vx for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 08:06:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNBoQ-0002u3-HR; Tue, 09 Jan 2024 08:06:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=s3HFkUrXXwyPopoZxvzwNM7gymdzUaXCgoBPzOA2bIM=; b=fGjg/ckfDldq GlbI2jj2MJ1/Iy/vRqC3lXSPVWanclVLz4tVVxjNLGrU/AqQp8mZOvPH8XOLIpVImdihxWm5i4GjE IP4zIXIwJshPuIeJdL8VrB2+kyw9wD92WUEicGZx+U+rRWKQOXn+skbP8Ik9tO+9KCUyxFQPdKFTq Ik+zN2TlEUOM+uUIZLzYttDlphxWcYYZCnTgEKuY/vY7XWLrI9+S9GkAmQtVOyDkVn2eOG9la/Kh+ PHk9w59c+rTdQ4obxQHZA0i+ImID/LL9E3PExxg7qwrE/LsUjXh8FL7UG+AFZfAcWbXk5cEFW767V cFX10b7uyodUlqKMHtsucg==; Date: Tue, 09 Jan 2024 15:06:14 +0200 Message-Id: <83mstepsft.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <874jfnig0b.fsf@daniel-mendler.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#68334: window-tool-bar (bug#68334) References: <874jfnig0b.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68334 Cc: emacs-devel@gnu.org, jared@finder.org, 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: emacs-devel@gnu.org, jared@finder.org > Date: Tue, 09 Jan 2024 00:04:20 +0100 > From: Daniel Mendler via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > Context: I am writing a package that displays toolbars attached to an Emacs > > window instead of attached to the frame. You can see the package at > > . > > Your idea of attaching toolbars to windows instead of frames sounds > interesting, e.g., in the context of touch screens. Would it make sense > to add this feature or your package to Emacs directly? I'd love to see a usable tool bar in "M-x gdb" on TTY frames, FWIW. Right now, we have a very poor substitute there, which looks not very nice, to put it mildly. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 08:14:04 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 13:14:04 +0000 Received: from localhost ([127.0.0.1]:38677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBvf-0003RZ-LE for submit@debbugs.gnu.org; Tue, 09 Jan 2024 08:14:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBve-0003Qv-1W for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 08:14:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNBvR-0006V7-KT; Tue, 09 Jan 2024 08:13:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eObnDHd/pBkKTCWPFzWWIr20aYdYZzreboR8Lry787c=; b=ZILQfQPeSqkV /QRBZPXfID6H93R1C6G4IUZ0x9JvRB6SEd2otVHELlPgJNKj9nh91/HcVLtzlvymqKjMx8vVIIdy6 bFWJJTEGplmLzGNjdfwVjS2PkeOoroHueFUv+RZsOFqXL+ocpcQayqMX9lmogYZ5CptsJaOQ2Gewv a4hAaRO2MmbS6rt2cUtVXvsJmosmaxUTsLtIdRuEh1+aHR+ku+a52ZEMm9GuMWMJCJZoPxy2hUqq+ 4q/cA3z9BzBtJP4NeNlE2zdBoNu7E+4dskar1dsdH1y84Irg8wJ3vPNTxusKodhEjJNzExCVYeaCu WRG6XPrT3/fta2NnAplXhA==; Date: Tue, 09 Jan 2024 15:13:27 +0200 Message-Id: <83le8yps3s.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Mon, 8 Jan 2024 20:57:47 -0800) Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68334 Cc: jared@finder.org, 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Mon, 8 Jan 2024 20:57:47 -0800 > Cc: Eli Zaretskii > > Jared Finder via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > Context: I am writing a package that displays toolbars attached to an > > Emacs window instead of attached to the frame. You can see the package > > at . > > Shouldn't this be a feature in core Emacs? I believe that we have > discussed that in the past. > > Eli, WDYT? I won't mind, if Jared thinks the package will be useful in enough situations or for enough packages. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 13:39:20 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 18:39:20 +0000 Received: from localhost ([127.0.0.1]:40937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNH0S-0002eM-Bm for submit@debbugs.gnu.org; Tue, 09 Jan 2024 13:39:20 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:45281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNH0Q-0002e8-Cr for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 13:39:19 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5582796b85bso609808a12.2 for <68334@debbugs.gnu.org>; Tue, 09 Jan 2024 10:39:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704825545; x=1705430345; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=fWJ9PThnQ1p2riCwSrQo2xc5Iz2USkH1fKZVkRRbAz8=; b=eFkox0A/T5QcDxBmSUjx080U7+b0EIhNk5cfGWEgLKTz5MmcLd26R6iU31OUo/FIrR mwH71YrDyZXBujoOIzULoqFlxVPSaMobzo7nudiu/igAW8L6ifjmVzU6a16yRaVSqwES gsdzWF1k0yCZpgMX40xqWO8/5+IrqzfbzeW0SrGEJh6BctMNpEqMYt2RIbILgYW2ByoZ szRVoRJbHVGI6m2xVH952LunNKr6qqzbQgvBHBhCrbuPD1eCkoDgwjbiJUgmJ/XRyOxi u18qv8t2JjzRze9RTJA6llxYEwAvmcXB2Noc29aeCSQ/bXe8MIFg5yXFsByW+G2u5jOL QYfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704825545; x=1705430345; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fWJ9PThnQ1p2riCwSrQo2xc5Iz2USkH1fKZVkRRbAz8=; b=Bp7RodOeKIdC9pWfJnB/20hkgbxS0Qa57kQpvEF936s3kROoZsFBkDqIl/5/muARIq T63A7tt5gpR0gTEwq1OCAvlanFn4yos5Sb8cIMyGQmAoyFRki4/bML/g7xqcZVH6VrMr retQKJJsriCKWsnMoP1deVXCT256D0L70tfpp+mOmcb5+mkWuIY3ukrlPx7HJ+ryo51V yQye0LjNHDB1aAPj8ybBcAWIcj7/8A+XNtmquV1st4/PJvK+pv7sYduSPYeJfCmZEWK/ VCFdKNXMvqznIg0wcKTJ2JlIlNC5O3ae06GukvkyqraagXmnIHU8O6aUEQCiiI5jV3NL vPNw== X-Gm-Message-State: AOJu0YzHjpLLHU5CYdvM6qqY2NyPpNhHR4Um4fVr2DEqGeZTXW7X/3NB idFF3j085JnFEF7oTwj7DfientRtGk0iHAc4uNGz8B+N X-Google-Smtp-Source: AGHT+IG/q3GkiNRQtrLkiahSQa2husmOrM0AHK388u/UXiqNvrL28BOYc1KMQ34MPqe6pX6DIfaF9D/yWFyiwDmvIMo= X-Received: by 2002:a50:ec96:0:b0:553:7613:ff4a with SMTP id e22-20020a50ec96000000b005537613ff4amr3093072edr.5.1704825545440; Tue, 09 Jan 2024 10:39:05 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Jan 2024 10:39:05 -0800 From: Stefan Kangas In-Reply-To: <83le8yps3s.fsf@gnu.org> References: <83le8yps3s.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 9 Jan 2024 10:39:05 -0800 Message-ID: Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68334 Cc: jared@finder.org, 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> > Context: I am writing a package that displays toolbars attached to an >> > Emacs window instead of attached to the frame. You can see the package >> > at . >> >> Shouldn't this be a feature in core Emacs? I believe that we have >> discussed that in the past. >> >> Eli, WDYT? > > I won't mind, if Jared thinks the package will be useful in enough > situations or for enough packages. I didn't intend to propose including the existing implementation as is, which I hadn't looked closely at. Having done that just now, it seems like it's implemented on the tab bar, as Juri has pointed out. I think this is probably not the right thing for a feature in Emacs itself. This feature would be most useful as a first class feature, but that might require C changes. My intention here is merely to ask if anyone (perhaps Jared) would be interested in working on that. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 13:58:11 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 18:58:11 +0000 Received: from localhost ([127.0.0.1]:40957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHIg-0005pS-Pi for submit@debbugs.gnu.org; Tue, 09 Jan 2024 13:58:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHIf-0005pG-CQ for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 13:58:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNHIS-0008TS-4j; Tue, 09 Jan 2024 13:57:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=b+1LjwkUMSsrmLn+Thac4/xvQHJ/IVhX039S99bzOZI=; b=Ol1vXrfY/mOR 3bGOXFSU+iFacN9s40YubHH2ntor5mO0ctVL//0NwSYUINzFj1Fmm2qQnH2HqlyixUlclaxdVyrWH EjOsRDt/uHip8u9rWklzqqLSftyqTo0RNKqMnsIPYpaqKpGxZjmzt2QBW7yu1tpeFeYh57IZ+ceeh ZDnnduJOoRs796kS5Hu8g2aU2HzqnOBzosNTqNdRzix5P3x4kzDJM5slyaFF17aE72yJ43Re1K00h bNa5hG5cILUPnQJ7HffMLwjeoQM8A+O79Z3whfIKDAbleRdrFDMab5HJayR2fQw9SL4VR0bjuisBG El19Urtsocb71/O/GwynBg==; Date: Tue, 09 Jan 2024 20:57:35 +0200 Message-Id: <8334v6pc68.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 9 Jan 2024 10:39:05 -0800) Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals References: <83le8yps3s.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68334 Cc: jared@finder.org, 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 9 Jan 2024 10:39:05 -0800 > Cc: jared@finder.org, 68334@debbugs.gnu.org > > Eli Zaretskii writes: > > >> > Context: I am writing a package that displays toolbars attached to an > >> > Emacs window instead of attached to the frame. You can see the package > >> > at . > >> > >> Shouldn't this be a feature in core Emacs? I believe that we have > >> discussed that in the past. > >> > >> Eli, WDYT? > > > > I won't mind, if Jared thinks the package will be useful in enough > > situations or for enough packages. > > I didn't intend to propose including the existing implementation as is, > which I hadn't looked closely at. Having done that just now, it seems > like it's implemented on the tab bar, as Juri has pointed out. I think > this is probably not the right thing for a feature in Emacs itself. How else do you expect this to be implemented on TTY frames? It can either overwrite parts of the menu bar, or it could overwrite parts of the tab bar. Something's gotta give, no? I also don't understand why the tab bar is deemed more important than the tool bar. Let's let users decide what they prefer. (Of course, if there's a way to let them have the cake and eat it, too, that would be the best.) > This feature would be most useful as a first class feature, but that > might require C changes. IMO, usurping one more screen line from TTY frames could be problematic, especially on terminals that display a relatively small number of lines. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 14:09:01 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 19:09:01 +0000 Received: from localhost ([127.0.0.1]:40962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHTB-0000Fm-0V for submit@debbugs.gnu.org; Tue, 09 Jan 2024 14:09:01 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:42460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHT9-0000FX-6H for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 14:08:59 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-557c188f313so3667867a12.1 for <68334@debbugs.gnu.org>; Tue, 09 Jan 2024 11:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704827326; x=1705432126; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=dr/pqXshlbTjqHPnAL1ZuXPMRoueA5Im7/qZoblY0Wc=; b=aJeb+pFPzv9CjXqk7ZiFd9VbQPH0ftg6hV9GTj7ZwaCUvktFCKS5zqh/2ORNb82FR1 LfPNQVeRhiBR01BpqaACvN7piivqungwWZkTjA31HbYBC2QWM35/vV2kWBNGaZhgOkYA 76UReguq5fCLIL3wZk/hjg7wfXzM/hV3P+gUwtRqB+eTn5Rtjwxb5EFK88JcqcayL8Xe F2xI7E7SSihezsvaLy0X9/y3eFBAl79SWs1DFb8zA6+qz+tgFLkXhlxEX9pbwSSY7UE3 0DYP4qKFouBnMcBsCW0htsr1a3yQfnAdIlZaFaCBF33anV21yfXcBRljQXt/qv3uInI5 XDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704827326; x=1705432126; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dr/pqXshlbTjqHPnAL1ZuXPMRoueA5Im7/qZoblY0Wc=; b=cLHl5fgMcDyb2k3PuQ33OB3Xx0eAhCORvEmU2JJroa5/V+RmxDulWxWmf2iMVdmIYv 9nXkAXL37xEtDKKgQFXa5XBteO7HbfZ0iD4VOURziaDhwLqXjbji0YCQn0CuR6a/GAGN 0PO9GEhY9RrVIec8kH4vr6y1+q8ULA4mJWthf5CR7/Goh2BF7TpI4uAaowJv2WidEx6Q CM1+NWrf+7LDAI33bF/D+q1O6DvVHS1sETprPPk3C+YkdJoSCx9eWBIf/OsE6IawIFmU ehTe6261q8eys7h9ZcU8GBWp4K8SzgmRu/5qgRd9p17Rksoz/MBxbPq7M7WcGExWaFg2 68Jg== X-Gm-Message-State: AOJu0YwdgILWOlJWHwlO+dD8USC/Gglu/osBP4ERlm7nB4tw2iyABVl0 K3vYszhzs+I8SG0bXkRC8tmKX9AODr8Mr9GxNE+V09rY X-Google-Smtp-Source: AGHT+IHIxF0atzJKyo5QmnUL4vYF/7Rse/RhgbYCpzRgQ7Hm/85Dtwg2Qbt1RmPRHJKfD/YDHQHn3i9TV9CSGWCcJ9k= X-Received: by 2002:a50:bae7:0:b0:557:fc7a:3a5c with SMTP id x94-20020a50bae7000000b00557fc7a3a5cmr1200659ede.6.1704827326321; Tue, 09 Jan 2024 11:08:46 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Jan 2024 11:08:46 -0800 From: Stefan Kangas In-Reply-To: <8334v6pc68.fsf@gnu.org> References: <83le8yps3s.fsf@gnu.org> <8334v6pc68.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 9 Jan 2024 11:08:46 -0800 Message-ID: Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68334 Cc: jared@finder.org, 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I didn't intend to propose including the existing implementation as is, >> which I hadn't looked closely at. Having done that just now, it seems >> like it's implemented on the tab bar, as Juri has pointed out. I think >> this is probably not the right thing for a feature in Emacs itself. > > How else do you expect this to be implemented on TTY frames? It can > either overwrite parts of the menu bar, or it could overwrite parts of > the tab bar. Something's gotta give, no? > > I also don't understand why the tab bar is deemed more important than > the tool bar. Let's let users decide what they prefer. (Of course, > if there's a way to let them have the cake and eat it, too, that would > be the best.) > >> This feature would be most useful as a first class feature, but that >> might require C changes. > > IMO, usurping one more screen line from TTY frames could be > problematic, especially on terminals that display a relatively small > number of lines. You could add another line, so that you could use the tab-bar and the tool-bar at the same time. That would provide the most flexibility for users, I think. They would themselves get to decide how many lines to sacrifice. (Many users also have huge screens these days, including vertical ones.) That said, I don't at all object to the current implementation as an optional feature in core, if you think it's a good idea. There's no reason to allow perfect to be the enemy of the good. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 14:28:28 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 19:28:29 +0000 Received: from localhost ([127.0.0.1]:40988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHm0-0003NG-Ii for submit@debbugs.gnu.org; Tue, 09 Jan 2024 14:28:28 -0500 Received: from greenhill.hpalace.com ([192.155.80.58]:55458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHly-0003N4-LC for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 14:28:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1704828498; bh=6noZ2LIO49v8/qh+fN3BtVxd8oaJSvXoxT1Scz3ksT4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NJOPFiubJRDV0GyVG3XHTC/iFMbfjrK3nhzOb8uXeGLsjrGAiIp/RwdkTveFYUlNV bd40l0QedBjF0lvmrbSRSAy/GgEysB44UGRZby/GcOE36FOOSC0gxFzPrxdOgPMCNt iUN+oCI8s9eEfDR3T+bTcb/PI3jwWgjf2F5lO6Gl9SSoPFzD3AkyrRzSZcvzVthqrF 2K/JGCvA1s9AnrDWOtx4tqnL4eBdRdRihA36n21VbOeACQIXwOw/wX7xx71rfWwlsG sSR5h5tbt+XLOmY0GWCkf0Zo2glu0Otzh/G6iURVSB1s2iJ16ElvN2VCOqm6R3UtdL VESGngdjZx6RQ== Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 2D1FECB8; Tue, 9 Jan 2024 19:28:18 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 09 Jan 2024 11:28:17 -0800 From: Jared Finder To: Stefan Kangas Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals In-Reply-To: References: <83le8yps3s.fsf@gnu.org> <8334v6pc68.fsf@gnu.org> Message-ID: <2620b07ece7042ee685f1a596ffe70d9@finder.org> X-Sender: jared@finder.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68334 Cc: Eli Zaretskii , 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-01-09 11:08, Stefan Kangas wrote: > Eli Zaretskii writes: > >>> I didn't intend to propose including the existing implementation as >>> is, >>> which I hadn't looked closely at. Having done that just now, it >>> seems >>> like it's implemented on the tab bar, as Juri has pointed out. I >>> think >>> this is probably not the right thing for a feature in Emacs itself. >> >> How else do you expect this to be implemented on TTY frames? It can >> either overwrite parts of the menu bar, or it could overwrite parts of >> the tab bar. Something's gotta give, no? >> >> I also don't understand why the tab bar is deemed more important than >> the tool bar. Let's let users decide what they prefer. (Of course, >> if there's a way to let them have the cake and eat it, too, that would >> be the best.) >> >>> This feature would be most useful as a first class feature, but that >>> might require C changes. >> >> IMO, usurping one more screen line from TTY frames could be >> problematic, especially on terminals that display a relatively small >> number of lines. > > You could add another line, so that you could use the tab-bar and the > tool-bar at the same time. That would provide the most flexibility for > users, I think. They would themselves get to decide how many lines to > sacrifice. (Many users also have huge screens these days, including > vertical ones.) > > That said, I don't at all object to the current implementation as an > optional feature in core, if you think it's a good idea. There's no > reason to allow perfect to be the enemy of the good. If this goes in core, I'd like to make window-tool-bar-mode and tab-line-mode work nicely together. Right now they both just overwrite tab-line-format, but I think a better implementation would result in them both appears in the tab-line side by side when both are enabled. In other words, if both are enabled tab-line-format would have a value like ((:eval (tab-line-format)) " " (:eval (window-tool-bar-string))). I'm also happy to also add an additional line. At that point there'd be three lines, so would it be worth it to add an option to control the order of the lines? I can imagine a variable that contains lines / prefix events for lines above a buffer and controls the order. I certainly would appreciate this flexibility. Let me know what you think is the right way to proceed. -- MJF From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 14:57:02 2024 Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 19:57:02 +0000 Received: from localhost ([127.0.0.1]:41037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNIDe-00014E-HC for submit@debbugs.gnu.org; Tue, 09 Jan 2024 14:57:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNIDc-00013i-VY for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 14:57:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNIDO-0002GG-C9; Tue, 09 Jan 2024 14:56:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uGEjYNou+IxZfVlQrP5oV5m9vLlP5UoDCKI9lczmW1k=; b=P3XngMdBpHiF C02y7262FlTc9PYkfeipKWEP7IIcwQmU2Vt8DjwWBos2YIn/dwfWTISS+eazetgtOXA+IVt6ylYg0 UXUyu7N/gWgGzKLfdsE7YbR7lkJCz3kA00Lt37p4l0WKrlIi0cV/2Zenys78CEH8U6C6+nyk7V2BL g5LFYivIP1IWr/RJpQ0VC7wVgeDuidn+I88pa+zbKfPXOpBk0WAqNXkNJMRV6Y+nUAuZU+CSpivF8 LIcW/wNYleUz8sukUCh+ynDHRkifevOXnWpUc08HnaEUzbMRSnTeXsJPtrFA5puhcBiis4Tm5w3ZF IM8K3Rts7Rspma5IWDG+ew==; Date: Tue, 09 Jan 2024 21:56:27 +0200 Message-Id: <83v882nuvo.fsf@gnu.org> From: Eli Zaretskii To: Jared Finder In-Reply-To: <2620b07ece7042ee685f1a596ffe70d9@finder.org> (message from Jared Finder on Tue, 09 Jan 2024 11:28:17 -0800) Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals References: <83le8yps3s.fsf@gnu.org> <8334v6pc68.fsf@gnu.org> <2620b07ece7042ee685f1a596ffe70d9@finder.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68334 Cc: stefankangas@gmail.com, 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 09 Jan 2024 11:28:17 -0800 > From: Jared Finder > Cc: Eli Zaretskii , 68334@debbugs.gnu.org > > If this goes in core, I'd like to make window-tool-bar-mode and > tab-line-mode work nicely together. Right now they both just overwrite > tab-line-format, but I think a better implementation would result in > them both appears in the tab-line side by side when both are enabled. > In other words, if both are enabled tab-line-format would have a value > like > > ((:eval (tab-line-format)) " " (:eval (window-tool-bar-string))). > > > I'm also happy to also add an additional line. At that point there'd be > three lines, so would it be worth it to add an option to control the > order of the lines? I can imagine a variable that contains lines / > prefix events for lines above a buffer and controls the order. I > certainly would appreciate this flexibility. I'd prefer not to add another line, if possible. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 02:32:41 2024 Received: (at 68334) by debbugs.gnu.org; 10 Jan 2024 07:32:41 +0000 Received: from localhost ([127.0.0.1]:41624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNT4r-0007gB-JP for submit@debbugs.gnu.org; Wed, 10 Jan 2024 02:32:41 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:57637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNT4p-0007ft-5v for 68334@debbugs.gnu.org; Wed, 10 Jan 2024 02:32:39 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0FF5EE0004; Wed, 10 Jan 2024 07:32:23 +0000 (UTC) From: Juri Linkov To: Jared Finder Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals In-Reply-To: <2620b07ece7042ee685f1a596ffe70d9@finder.org> (Jared Finder via's message of "Tue, 09 Jan 2024 11:28:17 -0800") Organization: LINKOV.NET References: <83le8yps3s.fsf@gnu.org> <8334v6pc68.fsf@gnu.org> <2620b07ece7042ee685f1a596ffe70d9@finder.org> Date: Wed, 10 Jan 2024 09:24:35 +0200 Message-ID: <86wmshoglk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68334 Cc: Eli Zaretskii , Stefan Kangas , 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > If this goes in core, I'd like to make window-tool-bar-mode and > tab-line-mode work nicely together. Right now they both just overwrite > tab-line-format, but I think a better implementation would result in them > both appears in the tab-line side by side when both are enabled. In other > words, if both are enabled tab-line-format would have a value like > > ((:eval (tab-line-format)) " " (:eval (window-tool-bar-string))). > > I'm also happy to also add an additional line. At that point there'd be > three lines, so would it be worth it to add an option to control the order > of the lines? I can imagine a variable that contains lines / prefix events > for lines above a buffer and controls the order. I certainly would > appreciate this flexibility. Instead of asking the users to set tab-line-format to the expression above adding a simple option would be nice. Such option could define how to combine the window tool-line with the tab-line. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 17:59:27 2024 Received: (at 68334) by debbugs.gnu.org; 10 Jan 2024 22:59:28 +0000 Received: from localhost ([127.0.0.1]:43538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhXj-0005oM-GR for submit@debbugs.gnu.org; Wed, 10 Jan 2024 17:59:27 -0500 Received: from greenhill.hpalace.com ([192.155.80.58]:41068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhXh-0005oD-PA for 68334@debbugs.gnu.org; Wed, 10 Jan 2024 17:59:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1704927565; bh=dqvIPiX9O2KRg+minRKQRQNBwT/wfpHFNK21m0Oj0io=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=X2683tjnGGjaTo4wEmndsWlu6jNolXaBGtAAj5QVZ6CeE7RpJCRJchSGNVZZiwxuE D+ToOwOmvYikVJ2dHwOvmjW7pWqSnprXFT/mMmH5VrXC11tJekmNQIkZSwLmWQcX18 1NTTAw33OMAOJ3ZwgV3+jhwjsbriTe3wulLAhTqF+4uLC7I9zalDRxrhmncf9sdpXg w2MebevqbItQmlQl34Oel5nFpUOnXeI2kiiS36dqXIB7HUklWcycNFyG0rXr0ZkeXP 6L9mr0T5//IFPbI5XLoqmbKcoqQwo6/njPMAmvCnjvBMn5fB38kK5H4gMvwMGmNQFn +Cd+IiY4X4Scg== Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id C0534108D; Wed, 10 Jan 2024 22:59:25 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 10 Jan 2024 14:59:25 -0800 From: Jared Finder To: Eli Zaretskii Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals In-Reply-To: <83plyaptn8.fsf@gnu.org> References: <83plyaptn8.fsf@gnu.org> Message-ID: <8721504db5c2be47352db0230248f036@finder.org> X-Sender: jared@finder.org Content-Type: multipart/mixed; boundary="=_77380c36db3254c8fbfa935a1c9239f2" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68334 Cc: 68334@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=_77380c36db3254c8fbfa935a1c9239f2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2024-01-09 04:40, Eli Zaretskii wrote: >> Date: Mon, 08 Jan 2024 13:39:25 -0800 >> From: Jared Finder via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> I'd like tool-bar-make-keymap-1 to return a sensible keymap on >> terminals. This is only a small change from current code, patch >> attached. > > I don't see any problems with the change, but please add comments > there explaining that some parts of the code are supposed to work on > frames where images cannot be displayed, because it is very easy to > mistakenly assume this only needs to work on GUI frames. New patch attached with comment added. For the other discussions about making per-window tool bars part of core, I expect a handful of additional patches so I can file a separate bug report if that makes tracking things easier. > Btw, what happens if display-images-p returns non-nil, but the session > doesn't support images of the type used for tool-bar icons? Then a keybind is generated with no image spec because find-image will not find any supported image. Such binds are silently ignored by the current tool bar logic on PGTK and Mac builds. You can see this behavior today in M-x customize, where the " Toggle hiding all values " bind is not displayed. I was going to report this as a separate bug because this behavior seems poor -- I think a text only tool bar button would be preferred. -- MJF --=_77380c36db3254c8fbfa935a1c9239f2 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-lisp-tool-bar.el-tool-bar-make-keymap-1-Populate-on-.patch Content-Disposition: attachment; filename=0001-lisp-tool-bar.el-tool-bar-make-keymap-1-Populate-on-.patch; size=1740 RnJvbSA3NTgxYmZkYTVkZmUzYWQ1NzMyZGE2YjUxOGI4Yzc3ZTM1MGIxYjllIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXJlZCBGaW5kZXIgPGphcmVkQGZpbmRlci5vcmc+CkRhdGU6 IE1vbiwgOCBKYW4gMjAyNCAxMzoyMDoyNSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdICogbGlzcC90 b29sLWJhci5lbCAodG9vbC1iYXItbWFrZS1rZXltYXAtMSk6IFBvcHVsYXRlIG9uCiB0ZXJtaW5h bHMKCi0tLQogbGlzcC90b29sLWJhci5lbCB8IDE5ICsrKysrKysrKystLS0tLS0tLS0KIDEgZmls ZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpc3AvdG9vbC1iYXIuZWwgYi9saXNwL3Rvb2wtYmFyLmVsCmluZGV4IDRjYTgxZmIwMWUwLi45 NmI2MWM3YjIyOSAxMDA2NDQKLS0tIGEvbGlzcC90b29sLWJhci5lbAorKysgYi9saXNwL3Rvb2wt YmFyLmVsCkBAIC0xNjUsNiArMTY1LDggQEAgdG9vbC1iYXItbWFrZS1rZXltYXAKICAgICAgICAg ICAgIGJhc2Uta2V5bWFwKQogICAgICAgYmFzZS1rZXltYXApKSkKIAorOzsgVGhpcyBmdW5jdGlv biBzaG91bGQgcmV0dXJuIGJpbmRzIGV2ZW4gaWYgaW1hZ2VzIGNhbiBub3QgYmUKKzs7IGRpc3Bs YXllZCBzbyB0aGUgdG9vbCBiYXIgY2FuIHN0aWxsIGJlIGRpc3BsYXllZCBvbiB0ZXJtaW5hbHMu CiAoZGVmdW4gdG9vbC1iYXItbWFrZS1rZXltYXAtMSAoJm9wdGlvbmFsIG1hcCkKICAgIkdlbmVy YXRlIGFuIGFjdHVhbCBrZXltYXAgZnJvbSBgdG9vbC1iYXItbWFwJywgd2l0aG91dCBjYWNoaW5n LgogTUFQIGlzIGVpdGhlciBhIGtleW1hcCB0byB1c2UgYXMgYSBzb3VyY2UgZm9yIG1lbnUgaXRl bXMsIG9yIG5pbCwKQEAgLTE4MCwxNSArMTgyLDE0IEBAIHRvb2wtYmFyLW1ha2Uta2V5bWFwLTEK IAkJCSAoY29uc3AgaW1hZ2UtZXhwKQogCQkJIChub3QgKGVxIChjYXIgaW1hZ2UtZXhwKSAnaW1h Z2UpKQogCQkJIChmYm91bmRwIChjYXIgaW1hZ2UtZXhwKSkpCi0JCShpZiAobm90IChkaXNwbGF5 LWltYWdlcy1wKSkKLQkJICAgIChzZXRxIGJpbmQgbmlsKQotCQkgIChsZXQgKChpbWFnZSAoZXZh bCBpbWFnZS1leHApKSkKLQkJICAgICh1bmxlc3MgKGFuZCBpbWFnZSAoaW1hZ2UtbWFzay1wIGlt YWdlKSkKLQkJICAgICAgKHNldHEgaW1hZ2UgKGFwcGVuZCBpbWFnZSAnKDptYXNrIGhldXJpc3Rp YykpKSkKLQkJICAgIChzZXRxIGJpbmQgKGNvcHktc2VxdWVuY2UgYmluZCkKLQkJCSAgcGxpc3Qg KG50aGNkciAoaWYgKGNvbnNwIChudGggNCBiaW5kKSkgNSA0KQotCQkJCQliaW5kKSkKLQkJICAg IChwbGlzdC1wdXQgcGxpc3QgOmltYWdlIGltYWdlKSkpKQorCQkobGV0ICgoaW1hZ2UgKGFuZCAo ZGlzcGxheS1pbWFnZXMtcCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXZh bCBpbWFnZS1leHApKSkpCisJCSAgKHVubGVzcyAoYW5kIGltYWdlIChpbWFnZS1tYXNrLXAgaW1h Z2UpKQorCQkgICAgKHNldHEgaW1hZ2UgKGFwcGVuZCBpbWFnZSAnKDptYXNrIGhldXJpc3RpYykp KSkKKwkJICAoc2V0cSBiaW5kIChjb3B5LXNlcXVlbmNlIGJpbmQpCisJCQlwbGlzdCAobnRoY2Ry IChpZiAoY29uc3AgKG50aCA0IGJpbmQpKSA1IDQpCisJCQkJICAgICAgYmluZCkpCisJCSAgKHBs aXN0LXB1dCBwbGlzdCA6aW1hZ2UgaW1hZ2UpKSkKIAkgICAgICBiaW5kKSkKIAkgIChvciBtYXAg dG9vbC1iYXItbWFwKSkpCiAKLS0gCjIuMzkuMgoK --=_77380c36db3254c8fbfa935a1c9239f2-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 05:51:29 2024 Received: (at 68334-done) by debbugs.gnu.org; 11 Jan 2024 10:51:29 +0000 Received: from localhost ([127.0.0.1]:58815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNsen-0007lQ-7t for submit@debbugs.gnu.org; Thu, 11 Jan 2024 05:51:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNsek-0007l9-SF for 68334-done@debbugs.gnu.org; Thu, 11 Jan 2024 05:51:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNseh-0006Fq-LC; Thu, 11 Jan 2024 05:51:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QG3kTDEM05PUrcPBLXz9LTmEJ+sQUX9wI7KBdXv30v8=; b=DpTjPBEzUebT kU1MEaB4B7fo7shDtJXJjGTu1UgK1c8VgjRS5vQwTbHEwEg0631OqhZ9luS9Eu0K/UWeJWGe2SeZt 4o+1uQQS96i5PUkHrUxNOnAnK3ZE7PidjJp3v12txzr1PC5FyRsaoTYK3gl1oWzAObxTELrUHXrNH pRKm/hpgntam7UNP2HFWSq5QA0zGg/2AAS/4NdmFudLUggAqsPwlJ5Gw6XtvdA7C5Y65/hsED9+8a 5FpgFvWbJAVKMUxQ01hf7HrlMvw1IXnBlbeYdFiG/CICU6LQxific2Ha1Tdh2nkI81S2+g/9vbZry J5ohVzc5Hof2OIzRGlT9aQ==; Date: Thu, 11 Jan 2024 12:51:06 +0200 Message-Id: <83v880kusl.fsf@gnu.org> From: Eli Zaretskii To: Jared Finder In-Reply-To: <8721504db5c2be47352db0230248f036@finder.org> (message from Jared Finder on Wed, 10 Jan 2024 14:59:25 -0800) Subject: Re: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals References: <83plyaptn8.fsf@gnu.org> <8721504db5c2be47352db0230248f036@finder.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68334-done Cc: 68334-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 10 Jan 2024 14:59:25 -0800 > From: Jared Finder > Cc: 68334@debbugs.gnu.org > > > I don't see any problems with the change, but please add comments > > there explaining that some parts of the code are supposed to work on > > frames where images cannot be displayed, because it is very easy to > > mistakenly assume this only needs to work on GUI frames. > > New patch attached with comment added. Thanks, installed on master. > For the other discussions about making per-window tool bars part of > core, I expect a handful of additional patches so I can file a separate > bug report if that makes tracking things easier. OK, so I'm closing this bug. From unknown Sun Aug 17 22:12:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Feb 2024 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator