GNU bug report logs - #68309
[PATCH] gnu: Add powertop-service-type.

Previous Next

Full log

Message #26 received at 68309 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 68309 <at> debbugs.gnu.org
Subject: Re: [bug#68309] [PATCH 1/2] gnu: Add powertop-service-type.
Date: Sat, 01 Jun 2024 11:18:28 -0700

Hi Mathieu,

Sorry for the extremely late response on this.

Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hey,
>
> Thanks for the v2!
>
>> +The @code{(gnu services pm)} module provides a Guix service 
>> definition
>> +for PowerTOP.  When started, it tunes kernel settings to 
>> reduce power
>> +consumption.
>
> I have this error when building the documentation:
>
> guix.texi:34841: `@end' expected `lisp', but saw `defvar'
>

Fixed in v3, which I just sent.

>> +
>> +
>> +
>
> Kill that extra line
>

This matches the style used by every other package in the module, 
so I believe it should stay how it is.

>> +;;;
>> +;;; powertop
>> +;;;
>> +;;; Calls `powertop --auto-tune' to reduce energy consumption.
>> +
>> +
>
> That one too.
>

Done.

>> +   (description "Tune power-related kernel parameters to 
>> reduce energy consumption.")))
>
> Wrap it to be under 78 characters.
>

Done.

 — Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.