GNU bug report logs - #68294
[PATCH] Set the 'name' prop in 'define-advice'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Steven Allen <steven <at> stebalien.com>
Subject: bug#68294: closed (Re: bug#68294: [PATCH] Set the 'name' prop in
 'define-advice')
Date: Sat, 13 Jan 2024 09:45:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#68294: [PATCH] Set the 'name' prop in 'define-advice'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 68294 <at> debbugs.gnu.org.

-- 
68294: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68294
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Steven Allen <steven <at> stebalien.com>
Cc: 68294-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#68294: [PATCH] Set the 'name' prop in 'define-advice'
Date: Sat, 13 Jan 2024 11:44:19 +0200

> From: Steven Allen <steven <at> stebalien.com>
> Cc: 68294 <at> debbugs.gnu.org
> Date: Mon, 08 Jan 2024 07:42:29 -0800
> 
> >>  @defmac define-advice symbol (where lambda-list &optional name depth) &rest body
> >>  This macro defines a piece of advice and adds it to the function named
> >> -@var{symbol}.  The advice is an anonymous function if @var{name} is
> >> -@code{nil} or a function named @code{symbol@@name}.  See
> >> -@code{advice-add} for explanation of other arguments.
> >> +@var{symbol}.  If @var{name} is non-nil, the advice is named
> >> +@code{symbol@@name} and installed with the name @var{name}; otherwise,
> >    ^^^^^^^^^^^^^^^^^^^
> > This should be @code{@var{symbol}@@@var{name}}.
> 
> Fixed.
> 
> >> +** 'define-advice' now sets the new advice's 'name' property to NAME
> >> +Named advice defined with 'define-advice' can now be remove with
> >                                                         ^^^^^^
> > This should be "removed".
> 
> Fixed.

Thanks, installed on master, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Steven Allen <steven <at> stebalien.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Set the 'name' prop in 'define-advice'
Date: Sat, 06 Jan 2024 09:54:36 -0800

[Message part 4 (text/plain, inline)]

In addition to naming the advice function 'symbol <at> name', set the 'name'
property to NAME. The code should be good, but I'm less sure about the
updated documentation.

Requested in Bug#68114.

[Message part 5 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.