GNU bug report logs - #68294
[PATCH] Set the 'name' prop in 'define-advice'

Previous Next

Full log

View this message in rfc822 format

From: Steven Allen <steven <at> stebalien.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 68294 <at> debbugs.gnu.org
Subject: bug#68294: [PATCH] Set the 'name' prop in 'define-advice'
Date: Mon, 08 Jan 2024 07:42:29 -0800

[Message part 1 (text/plain, inline)]

>>  @defmac define-advice symbol (where lambda-list &optional name depth) &rest body
>>  This macro defines a piece of advice and adds it to the function named
>> -@var{symbol}.  The advice is an anonymous function if @var{name} is
>> -@code{nil} or a function named @code{symbol@@name}.  See
>> -@code{advice-add} for explanation of other arguments.
>> +@var{symbol}.  If @var{name} is non-nil, the advice is named
>> +@code{symbol@@name} and installed with the name @var{name}; otherwise,
>    ^^^^^^^^^^^^^^^^^^^
> This should be @code{@var{symbol}@@@var{name}}.

Fixed.

>> +** 'define-advice' now sets the new advice's 'name' property to NAME
>> +Named advice defined with 'define-advice' can now be remove with
>                                                         ^^^^^^
> This should be "removed".

Fixed.

[Message part 2 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.