From unknown Sat Jun 21 03:02:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6829 <6829@debbugs.gnu.org> To: bug#6829 <6829@debbugs.gnu.org> Subject: Status: M-; doesn't comment lines in Octave mode Reply-To: bug#6829 <6829@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:02:50 +0000 retitle 6829 M-; doesn't comment lines in Octave mode reassign 6829 emacs submitter 6829 Steve Chapel severity 6829 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 08 22:54:00 2010 Received: (at submit) by debbugs.gnu.org; 9 Aug 2010 02:54:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiIUx-0001jl-HL for submit@debbugs.gnu.org; Sun, 08 Aug 2010 22:54:00 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiHma-0000nD-8O for submit@debbugs.gnu.org; Sun, 08 Aug 2010 22:08:09 -0400 Received: from lists.gnu.org ([199.232.76.165]:38313) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OiHnE-00014e-Mx for submit@debbugs.gnu.org; Sun, 08 Aug 2010 22:08:48 -0400 Received: from [140.186.70.92] (port=50482 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiHnC-0002Yi-Og for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 22:08:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OiHnB-00083V-0v for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 22:08:46 -0400 Received: from mail-qw0-f41.google.com ([209.85.216.41]:49979) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiHnA-00083Q-V0 for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 22:08:44 -0400 Received: by qwk4 with SMTP id 4so7827296qwk.0 for ; Sun, 08 Aug 2010 19:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=p2luWChIFzeHvnem6IEbDgFErCy+wngvme1Aj6U+PI0=; b=Mfn+FEwk+gErXjOfL7aDupMZFCYM4DBQxEr2dGE+7pskAmdN92y0gAqe5+jfh+4nXf 7xpgA+PAw6gXW37+1lhjwr4Qp/FpmQD2MlSaZ8LwWusilnzU21QHFVpf8zBjXMc1Fwst n2VeAc0b7Aogsl3ySXUeQqNkFjFrUtITPY+eQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=a43wIe5FHjlMABnzwruhafgAKo2u2YvfWCb8/M174Bx8HFD74VObUXd91ygFl0gyjp iXcQnEutNsSkJZc3ULvsF/6JjHqKphEuW2RspwT671P8UppdaG4qeb6kQ2uuih/G0X3I 9z35I5EahwqGM+0SnuFup3VJjLcK0BVG5zhhc= Received: by 10.224.36.207 with SMTP id u15mr7754179qad.0.1281319724035; Sun, 08 Aug 2010 19:08:44 -0700 (PDT) Received: from laptop.stevechapel.com (stevechapel.com [69.11.220.126]) by mx.google.com with ESMTPS id t4sm5662368qcs.16.2010.08.08.19.08.42 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 08 Aug 2010 19:08:43 -0700 (PDT) Message-ID: <4C5F6329.8010000@gmail.com> Date: Sun, 08 Aug 2010 22:08:41 -0400 From: Steve Chapel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: M-; doesn't comment lines in Octave mode Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 08 Aug 2010 22:53:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) In Octave mode, select a line or several lines of code. I would expect M-; would comment the lines, or uncomment them if they are already commented out. Instead, Octave starts a comment at the end of the line the comment is on, which is the behavior I would expect if no lines were selected. In GNU Emacs 23.2.1 (x86_64-redhat-linux-gnu, GTK+ Version 2.20.1) of 2010-05-13 on x86-07.phx2.fedoraproject.org configured using `configure '--build=x86_64-redhat-linux-gnu' '--host=x86_64-re dhat-linux-gnu' '--program-prefix=' '--disable-dependency-tracking' '--prefix=/u sr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir =/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib64' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' ' --mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=x86_64-redhat-linux-gnu' 'host_alias=x86_64 -redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SO URCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=gene ric'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: ESC [ > 1 ; 2 4 0 1 ; 0 c ESC x r e p o TAB r t TAB RET Recent messages: ("emacs") Loading /usr/share/emacs/site-lisp/site-start.d/focus-init.el (source)...done Loading /usr/share/emacs/site-lisp/site-start.d/php-mode-init.el (source)...done Loading /usr/share/emacs/site-lisp/site-start.d/po-mode-init.el (source)...done Loading /usr/share/emacs/site-lisp/site-start.d/rpm-spec-mode-init.el (source).. .done For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort mail-extr message idna sendmail regexp-opt ecomplete rfc822 mml mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash mail-utils emacsbug help-mode easymenu view tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 12 09:09:58 2010 Received: (at 6829-done) by debbugs.gnu.org; 12 Aug 2010 13:09:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjXXh-0005N6-SS for submit@debbugs.gnu.org; Thu, 12 Aug 2010 09:09:58 -0400 Received: from impaqm2.telefonica.net ([213.4.138.2]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjVLT-0003jx-MN for 6829-done@debbugs.gnu.org; Thu, 12 Aug 2010 06:49:12 -0400 Received: from IMPmailhost6.adm.correo ([10.20.102.127]) by IMPaqm2.telefonica.net with bizsmtp id tMBG1e00d2kvMAa3MNpzxK; Thu, 12 Aug 2010 12:49:59 +0200 Received: from ceviche.home ([88.12.128.176]) by IMPmailhost6.adm.correo with BIZ IMP id tNpx1e00B3oVAVk1mNpyrM; Thu, 12 Aug 2010 12:49:59 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="monnier$movistar.es" |auth_email="monnier@movistar.es" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" Received: by ceviche.home (Postfix, from userid 20848) id 73B58666AD; Thu, 12 Aug 2010 12:49:57 +0200 (CEST) From: Stefan Monnier To: Steve Chapel Subject: Re: bug#6829: M-; doesn't comment lines in Octave mode Message-ID: References: <4C5F6329.8010000@gmail.com> Date: Thu, 12 Aug 2010 12:49:57 +0200 In-Reply-To: <4C5F6329.8010000@gmail.com> (Steve Chapel's message of "Sun, 08 Aug 2010 22:08:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 6829-done X-Mailman-Approved-At: Thu, 12 Aug 2010 09:09:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > In Octave mode, select a line or several lines of code. > I would expect M-; would comment the lines, or uncomment > them if they are already commented out. Instead, Octave > starts a comment at the end of the line the comment is on, > which is the behavior I would expect if no lines were selected. I've installed the patch below into trunk, which should fix this problem. Stefan === modified file 'lisp/progmodes/octave-mod.el' --- lisp/progmodes/octave-mod.el 2010-05-20 15:12:20 +0000 +++ lisp/progmodes/octave-mod.el 2010-08-12 10:44:34 +0000 @@ -194,7 +194,6 @@ (define-key map ";" 'octave-electric-semi) (define-key map " " 'octave-electric-space) (define-key map "\n" 'octave-reindent-then-newline-and-indent) - (define-key map "\e;" 'octave-indent-for-comment) (define-key map "\e\n" 'octave-indent-new-comment-line) (define-key map "\e\t" 'octave-complete-symbol) (define-key map "\M-\C-a" 'octave-beginning-of-defun) @@ -507,6 +506,7 @@ (setq comment-start-skip "\\s<+\\s-*") (make-local-variable 'comment-indent-function) (setq comment-indent-function 'octave-comment-indent) + (set (make-local-variable 'comment-add) 1) (make-local-variable 'parse-sexp-ignore-comments) (setq parse-sexp-ignore-comments t) From unknown Sat Jun 21 03:02:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 10 Sep 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator