From unknown Fri Jun 20 07:11:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6828 <6828@debbugs.gnu.org> To: bug#6828 <6828@debbugs.gnu.org> Subject: Status: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows Reply-To: bug#6828 <6828@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:46 +0000 retitle 6828 24.0.50; [PATCH] rcirc process buffer log filenames invalid on= Windows reassign 6828 emacs submitter 6828 Deniz Dogan severity 6828 normal tag 6828 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 08 20:28:24 2010 Received: (at submit) by debbugs.gnu.org; 9 Aug 2010 00:28:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGE4-00007I-86 for submit@debbugs.gnu.org; Sun, 08 Aug 2010 20:28:24 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGE2-00007D-43 for submit@debbugs.gnu.org; Sun, 08 Aug 2010 20:28:23 -0400 Received: from lists.gnu.org ([199.232.76.165]:57840) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OiGEf-0000WH-G5 for submit@debbugs.gnu.org; Sun, 08 Aug 2010 20:29:01 -0400 Received: from [140.186.70.92] (port=60377 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiGEd-0001nW-B3 for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:29:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OiGEb-0004bP-FP for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:28:58 -0400 Received: from mail-qw0-f41.google.com ([209.85.216.41]:64180) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiGEb-0004bJ-DG for bug-gnu-emacs@gnu.org; Sun, 08 Aug 2010 20:28:57 -0400 Received: by qwk4 with SMTP id 4so7771421qwk.0 for ; Sun, 08 Aug 2010 17:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=FrasqIeeRLncPgpLp0V1Mf1ylpDsnwu8MSX5Fy4tHNY=; b=qxswZS7YjKL/AGslWAcFtM1G130MkU+HaylnhUb+5sCXXWHepYNgjgvTlg6wXHOhJa 7g6xOWxEmEkRM7GJOvkO60jV+EjrkWSyw6laCTOqftibemLfViFCX26jCGtwBipRliEX tmCESB5Y72HbO8BYY16nrW5Je52QU+1q7dav0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=o3zjmLGSS9IiwiWf10rQzCd8EyKHW58xKoQ3CuyCQ0oSh4pKCHxGptx+6Yc6Nh8m1f q/WCQTxGLDj+Lf4Vy3nmgl33L0nWGIfB51sgtkzV5fO0Kna2dabVffCXUOxO+owoaLIA UjTe3vWuQGJKmd0Hkhzwr1wD/B+ccKWaIu+VU= Received: by 10.220.157.141 with SMTP id b13mr9247386vcx.27.1281313736216; Sun, 08 Aug 2010 17:28:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.188.77 with HTTP; Sun, 8 Aug 2010 17:28:26 -0700 (PDT) From: Deniz Dogan Date: Mon, 9 Aug 2010 02:28:26 +0200 Message-ID: Subject: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows To: bug-gnu-emacs@gnu.org, Ryan Yeske Content-Type: multipart/mixed; boundary=e0cb4e887bc117d1d9048d591aec X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) --e0cb4e887bc117d1d9048d591aec Content-Type: text/plain; charset=ISO-8859-1 The rcirc logging facility doesn't play nicely when it comes to writing process buffers (or "server buffers") to disk on Windows systems. The generated log filenames contain asterisks which are not allowed on Windows systems. This makes rcirc and Emacs as a whole unusable when rcirc-log-flag is non-nil, i.e. when logging to disk is turned on. Emacs just messages errors in the echo area when this happens and you can't easily stop it. Attached is a patch which introduces a new function and a new customizable variable. rcirc-generate-log-filename is the function which takes care of generating filenames for rcirc buffer logs. It is now the default instead of the old rcirc-generate-new-buffer-name. rcirc-log-process-buffers is the new variable which decides whether or not to log process buffers to disk at all. I get the feeling that not that many people are interested in logging this as it rarely contains any useful information that you would want to store. Nevertheless, the variable is non-nil by default which turns on process buffer logging. The setup I'm using by the way: In GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7600) of 2010-08-02 on 3249CTO Windowing system distributor `Microsoft Corp.', version 6.1.7600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include' -- Deniz Dogan --e0cb4e887bc117d1d9048d591aec Content-Type: application/octet-stream; name="rcirc-log-patch-dd.diff" Content-Disposition: attachment; filename="rcirc-log-patch-dd.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gcml1ps90 MTUxMCwxNTExYzE1MTAsMTUxMw0KPCAgICAgICAod2hlbiByY2lyYy1sb2ctZmxhZw0KPCAgICAg ICAgIChyY2lyYy1sb2cgcHJvY2VzcyBzZW5kZXIgcmVzcG9uc2UgdGFyZ2V0IHRleHQpKQ0KLS0t DQo+ICAgICAgICh3aGVuIChhbmQgcmNpcmMtbG9nLWZsYWcNCj4gICAgICAgICAgICAgICAgICAg IChvciB0YXJnZXQNCj4gICAgICAgICAgICAgICAgICAgICAgICByY2lyYy1sb2ctcHJvY2Vzcy1i dWZmZXJzKSkNCj4gICAgICAgICAgIChyY2lyYy1sb2cgcHJvY2VzcyBzZW5kZXIgcmVzcG9uc2Ug dGFyZ2V0IHRleHQpKQ0KMTUxN2MxNTE5LDE1MjkNCjwgKGRlZmN1c3RvbSByY2lyYy1sb2ctZmls ZW5hbWUtZnVuY3Rpb24gJ3JjaXJjLWdlbmVyYXRlLW5ldy1idWZmZXItbmFtZQ0KLS0tDQo+IChk ZWZ1biByY2lyYy1nZW5lcmF0ZS1sb2ctZmlsZW5hbWUgKHByb2Nlc3MgdGFyZ2V0KQ0KPiAgIChp ZiB0YXJnZXQNCj4gICAgICAgKHJjaXJjLWdlbmVyYXRlLW5ldy1idWZmZXItbmFtZSBwcm9jZXNz IHRhcmdldCkNCj4gICAgIChwcm9jZXNzLW5hbWUgcHJvY2VzcykpKQ0KPg0KPiAoZGVmY3VzdG9t IHJjaXJjLWxvZy1wcm9jZXNzLWJ1ZmZlcnMgdA0KPiAgICJOb24tbmlsIGlmIHJjaXJjIHByb2Nl c3MgYnVmZmVycyBzaG91bGQgYmUgbG9nZ2VkIHRvIGRpc2suIg0KPiAgIDpncm91cCAncmNpcmMN Cj4gICA6dHlwZSAnYm9vbGVhbikNCj4NCj4gKGRlZmN1c3RvbSByY2lyYy1sb2ctZmlsZW5hbWUt ZnVuY3Rpb24gJ3JjaXJjLWdlbmVyYXRlLWxvZy1maWxlbmFtZQ== --e0cb4e887bc117d1d9048d591aec-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 14 19:06:20 2010 Received: (at 6828) by debbugs.gnu.org; 14 Aug 2010 23:06:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkPnv-00029t-I1 for submit@debbugs.gnu.org; Sat, 14 Aug 2010 19:06:19 -0400 Received: from pantheon-po45.its.yale.edu ([130.132.50.79]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkPnu-00029m-7N for 6828@debbugs.gnu.org; Sat, 14 Aug 2010 19:06:18 -0400 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po45.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o7EN7Dop002506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 14 Aug 2010 19:07:13 -0400 Received: by furry (Postfix, from userid 1000) id 4C7E116D402; Sat, 14 Aug 2010 19:07:13 -0400 (EDT) From: Chong Yidong To: Ryan Yeske Subject: Re: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows Date: Sat, 14 Aug 2010 19:07:13 -0400 Message-ID: <87d3tk7pzy.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6828 Cc: 6828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Hi Ryan, Could you review the patch at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6828 ? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 15 23:26:02 2010 Received: (at 6828) by debbugs.gnu.org; 16 Aug 2010 03:26:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkqKo-00005e-6Q for submit@debbugs.gnu.org; Sun, 15 Aug 2010 23:26:02 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkqKm-00005I-CE for 6828@debbugs.gnu.org; Sun, 15 Aug 2010 23:26:00 -0400 Received: by pzk6 with SMTP id 6so1696377pzk.3 for <6828@debbugs.gnu.org>; Sun, 15 Aug 2010 20:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:message-id:to :from; bh=gT03t/Q/b/sJBv27FsSxyeq9Ku5Qzw0OF3TCf42AshY=; b=cWBABRCP2XEKkd550Xf+QsiK307jSb6lq48QOgyva+VdWJxSKreijCgRpchPxeGohA AzJR9Mq2cZVhz8MYnFrg9bqK3urqoNnE6JmRvhteJda6BUAuz9ax8K7poFo+ZxHPyIGW BwMqSz7uwGg5Q8yPJGJbPDseVmJakd2UjmKVo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:to:from; b=lIvKS9fOhnEk4Jrvi+xVC3EFlmNjl4z0cjqgFIFbGHv3dGh/8MLP6ltSbHsswaORG9 rCd0AAfpT7MYYmV812DygVscD4I/dpMHjeGn+hvUyijm6ej7XAMHmjHdPhPk1bA9n66q Jjg616HEOk3BS6wROkT6piUSQMrFtI3/akYD4= Received: by 10.142.141.8 with SMTP id o8mr571587wfd.298.1281929217745; Sun, 15 Aug 2010 20:26:57 -0700 (PDT) Received: from eggplant (S010600222da29b77.wk.shawcable.net [24.67.198.51]) by mx.google.com with ESMTPS id v38sm7696907wfh.0.2010.08.15.20.26.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 15 Aug 2010 20:26:55 -0700 (PDT) Received: from rcy by eggplant with local (Exim 4.71) (envelope-from ) id 1OkqLc-0007qJ-Mj; Sun, 15 Aug 2010 20:26:52 -0700 Date: Sun, 15 Aug 2010 20:26:52 -0700 Message-Id: To: 6828@debbugs.gnu.org, cyd@stupidchicken.com From: Ryan Yeske X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 6828 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.8 (/) From: Ryan Yeske To: Chong Yidong Cc: 6828@debbugs.gnu.org Subject: Re: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows References: <87d3tk7pzy.fsf@stupidchicken.com> Date: Sun, 15 Aug 2010 20:26:52 -0700 In-Reply-To: <87d3tk7pzy.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 14 Aug 2010 19:07:13 -0400") Message-ID: <878w47s0eb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii These are good changes. I agree with Deniz that logging the process buffer is hardly ever desirable, so I suggest `rcirc-log-process-buffers' should be nil by default. Ryan Chong Yidong writes: > Hi Ryan, > > Could you review the patch at > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6828 > > ? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 15 23:34:32 2010 Received: (at 6828) by debbugs.gnu.org; 16 Aug 2010 03:34:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkqT2-00009L-JJ for submit@debbugs.gnu.org; Sun, 15 Aug 2010 23:34:32 -0400 Received: from pantheon-po23.its.yale.edu ([130.132.50.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkqT0-00009A-Ca for 6828@debbugs.gnu.org; Sun, 15 Aug 2010 23:34:30 -0400 Received: from furry (dhcp184-49-148-234.whfp.phl.wayport.net [184.49.148.234]) (authenticated bits=0) by pantheon-po23.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o7G3ZRRd010561 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 15 Aug 2010 23:35:28 -0400 Received: by furry (Postfix, from userid 1000) id 58DB416D402; Sun, 15 Aug 2010 23:35:27 -0400 (EDT) From: Chong Yidong To: Ryan Yeske Subject: Re: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows References: Date: Sun, 15 Aug 2010 23:35:27 -0400 In-Reply-To: (Ryan Yeske's message of "Sun, 15 Aug 2010 20:26:52 -0700") Message-ID: <87zkwn9qm8.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 6828 Cc: 6828@debbugs.gnu.org, Deniz Dogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Ryan Yeske writes: > These are good changes. > > I agree with Deniz that logging the process buffer is hardly ever > desirable, so I suggest `rcirc-log-process-buffers' should be nil by > default. OK. I've checked the patch into the trunk, with rcirc-log-process-buffers defaulting to nil. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 15 23:34:46 2010 Received: (at control) by debbugs.gnu.org; 16 Aug 2010 03:34:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkqTG-00009X-4p for submit@debbugs.gnu.org; Sun, 15 Aug 2010 23:34:46 -0400 Received: from pantheon-po45.its.yale.edu ([130.132.50.79]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OkqTD-00009R-Tk for control@debbugs.gnu.org; Sun, 15 Aug 2010 23:34:44 -0400 Received: from furry (dhcp184-49-148-234.whfp.phl.wayport.net [184.49.148.234]) (authenticated bits=0) by pantheon-po45.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o7G3ZgZ8013600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 15 Aug 2010 23:35:42 -0400 Received: by furry (Postfix, from userid 1000) id 8140816D402; Sun, 15 Aug 2010 23:35:42 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6828 Date: Sun, 15 Aug 2010 23:35:42 -0400 Message-ID: <87wrrr9qlt.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 6828 thanks From unknown Fri Jun 20 07:11:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 13 Sep 2010 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator