GNU bug report logs - #68272
[PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.

Previous Next

Full log

Message #62 received at 68272 <at> debbugs.gnu.org (full text, mbox):

From: Tim Ruffing <crypto <at> timruffing.de>
To: Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 68272 <at> debbugs.gnu.org
Subject: Re: bug#68272: [PATCH] Fix -1 leaking from C to lisp in
 'read-event' etc.
Date: Sat, 09 Mar 2024 13:33:53 +0100

[Message part 1 (text/plain, inline)]

Third revision.

 - Addressed Stefan's nit.
 - Extended the large comment.
 - Switched to Stefan's suggestion for calc.
 - Added a NEWS item that describes the suggestion
 - Added a commit that removes the Microsoft hack

> > It might be worth mentioning that the main difference is the
> > availability of `executing-kbd-macro` to let ELisp code behave
> > differently when called via a kmacro than via "live input".
> > Which also kind of justifies why `read-key-sequence` wants to
> > detect the end: if a kmacro ends in the middle of a key sequence,
> > then
> > it's triggered both my kmacro and by live input.
> > [ Of course, we could handle it in the command loop instead:
> >   check and compare the set of pending kmacro events before and
> > after
> > we
> >   call `read-key-sequence`.  ]

I didn't do this, because I couldn't follow exactly what you're saying.
Feel free to suggest a sentence.

Best,
Tim

[0001-Extract-check-for-end-of-macro-to-function.patch (text/x-patch, attachment)]

[0002-src-keyboard.c-requeued_events_pending_p-Improve-nam.patch (text/x-patch, attachment)]

[0003-src-keyboard.c-requeued_events_pending_p-New-functio.patch (text/x-patch, attachment)]

[0004-Continue-reading-in-read-event-etc.-at-the-end-of-a-.patch (text/x-patch, attachment)]

[0005-Remove-workarounds-for-solved-read-event-bug.patch (text/x-patch, attachment)]

[0006-lisp-calc-calc-prog.el-Switch-to-new-method-of-detec.patch (text/x-patch, attachment)]

[0007-src-keyboard.c-read_key_sequence-Remove-MSVC-compati.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.