GNU bug report logs - #68272
[PATCH] Fix -1 leaking from C to lisp in 'read-event' etc.

Previous Next

Full log

Message #32 received at 68272 <at> debbugs.gnu.org (full text, mbox):

From: Tim Ruffing <crypto <at> timruffing.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 68272 <at> debbugs.gnu.org
Subject: Re: bug#68272: [PATCH] Fix -1 leaking from C to lisp in
 'read-event' etc.
Date: Mon, 04 Mar 2024 19:42:09 +0100

[Message part 1 (text/plain, inline)]

Hi, this is an updated patch set.

Changes to the previous revision:
 * Instead of changing requeued_events_pending_p, it's renamed to
   requeued_command_events_pending_p, and I've fixed the outdated
   comment that had misled me.  Then a new requeued_events_pending_p
   with different semantics is added and used in following commits.
   This addresses one of Eli's comments, and should make sure that
   existing callers of requeued_events_pending_p are not affected by
   the patch.
 * I've added a large comment to src/macro.c as an attempt to explain
   how we handle the end of a keyboard macro.
 * I've improved the commit message of (now) 6be0f5f. 

Best,
Tim

[0001-Extract-check-for-end-of-macro-to-function.patch (text/x-patch, attachment)]

[0002-src-keyboard.c-requeued_events_pending_p-Improve-nam.patch (text/x-patch, attachment)]

[0003-src-keyboard.c-requeued_events_pending_p-New-functio.patch (text/x-patch, attachment)]

[0004-Continue-reading-in-read-event-etc.-at-the-end-of-a-.patch (text/x-patch, attachment)]

[0005-Remove-workarounds-for-solved-read-event-bug.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.