GNU bug report logs - #68268
30.0.50; [PATCH] use special mode in checkdoc status buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68268 in the body.
You can then email your comments to 68268 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] use special mode in checkdoc status buffer
Date: Fri, 05 Jan 2024 12:27:27 -0500

[Message part 1 (text/plain, inline)]

It'd be nice if the checkdoc status buffer were in special-mode.
Always annoys me when it hangs around and I don't have the 
quit-window bindings available.
See attached patch.

[0001-Use-special-mode-in-checkdoc-status-buffer.patch (text/x-patch, attachment)]

Message #8 received at 68268 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: No Wayman <iarchivedmywholelife <at> gmail.com>, 68268 <at> debbugs.gnu.org
Subject: Re: bug#68268: 30.0.50;
 [PATCH] use special mode in checkdoc status buffer
Date: Fri, 5 Jan 2024 11:08:47 -0800

No Wayman <iarchivedmywholelife <at> gmail.com> writes:

> It'd be nice if the checkdoc status buffer were in special-mode.
> Always annoys me when it hangs around and I don't have the
> quit-window bindings available.
> See attached patch.

Indeed, this has been a constant annoyance for years.  Thanks for
addressing it.

Your patch LGTM to me (assuming that it works ;-), but it is missing a
NEWS entry.  Could you please add one?

Please also add the bug number to the commit message while you're at it.

Message #11 received at 68268 <at> debbugs.gnu.org (full text, mbox):

From: No Wayman <iarchivedmywholelife <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 68268 <at> debbugs.gnu.org
Subject: Re: bug#68268: 30.0.50; [PATCH] use special mode in checkdoc status
 buffer
Date: Fri, 05 Jan 2024 16:00:17 -0500

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefankangas <at> gmail.com> writes:

> No Wayman <iarchivedmywholelife <at> gmail.com> writes:
>
>> It'd be nice if the checkdoc status buffer were in 
>> special-mode.
>> Always annoys me when it hangs around and I don't have the
>> quit-window bindings available.
>> See attached patch.
>
> Indeed, this has been a constant annoyance for years.  Thanks 
> for
> addressing it.

> Your patch LGTM to me (assuming that it works ;-), but it is 
> missing a
> NEWS entry.  Could you please add one?

I didn't add one because I didn't see entries for the following 
commits which made similar changes elsewhere:

- f947b20a1926ffc5b0553297dfc26d8390bcb328
- 02a2fba7869db7ae23c65ab1ea47db7ba556ffac
- 97abe8511a829861f6efb865209ac2dd0e7ae129
- ab5468e1a01ede3d571765ab491ce2c933ace70f
- 02a2fba7869db7ae23c65ab1ea47db7ba556ffac

Grepping etc/NEWS files for "special-mode" doesn't turn up much 
either:

> TODO
> 57:** Convert modes that use view-mode to be derived from 
> special-mode instead
> 
> NEWS.23
> 2543:** The new major mode 'special-mode' is intended as a 
> parent for
> 
> NEWS.27
> 1093:links to most ordinary special-mode buffers that display 
> text that
> 
> NEWS.28
> 786:doesn't turn on 'display-fill-column-indicator-mode' in 
> special-mode
> 
> NEWS.29
> 302:** 'show-paren-mode' is now disabled in 'special-mode' 
> buffers.
> 306:buffers, but not in buffers that inherit from 
> 'special-mode'.  To go
> 3829:like '(and "\\`\\*.+\\*\\'" (major-mode . special-mode))'.
> 
> NEWS.21
> 1279:See the documentation of variable 'hs-special-modes-alist'.

Let me know if you still think one is necessary and I'll add it in 
the next patch.

> Please also add the bug number to the commit message while 
> you're at it.

Addressed in attached patch.

[0001-Use-special-mode-in-checkdoc-status-buffer.patch (text/x-patch, attachment)]

Message #16 received at 68268-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 68268-done <at> debbugs.gnu.org
Subject: Re: bug#68268: 30.0.50;
 [PATCH] use special mode in checkdoc status buffer
Date: Fri, 5 Jan 2024 14:00:11 -0800

Version: 30.1

No Wayman <iarchivedmywholelife <at> gmail.com> writes:

> I didn't add one because I didn't see entries for the following
> commits which made similar changes elsewhere:
>
> - f947b20a1926ffc5b0553297dfc26d8390bcb328
> - 02a2fba7869db7ae23c65ab1ea47db7ba556ffac
> - 97abe8511a829861f6efb865209ac2dd0e7ae129
> - ab5468e1a01ede3d571765ab491ce2c933ace70f
> - 02a2fba7869db7ae23c65ab1ea47db7ba556ffac
>
> Grepping etc/NEWS files for "special-mode" doesn't turn up much
> either:

OK.

> Addressed in attached patch.

Thanks, installed on master and closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.