Subject: [bug#68266] [PATCH 1/7] gnu: Memozise make-ld-wrapper results.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 08 Jan 2024 18:22:28 +0100

Hi,

Christopher Baines <[email-masked]> skribis:

> To ensure that it just returns a single package record for some given
> arguments, as this helps to avoid poor performance of the store connection
> object cache.
>
> * gnu/packages/base.scm (make-ld-wrapper): Move code to
> make-ld-wrapper/implementation and call it.
> (make-ld-wrapper/implementation) New procedure.
>
> Change-Id: Id6fc805a4a7ffbc5ff0a5174eafcdf2c7c46854d

Do you have figures before and after the change?

The reason I’m asking is that (gnu packages commencement) arranges to
not call ‘make-ld-wrapper’ repeatedly already.  For instance, there’s:

  (define-public ld-wrapper
    ;; The final 'ld' wrapper, which uses the final Guile and Binutils.
    (make-ld-wrapper "ld-wrapper"
                     #:binutils binutils-final
                     #:guile guile-final
                     #:bash bash-final))

and from there on we manipulate a single <package> record.

Thanks,
Ludo’.