From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 05 00:07:21 2024 Received: (at submit) by debbugs.gnu.org; 5 Jan 2024 05:07:21 +0000 Received: from localhost ([127.0.0.1]:56146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLcQT-0000K4-EE for submit@debbugs.gnu.org; Fri, 05 Jan 2024 00:07:21 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLcQO-0000Jo-Mg for submit@debbugs.gnu.org; Fri, 05 Jan 2024 00:07:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLcQE-0000OA-VT for guix-patches@gnu.org; Fri, 05 Jan 2024 00:07:07 -0500 Received: from mail.boiledscript.com ([144.168.59.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLcQC-0007o6-Q0 for guix-patches@gnu.org; Fri, 05 Jan 2024 00:07:06 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1704431190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ytJREIQufEQ/R/uNA1NQYlIS8XnSwxNvMy9390I2pdQ=; b=0hv9BL2buKyMPS9dkWyVsPkNQuQy+8A48ftPFrF2TnOgk04YygLJFJgTEBvGOsXlrI4s8v rewzg9REkKpOpIjAvswllTced6e5VIJWuOQuI6anmYGwHzmbqec74v5KTLxW4eLtOcABSr RSlkHS2z8w0OtMPSmnXV1gxPhpQ2b7zupNmjZU5/npWG+rlo9IPTtHFxJCCKDKRy1AvQZQ LHUtR5ceZsHqrl0yOtweFvFI3nB0PJzn9SB/gRA9XikilCC8myEzYVW4/ND6L3ivfYXF00 wZHXEmReFUlFbv9MNfJp/wqHrkH5w5I1q2+ioZhrj0UqwTT4osygvpm1WOs5gQ== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space To: guix-patches@gnu.org Subject: [PATCH] gnu: Add libmpv. Date: Fri, 5 Jan 2024 13:06:17 +0800 Message-ID: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> MIME-Version: 1.0 X-Debbugs-Cc: Lars-Dominik Braun , Marius Bakke , Munyoki Kilyungi , jgart Content-Transfer-Encoding: 8bit X-Spamd-Bar: + X-Spam-Level: * Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@ultrarare.space; helo=mail.boiledscript.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/video.scm (libmpv): New variable. (mpv)[arguments]<#:configure-flags>: Remove libmpv library. (celluloid,mpv-mpris)[inputs]: Replace mpv with libmpv. * gnu/packages/kde-plasma.scm (plasmatube)[inputs]: Likewise. * gnu/packages/python-xyz.scm (python-mpv)[inputs]: Likewise. Change-Id: I7c0a808f9d54f9bfd98b3d2632316c7d58b67896 --- gnu/packages/kde-plasma.scm | 2 +- gnu/packages/python-xyz.scm | 2 +- gnu/packages/video.scm | 24 ++++++++++++++++++++---- 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm index 331ab28cd1..0527fa136a 100644 --- a/gnu/packages/kde-plasma.scm +++ b/gnu/packages/kde-plasma.scm @@ -1611,12 +1611,12 @@ (define-public plasmatube (list kconfig kirigami ki18n + libmpv qtbase-5 qtdeclarative-5 qtmultimedia-5 qtquickcontrols2-5 qtsvg-5 - mpv youtube-dl)) (home-page "https://apps.kde.org/plasmatube/") (synopsis "Kirigami YouTube video player") diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 2afce6c667..b23eaaadfc 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -33948,7 +33948,7 @@ (define-public python-mpv (setenv "HOME" (getcwd))))))) (native-inputs (list python-xvfbwrapper)) ; needed for tests only - (inputs (list mpv)) + (inputs (list libmpv)) (propagated-inputs (list python-pillow)) ; for raw screenshots (home-page "https://github.com/jaseg/python-mpv") (synopsis "Python interface to the mpv media player") diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 6da4897a57..b532181225 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -867,7 +867,7 @@ (define-public celluloid pkg-config python-wrapper)) ; for generate-authors.py (inputs - (list gtk libadwaita libepoxy mpv)) + (list gtk libadwaita libepoxy libmpv)) (home-page "https://github.com/celluloid-player/celluloid") (synopsis "GTK+ frontend for the mpv media player") (description "Celluloid is a simple GTK+ frontend for the mpv media player. @@ -2367,8 +2367,7 @@ (define-public mpv ;; Set PYTHONHASHSEED as a workaround for deterministic results. (setenv "PYTHONHASHSEED" "1")))) #:configure-flags - #~(list "-Dlibmpv=true" - "-Dcdda=enabled" + #~(list "-Dcdda=enabled" "-Ddvdnav=enabled" "-Dbuild-date=false"))) (native-inputs @@ -2422,6 +2421,23 @@ (define-public mpv projects while introducing many more.") (license license:gpl2+))) +(define-public libmpv + (package + (inherit mpv) + (name "libmpv") + (arguments + (substitute-keyword-arguments (package-arguments mpv) + ((#:configure-flags flags ''()) + #~(cons* "-Dcplayer=false" + "-Dlibmpv=true" + #$flags)))) + (native-inputs + (modify-inputs (package-native-inputs mpv) + (delete "perl" "python-docutils"))) + (propagated-inputs (package-inputs mpv)) + (inputs '()) + (synopsis "mpv media player client library"))) + (define-public smplayer (package (name "smplayer") @@ -2524,7 +2540,7 @@ (define-public mpv-mpris (native-inputs (list pkg-config)) (inputs - (list ffmpeg glib mpv)) + (list ffmpeg glib libmpv)) (home-page "https://github.com/hoyon/mpv-mpris") (synopsis "MPRIS plugin for mpv") (description "This package provides an @dfn{MPRIS} (Media Player Remote base-commit: be1d05c10766a979dd0720b677889ed950d3b895 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 05 00:09:40 2024 Received: (at 68250) by debbugs.gnu.org; 5 Jan 2024 05:09:40 +0000 Received: from localhost ([127.0.0.1]:56158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLcSh-0000OP-OO for submit@debbugs.gnu.org; Fri, 05 Jan 2024 00:09:40 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:50346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLcSe-0000Nv-2v; Fri, 05 Jan 2024 00:09:37 -0500 Date: Fri, 05 Jan 2024 13:09:17 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1704431341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6aB32GasFbSIjCLyzzzrrqdM2HhmxOYhQdIX5tiiKnM=; b=pxEkWCU+Ex2ftdMwBoDqWdIlkd4JKmpy27HEJsFs6Zqas43S/0dARsI87qyQV7SXQH24vu mV9Ws888W/emZf+fUn8+/v/hjMtFOAY/graiTEhNwRYLRCycV6N2jXx6xiF+1XZ14aqJ3P pE6Svoqh4ywbxAsjoSjlM67zP6HR0ZweTC/E00C3gC1gpgPA8O2ijC/WwFHU7zExXaSCDM qqkXcHaZ77c9O6DGhd+K/ckoeOmZYxCJSr4aX98DLO8dAqLCwQs/aGhlwI/h/Uv/faJ2j+ RgBWgQX7W2z4s3TBKwL2YkiQrD33/SPJi80p5MNYAupiQe44U42YVKtp37qFqQ== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <87sf3c5ptu.wl-hako@ultrarare.space> From: Hilton Chain To: Andrew Tropin Subject: Re: bug#67814: [PATCH 0/3] gnu: mpv: Update to 0.37.0. In-Reply-To: <87sf3q1ppm.fsf@trop.in> References: <87ttoatigz.wl-hako@ultrarare.space> <87sf3q1ppm.fsf@trop.in> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: 68044@debbugs.gnu.org, Josselin Poiret , Zheng Junjie , 68250@debbugs.gnu.org, 67814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Mon, 25 Dec 2023 19:33:41 +0800, Andrew Tropin wrote: > > Hi Hilton! > > It seem the mpv update breaks mpv-mpris build. I didn't dive into > issue yet, only tried to revert this patch. It's because mpv's pkgconfig file (for libmpv) now includes all its dependencies in Requires.private. Sorry that I didn't check all the dependent packages. Josselin has sent bug#68044, which adds mpv's inputs to mpv-mpris. However there're actually other packages depend on libmpv, so I think the proper fix is to split libmpv from the mpv package and propagate inputs in a new package (as mpv users are likely to include mpv in their profiles, thus these propagated inputs are usually unwanted). I tried to add a "lib" output for mpv first but there would be cycles. As a result, I disabled libmpv in mpv, added a libmpv package which inherits from mpv, and sent it to bug#68250. Thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 05 23:29:42 2024 Received: (at 68250) by debbugs.gnu.org; 6 Jan 2024 04:29:42 +0000 Received: from localhost ([127.0.0.1]:58278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLyJZ-0001B2-Uc for submit@debbugs.gnu.org; Fri, 05 Jan 2024 23:29:42 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:37398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLyJW-0001Ar-KF for 68250@debbugs.gnu.org; Fri, 05 Jan 2024 23:29:40 -0500 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1704515341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZYosqGfqk6F3FwxXQYoJh7Z7payyadTyszvFwkdJ2gg=; b=E+BXHadBndU2pZ8nX3oT4iO6wK6cYUxetJ/qnoS449zUKym1XzsvEDATqj2rDRIFQd14zb 4NTTdWpGKD81pCZfm/VzEPhAbdpfZBVu+RLE9S0uWgBa3mBQ/tqyfKwTAAn1M2dJo155+e DzgP1XZVXc4ezydSk1uxDSNwRiFcflYux6/ox1WXWWIyl4kYlG5tI8siA/52uheO5vSgvi ti5TWM2wN2O6GXwepUV97bIVNZav3hqKHsklEI92BVKrnORSKaoWZzKpPHBHA4+wSiW9M+ xcwJnQIVObilmaHJtcHap8RrAtPpa/WOKzf17kzHxQF1jXCMGyW1qnnlwWOmGg== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space To: 68250@debbugs.gnu.org Subject: [PATCH v2] gnu: mpv: Fix pkgconfig file. Date: Sat, 6 Jan 2024 12:23:49 +0800 Message-ID: <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> In-Reply-To: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> X-Debbugs-Cc: Hilton Chain , 宋文武 , Lars-Dominik Braun , Marius Bakke , Munyoki Kilyungi , jgart , Andrew Tropin , Josselin Poiret , Zheng Junjie MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: --- X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: Hilton Chain , =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. Suggested-by: 宋文武 Change-Id: I9826d5d6c957ca3022fa326aee111edb533f05bc --- gnu/packages/video.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index e70aa5352e..10d46db38b 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -2365,7 +2365,13 @@ (define-public mpv ;; and passed as linker flags, but the order in which they are added ;; varies. See . ;; Set PYTHONHASHSEED as a workaround for deterministic results. - (setenv "PYTHONHASHSEED" "1")))) + (setenv "PYTHONHASHSEED" "1"))) + ;; mpv.pc is generated by meson. libmpv's headers don't actually + ;; require these dependencies so it's safe to remove these two fields. + (add-after 'install 'fix-mpv.pc + (lambda _ + (substitute* (string-append #$output "/lib/pkgconfig/mpv.pc") + (("^(Requires|Libs)\\.private:.*") ""))))) #:configure-flags #~(list "-Dlibmpv=true" "-Dcdda=enabled" base-commit: c0e21e523d93081153a2ffc91e5a9f06afe62b91 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 05 23:32:12 2024 Received: (at control) by debbugs.gnu.org; 6 Jan 2024 04:32:12 +0000 Received: from localhost ([127.0.0.1]:58290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLyM0-0003qm-FM for submit@debbugs.gnu.org; Fri, 05 Jan 2024 23:32:12 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:34478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLyLy-0003qb-GQ for control@debbugs.gnu.org; Fri, 05 Jan 2024 23:32:11 -0500 Date: Sat, 06 Jan 2024 12:31:54 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1704515494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=SagJ5QU8OqVgEXmmrkJJ35CKDz3eBFLvlrZgAMR4Mhw=; b=GLiYTmLoPuY82r9tjMMfhQjEsngkifLEYeHrqLCVU1xr3LFm3sYbciUNZSz/JWBXyOPAsA Ns0ZDuLi2xblMnjSbL9zvHC0eZ+XcpE6u+LQbU8U25TlB64TJaCuKVysGxmyppe87TiXiJ wHMun0hY9OIWjzAK6xYgLwnHHqzLcyk7UsQImg61I6cBVKbWgBk9Hio/T+QtUgHp46JlKi CWucPku8Stola+EBOQ0RgDOGYiEROFmVjVWPtPHy2hu+wcAliHxy9YH7DFdvgnEq/qzfcK 6ZxCEX0JoflRrMCmk2qzQ0YdJ82MUGwx+dO9yJ/XRiu7seAyKI4RkY0nj6b+4w== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <87ttnr9j5x.wl-hako@ultrarare.space> To: control@debbugs.gnu.org Subject: control message for bug #68250 From: Hilton Chain MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 68250 [PATCH v2] gnu: mpv: Fix pkgconfig file. quit From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 13:24:40 2024 Received: (at 68250) by debbugs.gnu.org; 10 Jan 2024 18:24:40 +0000 Received: from localhost ([127.0.0.1]:43070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNdFo-0000h0-9v for submit@debbugs.gnu.org; Wed, 10 Jan 2024 13:24:40 -0500 Received: from jpoiret.xyz ([206.189.101.64]:58122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNdFl-0000gp-RD for 68250@debbugs.gnu.org; Wed, 10 Jan 2024 13:24:38 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 2B297185446; Wed, 10 Jan 2024 18:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1704911077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QxUEAhFEQS2nEvAVdx+4xl/RzCrEm9os2U03MxG33ww=; b=W8qF/lGHtvxzE3HSVm1x88CMmirLvc6jk/naj/sD5GoFjoplfyhsHn5oTmCXw/uj0hB3AW K+OhJWYM2Iynk24VtRyT0WNEDyOuX8w1Vx/pEpmMxNJt/VSOzwdQEbJNIY+Jt3fLTC9I5S n2n9//zbi9E7Ag84XAAfIaANWE8xh6nf9JXSn8266Cfb4VvArtgq9mkr4u1jZpgiK7jELs JeLwe+PmbjNEXDEWGIkSiKNARwzKzivbSIo7rwDoxR+WB5UA6+YCngT6n318Z4X664CAY6 XG30iGYzkrqX0kLjNVFxKLpj1SxBdaEBWt3Q2GOgj+66txs1gGkp8UuVgld91w== From: Josselin Poiret To: Hilton Chain , 68250@debbugs.gnu.org Subject: Re: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file. In-Reply-To: <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> Date: Wed, 10 Jan 2024 19:24:16 +0100 Message-ID: <875y01hwrz.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Level: * X-Spamd-Bar: + Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Hilton, Hilton Chain writes: > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.0 MANY_TO_CC Sent to 10+ recipients -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 68250 Cc: =?utf-8?B?5a6L5paH5q2m?= , Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Andrew Tropin , Hilton Chain , jgart , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Hilton, Hilton Chain writes: > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. Does this completely replace the previous patch, instead of augmenting it? Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmWe4NAQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaihZfDACM1eHR2b6sjIjiLQuDGRgfkfymdEIvz+Xm nxJ7SAz5EhpGkJF/ftigLHQiLDZJ3WMf+A9IEMSr50uxaQNPDwq6tGgk/Gf/eVlU GbsJS53jfCtHfNazu/MOS1ZWcqwUvQuugx2v3iWIMFkyRJrClW9S9d/3z+SzlcLs 9Z04hwDBzWd+nizakzv1+50Jk3YAvwC4xEADjBYsr1bBK85HpPknaIcK+vhXWr5Y rB17WBCUMmG+FilyWUwZir3fjH2yKp1msKk8HheXnzvFzXGtzJEjXm7FByI7uEdI W02VBtymvnm7LsjE+dbSA6YQdPUdoCMKnLrfpI3vXbmTcvSMy+wUXY4bcuf3Q1gf e2rGsCmJPdhFJtSJQqAZ5QwRCpR+l4FHMAsnVkmguONr6iN23KVBm9LFK2ewKFoc hqCC313xVogNtVVSnfAYdjEMWK5++ZZ/YQt9KxY7hiO05a1I5RBiYreCHBlKdQ7b S8R7uYrCFgW3j/HK56f5rr0gGbkinG8= =cvTE -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 01:48:58 2024 Received: (at 68250) by debbugs.gnu.org; 13 Jan 2024 06:48:58 +0000 Received: from localhost ([127.0.0.1]:38217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOXpB-0007zm-PS for submit@debbugs.gnu.org; Sat, 13 Jan 2024 01:48:58 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:35134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOXp7-0007zc-A9 for 68250@debbugs.gnu.org; Sat, 13 Jan 2024 01:48:56 -0500 Date: Sat, 13 Jan 2024 14:48:35 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1705128520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6A24SpaekR/youQcO1j7ojQ1l4hGATBzWKpfcEwhZG0=; b=eT9/8LSFAmGLYIZD9BNKRFXajQq6A+dGeLW8xIv+fL7EY3YYBx7+YO+oiR/4DnzJJs6YY+ e3kIOeoEsI+5gAt5v7GxijqFmLVNiRB6WkfOZeLSSYURwtnMVZWCMBdg8XVsYPPWCI9sev PnQVaTgI1FGW+L9wH6SD+arm2BhwftIVya5wECMoXm8x2wHLxDt+n3R2o8yOJmuTpo2tTv DWAPb5NgruznVvPNpQE7DccIZCucD1+EIpC0x5W5CF48zn3TbRJtqDcci8ahAW1KCMS/X4 utksBH3WnhLVNBD2+T3WDIGmuoMctJd4vpDY5qqC1miBKLy1+uXL6/iQbzPd8w== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <871qalvid8.wl-hako@ultrarare.space> From: Hilton Chain To: Josselin Poiret Subject: Re: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file. In-Reply-To: <875y01hwrz.fsf@jpoiret.xyz> References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <875y01hwrz.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: =?ISO-2022-JP?B?GyRCQVdKOElwGyhC?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Andrew Tropin , jgart , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Josselin, On Thu, 11 Jan 2024 02:24:16 +0800, Josselin Poiret wrote: > > [1 ] > Hi Hilton, > > Hilton Chain writes: > > > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > > > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. > > Does this completely replace the previous patch, instead of augmenting it? Yes! I should clarify this before. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 18 21:05:54 2024 Received: (at 68250) by debbugs.gnu.org; 19 Jan 2024 02:05:54 +0000 Received: from localhost ([127.0.0.1]:57064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQeGX-0006k3-Vg for submit@debbugs.gnu.org; Thu, 18 Jan 2024 21:05:54 -0500 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]:61910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQeGU-0006jk-T5 for 68250@debbugs.gnu.org; Thu, 18 Jan 2024 21:05:52 -0500 Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-68174626bb9so2259916d6.3 for <68250@debbugs.gnu.org>; Thu, 18 Jan 2024 18:05:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705629943; x=1706234743; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/62Rlj6DoHWdvj6SdJwHUsyxwrpcNcwDZyzSpPcDlu0=; b=Tan05v7IciqNe+fGc0HbjbC71yaYI0WPtPiVDVwUO77wmOIZbaE9KwGKPbAwa9FTAP m2aKBdquBYytgBMGn8MNvq85RcdxYi568Al5Q60U5z3si3jV4Njr+rmEKTY73ZW01Ci8 1EZCVDjzscfNi1x5WnE80Mf+yJpvJ5MZ67rjLZKXSsNGzMVyfj0dtAdcGUYrdSJTV3pd hEORijzDSmPmqktQeHY/PeNjN9d4QykFO25+Ylw81pLf1BUMIdMsCdKJDIHXYYfsgaGM 45P2J3uxQBtSFmobtKoefb5hH5HIYvw+ZlZyOYi5zSevRTDdPHbYVjOMKsv2UQeYFikQ Ntow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705629943; x=1706234743; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/62Rlj6DoHWdvj6SdJwHUsyxwrpcNcwDZyzSpPcDlu0=; b=hjN8DmRy1Pz3hHcLqkxKptFRSw9mNLeZuWWBjMsATa3sDkve1aSbHXuI1dT47Kk5C0 iD1NaJVt754Rs+driutXvIrMiwo9wu4ivQGbvLPsvARFAN0XrHoodRAzjQsNyqYkuKFS +5VBptNIOWWyXnX59rPshO7Cm003eqxvDruRiQIqOEHSkniZGa8fltfn4mouGU+7g6AU Ok+1iyaDhfnjgkbVp8OrqryQH/9q4TufkCmEpHsviZvVWsReTYrFX0Qip4mLFK+T38kG Vi0hzFDPWILfyE6i8+Vj7QC2bFL+sgMf8Pey7JRaH0jc93gcNtUwVi8VZoQMEthB2F9a ZkVw== X-Gm-Message-State: AOJu0YyR1NCjpmMetOSBE0CLYuOjWIIyB8TYnCvDi1BLAKhjwjNFQL+Q HXconERhPjeHeNDvhsjxiBQS/7fKdN0vnloDsfqB6hi7zZAJVUSc X-Google-Smtp-Source: AGHT+IHxgPS1y5jcXfvVzsjIjFvaWraUlQ2UmwnbFaVmvM4GubFMYNRhKS2I6Ep68CJp3FeNmd3wJA== X-Received: by 2002:a05:6214:1bcf:b0:681:789f:4358 with SMTP id m15-20020a0562141bcf00b00681789f4358mr2068266qvc.39.1705629943319; Thu, 18 Jan 2024 18:05:43 -0800 (PST) Received: from hurd (dsl-10-132-160.b2b2c.ca. [72.10.132.160]) by smtp.gmail.com with ESMTPSA id oh10-20020a056214438a00b0068187f22739sm1356864qvb.39.2024.01.18.18.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 18:05:42 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: bug#68250: [PATCH v2] gnu: mpv: Fix pkgconfig file. In-Reply-To: <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> (Hilton Chain's message of "Sat, 6 Jan 2024 12:23:49 +0800") References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> Date: Thu, 18 Jan 2024 21:05:41 -0500 Message-ID: <8734uukrgq.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: =?utf-8?B?5a6L5paH5q2m?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Hilton Chain writes: > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. > > Suggested-by: =E5=AE=8B=E6=96=87=E6=AD=A6 > Change-Id: I9826d5d6c957ca3022fa326aee111edb533f05bc > --- > gnu/packages/video.scm | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index e70aa5352e..10d46db38b 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -2365,7 +2365,13 @@ (define-public mpv > ;; and passed as linker flags, but the order in which they= are added > ;; varies. See . > ;; Set PYTHONHASHSEED as a workaround for deterministic re= sults. > - (setenv "PYTHONHASHSEED" "1")))) > + (setenv "PYTHONHASHSEED" "1"))) > + ;; mpv.pc is generated by meson. libmpv's headers don't actua= lly > + ;; require these dependencies so it's safe to remove these two= fields. > + (add-after 'install 'fix-mpv.pc > + (lambda _ > + (substitute* (string-append #$output "/lib/pkgconfig/mpv.p= c") > + (("^(Requires|Libs)\\.private:.*") ""))))) > #:configure-flags > #~(list "-Dlibmpv=3Dtrue" > "-Dcdda=3Denabled" I've just seen this, after pushing a hot fix as f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed libraries in Requires.private. I suppose that someone wanting to build something statically from mpv would benefit from having the original mpv.pc file without modifications. Perhaps we can try it out for a bit, and if the propagation causes problems, we can fall-back to this change here? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 01 00:02:26 2024 Received: (at 68250) by debbugs.gnu.org; 1 Feb 2024 05:02:27 +0000 Received: from localhost ([127.0.0.1]:39502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVPDW-0002ZT-H2 for submit@debbugs.gnu.org; Thu, 01 Feb 2024 00:02:26 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:47334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVPDR-0002ZH-Rw for 68250@debbugs.gnu.org; Thu, 01 Feb 2024 00:02:24 -0500 Date: Thu, 01 Feb 2024 13:01:59 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1706763680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T+BzIjNeW9FmrhCZSTbMi2f1dFGknkzjIshGsrtHo7U=; b=JNIF7ZmZ8J8NzJw0InCuDly7k81GOMj9l3rzG+OwJ8ydnOX2Sor74OwqAteKbKOcYPZnES S54IQpmzwlp8q/TttRCFhmIoTRHNFydpep8/wyntJBpeAGJ9rl2ilexKTGvHoMlf8O9/F6 8+ke/4w0tP6iEgubCgLdkjf7B/qpqyrd/neQlq1dgprGZHMKAIJ67E5QFSpxCh8ThMZ3wK 4wAikdkoycOo+XdXaDiCMZgsvQGbAqlObuzv1oSpH3btAK/maVpGgzOdVFDl0T97FX53fK ndMBAlt3nSie8vcfPtO4bygdXTMMZ5+0ejdcZDF9oY908irpzvFXBm3fcj99Ag== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <87o7d04w1k.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: bug#68250: [PATCH v2] gnu: mpv: Fix pkgconfig file. In-Reply-To: <8734uukrgq.fsf_-_@gmail.com> References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP X-Spamd-Bar: ++ X-Spam-Level: ** X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: =?ISO-2022-JP?B?GyRCQVdKOElwGyhC?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Fri, 19 Jan 2024 10:05:41 +0800, Maxim Cournoyer wrote: > > Hi, > > Hilton Chain writes: > > > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > > > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. > > > > Suggested-by: $BAWJ8Ip(B > > Change-Id: I9826d5d6c957ca3022fa326aee111edb533f05bc > > --- > > gnu/packages/video.scm | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > > index e70aa5352e..10d46db38b 100644 > > --- a/gnu/packages/video.scm > > +++ b/gnu/packages/video.scm > > @@ -2365,7 +2365,13 @@ (define-public mpv > > ;; and passed as linker flags, but the order in which they are added > > ;; varies. See . > > ;; Set PYTHONHASHSEED as a workaround for deterministic results. > > - (setenv "PYTHONHASHSEED" "1")))) > > + (setenv "PYTHONHASHSEED" "1"))) > > + ;; mpv.pc is generated by meson. libmpv's headers don't actually > > + ;; require these dependencies so it's safe to remove these two fields. > > + (add-after 'install 'fix-mpv.pc > > + (lambda _ > > + (substitute* (string-append #$output "/lib/pkgconfig/mpv.pc") > > + (("^(Requires|Libs)\\.private:.*") ""))))) > > #:configure-flags > > #~(list "-Dlibmpv=true" > > "-Dcdda=enabled" > > I've just seen this, after pushing a hot fix as > f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed > libraries in Requires.private. > > I suppose that someone wanting to build something statically from mpv > would benefit from having the original mpv.pc file without > modifications. > > Perhaps we can try it out for a bit, and if the propagation causes > problems, we can fall-back to this change here? Then we should follow the approach in v1 to add libmpv as a separate package. I'll send v3 later. Thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 05 14:38:20 2024 Received: (at 68250) by debbugs.gnu.org; 5 Feb 2024 19:38:20 +0000 Received: from localhost ([127.0.0.1]:52341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX4nL-0003af-Nq for submit@debbugs.gnu.org; Mon, 05 Feb 2024 14:38:20 -0500 Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]:53253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX4nI-0003aS-T0 for 68250@debbugs.gnu.org; Mon, 05 Feb 2024 14:38:18 -0500 Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-21920f89441so2136661fac.2 for <68250@debbugs.gnu.org>; Mon, 05 Feb 2024 11:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707161878; x=1707766678; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hrkJgfOUJ77/hkG54l7cbPOX3+i6bzq70G4wNWspAlY=; b=VAWblA9WPF8zgdkDSRdoqJArg+tgsKmEYk7gHsEznovozZNnzWxE+DTSqKAycLmFkj n25MN7KITnrctMJtp0G7rPvyFgDB1iIgnJ7UH1Y1fRfcTnrX39AF3x8bXl1Po084tNs/ XICGnF3zhgegqmbi47hDpCwGu3apghyRhm/XamCp09k1Q8vdqqILZ/PrPC+PF3FGrnrY Kwdjrx7QaC5VWxmvvp41hjtG6/Ajb6K+LUtFx196nup4MPpz2dJHZloYL1lkiuApxMdl 4wgeaDKMj7LQt4oKoH1VtZdYIqAvG6B/uFlauXmej7sN/OZnbJYuqO94o8wlKQ6qKjcj 6U6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707161878; x=1707766678; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hrkJgfOUJ77/hkG54l7cbPOX3+i6bzq70G4wNWspAlY=; b=CuvGTtIYdr2O0yOnWYoe+ZkJWkDtem+AroPaRUB+oRW+R7LM4ur1byIsBcJHptvhQ0 7HynjJihsmx0vx7AgZWqhWIG+/HhFhRj9yP64lHetfzi3AevoRLuvZMLxosq9Csiiwql +7EbOtJXGts8Ni3rtaa+0LelUSPPamL32xA6eObeJwKn7DF7hqZs86xDE6/IogWOFWsA /YB80Vbe/Qf4dY620AiRkpjRLW3YvkbDMVrcrrasROPkKD/R3huuKVsQfZxu2aNcUXgY i7t0gGzIBkQU+/sl3y+WHh7K5QKJL7yPCM7kqUBnhbCaNRfwj3XdFCaCxKl2vvnHPM4g 5pTQ== X-Gm-Message-State: AOJu0YznWTpJcHwBs6KmZXTZkNlVO/OJ5bgNkjmNfKrTgjU1B6mw8n4i wiFS5kOZWlMR9Q84bqp+YQ9UcFXBX309zYG3l0y+KTK5EjOWTowd X-Google-Smtp-Source: AGHT+IFewAucDYB+6rKqPrkyRGx3DJ4hy2r+0TJLdp8LITld4a3iJpF/6yB+mZjjRq+Mo5w1vhbdWQ== X-Received: by 2002:a05:6871:6a5:b0:214:d3ae:d47c with SMTP id l37-20020a05687106a500b00214d3aed47cmr877193oao.0.1707161878446; Mon, 05 Feb 2024 11:37:58 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXe7eidw1XUa9XCgp9VIK+kFSYxwn2mOwKdiAZwT5Te3JG1i4571SuIeyS1NeVDWSqBqiZfKs81jlmfLPYvnfIHwlL8qyhvz64wEmbf1tzytlnGU8ORMKHHha3coqsNYshb2k126z/ZLbXOKXUXCkjfuqyRaXE83MGJ8Ngx1D/S4/p1UZ9uCrPo+WrrZc7PiGPKxeJzcGTGU5tDbFJFHnmEOLmgle/miVdesstTD2Hwf4BR3ZvE44T1vFserdfOQra11cRA0eIG Received: from hurd (dsl-10-130-152.b2b2c.ca. [72.10.130.152]) by smtp.gmail.com with ESMTPSA id d18-20020a05622a15d200b0042992b06012sm235160qty.2.2024.02.05.11.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 11:37:57 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: bug#68250: [PATCH v2] gnu: mpv: Fix pkgconfig file. In-Reply-To: <87o7d04w1k.wl-hako@ultrarare.space> (Hilton Chain's message of "Thu, 01 Feb 2024 13:01:59 +0800") References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> <87o7d04w1k.wl-hako@ultrarare.space> Date: Mon, 05 Feb 2024 14:37:56 -0500 Message-ID: <87cyta66sr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: =?utf-8?B?5a6L5paH5q2m?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, [...] >> I've just seen this, after pushing a hot fix as >> f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed >> libraries in Requires.private. >> >> I suppose that someone wanting to build something statically from mpv >> would benefit from having the original mpv.pc file without >> modifications. >> >> Perhaps we can try it out for a bit, and if the propagation causes >> problems, we can fall-back to this change here? > > > Then we should follow the approach in v1 to add libmpv as a separate package. > I'll send v3 later. Actually I don't think we need to split out a library for mpv here; there are two things we can do in the short term: 1. Build MPV strictly as a shared library (-Dbuild=shared) or something in Meson. Then Meson doesn't output all these Requires.private dependencies, which are only useful for static linking, and which pkg-config confusingly uses for its --exists check. 2. On core-updates, I've been experimenting with replacing pkg-config with pkgconf, which seems to be designed better for avoiding the above pkg-config's pitfall. Currently stuck on a hard to understand cycle. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 11:03:08 2024 Received: (at 68250) by debbugs.gnu.org; 26 Feb 2024 16:03:08 +0000 Received: from localhost ([127.0.0.1]:46331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redRc-0004Kd-0b for submit@debbugs.gnu.org; Mon, 26 Feb 2024 11:03:08 -0500 Received: from mail-ot1-f49.google.com ([209.85.210.49]:52436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redRZ-0004Jz-BD for 68250@debbugs.gnu.org; Mon, 26 Feb 2024 11:03:06 -0500 Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-6e4899fa7f1so1338583a34.0 for <68250@debbugs.gnu.org>; Mon, 26 Feb 2024 08:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708963294; x=1709568094; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=H4UVTP+k0KJHSwLR7FOQq1GMytjdABWDtRtjzcEZp80=; b=jHKLE1USWdQIx58tJYnPXUtme6etqUfngFmXkLCGbz03lrIvPfdRPm0p1KPa5nlBG8 fTYn6k/gxmoPKUGlUeYrAsvgHfigQgOidrW6xjjWjnQ7hpdmI17ZtMSX0tvWRlsjmDQ1 I6J9sM2Q8Zda/FcHXhb7znlwH9nQVMn+09TH4SymFsAJOb6QdU6p829QhsX6XGs7vUQb 6ekI5jKwDp8x7vn0R8KGw5JOSyCHDOfe8tAKu4Ze+19PfYnHs6I1AyItyLX4yX4kSevC oLEIYjZH8QCLvLqLJI5I0Uz9BinAz/AlHjXB610wlPVDZePN3FZEhZgTHBXDMr2Co3pm tgdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708963294; x=1709568094; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H4UVTP+k0KJHSwLR7FOQq1GMytjdABWDtRtjzcEZp80=; b=WuXx0ueX2NSQIsLIzd+bDWmc/C1Lv6tIdZvbN/u2VGLyQyugbBbvPa2XNUIQaCKmJY 35vibcH9NipCPzWxPu90A0JsBHSXYqrAduDIlAsVUkpWpNl/VOcm+BaPqxTDibCXPydZ MtiHCA95AHBO+k8XVKAcA1GUHq66HBiLJNVCu5EkRw9nbe9DWSuuuubG5R8McgbnEmMa k/au6azREHu4TvKLieJoEs2FGl/e3pfG3yX7yaZ9uLjwNEJS0HdVLBQNSleFi1Japd3F toW2txqfWo2tQwyaNj0zBKcx36B8M0W05WmDXfP/6nfcTieezPqVugmuTBj8P5pHRkdx QorQ== X-Forwarded-Encrypted: i=1; AJvYcCVCd1iF9f+gsv68WFJBqKkhurqI6JYMTXJIfdJNG/mf+vOjBu3w9tHQby3+0sk4P7vmFs7NX7tnqFM+qktOjgFlGnxaYNo= X-Gm-Message-State: AOJu0YwM+9+vdg2wyDQDcEVVH/8rvKlD4Vk6jVc4Gm/75+nTi0/OXmWE YF9hatbaM/CVlZOZ5c3zqjjNmwV2LUVe7IumdMdzhyJ3+paOoPwi X-Google-Smtp-Source: AGHT+IF3G02OFhGOPqlz9E/QXWdR1Dv7M3PE5o0UG7CiQhxiNsVROH6Bq6g7EIViPRT/EsuwDoRDkw== X-Received: by 2002:a05:6830:11d2:b0:6e4:6305:367b with SMTP id v18-20020a05683011d200b006e46305367bmr8783726otq.30.1708963293538; Mon, 26 Feb 2024 08:01:33 -0800 (PST) Received: from hurd (dsl-141-6.b2b2c.ca. [66.158.141.6]) by smtp.gmail.com with ESMTPSA id x1-20020a05620a0b4100b00787c9b2459bsm1987018qkg.72.2024.02.26.08.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 08:01:33 -0800 (PST) From: Maxim Cournoyer To: Hilton Chain Subject: Re: bug#68250: [PATCH v2] gnu: mpv: Fix pkgconfig file. In-Reply-To: <87cyta66sr.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 05 Feb 2024 14:37:56 -0500") References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> <87o7d04w1k.wl-hako@ultrarare.space> <87cyta66sr.fsf@gmail.com> Date: Mon, 26 Feb 2024 11:01:31 -0500 Message-ID: <87cysjkyec.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: =?utf-8?B?5a6L5paH5q2m?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Lars-Dominik Braun , Zheng Junjie , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Hilton, Maxim Cournoyer writes: > Hi Hilton, > > [...] > >>> I've just seen this, after pushing a hot fix as >>> f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed >>> libraries in Requires.private. >>> >>> I suppose that someone wanting to build something statically from mpv >>> would benefit from having the original mpv.pc file without >>> modifications. >>> >>> Perhaps we can try it out for a bit, and if the propagation causes >>> problems, we can fall-back to this change here? >> >> >> Then we should follow the approach in v1 to add libmpv as a separate package. >> I'll send v3 later. > > Actually I don't think we need to split out a library for mpv here; > there are two things we can do in the short term: > > 1. Build MPV strictly as a shared library (-Dbuild=shared) or something > in Meson. Then Meson doesn't output all these Requires.private > dependencies, which are only useful for static linking, and which > pkg-config confusingly uses for its --exists check. > > 2. On core-updates, I've been experimenting with replacing pkg-config > with pkgconf, which seems to be designed better for avoiding the above > pkg-config's pitfall. Currently stuck on a hard to understand cycle. I've implemented 2. above; see: , which removes the need to propagate pkg-config *.private fields, which should only be needed when doing static builds. I'm thus closing this issue. Let me know if I've missed anything! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 11:03:18 2024 Received: (at control) by debbugs.gnu.org; 26 Feb 2024 16:03:18 +0000 Received: from localhost ([127.0.0.1]:46343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redRm-0004LH-D1 for submit@debbugs.gnu.org; Mon, 26 Feb 2024 11:03:18 -0500 Received: from mail-qt1-f175.google.com ([209.85.160.175]:56385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redRk-0004Ks-TD for control@debbugs.gnu.org; Mon, 26 Feb 2024 11:03:17 -0500 Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-42e5e16559cso22125451cf.0 for ; Mon, 26 Feb 2024 08:02:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708963305; x=1709568105; darn=debbugs.gnu.org; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=WuyaTFKSLYVh2g7o/0qAS4gFG4Xz2dW6rUazZ58dH6s=; b=kMUYCoUVGpIuKZgRKcPXvGVa9riqOAlpwVBtlUxboMsSSdv77dwwY1AsC3FJ3S7mV4 Ac+tEMl4NOqms+bX7SwFsKRFCsoRKthV5jlGO7t7TEM3v/a1jJIPn4mpjv0dxHYx4y+O 8NRmQazdqUvOM3iWy6Xxyz+KWBojOm5mvnuLAMuovzt1Et8lbQkIbdLpY9TWZ7Hnxecd 7NXLq1eAuXRYwIcb8WL8z8UbrXWOlzXsbL3YxuJpCH+ublKhSMmuVxKE4AIp/Bj63Fg+ JEiN8++x/t7ELo0fzHMr/EGG8R5f38DdwrjuORTQ4lYTsFu46XBxjOi5B0F3tw9ody/t FYbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708963305; x=1709568105; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WuyaTFKSLYVh2g7o/0qAS4gFG4Xz2dW6rUazZ58dH6s=; b=RdhNa62enreWfz/8jxE6ZoMzkyCVfQn0hLu+Kbui8NAk3BMpocFhRWLMKvMKp6Lq0P J7nsTzwBaZ01dOGRGJzW0FzVQ4MKXy3EhjQ/eQSeMzfdT21jtQ8nYgHJpnsRFlrO/XUh PXOfVXaVyL5x0gZXbSF/AWh3kV8PXL6oN1omucCL+0dGh4gvv5fp343aVYdoSgXcflXr o8oho3YsvmOaz3lLTjzVwZdT5CbIyjaHlM66PptCmT4VY5ICApSS8yR0EuMx8ZHJlp+6 5GvctV0CLQc2mivhYy1aKdVXletPc3d+6P8J1Q8om2m7CWXUWhLGVmrSJVQSAyYOh8wR 5ROQ== X-Gm-Message-State: AOJu0YxRy4Vk74Md5o3+bUVPOe1mIJPyWpj63/9mEbK3Di+FckKvZlcs Ltigg8ZC3KtpYntUvAgCl0J24F93+zKXEKB7Up7rezgdzc/oEZiaI8xTKUss X-Google-Smtp-Source: AGHT+IGoVza2ea+hvaEzoZdwWbOdS9iHW4Lt9rPqsO1i3AKRdlWHbdDV0NfsACJsJI4Q4v7on6R1iA== X-Received: by 2002:a05:622a:1788:b0:42e:57b7:b239 with SMTP id s8-20020a05622a178800b0042e57b7b239mr9901923qtk.20.1708963304877; Mon, 26 Feb 2024 08:01:44 -0800 (PST) Received: from hurd (dsl-141-6.b2b2c.ca. [66.158.141.6]) by smtp.gmail.com with ESMTPSA id bn9-20020a05622a1dc900b0042e7fa57dd6sm1463046qtb.37.2024.02.26.08.01.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 08:01:44 -0800 (PST) Date: Mon, 26 Feb 2024 11:01:43 -0500 Message-Id: <87bk83kye0.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #68250 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 68250 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 21:15:01 2024 Received: (at 68250) by debbugs.gnu.org; 27 Feb 2024 02:15:01 +0000 Received: from localhost ([127.0.0.1]:33334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1remzl-00060C-21 for submit@debbugs.gnu.org; Mon, 26 Feb 2024 21:15:01 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:43112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1remzj-0005zx-Gr for 68250@debbugs.gnu.org; Mon, 26 Feb 2024 21:15:00 -0500 Date: Tue, 27 Feb 2024 09:31:36 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1709000054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+HfwPiOPj36QPe/v+x49202UhGG0lrBl9IzMxDHsudQ=; b=p1mdNA23VDI8ao0jesXeda3xDUlE3baGsfEZuyB4ZxtSqKwM7+yDaSh9vfLYkCN7sgqPm1 vgEVYY9AuyuZK7n911n/fqwmQhAf50hG/ArqsFFU+c3LYiBdlWFGB0VRNHzkGh+mHVk2Fs xnDkBnPNVzKC2YPeSuyOQXReSiRSID9piFt+NA5mkBR/SOkVcaVgAPtMbSPWxr9zPs0eES rcfKB8w13VKq0ntzQ92QipklhuPNObnE0RDnjdHXfZtZCvg74GXD02rK5LK6E7CLBzBZ7m X4BuRDkK06E+hqIJx+tlf3gwiC6kLkKxjVe4OMtbjYRXdNYDD/7zK4lZdW7bag== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <87ttlu3d6v.wl-hako@ultrarare.space> From: Hilton Chain To: Maxim Cournoyer Subject: Re: bug#68250: [PATCH v2] gnu: mpv: Fix pkgconfig file. In-Reply-To: <87cysjkyec.fsf_-_@gmail.com> References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> <8734uukrgq.fsf_-_@gmail.com> <87o7d04w1k.wl-hako@ultrarare.space> <87cyta66sr.fsf@gmail.com> <87cysjkyec.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: ** X-Spamd-Bar: ++ X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68250 Cc: =?ISO-2022-JP?B?GyRCQVdKOElwGyhC?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Lars-Dominik Braun , Zheng Junjie , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Tue, 27 Feb 2024 00:01:31 +0800, Maxim Cournoyer wrote: > > Hi Hilton, > > Maxim Cournoyer writes: > > > Hi Hilton, > > > > [...] > > > >>> I've just seen this, after pushing a hot fix as > >>> f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed > >>> libraries in Requires.private. > >>> > >>> I suppose that someone wanting to build something statically from mpv > >>> would benefit from having the original mpv.pc file without > >>> modifications. > >>> > >>> Perhaps we can try it out for a bit, and if the propagation causes > >>> problems, we can fall-back to this change here? > >> > >> > >> Then we should follow the approach in v1 to add libmpv as a separate package. > >> I'll send v3 later. > > > > Actually I don't think we need to split out a library for mpv here; > > there are two things we can do in the short term: > > > > 1. Build MPV strictly as a shared library (-Dbuild=shared) or something > > in Meson. Then Meson doesn't output all these Requires.private > > dependencies, which are only useful for static linking, and which > > pkg-config confusingly uses for its --exists check. > > > > 2. On core-updates, I've been experimenting with replacing pkg-config > > with pkgconf, which seems to be designed better for avoiding the above > > pkg-config's pitfall. Currently stuck on a hard to understand cycle. > > I've implemented 2. above; see: , > which removes the need to propagate pkg-config *.private fields, which > should only be needed when doing static builds. > > I'm thus closing this issue. Let me know if I've missed anything! Great to see! Thank you very much! From unknown Tue Sep 09 13:20:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 Mar 2024 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator