From unknown Sun Jul 20 09:49:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68245: [PATCH] Add tracked file completion for "git blame" to pcomplete. Resent-From: Antero Mejr Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 68245@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17043985397725 (code B ref -1); Thu, 04 Jan 2024 20:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2024 20:02:19 +0000 Received: from localhost ([127.0.0.1]:55769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLTv1-00020W-5I for submit@debbugs.gnu.org; Thu, 04 Jan 2024 15:02:19 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLTuz-00020I-5t for submit@debbugs.gnu.org; Thu, 04 Jan 2024 15:02:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLTuo-0008DO-Pg for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 15:02:07 -0500 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1rLTum-0008WD-ML for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 15:02:06 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4T5ctQ48L3z9sd7 for ; Thu, 4 Jan 2024 21:01:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1704398510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=b3yzRc3bcf+edejq9FYdHTtrM4zQRn9E7UkPlyR/VZY=; b=cMK2fpkq3+A5Ix2yc1aFFpfA3KSvRtjkN8EZ5XnZsXfagfFOyeVGpI2R+2LZGqXpvJQK4I K8w2arN6vN+M5EVRCJQC2k2j183M8kVUNyY9Y52jA7370/WzWPYRv4Hy8xd1pswui1WBMl bg95QsaiWvfO1DCkEBoDAK3Ni8h41k1/uXOUx0I1N/2QX4S+sdsfkmGPSSLHSQs3QmlodK 06fGzlu8sVeUvawIqesqBV9M6soD+dh8jZoRIl5hWOWBbAHomRO35zVB3Ayo2XDV7WoWHX +dEiq/2DpjjaJeWMGb6INC88uRzSJWkw9Qayu2DfeGDmLXCTI4selumOqU/8NQ== From: Antero Mejr Date: Thu, 04 Jan 2024 20:00:59 +0000 Message-ID: <87frzcswas.fsf@mailbox.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-MBO-RS-META: wan5w1qash4cawez4ihffdw6f157p9fz X-MBO-RS-ID: 3883f72c58917b93efc Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=antero@mailbox.org; helo=mout-p-101.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain This patch makes pcomplete provide completions for tracked files when completing "git blame", which requires a mandatory file argument. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-tracked-file-completion-for-git-blame-to-pcomple.patch >From 1f4e5f711a9b98a0921a57d262fd086b440ffccd Mon Sep 17 00:00:00 2001 From: Antero Mejr Date: Thu, 4 Jan 2024 19:49:23 +0000 Subject: [PATCH] Add tracked file completion for "git blame" to pcomplete. * lisp/pcmpl-git.el (pcomplete/git): Add "blame" to the tracked files clause. --- lisp/pcmpl-git.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/pcmpl-git.el b/lisp/pcmpl-git.el index facca4107a1..95b6859dd23 100644 --- a/lisp/pcmpl-git.el +++ b/lisp/pcmpl-git.el @@ -88,7 +88,7 @@ Files listed by `git ls-files ARGS' satisfy the predicate." (pcomplete-entries nil (pcmpl-git--tracked-file-predicate "-m")))) ;; Complete all tracked files - ((or "mv" "rm" "grep" "status") + ((or "mv" "rm" "grep" "status" "blame") (pcomplete-here (pcomplete-entries nil (pcmpl-git--tracked-file-predicate)))) ;; Complete revisions -- 2.43.0 --=-=-=-- From unknown Sun Jul 20 09:49:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Antero Mejr Subject: bug#68245: closed (Re: bug#68245: [PATCH] Add tracked file completion for "git blame" to pcomplete.) Message-ID: References: <87frzcswas.fsf@mailbox.org> X-Gnu-PR-Message: they-closed 68245 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 68245@debbugs.gnu.org Date: Thu, 04 Jan 2024 21:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1704402482-22245-1" This is a multi-part message in MIME format... ------------=_1704402482-22245-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #68245: [PATCH] Add tracked file completion for "git blame" to pcomplete. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 68245@debbugs.gnu.org. --=20 68245: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68245 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1704402482-22245-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 68245-done) by debbugs.gnu.org; 4 Jan 2024 21:07:18 +0000 Received: from localhost ([127.0.0.1]:55837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLUvt-0005lh-RN for submit@debbugs.gnu.org; Thu, 04 Jan 2024 16:07:18 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:55387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLUvr-0005lT-7Z for 68245-done@debbugs.gnu.org; Thu, 04 Jan 2024 16:07:17 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-555936e7018so1122206a12.2 for <68245-done@debbugs.gnu.org>; Thu, 04 Jan 2024 13:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704402425; x=1705007225; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=8/NYBywZHggdeV4ZQ/OpBsdwW81sTaRHgr/O9fCpm7Q=; b=fdYS3C0ot5lHDwxwkcrmOFIYWB7581cgbwwNeCFNCQFa3CKySRGXzSJCCwmNmf7iBt 92roqJBmRv7b7nTqTHc6JYxlR/i/FbbNJoLPuqYwPpbOJHQ6q+S+lRqVjp14VCzG3wQ9 pq3xFYyOm59Bvo7j5SLFKbeF/QsnefZKy0yOVQdXlQmKgOMaY2rmH9dm7sc9K0KGk/RN atuRui/co4bTRRmm5LFc9JKI5ykmUtyB8UZZUFz9QeTMFDhlAV1DUjCiXBtfKx52pVK5 gLld9lIVHdqQtakkIdLctabGBV/pIv+4K9FqsON/5Otp9VFaBY4GljsEOQM/3y01NEzq rtoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704402425; x=1705007225; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8/NYBywZHggdeV4ZQ/OpBsdwW81sTaRHgr/O9fCpm7Q=; b=WlvQtPd/yY6T/mvsqym5vhmB1a3Hr3kLJVc0t7rSpCvyGchMn/N+aE1LaRzQhqFD+0 oeSXmXNaKmkCUWSqzgxzQLjQdSaEM+KVKu2JE/s192Riz3pQ08CkaC6lHQN3ins7r82O HSow1IT6ciTYqw774h6XuTt1Uh7qChXOc1N/OOhBG8TpNpoIf9FWZ7NVyr4wq9kTt3nb 0j68LY9hQKzdCw9TWMUmv8Qpiu/sb4lUyO7FaCabXBNjH/VTj8xrmvpJnpdj/eGbJu7f Hx/vjo73cm2KRMJk4MuZtx8+uIcspstR3GZhGbxZrSfDUTGmg1c+pMPbgW/O0D9HVXUP gPOQ== X-Gm-Message-State: AOJu0YxKt/lv6xekESH59D4453vN9DjGzmsVjCesjumnZI7FtnziAySH opZt+jp5K3NWX9xoFeXuLqqZFpCHENkD0Ho7p1A= X-Google-Smtp-Source: AGHT+IEKVXN52bACPP+Ao80Hn06r/64mJdzVijViOEJfPooyQPgDubuWUwcGe/qW81/VVv/19cQxCbclOclbGl2fPdQ= X-Received: by 2002:a50:c112:0:b0:557:172c:d513 with SMTP id l18-20020a50c112000000b00557172cd513mr317607edf.76.1704402425086; Thu, 04 Jan 2024 13:07:05 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 4 Jan 2024 13:07:04 -0800 From: Stefan Kangas In-Reply-To: <87frzcswas.fsf@mailbox.org> References: <87frzcswas.fsf@mailbox.org> MIME-Version: 1.0 Date: Thu, 4 Jan 2024 13:07:04 -0800 Message-ID: Subject: Re: bug#68245: [PATCH] Add tracked file completion for "git blame" to pcomplete. To: Antero Mejr , 68245-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68245-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Antero Mejr via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > This patch makes pcomplete provide completions for tracked files when > completing "git blame", which requires a mandatory file argument. Thanks, installed on master as commit 225710ba79c and closing. ------------=_1704402482-22245-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jan 2024 20:02:19 +0000 Received: from localhost ([127.0.0.1]:55769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLTv1-00020W-5I for submit@debbugs.gnu.org; Thu, 04 Jan 2024 15:02:19 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLTuz-00020I-5t for submit@debbugs.gnu.org; Thu, 04 Jan 2024 15:02:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLTuo-0008DO-Pg for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 15:02:07 -0500 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1rLTum-0008WD-ML for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 15:02:06 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4T5ctQ48L3z9sd7 for ; Thu, 4 Jan 2024 21:01:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1704398510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=b3yzRc3bcf+edejq9FYdHTtrM4zQRn9E7UkPlyR/VZY=; b=cMK2fpkq3+A5Ix2yc1aFFpfA3KSvRtjkN8EZ5XnZsXfagfFOyeVGpI2R+2LZGqXpvJQK4I K8w2arN6vN+M5EVRCJQC2k2j183M8kVUNyY9Y52jA7370/WzWPYRv4Hy8xd1pswui1WBMl bg95QsaiWvfO1DCkEBoDAK3Ni8h41k1/uXOUx0I1N/2QX4S+sdsfkmGPSSLHSQs3QmlodK 06fGzlu8sVeUvawIqesqBV9M6soD+dh8jZoRIl5hWOWBbAHomRO35zVB3Ayo2XDV7WoWHX +dEiq/2DpjjaJeWMGb6INC88uRzSJWkw9Qayu2DfeGDmLXCTI4selumOqU/8NQ== From: Antero Mejr To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add tracked file completion for "git blame" to pcomplete. Date: Thu, 04 Jan 2024 20:00:59 +0000 Message-ID: <87frzcswas.fsf@mailbox.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-MBO-RS-META: wan5w1qash4cawez4ihffdw6f157p9fz X-MBO-RS-ID: 3883f72c58917b93efc Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=antero@mailbox.org; helo=mout-p-101.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain This patch makes pcomplete provide completions for tracked files when completing "git blame", which requires a mandatory file argument. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-tracked-file-completion-for-git-blame-to-pcomple.patch >From 1f4e5f711a9b98a0921a57d262fd086b440ffccd Mon Sep 17 00:00:00 2001 From: Antero Mejr Date: Thu, 4 Jan 2024 19:49:23 +0000 Subject: [PATCH] Add tracked file completion for "git blame" to pcomplete. * lisp/pcmpl-git.el (pcomplete/git): Add "blame" to the tracked files clause. --- lisp/pcmpl-git.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/pcmpl-git.el b/lisp/pcmpl-git.el index facca4107a1..95b6859dd23 100644 --- a/lisp/pcmpl-git.el +++ b/lisp/pcmpl-git.el @@ -88,7 +88,7 @@ Files listed by `git ls-files ARGS' satisfy the predicate." (pcomplete-entries nil (pcmpl-git--tracked-file-predicate "-m")))) ;; Complete all tracked files - ((or "mv" "rm" "grep" "status") + ((or "mv" "rm" "grep" "status" "blame") (pcomplete-here (pcomplete-entries nil (pcmpl-git--tracked-file-predicate)))) ;; Complete revisions -- 2.43.0 --=-=-=-- ------------=_1704402482-22245-1--