GNU bug report logs - #68244
hash-table improvements

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattias.engdegard <at> gmail.com>

Date: Thu, 4 Jan 2024 16:29:02 UTC

Severity: wishlist

Full log


View this message in rfc822 format

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>, 68244 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>, Stefan Kangas <stefankangas <at> gmail.com>
Subject: bug#68244: hash-table improvements
Date: Tue, 13 Feb 2024 13:12:08 +0100
Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> 13 feb. 2024 kl. 10.05 skrev Gerd Möllmann <gerd.moellmann <at> gmail.com>:
>
>> I wonder, what does your code do for the places using (make-vector n 0)
>> create obarrays? I'm not 100% sure, but I think Cedet was an example of
>> that in Emacs itself.
>
> That code would still work, but just for completeness I changed all
> those instances to using `obarray-make`, including cedet. (See the
> branch scratch/obarray.)
>
> A more worrying problem is code that uses `obarray-make` but assumes
> the result to be vectors. It may be unsafe to let obarray-make return
> an obarray object for that reason. With Stefan's suggestion, if I
> understood it right, we'd have `obarray-make` return (vector 0). I'll
> give it a try.

Thanks for the pointer.




This bug report was last modified 1 year and 146 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.