GNU bug report logs - #68242
[core-updates] Compress man pages using zstd

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Thu, 4 Jan 2024 15:18:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #63 received at 68242-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, 68242-done <at> debbugs.gnu.org,
 Ricardo Wurmus <rekado <at> elephly.net>, Christopher Baines <guix <at> cbaines.net>
Subject: Re: bug#68242: [core-updates] Compress man pages using zstd
Date: Mon, 08 Jan 2024 22:31:54 -0500
Hi!

Ludovic Courtès <ludo <at> gnu.org> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> * guix/man-db.scm (<mandb-entry>): Adjust comment.
>> (abbreviate-file-name): Adjust regexp.
>> (gz-compressed?, zstd-compressed?): New predicates.
>> (entry->string): Use them.
>> (man-page->entry): Adjust doc.  Use input port reader appropriate to the
>> compression type, if any.
>> (man-files): Adjust regexp.
>> (mandb-entries): Adjust link resolving predicate.
>> * guix/profiles.scm (manual-database): Add guile-zlib extension.
>>
>> Change-Id: I6336e46e2d324c520a7d15d6cafd12bbf43c5b09
>
> [...]
>
>>  (define-module (guix man-db)
>>    #:use-module (zlib)
>> +  #:use-module (zstd)
>
> Maybe #:autoload both modules for good measure.

Done.

> Otherwise LGTM, thanks!

Excellent, I've pushed the series.

Closing!

-- 
Thanks,
Maxim




This bug report was last modified 1 year and 165 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.