Subject: Re: [bug#68228] [PATCH v2] gnu: Add gnome-software.

From: Maxim Cournoyer <[email-masked]>
Date: Tue, 18 Mar 2025 15:55:43 +0900

Hi,

Noé Lopez <[email-masked]> writes:

[...]

> +    (native-inputs
> +     (list
> +      pkg-config
> +      (list glib "bin")
> +      gettext-minimal
> +      gtk-doc))

Nitpick, but it is more conventional to format inputs as:

--8<---------------cut here---------------start------------->8---
       (native-inputs
        (list first
              second
              ...))
--8<---------------cut here---------------end--------------->8---

> +    (inputs
> +     (list
> +      appstream
> +      gdk-pixbuf
> +      libxmlb
> +      gtk
> +      json-glib
> +      libadwaita
> +      libglib-testing
> +      valgrind
> +      polkit
> +      packagekit
> +      flatpak
> +      libostree
> +      libsoup-minimal-2
> +      malcontent
> +      libgudev
> +      sysprof
> +      fwupd))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-iso-codes
> +            (lambda* (#:key native-inputs inputs #:allow-other-keys)

Since you aren't using the arguments, this should be a
--8<---------------cut here---------------start------------->8---
   (lambda _
    [...]
--8<---------------cut here---------------end--------------->8---

> +              (with-directory-excursion
> +                  "src"

Please format this as

--8<---------------cut here---------------start------------->8---
(with-directory-excursion "src"
 (substitute* [...]))
--8<---------------cut here---------------end--------------->8---

Otherwise I agree with Liliana's comments.  Thank you for working on
this!

-- 
Thanks,
Maxim