GNU bug report logs - #68204
[PATCH] gnu: Add emacs-ox-tufte.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Suhail via Guix-patches via <guix-patches <at> gnu.org>
Cc: Suhail <suhail <at> bayesians.ca>, 68204 <at> debbugs.gnu.org
Subject: Re: [bug#68204] [PATCH] gnu: Add emacs-ox-tufte.
Date: Tue, 02 Jan 2024 15:22:57 +0100

Hello,

Suhail via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ox-tufte): Add at 3.0.3

Thanks. Some comments follow.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://stable.melpa.org/packages/ox-tufte-"
> +                           version ".tar"))

MELPA Stable is not considered as desirable upstream source. I suggest
to use GitHub instead.

> +       (sha256
> +        (base32 "0bl4c8lv3z9r0kdf70fg3bkrm90yz15xbs5hzq8z5gk97iyvjvmx"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-org))
> +    (home-page "https://github.com/ox-tufte/ox-tufte")
> +    (synopsis "Tufte HTML org-mode export backend")

Nitpick: Org mode

> +    (description
> +     "This is an export backend for Org-mode that exports buffers to HTML that is

Nitpick: Org mode

> +compatible with Tufte CSS - <https://edwardtufte.github.io/tufte-css/>.  The

Please use @url{...} instead.

> +design goal is to \"minimally\" change the HTML structure as generated by `ox-html

@emph{minimally} but I have the feeling that you can simply drop the
last sentence of the description.

> +(with additional CSS as needed) to get behaviour that is equivalent to Tufte
> +CSS.")
> +    (license license:gpl3+)))

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.