From unknown Tue Jun 17 22:25:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68195: flite fails to build on core-updates Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 01 Jan 2024 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68195 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 68195@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17041455695963 (code B ref -1); Mon, 01 Jan 2024 21:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jan 2024 21:46:09 +0000 Received: from localhost ([127.0.0.1]:48859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKQ6q-0001Y0-FV for submit@debbugs.gnu.org; Mon, 01 Jan 2024 16:46:08 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKQ6p-0001MW-4q for submit@debbugs.gnu.org; Mon, 01 Jan 2024 16:46:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKQ6f-0007Ez-Bx for bug-guix@gnu.org; Mon, 01 Jan 2024 16:45:57 -0500 Received: from mailout.easymail.ca ([64.68.200.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKQ6c-0005Zy-6r for bug-guix@gnu.org; Mon, 01 Jan 2024 16:45:57 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 52C9D65896 for ; Mon, 1 Jan 2024 21:45:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo09-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo09-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6YS7IW3oVS3y for ; Mon, 1 Jan 2024 21:45:50 +0000 (UTC) Received: from jupiter (23-233-96-210.cpe.pppoe.ca [23.233.96.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 5AC0E65891 for ; Mon, 1 Jan 2024 21:45:50 +0000 (UTC) From: Simon South Date: Mon, 01 Jan 2024 16:45:44 -0500 Message-ID: <877ckssp6f.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On core-updates (4d1436b0ea65) the flite package is failing to build, with log output like making ../build/aarch64-linux-gnu/lib/libflite.so make[1]: *** No rule to make target 'flite_voice_list.c', needed by 'all'. Stop. make[1]: *** Waiting for unfinished jobs.... make: *** [config/common_make_rules:133: build/aarch64-linux-gnu/obj//.make_build_dirs] Error 2 This is caused by the upgrade to make 4.4 along with what appears to be an error in one of the project's makefiles. The workaround is to build flite with parallel build jobs disabled, using e.g. "./pre-inst-env guix build --cores=1 flite". The underlying issue appears to be a misuse of the ".NOTPARALLEL" special make target in the project's main/Makefile. Changing line 107 from .NOTPARALLEL: $(ALL) to simply .NOTPARALLEL: solves the problem: The entire project builds in parallel except for targets in the "main" subfolder, which are built serially instead. (These targets have to be built serially as they delete and re-create the same "flite_voice_list.o" object file in different ways.) With make versions 4.3 and earlier any prerequisites specified for ".NOTPARALLEL" ("$(ALL)" as shown above) were ignored, and make would unconditionally build all remaining targets in series. With make 4.4 this behaviour has changed and the prerequisites list is now honoured. However, this doesn't specify a list of targets to build serially, as it seems the flite authors expected. Rather, If the .NOTPARALLEL special target has prerequisites, then each of those prerequisites will be considered a target and all prerequisites of these targets will be run serially.[0] That is, it is the _prerequisites_ of the specified targets and not the targets themselves that are built serially. The targets themselves may still be built in parallel, which is how the upgrade to make 4.4 has caused this problem to appear. I'll add for completeness that getting clever and changing the makefile with something like notparallel: $(ALL) .NOTPARALLEL: notparallel doesn't work, as (for one reason or another) this doesn't sufficiently protect the targets from clobbering one another. -- Simon South simon@simonsouth.net [0] https://www.gnu.org/software/make/manual/html_node/Parallel-Disable.html From unknown Tue Jun 17 22:25:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68195: flite fails to build on core-updates Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 01 Jan 2024 23:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68195 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 68195@debbugs.gnu.org Received: via spool by 68195-submit@debbugs.gnu.org id=B68195.17041508731804 (code B ref 68195); Mon, 01 Jan 2024 23:15:01 +0000 Received: (at 68195) by debbugs.gnu.org; 1 Jan 2024 23:14:33 +0000 Received: from localhost ([127.0.0.1]:48889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKRUP-0000T2-2L for submit@debbugs.gnu.org; Mon, 01 Jan 2024 18:14:33 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:60112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKRUM-0000Sn-SI for 68195@debbugs.gnu.org; Mon, 01 Jan 2024 18:14:31 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 6672AE5AAA for <68195@debbugs.gnu.org>; Mon, 1 Jan 2024 23:14:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ETHngyQrSJZv for <68195@debbugs.gnu.org>; Mon, 1 Jan 2024 23:14:23 +0000 (UTC) Received: from jupiter (23-233-96-210.cpe.pppoe.ca [23.233.96.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id F2781E5AA9 for <68195@debbugs.gnu.org>; Mon, 1 Jan 2024 23:14:22 +0000 (UTC) From: Simon South In-Reply-To: <877ckssp6f.fsf@simonsouth.net> (Simon South's message of "Mon, 01 Jan 2024 16:45:44 -0500") References: <877ckssp6f.fsf@simonsouth.net> Date: Mon, 01 Jan 2024 18:14:17 -0500 Message-ID: <875y0cmyt2.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I am of course looking into submitting a patch for this upstream, but it's not clear how this might be done: The project's GitHub repository[0] has seen no activity since August 2022, shortly after the project's maintainer, Dr. Alan W. Black, retired from his position at CMU. I've sent an email to Dr. Black asking whether and how a patch might be accepted. -- Simon South simon@simonsouth.net [0] https://github.com/festvox/flite From unknown Tue Jun 17 22:25:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68195: [PATCH core-updates 0/1] gnu: flite: Fix build. References: <877ckssp6f.fsf@simonsouth.net> In-Reply-To: <877ckssp6f.fsf@simonsouth.net> Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 13 Jan 2024 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68195 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: guix-patches@gnu.org, 68195@debbugs.gnu.org Received: via spool by 68195-submit@debbugs.gnu.org id=B68195.17051586604463 (code B ref 68195); Sat, 13 Jan 2024 15:11:02 +0000 Received: (at 68195) by debbugs.gnu.org; 13 Jan 2024 15:11:00 +0000 Received: from localhost ([127.0.0.1]:40820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOff2-00019u-8A for submit@debbugs.gnu.org; Sat, 13 Jan 2024 10:11:00 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:41306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOff0-00019Y-1m for 68195@debbugs.gnu.org; Sat, 13 Jan 2024 10:10:58 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 05818E59EB; Sat, 13 Jan 2024 15:10:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RIkiR0fhWm2T; Sat, 13 Jan 2024 15:10:23 +0000 (UTC) Received: from jupiter.smallsystems.net (23-233-96-210.cpe.pppoe.ca [23.233.96.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 4C9A6E597C; Sat, 13 Jan 2024 15:10:23 +0000 (UTC) From: Simon South Date: Sat, 13 Jan 2024 10:09:59 -0500 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Here's a patch that allows flite, a lightweight speech-synthesis engine, to build in core-updates, by applying a small patch to one of its makefiles as outlined in an earlier email[0]. I've tested this on AArch64 and x86-64 and everything seems fine. Note I haven't received a response from Dr. Black in almost two weeks' time, and my email asking to join the festival-talk mailing list[1] has bounced, so it appears flite may be unmaintained at the moment. -- Simon South simon@simonsouth.net [0] https://lists.gnu.org/archive/html/bug-guix/2024-01/msg00000.html [1] http://www.festvox.org/maillists.html Simon South (1): gnu: flite: Fix build. gnu/local.mk | 1 + .../patches/flite-build-with-make-4.4.patch | 24 +++++++++++++++++++ gnu/packages/speech.scm | 3 ++- 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/flite-build-with-make-4.4.patch base-commit: a3ae833227a284fbcfbb813b1156d0e8aeeb29d1 -- 2.41.0 From unknown Tue Jun 17 22:25:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68195: [PATCH core-updates 1/1] gnu: flite: Fix build. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 13 Jan 2024 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68195 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: guix-patches@gnu.org, 68195@debbugs.gnu.org Received: via spool by 68195-submit@debbugs.gnu.org id=B68195.17051586614478 (code B ref 68195); Sat, 13 Jan 2024 15:11:02 +0000 Received: (at 68195) by debbugs.gnu.org; 13 Jan 2024 15:11:01 +0000 Received: from localhost ([127.0.0.1]:40823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOff2-00019w-Ld for submit@debbugs.gnu.org; Sat, 13 Jan 2024 10:11:01 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:41314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOff0-00019a-IH for 68195@debbugs.gnu.org; Sat, 13 Jan 2024 10:10:59 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 9E331E5D3F; Sat, 13 Jan 2024 15:10:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5OYh4A8WJOTN; Sat, 13 Jan 2024 15:10:24 +0000 (UTC) Received: from jupiter.smallsystems.net (23-233-96-210.cpe.pppoe.ca [23.233.96.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 3A922E597C; Sat, 13 Jan 2024 15:10:24 +0000 (UTC) From: Simon South Date: Sat, 13 Jan 2024 10:10:00 -0500 Message-ID: <01a83cb58c5a3e705670ad71887811b1115f19a1.1705157474.git.simon@simonsouth.net> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/patches/flite-build-with-make-4.4.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/speech.scm (flite)[source]: Apply it. Change-Id: I263696c9571e2bcf97d5a4fc619124bce90d6799 --- gnu/local.mk | 1 + .../patches/flite-build-with-make-4.4.patch | 24 +++++++++++++++++++ gnu/packages/speech.scm | 3 ++- 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/flite-build-with-make-4.4.patch diff --git a/gnu/local.mk b/gnu/local.mk index c1833cd0dd..9b2957c9cb 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1185,6 +1185,7 @@ dist_patch_DATA = \ %D%/packages/patches/flann-cmake-3.11.patch \ %D%/packages/patches/flatpak-fix-path.patch \ %D%/packages/patches/flatpak-unset-gdk-pixbuf-for-sandbox.patch \ + %D%/packages/patches/flite-build-with-make-4.4.patch \ %D%/packages/patches/fluxbox-1.3.7-no-dynamic-cursor.patch \ %D%/packages/patches/fluxbox-1.3.7-gcc.patch \ %D%/packages/patches/fontconfig-cache-ignore-mtime.patch \ diff --git a/gnu/packages/patches/flite-build-with-make-4.4.patch b/gnu/packages/patches/flite-build-with-make-4.4.patch new file mode 100644 index 0000000000..d959bb73a5 --- /dev/null +++ b/gnu/packages/patches/flite-build-with-make-4.4.patch @@ -0,0 +1,24 @@ +Building flite with GNU Make 4.4 or newer fails with log messages like + + making in main ... + gcc -g -O2 -Wall -I../include -c -o flitevox_info_main.o flitevox_info_main.c + making ../build/aarch64-linux-gnu/lib/libflite.so + make[1]: *** No rule to make target 'flite_voice_list.c', needed by 'all'. Stop. + +This is due to a change in how the .NOTPARALLEL special make target is +interpreted. This patch causes the package to build as it did with earlier +versions of Make. + +diff --git a/main/Makefile b/main/Makefile +index 8166182..e5ba866 100644 +--- a/main/Makefile ++++ b/main/Makefile +@@ -104,7 +104,7 @@ else + shared_libs: nothing + endif + +-.NOTPARALLEL: $(ALL) ++.NOTPARALLEL: + + flite_lang_list: + rm -f flite_lang_list.c diff --git a/gnu/packages/speech.scm b/gnu/packages/speech.scm index 2ea8e4f64f..4009da9654 100644 --- a/gnu/packages/speech.scm +++ b/gnu/packages/speech.scm @@ -67,7 +67,8 @@ (define-public flite (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "1n0p81jzndzc1rzgm66kw9ls189ricy5v1ps11y0p2fk1p56kbjf")))) + (base32 "1n0p81jzndzc1rzgm66kw9ls189ricy5v1ps11y0p2fk1p56kbjf")) + (patches (search-patches "flite-build-with-make-4.4.patch")))) (build-system gnu-build-system) (arguments ;; XXX: -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 10:12:50 2024 Received: (at control) by debbugs.gnu.org; 13 Jan 2024 15:12:50 +0000 Received: from localhost ([127.0.0.1]:40834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOfgo-0001Dv-8q for submit@debbugs.gnu.org; Sat, 13 Jan 2024 10:12:50 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:36852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOfgn-0001Di-1L for control@debbugs.gnu.org; Sat, 13 Jan 2024 10:12:49 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 1F53265DB1 for ; Sat, 13 Jan 2024 15:12:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xmui-CCtGCKw for ; Sat, 13 Jan 2024 15:12:44 +0000 (UTC) Received: from jupiter (23-233-96-210.cpe.pppoe.ca [23.233.96.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id DA0C065D7B for ; Sat, 13 Jan 2024 15:12:44 +0000 (UTC) Date: Sat, 13 Jan 2024 10:12:26 -0500 Message-Id: <87wmsdz2qt.fsf@simonsouth.net> To: control@debbugs.gnu.org From: Simon South Subject: control message for bug #68195 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 68195 + patch quit From unknown Tue Jun 17 22:25:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simon South Subject: bug#68195: closed (Re: bug#68195: flite fails to build on core-updates) Message-ID: References: <87bk92onlj.fsf@simonsouth.net> <877ckssp6f.fsf@simonsouth.net> X-Gnu-PR-Message: they-closed 68195 X-Gnu-PR-Package: guix X-Gnu-PR-Keywords: patch Reply-To: 68195@debbugs.gnu.org Date: Tue, 30 Jan 2024 15:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1706628122-28727-1" This is a multi-part message in MIME format... ------------=_1706628122-28727-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #68195: flite fails to build on core-updates which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 68195@debbugs.gnu.org. --=20 68195: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68195 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1706628122-28727-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 68195-done) by debbugs.gnu.org; 30 Jan 2024 15:21:30 +0000 Received: from localhost ([127.0.0.1]:36149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUpvW-0007Sf-Br for submit@debbugs.gnu.org; Tue, 30 Jan 2024 10:21:30 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:37804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUpvT-0007SO-Pw for 68195-done@debbugs.gnu.org; Tue, 30 Jan 2024 10:21:28 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 17E7068F65 for <68195-done@debbugs.gnu.org>; Tue, 30 Jan 2024 15:20:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo09-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo09-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nvzww6IjLCKD for <68195-done@debbugs.gnu.org>; Tue, 30 Jan 2024 15:20:42 +0000 (UTC) Received: from earth (23-233-96-210.cpe.pppoe.ca [23.233.96.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id C5E4F68F4A for <68195-done@debbugs.gnu.org>; Tue, 30 Jan 2024 15:20:42 +0000 (UTC) From: Simon South To: 68195-done@debbugs.gnu.org Subject: Re: bug#68195: flite fails to build on core-updates In-Reply-To: <877ckssp6f.fsf@simonsouth.net> (Simon South's message of "Mon, 01 Jan 2024 16:45:44 -0500") References: <877ckssp6f.fsf@simonsouth.net> Date: Tue, 30 Jan 2024 10:19:36 -0500 Message-ID: <87bk92onlj.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68195-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This was obsoleted by commit 5528123265f9, "gnu: flite: Disable parallel build." -- Simon South simon@simonsouth.net ------------=_1706628122-28727-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Jan 2024 21:46:09 +0000 Received: from localhost ([127.0.0.1]:48859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKQ6q-0001Y0-FV for submit@debbugs.gnu.org; Mon, 01 Jan 2024 16:46:08 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKQ6p-0001MW-4q for submit@debbugs.gnu.org; Mon, 01 Jan 2024 16:46:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKQ6f-0007Ez-Bx for bug-guix@gnu.org; Mon, 01 Jan 2024 16:45:57 -0500 Received: from mailout.easymail.ca ([64.68.200.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKQ6c-0005Zy-6r for bug-guix@gnu.org; Mon, 01 Jan 2024 16:45:57 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 52C9D65896 for ; Mon, 1 Jan 2024 21:45:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo09-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo09-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6YS7IW3oVS3y for ; Mon, 1 Jan 2024 21:45:50 +0000 (UTC) Received: from jupiter (23-233-96-210.cpe.pppoe.ca [23.233.96.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 5AC0E65891 for ; Mon, 1 Jan 2024 21:45:50 +0000 (UTC) From: Simon South To: bug-guix@gnu.org Subject: flite fails to build on core-updates Date: Mon, 01 Jan 2024 16:45:44 -0500 Message-ID: <877ckssp6f.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On core-updates (4d1436b0ea65) the flite package is failing to build, with log output like making ../build/aarch64-linux-gnu/lib/libflite.so make[1]: *** No rule to make target 'flite_voice_list.c', needed by 'all'. Stop. make[1]: *** Waiting for unfinished jobs.... make: *** [config/common_make_rules:133: build/aarch64-linux-gnu/obj//.make_build_dirs] Error 2 This is caused by the upgrade to make 4.4 along with what appears to be an error in one of the project's makefiles. The workaround is to build flite with parallel build jobs disabled, using e.g. "./pre-inst-env guix build --cores=1 flite". The underlying issue appears to be a misuse of the ".NOTPARALLEL" special make target in the project's main/Makefile. Changing line 107 from .NOTPARALLEL: $(ALL) to simply .NOTPARALLEL: solves the problem: The entire project builds in parallel except for targets in the "main" subfolder, which are built serially instead. (These targets have to be built serially as they delete and re-create the same "flite_voice_list.o" object file in different ways.) With make versions 4.3 and earlier any prerequisites specified for ".NOTPARALLEL" ("$(ALL)" as shown above) were ignored, and make would unconditionally build all remaining targets in series. With make 4.4 this behaviour has changed and the prerequisites list is now honoured. However, this doesn't specify a list of targets to build serially, as it seems the flite authors expected. Rather, If the .NOTPARALLEL special target has prerequisites, then each of those prerequisites will be considered a target and all prerequisites of these targets will be run serially.[0] That is, it is the _prerequisites_ of the specified targets and not the targets themselves that are built serially. The targets themselves may still be built in parallel, which is how the upgrade to make 4.4 has caused this problem to appear. I'll add for completeness that getting clever and changing the makefile with something like notparallel: $(ALL) .NOTPARALLEL: notparallel doesn't work, as (for one reason or another) this doesn't sufficiently protect the targets from clobbering one another. -- Simon South simon@simonsouth.net [0] https://www.gnu.org/software/make/manual/html_node/Parallel-Disable.html ------------=_1706628122-28727-1--