GNU bug report logs - #68183
28.3; vc-dir fails when I have a certain branch checked out

Previous Next

Full log

Message #41 received at 68183 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: 68183 <at> debbugs.gnu.org
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>,
 Tom Tromey <tom <at> tromey.com>, Sean Whitton <spwhitton <at> spwhitton.name>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#68183: 28.3; vc-dir fails when I have a certain branch
 checked out
Date: Wed, 07 Aug 2024 16:25:31 +0200

[Message part 1 (text/plain, inline)]

Heya,

Have spent cycles on this on-and-off these past few months; finally have
something worth discussing, I think 🤞

To recap where we stand, AFAIU: the reported vc-dir bug has been fixed
(in time for the emacs-30 branch), but the changes could feel intrusive,
since a new vc-dir header was added ("Tracking") that some users may not
care for.

I've now drafted a user option to give users more control over this new
header; see patch #3 in the attached series.

The first two patches are yak-shaving: patch #1 adds regression tests,
patch #2 splits vc-git-dir-extra-headers into more manageable chunks
(pure refactoring, no functional change intended).

Also attaching a 'squashed.patch' if that helps review.

About patch #2, CC'ing Sean Whitton for perspective on
vc-git--cmds-in-progress: I was puzzled by the function supporting many
commands (rebase, am, merge, bisect), whereas AFAICT its sole user only
heeds 'bisect & 'rebase.  Wondering if I've missed other in-tree uses,
or if we should add headers for 'am and 'merge, "while in there".

Curious what y'all think.  OT1H not sure an alist is the best UX, OTOH
struggled to keep option names concise otherwise.

[0001-Test-more-vc-dir-scenarios-with-Git-bug-68183.patch (text/x-diff, attachment)]

[0002-Split-vc-git-dir-extra-headers-into-more-manageable-.patch (text/x-diff, attachment)]

[0003-Let-users-choose-when-and-how-to-display-Git-trackin.patch (text/x-diff, attachment)]

[squashed.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.