GNU bug report logs - #68173
[PATCH] gnu: Add morris.

Previous Next

Package: guix-patches;

Reported by: Wilko Meyer <w <at> wmeyer.eu>

Date: Sun, 31 Dec 2023 13:19:01 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68173 in the body.
You can then email your comments to 68173 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org:
bug#68173; Package guix-patches. (Sun, 31 Dec 2023 13:19:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Wilko Meyer <w <at> wmeyer.eu>:
New bug report received and forwarded. Copy sent to liliana.prikler <at> gmail.com, iyzsong <at> envs.net, guix-patches <at> gnu.org. (Sun, 31 Dec 2023 13:19:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wilko Meyer <w <at> wmeyer.eu>
To: guix-patches <at> gnu.org
Cc: Wilko Meyer <w <at> wmeyer.eu>
Subject: [PATCH] gnu: Add morris.
Date: Sun, 31 Dec 2023 14:17:33 +0100

* gnu/packages/games.scm (morris): New variable.

Change-Id: I35158d1f5cfd5f7267dcb8295d8102e2dd3f575c
---
 gnu/packages/games.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 1e203af9d1d..fbca9b60815 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10446,6 +10446,31 @@ (define-public moonfish
 using any UCI engine and also to connect UCI engines to Lichess.")
       (license license:agpl3+))))
 
+(define-public morris
+  (package
+    (name "morris")
+    (version "0.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/farindk/morris")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1kkcnpkzgybm7rqg7nafd7sqd5m4alns6l4j5zcf3p41jdc9s3iv"))))
+    (build-system glib-or-gtk-build-system)
+    (inputs (list automake autoconf pkg-config intltool
+		 gnu-gettext libtool glib gtk+-2 boost))
+    (arguments `(#:tests? #f))
+    (home-page "http://nine-mens-morris.net/downloads.html")
+    (synopsis "Morris is an implementation of the board game Nine Men's Morris")
+    (description "Morris is an implementation of the board game Nine Men's Morris.
+It supports not only the standard game, but also several rule-variants and different
+board layouts. You can play against the computer, or simply use the program to
+present the board, but play against another human opponent.")
+    (license license:gpl3)))
+
 (define-public barrage
   (package
     (name "barrage")

base-commit: f24b14767d362a84e6469682b4fe303b50f4b589
prerequisite-patch-id: b3c8c2f810e3581b22e34e6852353ebb505fa020
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#68173; Package guix-patches. (Sun, 14 Jan 2024 12:06:02 GMT) Full text and rfc822 format available.

Message #8 received at 68173 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Wilko Meyer <w <at> wmeyer.eu>, 68173 <at> debbugs.gnu.org
Cc: 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#68173] [PATCH] gnu: Add morris.
Date: Sun, 14 Jan 2024 13:05:04 +0100

Am Sonntag, dem 31.12.2023 um 14:17 +0100 schrieb Wilko Meyer:
> * gnu/packages/games.scm (morris): New variable.
> 
> Change-Id: I35158d1f5cfd5f7267dcb8295d8102e2dd3f575c
> ---
Hi, this patch fails to apply both locally and on CI.  Can you rebase
this on your side and reroll?

Cheers
Information forwarded to guix-patches <at> gnu.org:
bug#68173; Package guix-patches. (Sun, 14 Jan 2024 13:03:01 GMT) Full text and rfc822 format available.

Message #11 received at 68173 <at> debbugs.gnu.org (full text, mbox):

From: Wilko Meyer <w <at> wmeyer.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Wilko Meyer <w <at> wmeyer.eu>, 68173 <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#68173] [PATCH] gnu: Add morris.
Date: Sun, 14 Jan 2024 13:46:59 +0100

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Sonntag, dem 31.12.2023 um 14:17 +0100 schrieb Wilko Meyer:
>> * gnu/packages/games.scm (morris): New variable.
>> 
>> Change-Id: I35158d1f5cfd5f7267dcb8295d8102e2dd3f575c
>> ---
> Hi, this patch fails to apply both locally and on CI.  Can you rebase
> this on your side and reroll?
>
> Cheers

Thanks for getting back to this! While preparing to do so I noticed:

(guix230 (~/devel/guix_proper)) λ git blame -L :morris gnu/packages/games.scm    
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10509) (define-public morris
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10510)   (package
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10511)     (name "morris")
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10512)     (version "0.3")
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10513)     (source
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10514)      (origin
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10515)        (method git-fetch)
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10516)        (uri (git-reference
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10517)              (url "https://github.com/farindk/morris")
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10518)              (commit (string-append "v" version))))
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10519)        (file-name (git-file-name name version))
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10520)        (sha256
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10521)         (base32 "1kkcnpkzgybm7rqg7nafd7sqd5m4alns6l4j5zcf3p41jdc9s3iv"))))
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10522)     (build-system glib-or-gtk-build-system)
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10523)     (inputs (list automake autoconf pkg-config intltool
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10524)                gnu-gettext libtool glib gtk+-2 boost))
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10525)     (arguments `(#:tests? #f))
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10526)     (home-page "http://nine-mens-morris.net/downloads.html")
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10527)     (synopsis "Morris is an implementation of the board game Nine Men's Morris")
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10528)     (description "Morris is an implementation of the board game Nine Men's Morris.
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10529) It supports not only the standard game, but also several rule-variants and different
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10530) board layouts. You can play against the computer, or simply use the program to
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10531) present the board, but play against another human opponent.")
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10532)     (license license:gpl3)))
11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10533) 

that the changes are already present and have been applied on
master[0]. I guess rebasing and resending an already applied patch isn't
feasible. Let me know if there's still work required on my side.

[0]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=11136fb0ad90937516ce0421a352e3a4513fca3b

-- 
Kind regards,

Wilko Meyer
w <at> wmeyer.eu
Reply sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
You have taken responsibility. (Sun, 14 Jan 2024 13:17:02 GMT) Full text and rfc822 format available.
Notification sent to Wilko Meyer <w <at> wmeyer.eu>:
bug acknowledged by developer. (Sun, 14 Jan 2024 13:17:02 GMT) Full text and rfc822 format available.

Message #16 received at 68173-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Wilko Meyer <w <at> wmeyer.eu>
Cc: 68173-done <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#68173] [PATCH] gnu: Add morris.
Date: Sun, 14 Jan 2024 14:16:39 +0100

Am Sonntag, dem 14.01.2024 um 13:46 +0100 schrieb Wilko Meyer:
> 
> Hi Liliana,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > Am Sonntag, dem 31.12.2023 um 14:17 +0100 schrieb Wilko Meyer:
> > > * gnu/packages/games.scm (morris): New variable.
> > > 
> > > Change-Id: I35158d1f5cfd5f7267dcb8295d8102e2dd3f575c
> > > ---
> > Hi, this patch fails to apply both locally and on CI.  Can you
> > rebase this on your side and reroll?
> > 
> > Cheers
> 
> Thanks for getting back to this! While preparing to do so I noticed:
> 
> (guix230 (~/devel/guix_proper)) λ git blame -L :morris
> gnu/packages/games.scm    
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10509) (define-
> public morris
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10510)   (package
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10511)     (name
> "morris")
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10512)    
> (version "0.3")
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10513)     (source
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10514)     
> (origin
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10515)       
> (method git-fetch)
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10516)        (uri
> (git-reference
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100
> 10517)              (url "https://github.com/farindk/morris")
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100
> 10518)              (commit (string-append "v" version))))
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10519)       
> (file-name (git-file-name name version))
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10520)       
> (sha256
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10521)        
> (base32 "1kkcnpkzgybm7rqg7nafd7sqd5m4alns6l4j5zcf3p41jdc9s3iv"))))
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10522)     (build-
> system glib-or-gtk-build-system)
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10523)     (inputs
> (list automake autoconf pkg-config intltool
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100
> 10524)                gnu-gettext libtool glib gtk+-2 boost))
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10525)    
> (arguments `(#:tests? #f))
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10526)     (home-
> page "http://nine-mens-morris.net/downloads.html")
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10527)    
> (synopsis "Morris is an implementation of the board game Nine Men's
> Morris")
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10528)    
> (description "Morris is an implementation of the board game Nine
> Men's Morris.
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10529) It supports
> not only the standard game, but also several rule-variants and
> different
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10530) board
> layouts. You can play against the computer, or simply use the program
> to
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10531) present the
> board, but play against another human opponent.")
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10532)    
> (license license:gpl3)))
> 11136fb0ad9 (Wilko Meyer 2023-12-31 14:17:33 +0100 10533) 
> 
> that the changes are already present and have been applied on
> master[0]. I guess rebasing and resending an already applied patch
> isn't feasible. Let me know if there's still work required on my
> side.
In that case, someone already pushed it without noticing the ML. 
Closing then.

Cheers
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 12 Feb 2024 12:24:13 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.