GNU bug report logs - #68171
[PATCH 0/2] Enable tests for python-h5py

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68171 in the body.
You can then email your comments to 68171 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Enable tests for python-h5py
Date: Sun, 31 Dec 2023 12:52:32 +0100

While writing a different package definition, I noticed python-h5py does
not have any of its tests enabled. To make the tests pass, only two new
packages needed to be added to the native inputs.

A total of 130 dependent packages would need to be rebuilt. Although it
seems unlikely that only adding tests would break dependent builds, I
checked that locally all dependent packages that could be built before
this patch series, can still be built when these patches are applied (at
least for x86_64-linux).

Troy Figiel (2):
  gnu: python-h5py: Enable tests.
  gnu: python-h5py: Reformat with guix style.

 gnu/packages/python-xyz.scm | 30 +++++++++++++-----------------
 1 file changed, 13 insertions(+), 17 deletions(-)


base-commit: 2a242e86379ebddbdddf2927f26e5e27a98fc605
-- 
2.40.1

Message #8 received at 68171 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 68171 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: python-h5py: Enable tests.
Date: Sat, 30 Dec 2023 11:36:37 +0100

* gnu/packages/python-xyz.scm (python-h5py)[native-inputs]: Add python-ipython and python-pytest.

Change-Id: Ia1cae8bce802805c9d9b38a3bf515423f9b719b4
---
 gnu/packages/python-xyz.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 2afce6c667..b5384b7c42 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2257,8 +2257,7 @@ (define-public python-h5py
         "0pyr6z4h2xqbp49yx2i1401gl6yqh03h771zslwcy0201hpxiskg"))))
     (build-system python-build-system)
     (arguments
-     `(#:tests? #f ; no test target
-       #:phases
+     '(#:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'fix-hdf5-paths
           (lambda* (#:key inputs #:allow-other-keys)
@@ -2268,7 +2267,7 @@ (define-public python-h5py
     (inputs
      (list hdf5-1.10))
     (native-inputs
-     (list python-cython python-pkgconfig pkg-config))
+     (list python-cython python-ipython python-pkgconfig python-pytest pkg-config))
     (home-page "https://www.h5py.org/")
     (synopsis "Read and write HDF5 files from Python")
     (description
-- 
2.40.1

Message #11 received at 68171 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 68171 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: python-h5py: Reformat with guix style.
Date: Sat, 30 Dec 2023 12:06:37 +0100

* gnu/packages/python-xyz.scm (python-h5py): Reformat with guix style.

Change-Id: I9c8fabcb8a438909ff70a2c98c9e01b3a82079f3
---
 gnu/packages/python-xyz.scm | 29 +++++++++++++----------------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b5384b7c42..3015f0356f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2250,24 +2250,21 @@ (define-public python-h5py
     (version "3.8.0")
     (source
      (origin
-      (method url-fetch)
-      (uri (pypi-uri "h5py" version))
-      (sha256
-       (base32
-        "0pyr6z4h2xqbp49yx2i1401gl6yqh03h771zslwcy0201hpxiskg"))))
+       (method url-fetch)
+       (uri (pypi-uri "h5py" version))
+       (sha256
+        (base32 "0pyr6z4h2xqbp49yx2i1401gl6yqh03h771zslwcy0201hpxiskg"))))
     (build-system python-build-system)
     (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'fix-hdf5-paths
-          (lambda* (#:key inputs #:allow-other-keys)
-            (setenv "HDF5_DIR" (assoc-ref inputs "hdf5")))))))
-    (propagated-inputs
-     (list python-six python-numpy))
-    (inputs
-     (list hdf5-1.10))
-    (native-inputs
-     (list python-cython python-ipython python-pkgconfig python-pytest pkg-config))
+     '(#:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'fix-hdf5-paths
+                    (lambda* (#:key inputs #:allow-other-keys)
+                      (setenv "HDF5_DIR"
+                              (assoc-ref inputs "hdf5")))))))
+    (propagated-inputs (list python-six python-numpy))
+    (inputs (list hdf5-1.10))
+    (native-inputs (list pkg-config python-cython python-ipython
+                         python-pkgconfig python-pytest))
     (home-page "https://www.h5py.org/")
     (synopsis "Read and write HDF5 files from Python")
     (description
-- 
2.40.1

Message #16 received at 68171-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Troy Figiel <troy <at> troyfigiel.com>
Cc: 68171-done <at> debbugs.gnu.org
Subject: Re: [bug#68171] [PATCH 0/2] Enable tests for python-h5py
Date: Tue, 09 Jan 2024 10:09:24 +0100

> While writing a different package definition, I noticed python-h5py does
> not have any of its tests enabled. To make the tests pass, only two new
> packages needed to be added to the native inputs.
>
> A total of 130 dependent packages would need to be rebuilt. Although it
> seems unlikely that only adding tests would break dependent builds, I
> checked that locally all dependent packages that could be built before
> this patch series, can still be built when these patches are applied (at
> least for x86_64-linux).

Agreed. Applied, thanks!

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.