GNU bug report logs - #6817
(Feature request w/ patch) wdired should create directories needed for destination files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6817 in the body.
You can then email your comments to 6817 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Phil Sung <philbert <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: (Feature request w/ patch) wdired should create directories needed 
	for destination files
Date: Fri, 6 Aug 2010 14:26:04 -0700

[Message part 1 (text/plain, inline)]

It is sometimes useful in wdired to be able to move files into
directories that don't yet exist, e.g. when one is reorganizing files
and directories. The attached patch (against git HEAD), based on
previous work by Joakim Verona (source:
http://www.emacswiki.org/emacs/WDired), makes wdired create parent
directories needed as necessary for the destination files, conditional
on the variable `wdired-create-parent-directories'.

What do others think of this feature?

Regards,
Phil

[wdired-create-parent-directories.patch (text/x-patch, attachment)]

Message #8 received at 6817 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Phil Sung <philbert <at> gmail.com>
Cc: 6817 <at> debbugs.gnu.org
Subject: Re: bug#6817: (Feature request w/ patch) wdired should create
 directories needed for destination files
Date: Fri, 26 Feb 2016 17:14:51 +1030

Phil Sung <philbert <at> gmail.com> writes:

> It is sometimes useful in wdired to be able to move files into
> directories that don't yet exist, e.g. when one is reorganizing files
> and directories. The attached patch (against git HEAD), based on
> previous work by Joakim Verona (source:
> http://www.emacswiki.org/emacs/WDired), makes wdired create parent
> directories needed as necessary for the destination files, conditional
> on the variable `wdired-create-parent-directories'.
>
> What do others think of this feature?

[...]

> +(defcustom wdired-create-parent-directories nil
> +  "If non-nil, create parent directories of destination files.
> +
> +If non-nil, when you rename a file to a destination path within a
> +nonexistent directory, wdired will create any parent directories
> +necessary. When nil, attempts to rename a file into a nonexistent
> +directory will fail."
> +  :type 'boolean
> +  :group 'wdired)

[...]

> +(defun wdired-create-parentdirs (file-new)
> +  "Create parent directories for FILE-NEW if they don't exist."
> +  (and (not (file-exists-p (file-name-directory file-new)))
> +       (message "Creating directory for file %s" file-new)
> +       (make-directory (file-name-directory file-new) t)))

I think this makes sense, but I've used wdired very little, so I don't
quite have a handle on whether this is a use case that people would
like.  (And if so, the default should probably be t, here.)

Opinions?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 6817 <at> debbugs.gnu.org (full text, mbox):

From: Ingo Lohmar <i.lohmar <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Phil Sung <philbert <at> gmail.com>
Cc: 6817 <at> debbugs.gnu.org
Subject: Re: bug#6817: (Feature request w/ patch) wdired should create
 directories	needed for destination files
Date: Fri, 26 Feb 2016 18:49:07 +0100

On Fri, Feb 26 2016 17:14 (+1030), Lars Ingebrigtsen wrote:

> Phil Sung <philbert <at> gmail.com> writes:
>
>> It is sometimes useful in wdired to be able to move files into
>> directories that don't yet exist, e.g. when one is reorganizing files
>> and directories. The attached patch (against git HEAD), based on
>> previous work by Joakim Verona (source:
>> http://www.emacswiki.org/emacs/WDired), makes wdired create parent
>> directories needed as necessary for the destination files, conditional
>> on the variable `wdired-create-parent-directories'.
>>
>> What do others think of this feature?
>
> [...]
>
>> +(defcustom wdired-create-parent-directories nil
>> +  "If non-nil, create parent directories of destination files.
>> +
>> +If non-nil, when you rename a file to a destination path within a
>> +nonexistent directory, wdired will create any parent directories
>> +necessary. When nil, attempts to rename a file into a nonexistent
>> +directory will fail."
>> +  :type 'boolean
>> +  :group 'wdired)
>
> [...]
>
>> +(defun wdired-create-parentdirs (file-new)
>> +  "Create parent directories for FILE-NEW if they don't exist."
>> +  (and (not (file-exists-p (file-name-directory file-new)))
>> +       (message "Creating directory for file %s" file-new)
>> +       (make-directory (file-name-directory file-new) t)))
>
> I think this makes sense, but I've used wdired very little, so I don't
> quite have a handle on whether this is a use case that people would
> like.  (And if so, the default should probably be t, here.)
>
> Opinions?



I've been running with this patch for years (though not extensively
using it), and it has never failed me.  I think this is a very useful
addition, and would also like the "t"-default, though that is not
essential..

Message #14 received at 6817 <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <jwiegley <at> gmail.com>
To: Ingo Lohmar <i.lohmar <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Phil Sung <philbert <at> gmail.com>,
 6817 <at> debbugs.gnu.org
Subject: Re: bug#6817: (Feature request w/ patch) wdired should create
 directories needed for destination files
Date: Fri, 26 Feb 2016 16:51:00 -0800

>>>>> Ingo Lohmar <i.lohmar <at> gmail.com> writes:

> I've been running with this patch for years (though not extensively using
> it), and it has never failed me. I think this is a very useful addition, and
> would also like the "t"-default, though that is not essential..

I think that having wdired DRTR with regard to what the renamed version of a
file should "mean" (i.e., if it implies the existence of directories that
don't yet exist, and so create them), sounds useful to me.


-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Message #17 received at 6817 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: John Wiegley <jwiegley <at> gmail.com>
Cc: Ingo Lohmar <i.lohmar <at> gmail.com>, 6817 <at> debbugs.gnu.org,
 John Wiegley <johnw <at> gnu.org>, Phil Sung <philbert <at> gmail.com>
Subject: Re: bug#6817: (Feature request w/ patch) wdired should create
 directories needed for destination files
Date: Sun, 28 Feb 2016 15:00:46 +1030

John Wiegley <jwiegley <at> gmail.com> writes:

>>>>>> Ingo Lohmar <i.lohmar <at> gmail.com> writes:
>
>> I've been running with this patch for years (though not extensively using
>> it), and it has never failed me. I think this is a very useful addition, and
>> would also like the "t"-default, though that is not essential..
>
> I think that having wdired DRTR with regard to what the renamed version of a
> file should "mean" (i.e., if it implies the existence of directories that
> don't yet exist, and so create them), sounds useful to me.

Ok; I'll apply the patch to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.