From unknown Fri Aug 15 16:22:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Dec 2023 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 68158@debbugs.gnu.org X-Debbugs-Original-To: Emacs Bugs Mailing List Received: via spool by submit@debbugs.gnu.org id=B.170397778717831 (code B ref -1); Sat, 30 Dec 2023 23:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Dec 2023 23:09:47 +0000 Received: from localhost ([127.0.0.1]:45228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiSh-0004dX-Fr for submit@debbugs.gnu.org; Sat, 30 Dec 2023 18:09:47 -0500 Received: from lists.gnu.org ([2001:470:142::17]:49954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiSf-0004dJ-1U for submit@debbugs.gnu.org; Sat, 30 Dec 2023 18:09:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJiSX-00042w-NH for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 18:09:38 -0500 Received: from out-186.mta0.migadu.com ([2001:41d0:1004:224b::ba]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJiSS-0005HG-3g for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 18:09:37 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1703977767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=cnmJwA9EfP69w/07BCI5qyHtcQfjqblnaf5kXZPjowg=; b=mul7IrSZ2yHGXIx/IUmgo8urJ7Vv/0B1GCVvzLz5SiDEl0le+R3ZDkx+GpBTyh+KgYjCoQ NkTcmlc3oorua/edSXuP8fb91oTkrvl8nGn9LnwlkqXwGS5dcvYdzgvoYn0QgICd15BBLc VKZLvcdWs9eqrcyYHhUllilg/wGU/Bw= From: Joseph Turner Date: Sat, 30 Dec 2023 14:56:13 -0800 Message-ID: <87sf3jmgo6.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::ba; envelope-from=joseph@breatheoutbreathe.in; helo=out-186.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) With emacs -Q, in the buffer which pops open after... (progn (setopt isearch-wrap-pause 'no) ;; (setopt isearch-wrap-pause 'no-ding) ; this causes the same problem (with-current-buffer (generate-new-buffer "isearch-wrap-pause-test") (insert "bar") (goto-char (point-min)) (pop-to-buffer (current-buffer)))) ...run isearch for "baz" with... C-s b a z ...then attempt to delete the non-matching "z" character with DEL. Expected contents of minibuffer: "Isearch: ba" Actual contents of minibuffer: "Failing overwrapped I-search: baz" Pressing DEL a second time actually deletes the "z". Thanks for your help!! Joseph GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) From unknown Fri Aug 15 16:22:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 11:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Joseph Turner , Juri Linkov Cc: 68158@debbugs.gnu.org Received: via spool by 68158-submit@debbugs.gnu.org id=B68158.170436666213576 (code B ref 68158); Thu, 04 Jan 2024 11:12:02 +0000 Received: (at 68158) by debbugs.gnu.org; 4 Jan 2024 11:11:02 +0000 Received: from localhost ([127.0.0.1]:53702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLLcs-0003Wu-50 for submit@debbugs.gnu.org; Thu, 04 Jan 2024 06:11:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLLcm-0003WK-GD for 68158@debbugs.gnu.org; Thu, 04 Jan 2024 06:11:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLLcc-0007X9-12; Thu, 04 Jan 2024 06:10:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZbaXmzvhcMZIJq2cPuJ5R3IzJ9/RHOTeOrS50/Msn68=; b=qUGJURRX1IB3 9NqiT3DpKB9NNQR24CsRqMmwJmqXvTDGolIQQPu8IUdAEmc7UPHqX9lND+gH5dgK1OKFfVw3sclY4 ZWhBusBGYOdqtVdsqjNsjkglHk3KOtLgtj/7xV5NNxNWQaJqNgsTt5qinC+6onD/HLKF9roTahR9Y dVnZuiE2DpVJWG/BCSvHlJM4tHHA5JfTKlYHeBVjlcdswr+kC5Zci+897yxdgEHNZUHjgmQouVSA9 zhcG9cMjM1HFLu7MwLC2SC4TLCUrcXdmncoE+m79kw3i3bfxNNtpVUtOCZK3yI9jo4WOUAiIPEk4h XkImheTe7kDoXiSz3qANSA==; Date: Thu, 04 Jan 2024 13:10:31 +0200 Message-Id: <831qaxxsk8.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sf3jmgo6.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org) References: <87sf3jmgo6.fsf@breatheoutbreathe.in> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 30 Dec 2023 14:56:13 -0800 > From: Joseph Turner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > With emacs -Q, in the buffer which pops open after... > > (progn > (setopt isearch-wrap-pause 'no) > ;; (setopt isearch-wrap-pause 'no-ding) ; this causes the same problem > (with-current-buffer (generate-new-buffer "isearch-wrap-pause-test") > (insert "bar") > (goto-char (point-min)) > (pop-to-buffer (current-buffer)))) > > ...run isearch for "baz" with... > > C-s b a z > > ...then attempt to delete the non-matching "z" character with DEL. > > Expected contents of minibuffer: > > "Isearch: ba" > > Actual contents of minibuffer: > > "Failing overwrapped I-search: baz" > > Pressing DEL a second time actually deletes the "z". > > Thanks for your help!! > > Joseph > > GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, > cairo version 1.16.0) Juri, could you please look into this? It seems to be a regression in Emacs 29.1 due to your changes in commit 7320a812e, to solve bug#56535. I guess we need to distinguish between self-inserting characters and DEL? From unknown Fri Aug 15 16:22:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 68158@debbugs.gnu.org, Joseph Turner Received: via spool by 68158-submit@debbugs.gnu.org id=B68158.1704388391883 (code B ref 68158); Thu, 04 Jan 2024 17:14:02 +0000 Received: (at 68158) by debbugs.gnu.org; 4 Jan 2024 17:13:11 +0000 Received: from localhost ([127.0.0.1]:55580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLRHK-0000EB-QH for submit@debbugs.gnu.org; Thu, 04 Jan 2024 12:13:11 -0500 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:51555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLRHH-0000Da-0e for 68158@debbugs.gnu.org; Thu, 04 Jan 2024 12:13:09 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4559840009; Thu, 4 Jan 2024 17:12:54 +0000 (UTC) From: Juri Linkov In-Reply-To: <831qaxxsk8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jan 2024 13:10:31 +0200") Organization: LINKOV.NET References: <87sf3jmgo6.fsf@breatheoutbreathe.in> <831qaxxsk8.fsf@gnu.org> Date: Thu, 04 Jan 2024 19:02:52 +0200 Message-ID: <86wmspnngh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> (progn >> (setopt isearch-wrap-pause 'no) >> ;; (setopt isearch-wrap-pause 'no-ding) ; this causes the same problem >> (with-current-buffer (generate-new-buffer "isearch-wrap-pause-test") >> (insert "bar") >> (goto-char (point-min)) >> (pop-to-buffer (current-buffer)))) >> >> ...run isearch for "baz" with... >> >> C-s b a z >> >> ...then attempt to delete the non-matching "z" character with DEL. >> >> GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, >> cairo version 1.16.0) > > Juri, could you please look into this? It seems to be a regression in > Emacs 29.1 due to your changes in commit 7320a812e, to solve > bug#56535. I guess we need to distinguish between self-inserting > characters and DEL? This means that we need to preclude 'isearch-push-state' in 'isearch-repeat' from updating 'isearch-cmds'. Should I push this patch to the emacs-29 branch? It looks safe. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=isearch-wrap-pause-no-ding.patch diff --git a/lisp/isearch.el b/lisp/isearch.el index ee5660309df..f753a5377ca 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2844,7 +2844,8 @@ isearch-search-and-update (isearch-search) (when (and (memq isearch-wrap-pause '(no no-ding)) (not isearch-success)) - (isearch-repeat (if isearch-forward 'forward 'backward))))) + (let ((isearch-cmds isearch-cmds)) + (isearch-repeat (if isearch-forward 'forward 'backward)))))) (isearch-push-state) (if isearch-op-fun (funcall isearch-op-fun)) (isearch-update)) --=-=-=-- From unknown Fri Aug 15 16:22:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 17:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 68158@debbugs.gnu.org, joseph@breatheoutbreathe.in Received: via spool by 68158-submit@debbugs.gnu.org id=B68158.17043906112108 (code B ref 68158); Thu, 04 Jan 2024 17:51:01 +0000 Received: (at 68158) by debbugs.gnu.org; 4 Jan 2024 17:50:11 +0000 Received: from localhost ([127.0.0.1]:55625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLRr9-0000Xw-CK for submit@debbugs.gnu.org; Thu, 04 Jan 2024 12:50:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLRr5-0000XO-0I for 68158@debbugs.gnu.org; Thu, 04 Jan 2024 12:50:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLRqv-0007Js-F2; Thu, 04 Jan 2024 12:49:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PjQcDMgRw6hmdUhuoESX466uBwMr29NPhy0cF9B/Vzo=; b=Drxz7hi94xfm u1FvcOuiXFnwiL1zifTRK/XnP3MyftWL5Ox7vSlu2IjRIRxrCAPE7PcchCPkWiVZWNeF0+TsyvLHH bcTHhf4lRrLXva1ySdXcl246s7DdTAxA4EXWPZ7T/hDHZbepfAzbOlCDCd3Pzz4qK9OLOPOgpVPpE z9t2/WFyW8nz6hMkDRkoJDpozQflY1BcBxeSUjc7IgrTg3hng82akNw4FzyDTfw7DGaizEjCPw4SV jHF3mKfQ520uO9cjJ9sgmxpf6S+0WFOQPycMSvxhWAme92/NB6n1BNs6rRjwtU3reCHcw2G9/H8kG dDi9K8wNkMdAyWVoYeRbug==; Date: Thu, 04 Jan 2024 19:49:42 +0200 Message-Id: <83le95vvih.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86wmspnngh.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 04 Jan 2024 19:02:52 +0200) References: <87sf3jmgo6.fsf@breatheoutbreathe.in> <831qaxxsk8.fsf@gnu.org> <86wmspnngh.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Joseph Turner , 68158@debbugs.gnu.org > Date: Thu, 04 Jan 2024 19:02:52 +0200 > > >> C-s b a z > >> > >> ...then attempt to delete the non-matching "z" character with DEL. > >> > >> GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, > >> cairo version 1.16.0) > > > > Juri, could you please look into this? It seems to be a regression in > > Emacs 29.1 due to your changes in commit 7320a812e, to solve > > bug#56535. I guess we need to distinguish between self-inserting > > characters and DEL? > > This means that we need to preclude 'isearch-push-state' in 'isearch-repeat' > from updating 'isearch-cmds'. > > Should I push this patch to the emacs-29 branch? It looks safe. Yes, please. Thanks. From unknown Fri Aug 15 16:22:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Eli Zaretskii , 68158@debbugs.gnu.org Received: via spool by 68158-submit@debbugs.gnu.org id=B68158.170439474416663 (code B ref 68158); Thu, 04 Jan 2024 19:00:02 +0000 Received: (at 68158) by debbugs.gnu.org; 4 Jan 2024 18:59:04 +0000 Received: from localhost ([127.0.0.1]:55713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLSvo-0004Kh-DI for submit@debbugs.gnu.org; Thu, 04 Jan 2024 13:59:04 -0500 Received: from out-172.mta1.migadu.com ([95.215.58.172]:48450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLSvm-0004KG-2s for 68158@debbugs.gnu.org; Thu, 04 Jan 2024 13:59:03 -0500 References: <87sf3jmgo6.fsf@breatheoutbreathe.in> <831qaxxsk8.fsf@gnu.org> <86wmspnngh.fsf@mail.linkov.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1704394736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WgR9Sv0m0YGevakxtUOgYW+gtqK0uIRTjLIYhMH29j4=; b=QsKlWxILneaffn4Eu0PvT5aGRrO2+yiFzW8H5h7T2Hxz6pQvG6/rejMwKQsPl9lS6bwkLT mBWokLftC+40oFKRBVMgTvDjfUMSKmqkT2doebgfTf1LEpaIkJ1c6ZROswRTCGwQI05tsp E2l5c9k672wTgCCmUNTZJQOuSPSc7uo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Thu, 04 Jan 2024 10:58:09 -0800 In-reply-to: <86wmspnngh.fsf@mail.linkov.net> Message-ID: <875y092adv.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: [...] > This means that we need to preclude 'isearch-push-state' in 'isearch-repeat' > from updating 'isearch-cmds'. > > Should I push this patch to the emacs-29 branch? It looks safe. Thank you! This solves the problem on my machine. Joseph From unknown Fri Aug 15 16:22:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jan 2024 07:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 68158@debbugs.gnu.org, joseph@breatheoutbreathe.in Received: via spool by 68158-submit@debbugs.gnu.org id=B68158.170444067520958 (code B ref 68158); Fri, 05 Jan 2024 07:45:01 +0000 Received: (at 68158) by debbugs.gnu.org; 5 Jan 2024 07:44:35 +0000 Received: from localhost ([127.0.0.1]:56242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLesd-0005Rx-4T for submit@debbugs.gnu.org; Fri, 05 Jan 2024 02:44:35 -0500 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:39577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLesb-0005Ri-75 for 68158@debbugs.gnu.org; Fri, 05 Jan 2024 02:44:33 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id F099B240005; Fri, 5 Jan 2024 07:44:21 +0000 (UTC) From: Juri Linkov In-Reply-To: <83le95vvih.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jan 2024 19:49:42 +0200") Organization: LINKOV.NET References: <87sf3jmgo6.fsf@breatheoutbreathe.in> <831qaxxsk8.fsf@gnu.org> <86wmspnngh.fsf@mail.linkov.net> <83le95vvih.fsf@gnu.org> Date: Fri, 05 Jan 2024 09:41:21 +0200 Message-ID: <865y08kz1a.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> >> C-s b a z >> >> >> >> ...then attempt to delete the non-matching "z" character with DEL. >> >> >> >> GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, >> >> cairo version 1.16.0) >> > >> > Juri, could you please look into this? It seems to be a regression in >> > Emacs 29.1 due to your changes in commit 7320a812e, to solve >> > bug#56535. I guess we need to distinguish between self-inserting >> > characters and DEL? >> >> This means that we need to preclude 'isearch-push-state' in 'isearch-repeat' >> from updating 'isearch-cmds'. >> >> Should I push this patch to the emacs-29 branch? It looks safe. > > Yes, please. So now pushed to emacs-29. From unknown Fri Aug 15 16:22:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jan 2024 07:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Joseph Turner Cc: Eli Zaretskii , 68158@debbugs.gnu.org Received: via spool by 68158-submit@debbugs.gnu.org id=B68158.170444067920982 (code B ref 68158); Fri, 05 Jan 2024 07:45:02 +0000 Received: (at 68158) by debbugs.gnu.org; 5 Jan 2024 07:44:39 +0000 Received: from localhost ([127.0.0.1]:56245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLesh-0005SL-Eg for submit@debbugs.gnu.org; Fri, 05 Jan 2024 02:44:39 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:40325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLese-0005Rm-LW; Fri, 05 Jan 2024 02:44:37 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 93A53C0007; Fri, 5 Jan 2024 07:44:24 +0000 (UTC) From: Juri Linkov In-Reply-To: <875y092adv.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Thu, 04 Jan 2024 10:58:09 -0800") Organization: LINKOV.NET References: <87sf3jmgo6.fsf@breatheoutbreathe.in> <831qaxxsk8.fsf@gnu.org> <86wmspnngh.fsf@mail.linkov.net> <875y092adv.fsf@breatheoutbreathe.in> Date: Fri, 05 Jan 2024 09:42:31 +0200 Message-ID: <86zfxkjkew.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 68158 29.1.90 thanks >> This means that we need to preclude 'isearch-push-state' in 'isearch-repeat' >> from updating 'isearch-cmds'. >> >> Should I push this patch to the emacs-29 branch? It looks safe. > > Thank you! This solves the problem on my machine. Thanks for confirming and for the bug report. So now closing it.