GNU bug report logs - #68133
[PATCH] gnu: glew: Fix cross-compiling.

Previous Next

Package: guix-patches;

Reported by: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>

Date: Sat, 30 Dec 2023 04:55:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Subject: bug#68133: closed (Re: [bug#68133] [PATCH] gnu: glew: Fix
 cross-compiling.)
Date: Tue, 09 Jan 2024 09:37:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#68133: [PATCH] gnu: glew: Fix cross-compiling.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 68133 <at> debbugs.gnu.org.

-- 
68133: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68133
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 68133-done <at> debbugs.gnu.org
Subject: Re: [bug#68133] [PATCH] gnu: glew: Fix cross-compiling.
Date: Tue, 09 Jan 2024 10:35:45 +0100
Hello,

> * gnu/packages/gl.scm(mesa)[native-inputs]: when cross-compile, add
> cmake-minimal-cross.
> [arguments]: adjust fix-cross-compiling to find llvm.
>
> * gnu/packages/llvm.scm(llvm-for-mesa)
> [arguments]<#:configure-flags>: When cross-compile, set
> -DBUILD_SHARED_LIBS:BOOL=TRUE and -DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE,
> remove -DLLVM_LINK_LLVM_DYLIB.* .
> <#:phases>: when cross-compile, remove delete-static-libraries phase.

I amended the commit message and applied,

Thanks,

Mathieu

[Message part 3 (message/rfc822, inline)]
From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: glew: Fix cross-compiling.
Date: Sat, 30 Dec 2023 12:53:29 +0800
gnu/packages/gl.scm(glew):
[arguments]<#:make-flags>: when cross-compiling, use {cc,strip}-for-target.

Change-Id: I365f6635120a85359083beb88cb138f09a99fe33
---
 gnu/packages/gl.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gl.scm b/gnu/packages/gl.scm
index 192b5e84e0..56a1def37a 100644
--- a/gnu/packages/gl.scm
+++ b/gnu/packages/gl.scm
@@ -690,7 +690,12 @@ (define-public glew
                   #t))))
     (build-system gnu-build-system)
     (arguments
-     (list #:make-flags #~(list (string-append "GLEW_PREFIX=" #$output)
+     (list #:make-flags #~(list #$@(if (%current-target-system)
+                                       #~((string-append "CC=" #$(cc-for-target))
+                                          (string-append "LD=" #$(cc-for-target))
+                                          (string-append "STRIP=" #$(strip-for-target)))
+                                       #~())
+                                (string-append "GLEW_PREFIX=" #$output)
                                 (string-append "GLEW_DEST=" #$output))
            #:phases
            #~(modify-phases %standard-phases

base-commit: f76ca2b0e894c244d5011a32b30dee8fd874e322
-- 
2.41.0




This bug report was last modified 1 year and 134 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.