Subject: Re: bug#6811: [PATCH] emacs-23.2 on hpux

From: "Peter O'Gorman" <[email-masked]>
Date: Mon, 9 Aug 2010 15:42:02 -0500

On Mon, Aug 09, 2010 at 05:47:58AM -0400, Dan Nicolaescu wrote:
> > +  ia64*-hp-hpux1[1-9]* )
> > +    machine=hp800 opsys=hpux11
> 
> I think new ports need to be approved by the maintainers. 
> This looks a bit odd.
> Shouldn't the machine file be ia64?  Or a new file with ia64 in the name?

At least for 23.2 ia64.h doesn't work. We'll try again on the next
release.

> 
> >  /* Tested in getloadavg.c.  */
> > +#ifndef HAVE_PSTAT_GETDYNAMIC
> >  #define HAVE_PSTAT_GETDYNAMIC
> > +#endif
> 
> If autoconf sets HAVE_PSTAT_GETDYNAMIC, then it seems that it's better
> to just remove the #define.

Sure, autoconf does set it.

> >  
> > +#if __ia64
> > +#define CANNOT_DUMP 1
> > +#endif
> 
> This looks bad, we don't have any port in the tree that does CANNOT_DUMP.
> Does it work if you dump using unexelf.o?

No.

> >  
> >  #else /* USE_LISP_UNION_TYPE */
> 
> There's some code that does DATA_SEG_BITS further down in the file,
> maybe some untangling is needed in lisp.h...

That would be nice, it gave me a headache :-)

Peter
-- 
Peter O'Gorman
[email-masked]