From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 06 12:30:32 2010 Received: (at submit) by debbugs.gnu.org; 6 Aug 2010 16:30:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhPoW-0006Zs-07 for submit@debbugs.gnu.org; Fri, 06 Aug 2010 12:30:32 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhPoU-0006Zg-D4 for submit@debbugs.gnu.org; Fri, 06 Aug 2010 12:30:30 -0400 Received: from lists.gnu.org ([199.232.76.165]:55355) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OhPp2-0004Nh-SI for submit@debbugs.gnu.org; Fri, 06 Aug 2010 12:31:04 -0400 Received: from [140.186.70.92] (port=42534 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhPoy-0006lc-Jx for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 12:31:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OhOiH-00071K-9u for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 11:20:02 -0400 Received: from ppsw-31.csi.cam.ac.uk ([131.111.8.131]:52340) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhOiH-00070i-40 for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2010 11:20:01 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.cmbg.cable.ntl.com ([86.9.122.85]:58356 helo=Victoria.local) by ppsw-31.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1OhOiF-0000mQ-K5 (Exim 4.72) for bug-gnu-emacs@gnu.org (return-path ); Fri, 06 Aug 2010 16:19:59 +0100 From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.2; dired-omit-mode makes dired slow Date: Fri, 06 Aug 2010 16:19:57 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) When dired-omit-mode is on, operations on marked files become much slower. To see this, following these steps: 1. Emacs -q 2. eval: (require 'dired-x) (add-hook 'dired-mode-hook 'dired-omit-mode) 3. C-x d and enter emacs/lisp (or any dir that has a few dozen files) 4. Mark all files by typing: * / t 5. Change mode to 444 by typing: M 444 RET For every marked file, a message is displayed something like: Redisplaying...xyz.el Omitting... (Nothing to omit) Can this inefficiency be rid of? Thank you. Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 12:28:40 2010 Received: (at 6810) by debbugs.gnu.org; 4 Dec 2010 17:28:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POvua-0007OM-Ad for submit@debbugs.gnu.org; Sat, 04 Dec 2010 12:28:40 -0500 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POvuX-0007O9-Mf for 6810@debbugs.gnu.org; Sat, 04 Dec 2010 12:28:38 -0500 Received: by wyf23 with SMTP id 23so9893597wyf.3 for <6810@debbugs.gnu.org>; Sat, 04 Dec 2010 09:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=CXvphXVdu+Vr2pSxWYQbYlSSPul8Xi+DstvHUgyWjFY=; b=Wkepwfcd6lTIVY9eLPGhTrMdVhoRRFNDyuoytlXHPdyBxQRHjgcUvCsiNB2ojc+J6U +k4nThQ0F+O3bcIHznXLg/iCVrKUjRE8F/Otbxbj/CiBTomBHw/BRvkgDDDlDnVzMSYW abNLpVuygUqNzMOXUjY9YZ6gZikN9JCnzIr88= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; b=Sf/0wv+cDqb692c2abvQ0rqwuxC/VMdxgeIa21LPlo/ACISzucQLN0j+eqmob5vkOw ru52gSX+mdIVLjpAgUH17dZQKI1IVlvfZa+RjQuuvd9vSMRrnkLiPIozPHYb0kKGqxHX yGANirzAiMdFs3R1YByY+ih9bS0Y5mfZfTAqU= Received: by 10.227.145.68 with SMTP id c4mr3507846wbv.42.1291484064658; Sat, 04 Dec 2010 09:34:24 -0800 (PST) Received: from Victoria.local (cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com [86.9.122.85]) by mx.google.com with ESMTPS id a2sm1496076wer.17.2010.12.04.09.34.23 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 04 Dec 2010 09:34:23 -0800 (PST) From: Leo To: 6810@debbugs.gnu.org Subject: Re: bug#6810: 23.2; dired-omit-mode makes dired slow References: Date: Sat, 04 Dec 2010 17:34:21 +0000 In-Reply-To: (Leo's message of "Fri, 06 Aug 2010 16:19:57 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.90 (Mac OS X 10.6.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 6810 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) On 2010-08-06 16:19 +0100, Leo wrote: > When dired-omit-mode is on, operations on marked files become much > slower. To see this, following these steps: > > 1. Emacs -q > > 2. eval: > (require 'dired-x) > (add-hook 'dired-mode-hook 'dired-omit-mode) > > 3. C-x d and enter emacs/lisp (or any dir that has a few dozen files) > > 4. Mark all files by typing: * / t > > 5. Change mode to 444 by typing: M 444 RET > > > For every marked file, a message is displayed something like: > Redisplaying...xyz.el > Omitting... > (Nothing to omit) > > Can this inefficiency be rid of? Thank you. > > Leo `dired-do-redisplay' iterates over the marked files calling dired-update-file-line which triggers dired-after-readin-hook (see line 1132 in dired-aux). So that hook is being run for as many times as the number of files marked. Any objection to something like this: diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 62d6928..90fd1e69 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1017,10 +1017,13 @@ ;; message much faster than making dired-map-over-marks show progress (dired-uncache (if (consp dired-directory) (car dired-directory) dired-directory)) - (dired-map-over-marks (let ((fname (dired-get-filename))) + (dired-map-over-marks (let ((fname (dired-get-filename)) + ;; disable readin hook until later + (dired-after-readin-hook nil)) (message "Redisplaying... %s" fname) (dired-update-file-line fname)) arg) + (run-hooks 'dired-after-readin-hook) (dired-move-to-filename) (message "Redisplaying...done"))) Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 04 17:13:42 2010 Received: (at 6810) by debbugs.gnu.org; 4 Dec 2010 22:13:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0MQ-0006yR-GT for submit@debbugs.gnu.org; Sat, 04 Dec 2010 17:13:42 -0500 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP0MP-0006yG-3W for 6810@debbugs.gnu.org; Sat, 04 Dec 2010 17:13:41 -0500 Received: from furball (dhcp128036014248.central.yale.edu [128.36.14.248]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB4MJSqx005923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 4 Dec 2010 17:19:28 -0500 Received: by furball (Postfix, from userid 1000) id 3200C16059F; Sat, 4 Dec 2010 17:19:28 -0500 (EST) From: Chong Yidong To: Leo Subject: Re: bug#6810: 23.2; dired-omit-mode makes dired slow References: Date: Sat, 04 Dec 2010 17:19:28 -0500 In-Reply-To: (Leo's message of "Sat, 04 Dec 2010 17:34:21 +0000") Message-ID: <87d3phxjtb.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6810 Cc: 6810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Leo writes: > `dired-do-redisplay' iterates over the marked files calling > dired-update-file-line which triggers dired-after-readin-hook (see line > 1132 in dired-aux). So that hook is being run for as many times as the > number of files marked. > > Any objection to something like this: Shouldn't this handle dired-before-readin hook too? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 05 00:14:24 2010 Received: (at 6810) by debbugs.gnu.org; 5 Dec 2010 05:14:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP6vX-0004sz-Jz for submit@debbugs.gnu.org; Sun, 05 Dec 2010 00:14:23 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PP6vW-0004sf-RL for 6810@debbugs.gnu.org; Sun, 05 Dec 2010 00:14:23 -0500 Received: by wwj40 with SMTP id 40so4423157wwj.15 for <6810@debbugs.gnu.org>; Sat, 04 Dec 2010 21:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=YYjzyQudVr9GOuiI8Ef13g05Pn+ATMAr7GsbtyajVjc=; b=LRjACMrcsHmXL0yiNo9UqeghhXF/I2TXvny8Y8FSp7LNd4uPYT+UJXjn9ECszP6mds nXoDQTQkiDTR3QDI9hfXAWn9h+zsLmNmMg6Ng3uVmSvrMaMiHF0+YDsjNWDk4l1p6ywS +kehMWG/p2ZMfcUA9diSczVRetXd4ysEvtAvk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=NrWmusVnoPnQr4Il4eA7vsCF/O+sUiRYUDIMJbfQ4Car3JsqTQlZVxqQtkCPVkMG33 Q9WiXKCAd8AkjNEoi+PRyUIJA7F1mufdxu6LdiVhDb0GGmbzEZzi6oUhbxXr14sBLGJn xAid4a+ct7HRCAhs5AwWd3UjbnCenvyj1U9nc= Received: by 10.216.177.71 with SMTP id c49mr1252477wem.54.1291526411079; Sat, 04 Dec 2010 21:20:11 -0800 (PST) Received: from Victoria.local (cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com [86.9.122.85]) by mx.google.com with ESMTPS id w84sm1691725weq.44.2010.12.04.21.20.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 04 Dec 2010 21:20:09 -0800 (PST) From: Leo To: Chong Yidong Subject: Re: bug#6810: 23.2; dired-omit-mode makes dired slow References: <87d3phxjtb.fsf@stupidchicken.com> Date: Sun, 05 Dec 2010 05:20:07 +0000 In-Reply-To: <87d3phxjtb.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 04 Dec 2010 17:19:28 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.90 (Mac OS X 10.6.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 6810 Cc: 6810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) On 2010-12-04 22:19 +0000, Chong Yidong wrote: > Shouldn't this handle dired-before-readin hook too? I think at the time of running dired-map-over-marks, dired already passed before-readin stage. But I am not entirely sure. Best, Leo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 14:49:46 2010 Received: (at 6810) by debbugs.gnu.org; 6 Dec 2010 19:49:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPh4E-0002vm-Ba for submit@debbugs.gnu.org; Mon, 06 Dec 2010 14:49:46 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPh4C-0002vW-Ae for 6810@debbugs.gnu.org; Mon, 06 Dec 2010 14:49:44 -0500 Received: from furball (dhcp128036014234.central.yale.edu [128.36.14.234]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB6JtaQt017995 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 6 Dec 2010 14:55:37 -0500 Received: by furball (Postfix, from userid 1000) id E3929160C98; Mon, 6 Dec 2010 14:55:36 -0500 (EST) From: Chong Yidong To: Leo Subject: Re: bug#6810: 23.2; dired-omit-mode makes dired slow References: <87d3phxjtb.fsf@stupidchicken.com> Date: Mon, 06 Dec 2010 14:55:36 -0500 In-Reply-To: (Leo's message of "Sun, 05 Dec 2010 05:20:07 +0000") Message-ID: <87lj42k75z.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6810 Cc: 6810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Leo writes: > On 2010-12-04 22:19 +0000, Chong Yidong wrote: >> Shouldn't this handle dired-before-readin hook too? > > I think at the time of running dired-map-over-marks, dired already > passed before-readin stage. So it is. I've committed your fix, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 14:50:21 2010 Received: (at control) by debbugs.gnu.org; 6 Dec 2010 19:50:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPh4n-0002x2-M6 for submit@debbugs.gnu.org; Mon, 06 Dec 2010 14:50:21 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPh4l-0002wn-93 for control@debbugs.gnu.org; Mon, 06 Dec 2010 14:50:19 -0500 Received: from furball (dhcp128036014234.central.yale.edu [128.36.14.234]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB6JuBs7030091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 6 Dec 2010 14:56:12 -0500 Received: by furball (Postfix, from userid 1000) id ECFE1160C98; Mon, 6 Dec 2010 14:56:11 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6810 Date: Mon, 06 Dec 2010 14:56:11 -0500 Message-ID: <874oaqptes.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 6810 thanks From unknown Sun Jun 22 20:58:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator