From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 28 09:05:45 2023 Received: (at submit) by debbugs.gnu.org; 28 Dec 2023 14:05:46 +0000 Received: from localhost ([127.0.0.1]:38750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIr16-00010u-GO for submit@debbugs.gnu.org; Thu, 28 Dec 2023 09:05:45 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIr11-00010b-8O for submit@debbugs.gnu.org; Thu, 28 Dec 2023 09:05:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIr0v-0008T9-SK for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 09:05:33 -0500 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rIr0t-0000QO-2T for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 09:05:33 -0500 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6dc05409086so744207a34.1 for ; Thu, 28 Dec 2023 06:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703772328; x=1704377128; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Nl9FELVALvr+uXp8Fm3ikYppxZdjBb/t3ftv8ADC4Tw=; b=fVynQG1xU3LqIHaqzBZpjWuYj7l/LOnEMGk1UAkMr4NvCF1KRXvnH25NuczENX0Fcf c3ciuRpyQE0+XHSSBqCX3hks15BdIrCCFCAaHNWvh7UkY3RrtoD+YAkN5fB3Kx1Ig3Q1 DrbwTnQnLbOH1SQ9p7p84ZzjMN5AyFmy4gHZ3rXpziJwB3yJyBCPJCKGOKXXLgI8IMC4 VjxMKZAGjdkbfYJeTX6TlUtQvSUssgGzz6DXi6jNjoSO/KgbPLYhIyhSoBxssLymbH5i 3EIpYc2o5isJCGksCzbtXbICtAviVn2dN1niD2hsNdzxxydnA5niPN3OMh5SeTA2t+Qh GkKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703772328; x=1704377128; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Nl9FELVALvr+uXp8Fm3ikYppxZdjBb/t3ftv8ADC4Tw=; b=wU4XzC2d/zMB5fX0Byg+UHctCGngBgiQqNB4JBqODoVe6yVLH1jhyM4mI3UiWawUZZ Zh9Tgv2KK3YjcnbC+ey743ImMXIz8d/MOEdncpvKxX+hl3/dzCbu2IwRAzd820k7MQBo ufwknxj7vzUbDwn/A0n4/hH2mc3NqYyz2EIqVUZUR0cW3extEyVBm3aor9Fj4qR+FV6w 71uFfpvhzPwbcxeiIUra4v3M4zZ2hh6oZVhtAwzV9sjnzQ1auJAP8kznHfrFwPOYeklH Wu+ttu6PNpu3AUJuqhk2tcGJ1qo0wIeeCzu/wqWkCcTkEkTw7js8l9g1nLZb9nOtudRy NboQ== X-Gm-Message-State: AOJu0YxaRwNaDuVxbmBvn5CMnxHFGAwT7cpswRvY35fWtKx+pCHZ5EZk LH1WxlOPZVfnlv0iNNF2lKfVZtkyKF4= X-Google-Smtp-Source: AGHT+IHriMz2SSzJlgIASHYbIrdKGxquHgStgp7NI45XvpPWpC86CM+Cj5pmz1PIQpB+Q7fmC0cBXQ== X-Received: by 2002:a9d:7f81:0:b0:6db:e98c:23c6 with SMTP id t1-20020a9d7f81000000b006dbe98c23c6mr3514011otp.2.1703772328289; Thu, 28 Dec 2023 06:05:28 -0800 (PST) Received: from Aarons-MacBook-Pro.local (c-76-101-201-183.hsd1.fl.comcast.net. [76.101.201.183]) by smtp.gmail.com with ESMTPSA id et4-20020a05690c2e0400b005e5d28fc279sm984395ywb.63.2023.12.28.06.05.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 06:05:27 -0800 (PST) From: Aaron Jensen To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Intermittent build failure with native compilation X-Debbugs-Cc: Date: Thu, 28 Dec 2023 09:05:25 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::32e; envelope-from=aaronjensen@gmail.com; helo=mail-ot1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On macOS, I am often getting this when building Emacs from scratch. Could this be a race condition with a parallel build? I bisected and the problematic commit is: e670412a3e101e70dc26e021f467faece8cb7f6b In toplevel form: org/org-element.el:64:2: Error: Eager macro-expansion failure: (native-compiler-error (lambda (arg322 &optional arg323) (let ((f #'macroexpand)) (funcall f arg322 arg323))) "Compiling /private/var/tmp/emacs-plusA30-20231227- 10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln... File already exists: /private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln Error: file-already-exists (\"File already exists\" \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") mapbacktrace(#f(compiled-function (evald func args flags) #)) debug-early-backtrace() debug-early(error (file-already-exists \"File already exists\" \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln \")) rename-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\" \"/private/var/tmp/emacs-plusA30-20231 227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") comp-delete-or-replace-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\" \"/private/var/tmp/emacs-plusA30 -20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\") comp--compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") comp-compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") comp-final1() load-with-code-conversion(\"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\" \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.e l\" nil t) command-line-1((\"-l\" \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\")) command-line() normal-top-level() ") gmake[3]: *** [Makefile:330: org/org-element.elc] Error 1 In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.2.0, NS appkit-2487.30 Version 14.2.1 (Build 23C71)) of 2023-12-27 built on Aarons-MacBook-Pro.local Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.2.1 Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/opt/homebrew/share/emacs/site-lisp --infodir=/opt/homebrew/Cellar/emacs-plus@30/30.0.50/share/info/emacs --prefix=/opt/homebrew/Cellar/emacs-plus@30/30.0.50 --with-xml2 --with-gnutls --with-native-compilation --without-compress-install --without-dbus --without-imagemagick --with-modules --with-rsvg --with-webp --with-ns --disable-ns-self-contained 'CFLAGS=-Os -w -pipe -mmacosx-version-min=14 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' 'CPPFLAGS=-I/opt/homebrew/opt/zlib/include -I/opt/homebrew/opt/jpeg/include -I/opt/homebrew/opt/icu4c/include -isystem/opt/homebrew/include -F/opt/homebrew/Frameworks -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk' 'LDFLAGS=-L/opt/homebrew/opt/zlib/lib -L/opt/homebrew/opt/jpeg/lib -L/opt/homebrew/opt/icu4c/lib -L/opt/homebrew/lib -F/opt/homebrew/Frameworks -Wl,-headerpad_max_install_names -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -L/opt/homebrew/opt/libgccjit/lib'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Text Minor modes in effect: windmove-mode: t global-evil-mc-mode: t evil-mc-mode: t global-flycheck-mode: t flycheck-mode: t global-git-commit-mode: t transient-posframe-mode: t corfu-prescient-mode: t corfu-history-mode: t eval-sexp-fu-flash-mode: t tabspaces-mode: t org-roam-db-autosync-mode: t yas-global-mode: t yas-minor-mode: t vertico-prescient-mode: t prescient-persist-mode: t vertico-mouse-mode: t vertico-mode: t mini-frame-mode: t better-jumper-mode: t better-jumper-local-mode: t ns-auto-titlebar-mode: t global-anzu-mode: t anzu-mode: t which-key-posframe-mode: t which-key-mode: t gcmh-mode: t xterm-mouse-mode: t global-auto-revert-mode: t save-place-mode: t winner-mode: t savehist-mode: t delete-selection-mode: t recentf-mode: t repeat-mode: t +popup-mode: t evil-mode: t evil-local-mode: t server-mode: t leader-key-leader-override-mode: t global-leader-key-leader-override-mode: t elpaca-use-package-mode: t override-global-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t minibuffer-regexp-mode: t line-number-mode: t auto-fill-function: #[128 \304\300\301%3#\207 [yas--auto-fill do-auto-fill :around nil apply] 5 advice] transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /Users/aaronjensen/.emacs.d/elpaca/builds/lispy/elpa hides /Users/aaronjensen/.emacs.d/elpaca/builds/ivy/elpa Features: (org-clock image-file image-converter org-drill persist tramp-cmds dabbrev tab-line evil-collection-vterm vterm tramp tramp-message trampver tramp-integration files-x tramp-compat tramp-loaddefs term ehelp vterm-module term/xterm xterm json-mode json-snatcher lua-mode lsp-jq lsp-zig lsp-tilt lsp-steep lsp-svelte lsp-sqls lsp-solidity lsp-ruby-syntax-tree lsp-ruby-lsp lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-semgrep lsp-rust lsp-rubocop lsp-rf lsp-ruff-lsp lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-pwsh lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-mojo lsp-magik lsp-nix lsp-nim lsp-nginx lsp-move lsp-mint lsp-mdx lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-glsl lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-cypher lsp-css lsp-csharp lsp-crystal lsp-credo lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro lsp-awk lsp-ansible lsp-angular lsp-ada lsp-actionscript evil-collection-simple lsp-mode lsp-protocol spinner markdown-mode inline ht js c-ts-common cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine sql view cal-iso diary-lib diary-loaddefs evil-ruby-text-objects ruby-refactor bundler inf-ruby ruby-mode sh-script smie treesit epa-file network-stream mailalias smtpmail textsec uni-scripts idna-mapping uni-confusable textsec-check consult magit-bookmark bookmark dired-aux shadow sort mail-extr emacsbug evil-matchit-simple evil-matchit-prog evil-matchit evil-matchit-sdk semantic/lex semantic/fw hippie-exp evil-collection-helpful helpful cc-langs cc-vars cc-defs trace info-look elisp-refs hide-mode-line info magit-patch magit-subtree magit-gitignore magit-ediff evil-collection-ediff ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util magit-extras vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view bug-reference elpaca-log elpaca-ui popup-mode-core windmove evil-terminal-cursor-changer color executable evil-mc evil-mc-command-execute evil-mc-command-record evil-mc-cursor-make evil-mc-region evil-mc-cursor-state evil-mc-undo evil-mc-vars evil-mc-known-commands evil-mc-common magit-delta xterm-color flycheck evil-collection-magit magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit package url-handlers magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode diff git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient-posframe transient magit-git magit-base crm vertico-directory cape corfu-prescient corfu-history corfu dtrt-indent eval-sexp-fu eros lispyville lispy lispy-inline avy etags fileloop evil-collection-edebug edebug lispy-tags mode-local zoutline elisp-def ert ewoc evil-collection-xref xref f f-shortdoc sotlisp skeleton elec-pair envrc inheritenv evil-surround evil-matchit-evil-setup tabspaces dired-x vc vc-git diff-mode vc-dispatcher flyspell ispell org-indent org-appear orgonomic org-superstar form-feed oc-basic ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom browse-url gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message sendmail yank-media rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range ol-docview doc-view jka-compr image-mode exif dired dired-loaddefs ol-bibtex bibtex iso8601 ol-bbdb ol-w3m ol-doi org-link-doi org-download url-http url url-proxy url-privacy url-expand url-methods url-history mailcap url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-cookie generate-lisp-file url-domsuf url-util url-gw nsm puny async vulpea vulpea-meta vulpea-select vulpea-buffer vulpea-db s vulpea-utils vulpea-note org-roam-migrate org-roam-log org-roam-mode org-roam-capture org-roam-id org-roam-node org-roam-db emacsql-sqlite-builtin sqlite org-roam-utils org-roam-compat org-roam org-mac-link org-goto org-capture org-attach emacsql-sqlite emacsql-sqlite-common emacsql emacsql-compiler magit-section cursor-sensor dash evil-org-agenda evil-org imenu ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-ascii ox-gfm ox-md ox-html table ox-publish ox org-element org-persist xdg org-id org-refile avl-tree generator org-tempo tempo ob-shell shell org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs cal-menu calendar cal-loaddefs org-version org-compat org-macs format-spec undo-fu-session ws-butler yasnippet vertico-prescient prescient char-fold vertico-mouse vertico mini-frame better-jumper ns-auto-titlebar evil-anzu anzu which-key-posframe posframe evil-collection-which-key which-key gcmh help-fns radix-tree cl-print xt-mouse autorevert filenotify saveplace winner hl-line evil-collection-ibuffer ibuffer ibuffer-loaddefs savehist delsel popup-mode-hacks evil-collection-debug debug backtrace find-func recentf tree-widget repeat orderless popup-mode popup-mode-settings evil-collection annalist evil-little-word cus-edit cus-start cus-load wid-edit pp evil evil-integration evil-maps evil-commands reveal evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core advice evil-common thingatpt rect evil-vars memoize nano-modeline nano-light-theme face-remap nano-theme disp-table project gcmh-autoloads copy-as-format-autoloads pdf-tools-autoloads tablist-autoloads restclient-autoloads vterm-autoloads dumb-jump-autoloads popup-autoloads haml-mode-autoloads emmet-mode-autoloads terraform-mode-autoloads hcl-mode-autoloads dockerfile-mode-autoloads yaml-mode-autoloads json-mode-autoloads json-snatcher-autoloads grip-mode-autoloads lua-mode-autoloads bundler-autoloads inf-ruby-autoloads ruby-refactor-autoloads evil-ruby-text-objects-autoloads sotlisp-autoloads elisp-def-autoloads lispyville-autoloads lispy-autoloads iedit-autoloads swiper-autoloads ivy-autoloads zoutline-autoloads eros-autoloads eval-sexp-fu-autoloads web-mode-autoloads ripgrep-capf-autoloads git-link-autoloads consult-git-commit-autoloads git-timemachine-autoloads magit-delta-autoloads xterm-color-autoloads prettier-autoloads iter2-autoloads nvm-autoloads editorconfig-autoloads flycheck-autoloads pkg-info-autoloads epl-autoloads lsp-ui-autoloads lsp-mode-autoloads spinner-autoloads markdown-mode-autoloads denote-autoloads imenu-list-autoloads org-superstar-autoloads ox-gfm-autoloads org-pandoc-import-autoloads gnuplot-autoloads org-download-autoloads async-autoloads org-journal-autoloads vulpea-autoloads org-roam-autoloads emacsql-autoloads orgonomic-autoloads org-drill-autoloads persist-autoloads org-appear-autoloads org-mac-link-autoloads evil-org-autoloads evil-terminal-cursor-changer-autoloads transient-posframe-autoloads better-jumper-autoloads buffer-move-autoloads rotate-autoloads mini-frame-autoloads embark-consult-autoloads embark-autoloads consult-autoloads orderless-autoloads cape-autoloads corfu-prescient-autoloads corfu-autoloads vertico-prescient-autoloads vertico-autoloads prescient-autoloads tabspaces-autoloads which-key-posframe-autoloads which-key-autoloads popup-mode-autoloads hide-mode-line-autoloads evil-anzu-autoloads anzu-autoloads titlecase-autoloads wgrep-autoloads yasnippet-autoloads form-feed-autoloads drag-stuff-autoloads dtrt-indent-autoloads ws-butler-autoloads evil-collection-autoloads annalist-autoloads evil-mc-autoloads evil-numbers-autoloads speeddating-autoloads evil-little-word-autoloads evil-matchit-autoloads evil-nerd-commenter-autoloads evil-visualstar-autoloads evil-surround-autoloads vundo-autoloads undo-fu-session-autoloads ztree-autoloads dwim-shell-command-autoloads treemacs-tab-bar-autoloads treemacs-magit-autoloads magit-autoloads git-commit-autoloads magit-section-autoloads with-editor-autoloads treemacs-evil-autoloads evil-autoloads goto-chg-autoloads treemacs-autoloads ace-window-autoloads avy-autoloads pfuture-autoloads ht-autoloads cfrs-autoloads all-the-icons-autoloads rainbow-mode-autoloads posframe-autoloads ns-auto-titlebar-autoloads nano-modeline-autoloads nano-theme-autoloads memoize-autoloads envrc-autoloads inheritenv-autoloads helpful-autoloads f-autoloads elisp-refs-autoloads s-autoloads dired-subtree-autoloads dired-hacks-utils-autoloads dash-autoloads server pcase hydra lv url-parse auth-source eieio eieio-core password-cache json map url-vars edmacro kmacro byte-opt compdef derived leader-key bind-map no-littering compat compdef-autoloads hydra-autoloads lv-autoloads leader-key-autoloads bind-map-autoloads no-littering-autoloads compat-autoloads elpaca-use-package use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core elpaca-use-package-autoloads compile text-property-search comint ansi-osc ansi-color ring time-date comp-run cl-macs elpaca elpaca-process elpaca-autoloads comp cl-seq comp-cstr comp-common warnings subr-x rx gv bytecomp byte-compile cl-extra help-mode icons cl-loaddefs cl-lib display-line-numbers rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 1603207 1724654) (symbols 48 73841 1671) (strings 32 543300 273395) (string-bytes 1 15331101) (vectors 16 236430) (vector-slots 8 3553218 678973) (floats 8 1870 4220) (intervals 56 4454 1235) (buffers 992 19)) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 28 10:13:17 2023 Received: (at 68083) by debbugs.gnu.org; 28 Dec 2023 15:13:17 +0000 Received: from localhost ([127.0.0.1]:40177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIs4T-0005Aj-3X for submit@debbugs.gnu.org; Thu, 28 Dec 2023 10:13:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIs4Q-0005AV-ME for 68083@debbugs.gnu.org; Thu, 28 Dec 2023 10:13:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIs4M-00027Y-0H; Thu, 28 Dec 2023 10:13:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=a6RqL+3sqonZi6nVAGai2M4KkYWH0Nw3rH+hepYNMjE=; b=oz19ltXuRKgg QKvrGhXu7aui1+2e4T/XO1rBMA6VxwkxlUB1mKcwyTJiHyjPJhn4ruKgFD3On48TlI5EG6/wQ15Ue bfb76nA7YA16LtX/pujfxUoaurCtzZEaaxqDrMPMCJR9xgYdw0rOb1gEUoYQnjFB7D6nkoZua9UvL bR41tkKJ+zPYTjNeRXZyvYWvtfROXLVnqAx/mVDU9b15LAS7rH+y1tXfk4gZ5s7Ia7yfe5dmgB5ML Ei5kzx1FBtEJxCGhU7sAnLDYem1+QQMYuVJUkRbyVXsDO6nCoYpcq8gQ0YDyjW5O6ilOd7ye51L7n 8pnj5sP6+5fxUc8E/5YGHw==; Date: Thu, 28 Dec 2023 17:12:55 +0200 Message-Id: <83le9e743s.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen , Andrea Corallo In-Reply-To: (message from Aaron Jensen on Thu, 28 Dec 2023 09:05:25 -0500) Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > Date: Thu, 28 Dec 2023 09:05:25 -0500 > > > On macOS, I am often getting this when building Emacs from scratch. Could this be a race condition with a parallel build? > > I bisected and the problematic commit is: e670412a3e101e70dc26e021f467faece8cb7f6b > > In toplevel form: > org/org-element.el:64:2: Error: Eager macro-expansion failure: (native-compiler-error (lambda (arg322 &optional arg323) (let ((f #'macroexpand)) (funcall f arg322 arg323))) "Compiling /private/var/tmp/emacs-plusA30-20231227- > 10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln... > File already exists: /private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln > > Error: file-already-exists (\"File already exists\" \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > mapbacktrace(#f(compiled-function (evald func args flags) #)) > debug-early-backtrace() > debug-early(error (file-already-exists \"File already exists\" \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln > \")) > rename-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\" \"/private/var/tmp/emacs-plusA30-20231 > 227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > comp-delete-or-replace-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\" \"/private/var/tmp/emacs-plusA30 > -20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\") > comp--compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > comp-compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > comp-final1() > load-with-code-conversion(\"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\" \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.e > l\" nil t) > command-line-1((\"-l\" \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\")) > command-line() > normal-top-level() > ") > gmake[3]: *** [Makefile:330: org/org-element.elc] Error 1 Thanks. Adding Andrea to the discussion. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 13:44:00 2023 Received: (at 68083) by debbugs.gnu.org; 29 Dec 2023 18:44:00 +0000 Received: from localhost ([127.0.0.1]:42219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJHpw-0007LB-3y for submit@debbugs.gnu.org; Fri, 29 Dec 2023 13:44:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJHpu-0007Kz-2n for 68083@debbugs.gnu.org; Fri, 29 Dec 2023 13:43:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJHpo-0003Lv-OQ; Fri, 29 Dec 2023 13:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=97FIFvwYEnvNsFZ0gYJffRcI0KiazRP2X7DgnmMU5o4=; b=nAsZORLF0Z30hQpjAblb ch3acL9BldFPEovC1rPL4s/BqiQE20cYeVa6b0N/lD+ticmPCvj9o1SjJKC3M7elv0lRwUr8+rRf2 XXvaagjRUH1uRjZdmKMgA1o3ATIqUDCEyCwTN+qoP09zmUwCtYfVM56KpGDNNzisd/guDGiG1TIJI 2Zi4RMRdTtXvKSgmy8r27atWUBtz4sbrqDG0luJtJN0WS4oNSBPQwVRUQZlZxO58Y4zBkFrTYXnoj /bwQ4VnVJZci/bD3OemIUpMxBR5TCsdSY+DCz0C54PRxwc5CqQPH5z1IQR80l23oJU9NzaeQLLhAw mNN1fUk1WScTqw==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rJHpn-00032l-UY; Fri, 29 Dec 2023 13:43:52 -0500 From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation In-Reply-To: <83le9e743s.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Dec 2023 17:12:55 +0200") References: <83le9e743s.fsf@gnu.org> Date: Fri, 29 Dec 2023 13:43:51 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, Aaron Jensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Aaron Jensen >> Date: Thu, 28 Dec 2023 09:05:25 -0500 >> >> >> On macOS, I am often getting this when building Emacs from scratch. Could this be a race condition with a parallel build? >> >> I bisected and the problematic commit is: e670412a3e101e70dc26e021f467faece8cb7f6b >> >> In toplevel form: >> org/org-element.el:64:2: Error: Eager macro-expansion failure: >> (native-compiler-error (lambda (arg322 &optional arg323) (let ((f >> #'macroexpand)) (funcall f arg322 arg323))) "Compiling >> /private/var/tmp/emacs-plusA30-20231227- >> 10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln... >> File already exists: >> /private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln >> >> Error: file-already-exists (\"File already exists\" >> \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") >> mapbacktrace(#f(compiled-function (evald func args flags) #)) >> debug-early-backtrace() >> debug-early(error (file-already-exists \"File already exists\" >> \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln >> \")) >> rename-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\" >> \"/private/var/tmp/emacs-plusA30-20231 >> 227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") >> comp-delete-or-replace-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\" >> \"/private/var/tmp/emacs-plusA30 >> -20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\") >> comp--compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") >> comp-compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") >> comp-final1() >> load-with-code-conversion(\"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\" >> \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.e >> l\" nil t) >> command-line-1((\"-l\" \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\")) >> command-line() >> normal-top-level() >> ") >> gmake[3]: *** [Makefile:330: org/org-element.elc] Error 1 > > Thanks. Adding Andrea to the discussion. Hi all, reading from emacs-devel... is it still confirmed that the commit that introduced this is e670412a3e101e70dc26e021f467faece8cb7f6b? Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 14:10:00 2023 Received: (at 68083) by debbugs.gnu.org; 29 Dec 2023 19:10:00 +0000 Received: from localhost ([127.0.0.1]:42240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJIF5-0004pU-KY for submit@debbugs.gnu.org; Fri, 29 Dec 2023 14:10:00 -0500 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:60798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJIF3-0004pD-Em for 68083@debbugs.gnu.org; Fri, 29 Dec 2023 14:09:58 -0500 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2ccbded5aa4so45900631fa.1 for <68083@debbugs.gnu.org>; Fri, 29 Dec 2023 11:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703876991; x=1704481791; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KwbMqBRjEXWkVdTPJR9HrR3TLApSAlTnhywuok8jrQg=; b=MGjHu73/KkN63A9+DE8Bw9G76gVh+734HrU71ePdzniGgS7rWzve7SIsyC+HfpcpVy Gpx+KthbbMihYSAjfZZ904x4PcCR8w9uw2QBMT3TApHq7WravTNT8JysSWcCIJuP5OoO aq+bH4qQ1fLSi0zRnkcO5Ouphoi4PtZbc5JJAP/FUyz40nNow32He4/zvwwZEdcF3p9h m9glaq0xMDNoFuY6WmM1JwG6+238QIJVZndLtjW13dA+YGC/c7OIMRDR4DUUhy2aq5ps g2ZrcArI1OK9XKfewE5BxuASdUJvNi/lbWdvPwy3vYQokkRldqcqfyjLneAu5DYNnQwH 7J6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703876991; x=1704481791; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KwbMqBRjEXWkVdTPJR9HrR3TLApSAlTnhywuok8jrQg=; b=XHA0GI0+5y1kQeF3OE7dPzjxfwQjQnoTDPU1r4qa8C/hyE8/GtfaG73ybvlpcgzhV7 E0DkcqU4u9Is++WdKp+4r9Nj/tUH36ylKlHtlND8CQnVv3hJjY2fczHE6nvnrM/nKiPx eqo5bPAo26GmFYLkcICFbL8Ui0IHO0L5O8k50ZRK6qXrqx+U/7muwhv6VzkyIfpnxG1r aiqjjzf6GnrSs3F+NWb75oE2Anpip5JIwLBE0nhAMA+ngFUREDfZu08Jdr7BONixk2Ao HPXKnmfQH2y1mGGrF4s+iiTzfc1rNC1bljB7swmCqbRedrd9zQozgSjFuLOi5XL3oc9l SwSg== X-Gm-Message-State: AOJu0YwvkZOjEWQBA05e5VOTzqgnxE7CbDukCFXB6b46O7B1zenrut6A 2Ffs7AQN2xLo5hXjCl5SW7ylgJ+O3uIVIM4HI3k= X-Google-Smtp-Source: AGHT+IEQJYQmAUvMTHviJ/R9PnmaU+yxDWbAuWvwVmKzquYIz0x/MEls6+I9He3+Wax0gzlui2dnABY8UqTbXDmVH9k= X-Received: by 2002:a2e:320c:0:b0:2cc:87d7:a8e7 with SMTP id y12-20020a2e320c000000b002cc87d7a8e7mr5717955ljy.102.1703876991277; Fri, 29 Dec 2023 11:09:51 -0800 (PST) Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Fri, 29 Dec 2023 14:09:50 -0500 Mime-Version: 1.0 X-Superhuman-ID: lqr0crsm.4c652dcc-49e9-4795-84ed-701d8d1dfd16 From: Aaron Jensen X-Mailer: Superhuman Desktop (2023-12-22T20:06:10Z) X-Superhuman-Draft-ID: draft008b29ac35f306df In-Reply-To: References: <83le9e743s.fsf@gnu.org> Date: Fri, 29 Dec 2023 14:09:50 -0500 Message-ID: Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Andrea Corallo Content-Type: multipart/alternative; boundary="000000000000ce5e21060daac6d9" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68083 Cc: Eli Zaretskii , 68083@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ce5e21060daac6d9 Content-Type: text/plain; charset="UTF-8" Yes, that's what I've found. I can also confirm that compiling with 1 thread works around it. It's only a problem w/ gmake -jN where N is > 1 (I run w/ 8 or 12 or so typically). Aaron On Fri, Dec 29, 2023 at 1:43 PM, Andrea Corallo wrote: > Eli Zaretskii writes: > > From: Aaron Jensen > Date: Thu, 28 Dec 2023 09:05:25 -0500 > > On macOS, I am often getting this when building Emacs from scratch. Could > this be a race condition with a parallel build? > > I bisected and the problematic commit is: > e670412a3e101e70dc26e021f467faece8cb7f6b > > In toplevel form: > org/org-element.el:64:2: Error: Eager macro-expansion failure: > (native-compiler-error (lambda (arg322 &optional arg323) (let ((f > #'macroexpand)) (funcall f arg322 arg323))) "Compiling > /private/var/tmp/emacs-plusA30-20231227- > 10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln... > File already exists: > /private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln > > > Error: file-already-exists (\"File already exists\" > \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > mapbacktrace(#f(compiled-function (evald func args flags) # -0x1fcb3a734512f81>)) debug-early-backtrace() > debug-early(error (file-already-exists \"File already exists\" > \"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln > > \")) > rename-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\" > > \"/private/var/tmp/emacs-plusA30-20231 > 227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > comp-delete-or-replace-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\" > > \"/private/var/tmp/emacs-plusA30 > -20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\") > comp--compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > comp-compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln\") > comp-final1() > load-with-code-conversion(\"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\" > > \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.e > l\" nil t) > command-line-1((\"-l\" > \"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\")) > command-line() > normal-top-level() > ") > gmake[3]: *** [Makefile:330: org/org-element.elc] Error 1 > > Thanks. Adding Andrea to the discussion. > > Hi all, > > reading from emacs-devel... is it still confirmed that the commit that > introduced this is e670412a3e101e70dc26e021f467faece8cb7f6b? > > Thanks > > Andrea > --000000000000ce5e21060daac6d9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, that's wha= t I've found. I can also confirm that compiling with 1 thread works aro= und it. It's only a problem w/ gmake=C2=A0-jN where N is > 1 (I run = w/ 8 or 12 or so typically).


Aaron


On Fri, Dec 29, 2023 at 1:43 PM, Andrea Corallo <acorallo@gnu.o= rg> wrote:

Eli Zaretskii <eliz@gnu.org> writes:

From: Aaron Jensen <aaronje= nsen@gmail.com>
Date: Thu, 28 Dec 20= 23 09:05:25 -0500

On macOS, I am often getting this when building Emacs from scratch. Could t= his be a race condition with a parallel build?

I bisected and the problematic commit is: e670412a3e101e70dc26e021f467faece= 8cb7f6b

In toplevel form:
org/org-element.el:64:2: Error: Eager macro-expansion failure:
(native-compiler-error (lambda (arg322 &optional arg323) (let ((f
#'macroexpand)) (funcall f arg322 arg323))) "Compiling
/private/var/tmp/emacs-plusA30-20231227-
10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampolin= e-6d6163726f657870616e64_macroexpand_0.eln... File already exists:
/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/el= n-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpan= d_0.eln

Error: file-already-exists (\"File already exists\"
\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.ema= cs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_mac= roexpand_0.eln\") mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0x= 1fcb3a734512f81>)) debug-early-backtrace()
debug-early(error (file-already-exists \"File already exists\"
\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.ema= cs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_mac= roexpand_0.eln
\"))
rename-file(\"/private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.br= ew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f6578= 70616e64_macroexpand_08i0tl8.eln.tmp\"
\"/private/var/tmp/emacs-plusA30-20231
227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--tramp= oline-6d6163726f657870616e64_macroexpand_0.eln\") comp-delete-or-replace-file(\"/private/var/tmp/emacs-plusA30-20231227-= 10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampolin= e-6d6163726f657870616e64_macroexpand_0.eln\"
\"/private/var/tmp/emacs-plusA30
-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr-= -trampoline-6d6163726f657870616e64_macroexpand_08i0tl8.eln.tmp\") comp--compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-1= 0652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline= -6d6163726f657870616e64_macroexpand_0.eln\") comp-compile-ctxt-to-file(\"/private/var/tmp/emacs-plusA30-20231227-10= 652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-= 6d6163726f657870616e64_macroexpand_0.eln\") comp-final1()
load-with-code-conversion(\"/private/var/tmp/emacs-int-comp-subr--tram= poline-6d6163726f657870616e64_macroexpand_0-haajZW.el\"
\"/private/var/tmp/emacs-int-comp-subr--trampoline-6d6163726f657870616= e64_macroexpand_0-haajZW.e l\" nil t)
command-line-1((\"-l\" \"/private/var/tmp/emacs-int-comp-sub= r--trampoline-6d6163726f657870616e64_macroexpand_0-haajZW.el\")) command-line()
normal-top-level()
")
gmake[3]: *** [Makefile:330: org/org-element.elc] Error 1

Thanks. Adding Andrea to the discussion.

Hi all,

reading from emacs-devel... is it still confirmed that the commit that introduced this is e670412a3e101e70dc26e021f467faece8cb7f6b?

Thanks

Andrea


--000000000000ce5e21060daac6d9-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 15:17:13 2023 Received: (at 68083) by debbugs.gnu.org; 29 Dec 2023 20:17:14 +0000 Received: from localhost ([127.0.0.1]:42319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJI9-0002wN-K8 for submit@debbugs.gnu.org; Fri, 29 Dec 2023 15:17:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJI8-0002wB-6P for 68083@debbugs.gnu.org; Fri, 29 Dec 2023 15:17:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJJI1-0006eZ-UR; Fri, 29 Dec 2023 15:17:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=BgHkSM8WxCX4hfjoXDrxq8ZnldzJLv7OnvW+XcGJtqo=; b=hrHZgd02CaJToQlA+CCy YXiyr4IBl3pn88oWKktrjDYuafVLelyQef3dfF9OV2WhETgdYh79vzXUF8a8TSd6Rmwllc7tA/T1o NxdnpiqwJAGIOTvxHu65uPuIWoN+egBjHzHKaQ4yha2djCKA5bqxKbokiRC7nB0Kr7piHxl2v2A9j oAPaw8MXRJwU9a3XfJ9ccTG6zVoA104vQp7lJFFVqGvhLli0ORgukajC2SVu9+tly6z3jid8ReJrf 1HXQ8ZU1193d25wVoRHDiW//g4sKKUYOxNnkrojhSK0dSWTtHxtl9Xi8ir+i2Jz8Kds5QV1GT5B3q FrBJQSv7VcwcMQ==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rJJI1-0004Ls-Gi; Fri, 29 Dec 2023 15:17:05 -0500 From: Andrea Corallo To: Aaron Jensen Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation In-Reply-To: (Aaron Jensen's message of "Fri, 29 Dec 2023 14:09:50 -0500") References: <83le9e743s.fsf@gnu.org> Date: Fri, 29 Dec 2023 15:17:05 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: Eli Zaretskii , Jens Schmidt , 68083@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Aaron Jensen writes: > Yes, that's what I've found. I can also confirm that compiling with 1 thread works around it. It's only a problem w/ > gmake -jN where N is > 1 (I run w/ 8 or 12 or so typically). > > Aaron Intresting, adding Jens, hopefully he has some good idea. Maybe you could re-add 'macroexpand' and 'rename-buffer' to 'native-comp-never-optimize-functions' and discover which one of the two is triggering the bug? Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 15:27:08 2023 Received: (at 68083) by debbugs.gnu.org; 29 Dec 2023 20:27:08 +0000 Received: from localhost ([127.0.0.1]:42329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJRk-0003Bc-4H for submit@debbugs.gnu.org; Fri, 29 Dec 2023 15:27:08 -0500 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:56618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJRi-0003B6-19 for 68083@debbugs.gnu.org; Fri, 29 Dec 2023 15:27:06 -0500 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2ccf55bed13so1013341fa.1 for <68083@debbugs.gnu.org>; Fri, 29 Dec 2023 12:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703881620; x=1704486420; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bYACePUmCXXhF1K2vcovHZuhPglo/SOViFWiETl9gNw=; b=ESkx9vvwGqPMZ3AQkgxNjNMQXOPxdUvjNqgF7xNIvJISxfoz2Q4+uQ72w9R/yt4UCC xsn43nAkSesq4TtI0CcvgUE5QzW8XBKN8RZHQT7IcvpLc7EyzlH+wJBhV+i3/tzHJZk7 0tOt0iJF/xBkMf12TohDnxnN8zYHdcDEdIg/2RY1BJcKhGXkbnMP4eRtU/vT3/bpfFG7 zC0DcEblkAXLVLyNQBEzlXjvcPg2iXx2VgrpkIcBOj4sOr3iwa+LnxFAg1YXeNOma9pM uGdrSeqOrBWwZUN87M2ickbN3CKP9LzT+RbXiLa3HzBM9o2L9DcYT9WcAlsdMUqf6Jik EoQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703881620; x=1704486420; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bYACePUmCXXhF1K2vcovHZuhPglo/SOViFWiETl9gNw=; b=rL4xE5SuGG6DFifQLJtiZdrUwrIZ0Yg1yLqNIIeycOktELd77U1i3pRLHVWtcwINPw fKMG6mQY5QJPsRbPt6+bQRjt6LQeIHO5E6BnSaEj5swpOlz2On825NAZNHSAgYRN/WZZ argj1AT6HcjXew3QoEVerlpMYE8RLsxCRZ8kz/qCuOd9OygS2FdOOooUsG6FSOnGqrfJ p7bU8kca8K7bHzL5dhRyMfx0R/fK2qvUqGIbs032WHsdEO4+xX7TeitEoZ5zg/VvkWBH JV/rbCTc3ekXkT+K6QIUQ8lanmqzUnvertb3/5YDdjKdTorwRi+H8uIhW3jzFTnaA2Jz 2DqA== X-Gm-Message-State: AOJu0YzCKtmDBpyp+/mpc9DeRyvsGN4qLNlkigWLraST4rvmPW9ATIUl qUDj3SiKcqWOcD9JXtYNNsG+Ar40TYQv5SaxUvc= X-Google-Smtp-Source: AGHT+IE4OHb7IsRdrQbJmCX9kCKqwQm6YcS+86zl9UAmTfazPDNfMwgJgVvN3eDQrF2RdUNgqui4u17i5OipNaM41yQ= X-Received: by 2002:a2e:818e:0:b0:2cc:854b:556e with SMTP id e14-20020a2e818e000000b002cc854b556emr5064230ljg.70.1703881619600; Fri, 29 Dec 2023 12:26:59 -0800 (PST) Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Fri, 29 Dec 2023 15:26:58 -0500 Mime-Version: 1.0 X-Superhuman-Draft-ID: draft00c40bc2a28b52d4 In-Reply-To: From: Aaron Jensen X-Mailer: Superhuman Desktop (2023-12-22T20:06:10Z) X-Superhuman-ID: lqr33zh1.8d599a65-d7c3-46b8-b3c7-9eb501fac961 References: <83le9e743s.fsf@gnu.org> Date: Fri, 29 Dec 2023 15:26:58 -0500 Message-ID: Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Andrea Corallo Content-Type: multipart/alternative; boundary="000000000000acf884060dabda77" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68083 Cc: Eli Zaretskii , Jens Schmidt , 68083@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000acf884060dabda77 Content-Type: text/plain; charset="UTF-8" On Fri, Dec 29, 2023 at 3:17 PM, Andrea Corallo wrote: > Aaron Jensen writes: > > Yes, that's what I've found. I can also confirm that compiling with 1 > thread works around it. It's only a problem w/ gmake -jN where N is > 1 (I > run w/ 8 or 12 or so typically). > > Aaron > > Intresting, adding Jens, hopefully he has some good idea. > > Maybe you could re-add 'macroexpand' and 'rename-buffer' to > 'native-comp-never-optimize-functions' and discover which one of the two > is triggering the bug? > I can't try it just now, but my trace includes: `File already exists: /private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln` so I'm guessing it's macroexpand. Aaron --000000000000acf884060dabda77 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On= Fri, Dec 29, 2023 at 3:17 PM, Andrea Corallo <acorallo@gnu.org> wrote:
=
<= div class=3D"gmail_extra">

Aaron Je= nsen <aaronjensen@gmail.com> wri= tes:

Yes, that's what I've found. I can also confirm that compiling with= 1 thread works around it. It's only a problem w/ gmake -jN where N is > 1 (I run w/ 8 or 12 or so typically).

Aaron

Intresting, adding Jens, hopefully he has some good idea.

Maybe you could re-add 'macroexpand' and 'rename-buffer' to
'native-comp-never-optimize-functions' and discover which one of th= e two is triggering the bug?

=


I can't try it just now, but my trace includes:=C2=A0`File already exists:= /private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/e= ln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpa= nd_0.eln` so I'm guessing it's m= acroexpand.=C2=A0

Aar= on

--000000000000acf884060dabda77-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 29 16:07:47 2023 Received: (at 68083) by debbugs.gnu.org; 29 Dec 2023 21:07:47 +0000 Received: from localhost ([127.0.0.1]:42370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJK55-0003b8-E6 for submit@debbugs.gnu.org; Fri, 29 Dec 2023 16:07:47 -0500 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:58786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJK53-0003av-DW for 68083@debbugs.gnu.org; Fri, 29 Dec 2023 16:07:46 -0500 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2cce6bb9b48so18253341fa.1 for <68083@debbugs.gnu.org>; Fri, 29 Dec 2023 13:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703884059; x=1704488859; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0kpV9E6+LV22H0so31igfrZFXTNJVWJiUl1UeEp7suU=; b=g2SLunVIRfl5n5JWNomULGxixTnEpWrBJgFrdJvA45YlEBQLUWM3nMnyWIfBU67OQv LkIgBShgQWwoOFdtaFjlbLC3krZBQhm63x9TkhMRbK7bdTbdDuDddGM0HBhdWDKRXrdL iv3tlmbs2ZzVRzIkZWmLWtS5vqtnvC6BKbcM4O9l3BfYLrQLuvcRWGNb35ilio7nuzg4 QmJ2KpfPq4KSXT+I1HVo5Qvtxfbld81U0HarZ5kUvghhvIgYbGUxZJSf/6qENXjwL1IZ swlNyfd9MQVx1KOZtu+UdKUyK84f6cMrnCVzkdnGK4JGx9NbtJMp/izk6ySY/3HdNHyj LVuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703884059; x=1704488859; h=cc:to:subject:message-id:date:references:in-reply-to:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0kpV9E6+LV22H0so31igfrZFXTNJVWJiUl1UeEp7suU=; b=Z1mS/PcVmywVed+Nv2KMGvcCNl4u0gSCgPVLCisHhZOyOoB4csRypadTwT8XME37Nb ON5UbRMtzcsHy9CZcuVQyqYCPytfqK6gu0xxN9OAYv12Hio/nEaVbAhuut9nJfCduVJj Q9ZTUxs1tGPP9QNtEaSKuez8bnH7T6YRzwOiY8k3+GVW+pk4TtCCaX3XCMLx+xBO4/dL MhhE1TjuruinK5d4GPspUvaDXTO/+wUp4BYdNuNyGjMRlZ6BKEqPLZntNfGdCVl9hK1L BZ5STIMUPK7OEIa56qh/Slb1THSFV5BrKMPPA9Sm+diJnVSSS65gD/pcQy67AK1Sas+2 t5oQ== X-Gm-Message-State: AOJu0Yx4ayTtuSUsSKFxND2ui+rA0H1kh7bqdZESJG6A49/Fl2QLzx1+ KswppV+Csoivqch+GjrsmNspqUxpan4jDSkJxl4= X-Google-Smtp-Source: AGHT+IF1/2APHCcPm4cT7mrbhR4m7Xb+V4N2zi8+9f7Qcba322z9LXcB5gLcOzFogOx1QB3KsFsUclMBPKlSRXmCCE4= X-Received: by 2002:a2e:980d:0:b0:2cc:77fd:6f8 with SMTP id a13-20020a2e980d000000b002cc77fd06f8mr2927698ljj.64.1703884059156; Fri, 29 Dec 2023 13:07:39 -0800 (PST) Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Fri, 29 Dec 2023 16:07:38 -0500 Mime-Version: 1.0 From: Aaron Jensen X-Superhuman-ID: lqr4k9lw.ea6fede2-c71c-42d6-97f0-d3836b53dba6 In-Reply-To: References: <83le9e743s.fsf@gnu.org> X-Mailer: Superhuman Desktop (2023-12-22T20:06:10Z) X-Superhuman-Draft-ID: draft00d678f4ec37659a Date: Fri, 29 Dec 2023 16:07:38 -0500 Message-ID: Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Andrea Corallo Content-Type: multipart/alternative; boundary="00000000000015a581060dac6cd4" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68083 Cc: Eli Zaretskii , Jens Schmidt , 68083@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000015a581060dac6cd4 Content-Type: text/plain; charset="UTF-8" Just to confirm, adding macroexpand to native-comp-never-optimize-functions allows me to build successfully. It also looks like comp-delete-or-replace-file can be updated to protect rename-file against file-already-exists like it does for Windows. That would also likely solve the problem if you want to be able to optimize macroexpand. Aaron On Fri, Dec 29, 2023 at 3:26 PM, Aaron Jensen wrote: > On Fri, Dec 29, 2023 at 3:17 PM, Andrea Corallo wrote: > > Aaron Jensen writes: > > Yes, that's what I've found. I can also confirm that compiling with 1 > thread works around it. It's only a problem w/ gmake -jN where N is > 1 (I > run w/ 8 or 12 or so typically). > > Aaron > > Intresting, adding Jens, hopefully he has some good idea. > > Maybe you could re-add 'macroexpand' and 'rename-buffer' to > 'native-comp-never-optimize-functions' and discover which one of the two > is triggering the bug? > > > > I can't try it just now, but my trace includes: `File already exists: > /private/var/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln` > so I'm guessing it's macroexpand. > > Aaron > --00000000000015a581060dac6cd4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Just to confirm, ad= ding macroexpand=C2=A0to native-comp-never-optimize-functions allows me to = build successfully.

It also looks like comp-delete-or-replace-file can = be updated to protect rename-file against file-already-exists like it does = for Windows. That would also likely solve the problem if you=C2=A0want to b= e able to optimize macroexpand.

<= div class=3D"">


Aaron


O= n Fri, Dec 29, 2023 at 3:26 PM, Aaron Jensen <aaronjensen@gmail.com> wrote:
On Fri, De= c 29, 2023 at 3:17 PM, Andrea Corallo <acorallo@= gnu.org> wrote:

Aaron Jensen <aaronjensen@gmail.com> writes:

Yes, that's what I've found. I can also confirm that compiling with= 1 thread works around it. It's only a problem w/ gmake -jN where N is > 1 (I run w/ 8 or 12 or so typically).

Aaron

Intresting, adding Jens, hopefully he has some good idea.

Maybe you could re-add 'macroexpand' and 'rename-buffer' to
'native-comp-never-optimize-functions' and discover which one of th= e two is triggering the bug?

=


I can't try it just now, but my trace include= s:=C2=A0`File already exists: /private/va= r/tmp/emacs-plusA30-20231227-10652-1cz0rs/.brew_home/.emacs.d/eln-cache/30.= 0.50-69afc345/subr--trampoline-6d6163726f657870616e64_macroexpand_0.eln` so I'm guessing= it's macroexpand.=C2=A0

Aaron

--00000000000015a581060dac6cd4-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 01:48:02 2023 Received: (at 68083) by debbugs.gnu.org; 30 Dec 2023 06:48:02 +0000 Received: from localhost ([127.0.0.1]:42897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJT8c-0002US-3o for submit@debbugs.gnu.org; Sat, 30 Dec 2023 01:48:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJT8Z-0002TW-Tb for 68083@debbugs.gnu.org; Sat, 30 Dec 2023 01:48:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJT8S-00012b-UB; Sat, 30 Dec 2023 01:47:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fU67e99qmxgtiT9hc7XhWXwf6H+XmgkqGYmqK/Wy6+U=; b=LyYhs5wcNlX/ nD0C+K3W/Ao5lm8HGY8fwmwiHe7X8XFmV1Auw73gZk7YH9yA+fv+OIqXQHMuosZRIAJJsz+R/zlHM UI8oS9PEa3JF6YsTjm4RlSGKYGHIi+xjdTUaeFQZtitDlwnmPH/O86f1LJycpHumKBLk3GfO0bl/C qlMd0htD/2KuGjhyJE0lKrsddjizidDedmZcu+6q0t/3rTCsho1kVXs88o8b8ZBctZnIdv6TRlWQ3 Uqsaj2lua5D2NMXCQ4QOq5AuhOsWdoUmt6PLgdHHVQ07hC6aXUC9R1WhtuKnhDTUbOe7FXhC/n0tV 6QacLJG9ZTBfhm5JJS7uLA==; Date: Sat, 30 Dec 2023 08:47:43 +0200 Message-Id: <835y0g5gq8.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Fri, 29 Dec 2023 16:07:38 -0500) Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation References: <83le9e743s.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > Date: Fri, 29 Dec 2023 16:07:38 -0500 > Cc: Eli Zaretskii , 68083@debbugs.gnu.org, > Jens Schmidt > > Just to confirm, adding macroexpand to native-comp-never-optimize-functions allows me to build > successfully. > > It also looks like comp-delete-or-replace-file can be updated to protect rename-file against > file-already-exists like it does for Windows. That would also likely solve the problem if you want to be > able to optimize macroexpand. Are you sure? We do that on Windows because Windows doesn't allow us to delete a file that is open by another program. That shouldn't happen on Posix systems, so I think what you see here is due to a race between checking whether a file exists and renaming it, which is a different problem. However, feel free to try the same trick we use on Windows and see whether it helps. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 10:29:37 2023 Received: (at 68083) by debbugs.gnu.org; 30 Dec 2023 15:29:37 +0000 Received: from localhost ([127.0.0.1]:44899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJbHM-0004Bz-MF for submit@debbugs.gnu.org; Sat, 30 Dec 2023 10:29:37 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:50439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJbHK-0004Bm-Si for 68083@debbugs.gnu.org; Sat, 30 Dec 2023 10:29:35 -0500 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2ccc5fca3f6so48831141fa.1 for <68083@debbugs.gnu.org>; Sat, 30 Dec 2023 07:29:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703950168; x=1704554968; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dIxorhneqGxW+51nD1awVs+UPLk+2sIOGMWoRLrsJ88=; b=FaxghB1BSwH7uYzUi9EMIbLKMo605a1FhXPNpCtWXY3O/dtU+v9NPawcpH4pxz2RNc w87OA+jKA+XGwwVI4okowI4JFK9u6UG3Dv85Wmhtv20CMDCM98FNNYGqwq2u7wMAYrJt Q9VpwHSlQgtVT4stgIaW+m2h13f4hKX8BecXG80DvANhzjdp7Fhsnu9DgEz0IKns4tc6 KPqbsbK0BEQSbnpKeBTfSD8FyLk/o49VAsxtxrkCwGo/yn0WCyBDjroITjJHqBfTQBEy KoVPkcRhQkzFSXFf2MWntYxqLergsHHAp39mCsE+MagsIfrjmk/h31KmnxRRIUmsbKuB GGHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703950168; x=1704554968; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dIxorhneqGxW+51nD1awVs+UPLk+2sIOGMWoRLrsJ88=; b=RYNpBI+o4rm875+ergEEC63OKJrKvryMYHzBjPTo1NCdnsLOldA6g0W4KwHERcGgaW v4rGBJkaGFl/MD12dgnnuvbd+AOBr2XGfCT3ONmOqYrMZiTHnTcdOzp23RFFo59ohrfW DBnqUHNZo5IvLGTsLb4NkDH1eWP3Lqzdcby1po7Mtx0BjMGPB1GgvZBw6k6KnEKBbQqe 7ADf5734dppPraBBC34KUwo5DaslEPZ5ELzqVGkbOkRYGGdNIePNaBm7eDeJs0CiiqO7 VPTE+BI8qSvMzr1hHl8vy2e7P7qbO6aYZkblrVa3yiFWPqPfEFIaKH1ZjhQipUKwtBOM yxmQ== X-Gm-Message-State: AOJu0YyeWY79m0w/+Rjvge9u3qC56/0/rqwDUp4npzaZ2ngKP7tnluuX RHNojMk4V5fielK1hBAQIjOFzVihzCpWLmOZqnY= X-Google-Smtp-Source: AGHT+IGRPy/3neoKJXcDGsJb032n/QkS101skt81BvX5mOTnAqJLPqpRdfrS6yAo7GnMDtNFBeRc9tegbDHGmli715A= X-Received: by 2002:a05:651c:2c3:b0:2cc:6c35:71fc with SMTP id f3-20020a05651c02c300b002cc6c3571fcmr4726249ljo.11.1703950167897; Sat, 30 Dec 2023 07:29:27 -0800 (PST) MIME-Version: 1.0 References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> In-Reply-To: <835y0g5gq8.fsf@gnu.org> From: Aaron Jensen Date: Sat, 30 Dec 2023 10:29:16 -0500 Message-ID: Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Dec 30, 2023 at 1:47=E2=80=AFAM Eli Zaretskii wrote: > > > From: Aaron Jensen > > Date: Fri, 29 Dec 2023 16:07:38 -0500 > > Cc: Eli Zaretskii , 68083@debbugs.gnu.org, > > Jens Schmidt > > > > Just to confirm, adding macroexpand to native-comp-never-optimize-funct= ions allows me to build > > successfully. > > > > It also looks like comp-delete-or-replace-file can be updated to protec= t rename-file against > > file-already-exists like it does for Windows. That would also likely so= lve the problem if you want to be > > able to optimize macroexpand. > > Are you sure? We do that on Windows because Windows doesn't allow us > to delete a file that is open by another program. That shouldn't > happen on Posix systems, so I think what you see here is due to a race > between checking whether a file exists and renaming it, which is a > different problem. > > However, feel free to try the same trick we use on Windows and see > whether it helps. This fixes it for me: diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 3b2fd25e61c..80088f935a4 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -3341,7 +3341,11 @@ comp-delete-or-replace-file ;; is currently loaded. (t (delete-file oldfile) (when newfile - (rename-file newfile oldfile))))) + (condition-case _ + (rename-file newfile oldfile) + (file-already-exists + (delete-file newfile) + t)))))) (defun comp--native-compile (function-or-file &optional with-late-load out= put) "Compile FUNCTION-OR-FILE into native code. I imagine that this is worth doing just to make this operation parallel-safe, but I wonder why macroexpand is the only instance of this happening. I don't know if macroexpand should still be in native-comp-never-optimize-functions or not (i.e., is there another reason it was there other than to avoid this crash?) Aaron From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 12:43:12 2023 Received: (at 68083) by debbugs.gnu.org; 30 Dec 2023 17:43:13 +0000 Received: from localhost ([127.0.0.1]:45010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdMe-0005wX-Hg for submit@debbugs.gnu.org; Sat, 30 Dec 2023 12:43:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdMb-0005wJ-Nu for 68083@debbugs.gnu.org; Sat, 30 Dec 2023 12:43:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJdMU-0001JK-QI; Sat, 30 Dec 2023 12:43:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ugpM5Nrz5TGuuSxxxpiN0ZZ2pbM10hrR1vfD+XwWgjY=; b=ZoJ0ao3cwQ6kmp5PgvDT bw5BVEn259xpv/tGxvDzO4+DtwLyacv+OtXwOImkN9gZ1OyAKeX3E5RnBm1+AKlmYxzbg/bno7xm8 fIgc+E98KS8BtEjmWv0PqhJC3qG+NH9T8R/8Xgj0t4Qsky4AwbMaUf6/bHUYpC7aJKriohdDFq3ml BNzYnjo7PJnV8KqF9X5o7RJJcZlIcKcHQbSDSkEB1q+krTZ/t5axfIajJwt8px/NXvF1yaxa4OlnX z370IK4v0JLV1kmi39aDMjE9rY+cnXcr3lk9CpHNCUnSFko0yzkw/4to0B+52RCntFsazE99wMPi2 /8mAYUBcDdTQqw==; Date: Sat, 30 Dec 2023 19:42:54 +0200 Message-Id: <838r5b4me9.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Sat, 30 Dec 2023 10:29:16 -0500) Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > Date: Sat, 30 Dec 2023 10:29:16 -0500 > Cc: acorallo@gnu.org, 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de > > On Sat, Dec 30, 2023 at 1:47 AM Eli Zaretskii wrote: > > > > Are you sure? We do that on Windows because Windows doesn't allow us > > to delete a file that is open by another program. That shouldn't > > happen on Posix systems, so I think what you see here is due to a race > > between checking whether a file exists and renaming it, which is a > > different problem. > > > > However, feel free to try the same trick we use on Windows and see > > whether it helps. > > This fixes it for me: > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index 3b2fd25e61c..80088f935a4 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -3341,7 +3341,11 @@ comp-delete-or-replace-file > ;; is currently loaded. > (t (delete-file oldfile) > (when newfile > - (rename-file newfile oldfile))))) > + (condition-case _ > + (rename-file newfile oldfile) > + (file-already-exists > + (delete-file newfile) > + t)))))) What happens if, instead of wrapping rename-file in condition-case, you change that to say (t (if newfile (rename-file newfile oldfile) (delete-file oldfile)) > I imagine that this is worth doing just to make this operation > parallel-safe, but I wonder why macroexpand is the only instance of > this happening. I don't know if macroexpand should still be in > native-comp-never-optimize-functions or not (i.e., is there another > reason it was there other than to avoid this crash?) rename-file is supposed to be an atomic operation on Posix filesystems, so I don't quite understand why you see what you see, and I'm hesitant to sweep under the carpet a problem we don't understand. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 13:07:19 2023 Received: (at 68083) by debbugs.gnu.org; 30 Dec 2023 18:07:19 +0000 Received: from localhost ([127.0.0.1]:45029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdjz-0003VK-Ax for submit@debbugs.gnu.org; Sat, 30 Dec 2023 13:07:19 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:49393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJdju-0003Uq-AA for 68083@debbugs.gnu.org; Sat, 30 Dec 2023 13:07:17 -0500 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2cc3f5e7451so84927391fa.2 for <68083@debbugs.gnu.org>; Sat, 30 Dec 2023 10:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703959628; x=1704564428; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wmqj4PVkxfFr4V05MCB72dmB/ufEYBRWyOnPNTJdRgs=; b=Bm0VazxJXACcmdvwe9exYjHU8wGxOh2NTDVh4EpG+oyx0JykzsaO2BFqLqXUw3eKnF BpPJmqI1XdXYSYA8h2KmcYUivw2uSnY3Wf/lnaU8IGKViewxd3rHP93nyV0SJfgyCzj+ 28WhTizeBG386R6bFPkPVEvTEoY5WNrW1EDowDs+e35eiO4fVDDjtlDEmSbSclaiKPm5 yryHcdlZKTJmohCiycTANpsedAH++8tizQ94Kmia8/2NZ9kd8s9FggX7uyAJMqsPEqc4 F96uJtA5Lk1rfQUgs+cjLEKXttj5JPnVbh211p9sbynWy4BjRnuVdiLKRZNZVgaiJJov ubcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703959628; x=1704564428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wmqj4PVkxfFr4V05MCB72dmB/ufEYBRWyOnPNTJdRgs=; b=tdK9xCMtl/QFp4UsQSRirIQ76SMeUdENIhDLlp9LpDMsycBpXGfZ+/1gW58Y+z2YMz Bj/l52vtkoHC03DeD9wuYfi1GdjBPhqhnTfLrn4nSP8yEmTAH3l+bBLYenxDmhfviXlU zlONjUvLzVEQm72lD40aLoQOVwOUnIl/OMh7z8V25RPRrjrgUHqqDeqK90tm2YG8VR1x obV+kPuBnbJIr2iM+yHORpoNpeM0epYuM+9fGPrr8lQLDGVzyPyol9JJglRdjbXkbMBj 3M0AeVEdYsw3/0vYuYObFV7Xq4GsQ7GnDC43jwk04UPCbcETEOpY+pOlte3XnK/CGqXy OM+g== X-Gm-Message-State: AOJu0YxO9kRvFzVGP1G8V+NlZWR46Y1hTYEZJZ6o2P7uIhQwudOUypRI P97eh3m/Xd9HtKsChbGVdIBoiLdnKKmfWLkhgo8= X-Google-Smtp-Source: AGHT+IHvqI/GTRYqSfQ3+DZLekxIzQDVuAm0DnNpV44sBuIHoK0xbSUgGUCbWJ0uBRadBt9LvReA/j/fwSZrByyH2Oc= X-Received: by 2002:a2e:b0cf:0:b0:2cc:8437:1bdc with SMTP id g15-20020a2eb0cf000000b002cc84371bdcmr5532501ljl.47.1703959627377; Sat, 30 Dec 2023 10:07:07 -0800 (PST) MIME-Version: 1.0 References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> <838r5b4me9.fsf@gnu.org> In-Reply-To: <838r5b4me9.fsf@gnu.org> From: Aaron Jensen Date: Sat, 30 Dec 2023 13:06:55 -0500 Message-ID: Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Dec 30, 2023 at 12:43=E2=80=AFPM Eli Zaretskii wrote= : > > > From: Aaron Jensen > > Date: Sat, 30 Dec 2023 10:29:16 -0500 > > Cc: acorallo@gnu.org, 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.= de > > > > On Sat, Dec 30, 2023 at 1:47=E2=80=AFAM Eli Zaretskii wr= ote: > > > > > > Are you sure? We do that on Windows because Windows doesn't allow us > > > to delete a file that is open by another program. That shouldn't > > > happen on Posix systems, so I think what you see here is due to a rac= e > > > between checking whether a file exists and renaming it, which is a > > > different problem. > > > > > > However, feel free to try the same trick we use on Windows and see > > > whether it helps. > > > > This fixes it for me: > > > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > > index 3b2fd25e61c..80088f935a4 100644 > > --- a/lisp/emacs-lisp/comp.el > > +++ b/lisp/emacs-lisp/comp.el > > @@ -3341,7 +3341,11 @@ comp-delete-or-replace-file > > ;; is currently loaded. > > (t (delete-file oldfile) > > (when newfile > > - (rename-file newfile oldfile))))) > > + (condition-case _ > > + (rename-file newfile oldfile) > > + (file-already-exists > > + (delete-file newfile) > > + t)))))) > > What happens if, instead of wrapping rename-file in condition-case, > you change that to say > > (t (if newfile > (rename-file newfile oldfile) > (delete-file oldfile)) I don't really understand this change. The previous version of the code wraps the rename in a (when newfile) and deletes the oldfile right before that. The deletion would always be necessary if the oldfile exists unless OK-IF-ALREADY-EXISTS is specified in rename-file. I tried it anyway for diligence, and I get the exact same behavior (the rename fails because the file exists). > > I imagine that this is worth doing just to make this operation > > parallel-safe, but I wonder why macroexpand is the only instance of > > this happening. I don't know if macroexpand should still be in > > native-comp-never-optimize-functions or not (i.e., is there another > > reason it was there other than to avoid this crash?) > > rename-file is supposed to be an atomic operation on Posix > filesystems, so I don't quite understand why you see what you see, and > I'm hesitant to sweep under the carpet a problem we don't understand. Indeed, but we aren't specifying OK-IF-ALREADY-EXISTS, so if another process does the same compile at the same time (and therefore the same rename), they will conflict. We could specify OK-IF-ALREADY-EXISTS instead and that works as well: diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 3b2fd25e61c..d56c69d9470 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -3341,7 +3341,7 @@ comp-delete-or-replace-file ;; is currently loaded. (t (delete-file oldfile) (when newfile - (rename-file newfile oldfile))))) + (rename-file newfile oldfile t))))) (defun comp--native-compile (function-or-file &optional with-late-load out= put) "Compile FUNCTION-OR-FILE into native code. Aaron From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 13:46:28 2023 Received: (at 68083) by debbugs.gnu.org; 30 Dec 2023 18:46:28 +0000 Received: from localhost ([127.0.0.1]:45061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJeLs-0003mK-9H for submit@debbugs.gnu.org; Sat, 30 Dec 2023 13:46:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJeLo-0003ec-Q4 for 68083@debbugs.gnu.org; Sat, 30 Dec 2023 13:46:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJeLg-0001Fz-RJ; Sat, 30 Dec 2023 13:46:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ioqEP31IObGKwohkpIT+X1mebuJfy9PJZKl+w6ubD5s=; b=qSy+GGqQqKwYVusl2qPJ Aw94Q3v9BtPQqpj2qgaP8Q7aQHj22eOIzzbXbQcHeJaK4qagguegYKRWy8Ihy8xlwmRVPIplCVhuT I/7Rn0kwfyOS9xad3eu4K4v8P05wNdkBUPoo9luhsH6ndCkzrfQ3F17ocTEw+BZgJBlL7vexuBqSv wCWy8bGoE3BCUDDx5wd/UdBmLuhBCX3hWtgGvCp+NWZireimq7yAURtlEzQYmbka5EPNqvYeBEMJj f4fwqgMIf0V4Eb8VTU+6UPE8BVyF8Fe4QL0lBS2HI3bXFWvGGKFmZvYbkuqkNX+8eNNHj8oCVFQr/ 2DRJm7UKx5CiOA==; Date: Sat, 30 Dec 2023 20:46:08 +0200 Message-Id: <831qb34jgv.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Sat, 30 Dec 2023 13:06:55 -0500) Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> <838r5b4me9.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > Date: Sat, 30 Dec 2023 13:06:55 -0500 > Cc: acorallo@gnu.org, 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de > > On Sat, Dec 30, 2023 at 12:43 PM Eli Zaretskii wrote: > > > > What happens if, instead of wrapping rename-file in condition-case, > > you change that to say > > > > (t (if newfile > > (rename-file newfile oldfile) > > (delete-file oldfile)) > > I don't really understand this change. The previous version of the > code wraps the rename in a (when newfile) and deletes the oldfile > right before that. The deletion would always be necessary if the > oldfile exists unless OK-IF-ALREADY-EXISTS is specified in > rename-file. Sorry, I meant to add the OK-IF-ALREADY-EXISTS argument non-nil, of course. The point is that you can rename a file if the OLDFILE exists with no problem, and that is supposed to be an atomic operation, so no race conditions. > Indeed, but we aren't specifying OK-IF-ALREADY-EXISTS, so if another > process does the same compile at the same time (and therefore the same > rename), they will conflict. We could specify OK-IF-ALREADY-EXISTS > instead and that works as well: Then I prefer this version. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 15:55:03 2023 Received: (at 68083) by debbugs.gnu.org; 30 Dec 2023 20:55:03 +0000 Received: from localhost ([127.0.0.1]:45138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJgMI-00032w-Vj for submit@debbugs.gnu.org; Sat, 30 Dec 2023 15:55:03 -0500 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:57778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJgMG-00032L-M0 for 68083@debbugs.gnu.org; Sat, 30 Dec 2023 15:55:01 -0500 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2cceb90b398so20352961fa.3 for <68083@debbugs.gnu.org>; Sat, 30 Dec 2023 12:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703969694; x=1704574494; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Mp9BVH5OV152v6kwoaUJ+TLD/ewnHmcR2pSQPJtFn5g=; b=HhvTuPrv0bow0BdIXnuq2cV+TLFTON/cL4KIxNyWG3Le8tqGUdEWc5+4cv5roYeGXg 7TDldDvFoTjd0QXgzMt9NiGn3UbOdldhv4XgVHv0ZuLxG827tObNXiKH0OIF6hsW7Oli nO5I7R7nO6VEvd55+S/BLkSM1pI10AjbMXQVzDWXJbOPn5G9nvi+ra0AYziEsQfAzt3k AX2rZP2xbq526BXAG0k2SfBFnveRSj61OtN8A9bjP7DIF9en+710VkYdpQSCkcE5HoF4 RgbbbirnIQyHCCyDwhKj+h1sqoKcqfX0Xa3feSNKAESDhWANhtySxQNMelYjRpZYLzEk pPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703969694; x=1704574494; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mp9BVH5OV152v6kwoaUJ+TLD/ewnHmcR2pSQPJtFn5g=; b=ojmfLVrZKh1HULgJPti3EcRrFj5DcpNAYjV/e5HQ/vHfSv5iwCia3YJrjuTpvevGn+ 4LpLGl/U1zxzIrqAIJugcCIX2nwkCQB509zwnrOe+jiMQqM8qc/0Fbj/atfkNRZ2V2Tn F9fgFEElRKjfbjWvQaH+iJtFgQV/Ri0pBadsZ2AyHO7laksdOX55WoCgcE3l115HOZ9h cEEhprMcNmfqR5BGQeC0S8ltAK6nUx5c1eOBotCgHDLB0MItKU5hU51yjKxcgtk0cx9w Aq/z0xPylGuhYriPcPeeZrw002mKrKkmDcZrte8Os++m6P4yfq1F0HA0o07LiPK3+BCr 5oCw== X-Gm-Message-State: AOJu0YyloZMwSrm7BnEGLwqNwQRj2Z7M52VBRuzA3+TF/YP/m5BeCZ0e zrMiK/fq5G23U3swbQRx+/unpoOlD/ZizgW6nMo= X-Google-Smtp-Source: AGHT+IH8rAh2OUSTiZO1zYV4ANM5XZIrOJj4dKJk+Qt2GzaNSUodAOW+k6m+X/92c/UAdlwyorvSE5slhctTwTjkdVY= X-Received: by 2002:a2e:9186:0:b0:2cc:9342:a810 with SMTP id f6-20020a2e9186000000b002cc9342a810mr5530228ljg.88.1703969693735; Sat, 30 Dec 2023 12:54:53 -0800 (PST) Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 Dec 2023 14:54:53 -0600 Mime-Version: 1.0 In-Reply-To: <831qb34jgv.fsf@gnu.org> X-Superhuman-Draft-ID: draft00439ccdbe70bf4f X-Superhuman-ID: lqsjjh3z.c573d461-1374-4cac-b025-86b615f4bfe6 References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> <838r5b4me9.fsf@gnu.org> <831qb34jgv.fsf@gnu.org> X-Mailer: Superhuman iOS 11007 From: Aaron Jensen Date: Sat, 30 Dec 2023 14:54:53 -0600 Message-ID: Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000004d9fcc060dc05c16" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, Andrea Corallo , Jens Schmidt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004d9fcc060dc05c16 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Works for me, though is it still an outstanding question as to whether or not we should add macro expand back? Also yeah if we add the t we can do what you suggested where it=E2=80=99s e= ither a delete or rename force. Aaron On Sat, Dec 30 2023 at 1:46 PM, Eli Zaretskii wrote: > From: Aaron Jensen > Date: Sat, 30 Dec 2023 13:06:55 -0500 > Cc: acorallo@gnu.org, 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de > > On Sat, Dec 30, 2023 at 12:43=E2=80=AFPM Eli Zaretskii wro= te: > > > > What happens if, instead of wrapping rename-file in condition-case, > > you change that to say > > > > (t (if newfile > > (rename-file newfile oldfile) > > (delete-file oldfile)) > > I don't really understand this change. The previous version of the code > wraps the rename in a (when newfile) and deletes the oldfile right before > that. The deletion would always be necessary if the oldfile exists unless > OK-IF-ALREADY-EXISTS is specified in rename-file. > > Sorry, I meant to add the OK-IF-ALREADY-EXISTS argument non-nil, of > course. > > The point is that you can rename a file if the OLDFILE exists with no > problem, and that is supposed to be an atomic operation, so no race > conditions. > > Indeed, but we aren't specifying OK-IF-ALREADY-EXISTS, so if another > process does the same compile at the same time (and therefore the same > rename), they will conflict. We could specify OK-IF-ALREADY-EXISTS instea= d > and that works as well: > > Then I prefer this version. > --0000000000004d9fcc060dc05c16 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Works for me, though is it still an outstanding que= stion as to whether or not we should add macro expand back?

Also yeah if we add the t we can do what yo= u suggested where it=E2=80=99s either a delete or rename force.=C2=A0


Aaron
=20

On Sat, Dec 30 2023 at 1:46 PM, Eli Zaretskii <eliz@gnu.org<= /a>> wrote:

From: Aaron Jensen <aaronjensen= @gmail.com>
Date: Sat, 30 Dec 2023 13:06:55 -0500
Cc: acorallo@gnu.org, 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de

On Sat, Dec 30, 2023 at 12:43=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
>
> What happens if, instead of wrapping rename-file in condition-case,
> you change that to say
>
> (t (if newfile
> (rename-file newfile oldfile)
> (delete-file oldfile))

I don't really understand this change. The previous version of the code wraps the rename in a (when newfile) and deletes the oldfile right before that. The deletion would always be necessary if the oldfile exists unless OK-IF-ALREADY-EXISTS is specified in rename-file.

Sorry, I meant to add the OK-IF-ALREADY-EXISTS argument non-nil, of course.

The point is that you can rename a file if the OLDFILE exists with no problem, and that is supposed to be an atomic operation, so no race conditions.

Indeed, but we aren't specifying OK-IF-ALREADY-EXISTS, so if another process does the same compile at the same time (and therefore the same rename), they will conflict. We could specify OK-IF-ALREADY-EXISTS instead and that works as well:

Then I prefer this version.

--0000000000004d9fcc060dc05c16-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 30 18:08:25 2023 Received: (at 68083) by debbugs.gnu.org; 30 Dec 2023 23:08:25 +0000 Received: from localhost ([127.0.0.1]:45224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiRM-0004bT-Pr for submit@debbugs.gnu.org; Sat, 30 Dec 2023 18:08:25 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:61702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJiRH-0004bC-If for 68083@debbugs.gnu.org; Sat, 30 Dec 2023 18:08:23 -0500 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2cc7d2c1ff0so84317221fa.3 for <68083@debbugs.gnu.org>; Sat, 30 Dec 2023 15:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703977692; x=1704582492; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qzml/OQ67qxbBp/oCzdgxpw0awXuhqlu4p/XeYYIdbg=; b=fdwLuHD/cELFhLCxYjsDBdaNP7ZKMyJ42JRTvG50+z3r3NZlAoJvgrWXExmZwTZHUg lDm57R+wQh76nKGrIPo7gR9nG2ttU1tUr1EcxEVwDGFz1hL2uU9lX2gXYV2zJHR/Lx9A Y57D5XiTIHBVf5HKi2pzLAqH1zVaNP6B3uIwEDzcmAhlFykMUtLRCUDgS6EFkz4Vf2jM Il7OF/UKeoZbuRuz3IfjOKLsYj0zF/xWoZ79kHYOzxO4i+86Mkj0VuSsgkbCUdIx2CZo /DqGIsFD4Fn0yhWYFwWU/2mqDH03g0umOFZLSqdlZu6j/swdjnkZ9nb07Cr3M0yiZdx5 slkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703977692; x=1704582492; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qzml/OQ67qxbBp/oCzdgxpw0awXuhqlu4p/XeYYIdbg=; b=mDRDWswwfwwjlTF/qBlAIqWFP+RpLmQ5hEPJvKEuEw+Dfx5bI525EljS7a04K/W75p h3Hu+vQaw+xYLsDhBCHPmAnqIOblFC0CFs8r3rh3SkzfZzK0vORwi8RvglSJm50QyjR4 xYgZqknCrexFLtBWv+FqRi+08Hd6zP7zScNx/Vp4/IUbPyh8TmuXJ0URZPVid036KPq3 2sNvp9xr7Co1vT56mRXA0+295AAf6ClEk22nj4XGbfVjpF96Jo1WRH54dOaNdf9JujBs J8AD9ZBLa9IA2wt9EE40wVHwiXaPSQ1/bh2t6JdLMBOE0IziA/m17nP7g0UsnoS3X/xF AjsA== X-Gm-Message-State: AOJu0YxRq/Z3uDsdKY3VPPGB2jgbDkUj0XlzGKPiKd4URMxj3d2e6rkL stKvkUfjD+LYcwZ1sZ7kgxF3B5q1Q4s0b9PiZsY= X-Google-Smtp-Source: AGHT+IE63U8yidYgyT0YV0VK/b+VW/pEs6t7QBhGf4R5fnpqAkegkU6r0GDagQbfaAhuM1YDu/WOxwJHvR6Nrhe++wk= X-Received: by 2002:a2e:3a03:0:b0:2cc:5a00:8e0 with SMTP id h3-20020a2e3a03000000b002cc5a0008e0mr6652334lja.80.1703977692291; Sat, 30 Dec 2023 15:08:12 -0800 (PST) Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 Dec 2023 17:08:11 -0600 Mime-Version: 1.0 X-Mailer: Superhuman Desktop (2023-12-22T20:06:10Z) X-Superhuman-ID: lqsob57p.51c7a4cc-0d44-49ef-a217-a8f7efb905b2 In-Reply-To: References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> <838r5b4me9.fsf@gnu.org> <831qb34jgv.fsf@gnu.org> X-Superhuman-Draft-ID: draft00b67a882aea2dc3 From: Aaron Jensen Date: Sat, 30 Dec 2023 17:08:11 -0600 Message-ID: Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000000e03ef060dc23992" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, Andrea Corallo , Jens Schmidt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000e03ef060dc23992 Content-Type: multipart/alternative; boundary="0000000000000e03ed060dc23990" --0000000000000e03ed060dc23990 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here's a patch, if helpful. I've tested it and can build with it. Aaron On Sat, Dec 30, 2023 at 3:54 PM, Aaron Jensen wrote= : > Works for me, though is it still an outstanding question as to whether or > not we should add macro expand back? > > Also yeah if we add the t we can do what you suggested where it=E2=80=99s= either a > delete or rename force. > > > Aaron > > On Sat, Dec 30 2023 at 1:46 PM, Eli Zaretskii wrote: > > From: Aaron Jensen > Date: Sat, 30 Dec 2023 13:06:55 -0500 > Cc: acorallo@gnu.org, 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de > > On Sat, Dec 30, 2023 at 12:43=E2=80=AFPM Eli Zaretskii wro= te: > > > > What happens if, instead of wrapping rename-file in condition-case, > > you change that to say > > > > (t (if newfile > > (rename-file newfile oldfile) > > (delete-file oldfile)) > > I don't really understand this change. The previous version of the code > wraps the rename in a (when newfile) and deletes the oldfile right before > that. The deletion would always be necessary if the oldfile exists unless > OK-IF-ALREADY-EXISTS is specified in rename-file. > > Sorry, I meant to add the OK-IF-ALREADY-EXISTS argument non-nil, of > course. > > The point is that you can rename a file if the OLDFILE exists with no > problem, and that is supposed to be an atomic operation, so no race > conditions. > > Indeed, but we aren't specifying OK-IF-ALREADY-EXISTS, so if another > process does the same compile at the same time (and therefore the same > rename), they will conflict. We could specify OK-IF-ALREADY-EXISTS instea= d > and that works as well: > > Then I prefer this version. > > --0000000000000e03ed060dc23990 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here's a patch,= if helpful. I've tested it and can build with it.
=


Aaron


On Sat, Dec 30, 2023 at 3:54 PM, Aaro= n Jensen <aaronjensen@gmail.com> wrote:
Works for me= , though is it still an outstanding question as to whether or not we should= add macro expand back?

Also yeah if we add the t we can = do what you suggested where it=E2=80=99s either a delete or rename force.= =C2=A0


Aaron
=20

On Sat, Dec 30 2023 at 1:46 PM, Eli = Zaretskii <eliz@gnu.org&= gt; wrote:

From: Aaron Jensen <aaronje= nsen@gmail.com>
Date: Sat, 30 Dec 20= 23 13:06:55 -0500
Cc: acorallo@gnu.org,= 68083@debbugs.gnu.<= wbr>org, jschmidt4g= nu@vodafonemail.de

On Sat, Dec 30, 2023 at 12:43=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
>
> What happens if, instead of wrapping rename-file in condition-case,
> you change that to say
>
> (t (if newfile
> (rename-file newfile oldfile)
> (delete-file oldfile))

I don't really understand this change. The previous version of the code wraps the rename in a (when newfile) and deletes the oldfile right before that. The deletion would always be necessary if the oldfile exists unless OK-IF-ALREADY-EXISTS is specified in rename-file.

Sorry, I meant to add the OK-IF-ALREADY-EXISTS argument non-nil, of course.

The point is that you can rename a file if the OLDFILE exists with no problem, and that is supposed to be an atomic operation, so no race conditions.

Indeed, but we aren't specifying OK-IF-ALREADY-EXISTS, so if another process does the same compile at the same time (and therefore the same rename), they will conflict. We could specify OK-IF-ALREADY-EXISTS instead and that works as well:

Then I prefer this version.

<= /div>

--0000000000000e03ed060dc23990-- --0000000000000e03ef060dc23992 Content-Type: application/octet-stream; name="0001-comp.el-comp-delete-or-replace-file-Fix-parallel-com.patch" Content-Disposition: attachment; filename="0001-comp.el-comp-delete-or-replace-file-Fix-parallel-com.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: fe7a8a11c2e3eb3_0.1 RnJvbSBjMWFiMjcxNzllNjhiOTRjOWFkYjQ5MDVjNjc3YzdmMzQ0YzA5ZTZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAzMCBEZWMgMjAyMyAxODowNjo0NSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdICog Y29tcC5lbCAoY29tcC1kZWxldGUtb3ItcmVwbGFjZS1maWxlKTogRml4IHBhcmFsbGVsCiBjb21w aWxhdGlvbgoKLS0tCiBsaXNwL2VtYWNzLWxpc3AvY29tcC5lbCB8IDYgKysrLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvZW1hY3MtbGlzcC9jb21wLmVsIGIvbGlzcC9lbWFjcy1saXNwL2NvbXAuZWwKaW5kZXggM2Iy ZmQyNWU2MWMuLmY5ZWVlZjFiOWU4IDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvY29tcC5l bAorKysgYi9saXNwL2VtYWNzLWxpc3AvY29tcC5lbApAQCAtMzMzOSw5ICszMzM5LDkgQEAgY29t cC1kZWxldGUtb3ItcmVwbGFjZS1maWxlCiAgICAgICAgIDs7IFJlbW92ZSB0aGUgb2xkIGVsbiBp bnN0ZWFkIG9mIGNvcHlpbmcgdGhlIG5ldyBvbmUgaW50byBpdAogICAgICAgICA7OyB0byBnZXQg YSBuZXcgaW5vZGUgYW5kIHByZXZlbnQgY3Jhc2hlcyBpbiBjYXNlIHRoZSBvbGQgb25lCiAgICAg ICAgIDs7IGlzIGN1cnJlbnRseSBsb2FkZWQuCi0gICAgICAgICh0IChkZWxldGUtZmlsZSBvbGRm aWxlKQotICAgICAgICAgICAod2hlbiBuZXdmaWxlCi0gICAgICAgICAgICAgKHJlbmFtZS1maWxl IG5ld2ZpbGUgb2xkZmlsZSkpKSkpCisgICAgICAgICh0IChpZiBuZXdmaWxlCisgICAgICAgICAg ICAgICAocmVuYW1lLWZpbGUgbmV3ZmlsZSBvbGRmaWxlIHQpCisgICAgICAgICAgICAgKGRlbGV0 ZS1maWxlIG9sZGZpbGUpKSkpKQogCiAoZGVmdW4gY29tcC0tbmF0aXZlLWNvbXBpbGUgKGZ1bmN0 aW9uLW9yLWZpbGUgJm9wdGlvbmFsIHdpdGgtbGF0ZS1sb2FkIG91dHB1dCkKICAgIkNvbXBpbGUg RlVOQ1RJT04tT1ItRklMRSBpbnRvIG5hdGl2ZSBjb2RlLgotLSAKMi40Mi4xCgo= --0000000000000e03ef060dc23992-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 31 01:27:00 2023 Received: (at 68083) by debbugs.gnu.org; 31 Dec 2023 06:27:00 +0000 Received: from localhost ([127.0.0.1]:45514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJpHo-0007eX-5m for submit@debbugs.gnu.org; Sun, 31 Dec 2023 01:27:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJpHk-0007eI-Uj for 68083@debbugs.gnu.org; Sun, 31 Dec 2023 01:26:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJpHe-0002YI-BD; Sun, 31 Dec 2023 01:26:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8v8dJOdKr6QSO7ppz6bZw+xkHEpMBrXL8x68HldB4SI=; b=eBZCMHWQoxvZ BcNB65BMsy/kmZKPCK4CzVEKxl8QJF7nT4NPxjesPL01Zku1/7VTYEUpAk1Slr5OiYQDarK//6Rep 4517c+JxR5N75bbqUHdAEewCbcTspIEYFhVlXMS0wRDT2r9IQcDNLP5X5CkAxD6sIdlqtmN7b6Mvb Cah+2+jINt+hWMacWjUhLxr75/sgNafQ+Mlo5fsY5kPx2LXUnIpkf//69QgHle4YZ1lFCDY8caPOC wDjm1m7W5RGnV5C2Bw0axBiHMBtZk2Wbs+xtozXx0DWkggI3c4yxXQJciHNLgj21isjBtQtz0OSfE hJo2JdbEdvbz/NfoarxoJA==; Date: Sun, 31 Dec 2023 08:26:43 +0200 Message-Id: <83wmsu3n18.fsf@gnu.org> From: Eli Zaretskii To: Aaron Jensen In-Reply-To: (message from Aaron Jensen on Sat, 30 Dec 2023 14:54:53 -0600) Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> <838r5b4me9.fsf@gnu.org> <831qb34jgv.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Aaron Jensen > Date: Sat, 30 Dec 2023 14:54:53 -0600 > Cc: Andrea Corallo , 68083@debbugs.gnu.org, > Jens Schmidt > > Works for me, though is it still an outstanding question as to whether or not we should add macro > expand back? Andrea, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 31 15:31:26 2023 Received: (at 68083) by debbugs.gnu.org; 31 Dec 2023 20:31:27 +0000 Received: from localhost ([127.0.0.1]:47094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rK2T0-0002Y4-Fg for submit@debbugs.gnu.org; Sun, 31 Dec 2023 15:31:26 -0500 Received: from mr4.vodafonemail.de ([145.253.228.164]:49472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rK2Sw-0002PC-LC for 68083@debbugs.gnu.org; Sun, 31 Dec 2023 15:31:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1704054674; bh=ggTIG0KikaxtW/X59OsZyxpYZkg072vjsjm95v+1Iss=; h=Message-ID:Date:User-Agent:Subject:To:References:From: Content-Language:In-Reply-To:Content-Type:From; b=vf96FzylKYDKdlC5sTKlAHr0M3FjcAJpUZ0ieK07K8LjF/MPCInefhpLX8ieSBsPw NiosWfwdb43GIsv3jzh2guAuvRcUtrK7TJRexgUtXTuTkKRCp50zinp4PFhfPtGttL v/e+M4QLHWnZW7HgXfBAD+xhElPDBwdyQO2LiQ6A= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4T39kB5Xd8z1xy1; Sun, 31 Dec 2023 20:31:14 +0000 (UTC) Received: from [192.168.178.41] (port-92-196-93-223.dynamic.as20676.net [92.196.93.223]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4T39jx0Tnhz9tMd; Sun, 31 Dec 2023 20:30:57 +0000 (UTC) Message-ID: <66df862a-6af8-488f-a68d-a3fdf34666c3@vodafonemail.de> Date: Sun, 31 Dec 2023 21:30:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation To: Andrea Corallo , Aaron Jensen References: <83le9e743s.fsf@gnu.org> From: Jens Schmidt Content-Language: de-DE-frami, en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 265 X-purgate-ID: 155817::1704054670-1178DBDE-3C071032/0/0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68083 Cc: Eli Zaretskii , 68083@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2023-12-29 21:17, Andrea Corallo wrote: > Intresting, adding Jens, hopefully he has some good idea. Thanks for inviting me to the party and sorry for attending late, but I'm grounded by a flu ... will check later if there is still anything to check. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 01 14:39:49 2024 Received: (at 68083) by debbugs.gnu.org; 1 Jan 2024 19:39:49 +0000 Received: from localhost ([127.0.0.1]:48819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKO8b-0000hZ-5L for submit@debbugs.gnu.org; Mon, 01 Jan 2024 14:39:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKO8Z-0000hM-57 for 68083@debbugs.gnu.org; Mon, 01 Jan 2024 14:39:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKO8R-0004FL-8X; Mon, 01 Jan 2024 14:39:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=qOZUH+lO0iE8+X5kgKCOEwGi7GeSwIglkwCVHCCWTrU=; b=UFmjPaXJYSrk123/6gvH yR+fX9Xs/tUeE7iyTJRJkWyT+wjT81NcuACyQ0Lqe8QWNsaYf34apFtvyCy8OlyldChz136Hg3Z23 OJCChvL6rSqAW1hk3BxeQSmYvOdfl8KXN/hJpT1Tr+5L3HEBGixy7xN0ZmHShaCCn3TpKSxPyIxZl h9kvZkANXVwFe3y2Csfi6g0Gfv/uhEJyZwfC3Ucr9KufL08/lMtAzX1R0PSByJ4eQuzRKc/Atyjlh aZvK4/TU3N4615cHPIGK50gEXQjpbE83KgVBbZMRb4dCVK15ZKFeWga0V5h1srun/9QUbjuT8wx7/ JLx9QOWLEnSChg==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rKO8Q-0005QL-ET; Mon, 01 Jan 2024 14:39:38 -0500 From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation In-Reply-To: <83wmsu3n18.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 31 Dec 2023 08:26:43 +0200") References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> <838r5b4me9.fsf@gnu.org> <831qb34jgv.fsf@gnu.org> <83wmsu3n18.fsf@gnu.org> Date: Mon, 01 Jan 2024 14:39:38 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083 Cc: 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de, Aaron Jensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Aaron Jensen >> Date: Sat, 30 Dec 2023 14:54:53 -0600 >> Cc: Andrea Corallo , 68083@debbugs.gnu.org, >> Jens Schmidt >> >> Works for me, though is it still an outstanding question as to whether or not we should add macro >> expand back? > > Andrea, WDYT? I think we should not re-add it unless there's a specific reason. If the proposed patch solves the issue I guess we should be fine with that. Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 01 15:12:35 2024 Received: (at 68083-done) by debbugs.gnu.org; 1 Jan 2024 20:12:35 +0000 Received: from localhost ([127.0.0.1]:48826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKOeJ-0006kO-3y for submit@debbugs.gnu.org; Mon, 01 Jan 2024 15:12:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKOeF-0006k9-V0 for 68083-done@debbugs.gnu.org; Mon, 01 Jan 2024 15:12:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKOe0-0000dZ-Jw; Mon, 01 Jan 2024 15:12:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EIXqXej6m9G4FpxNIz8Qc9HeRHzKKriMUriGUaSY1cw=; b=IlzfA/vZG5lw cl1WYaaVt0ZHcgkGUcj/mKA3l/9e9tqz/H7ubizXxZ2FBAJCWbIjD3UU0BBRJ+TB7I1FqeiDNtHbO ffmeQJL8PZenFOKc4+QGDxgfp6s5MkUNMuaqVaohoFDwWq0SE/MKLHregdIfM3mb8K6QyGX9tHkiC wd//Lmco0gNhRy0psBYf7Jb/4IYuUJdi9hUDXsjfsNsHf83RQnHKyCtuySwVXI2pqUBoLYyMaK7jr 4RW5irvUGOwVvxRRlKBEUGyvpBIkDN1BXio8UFXUU/qv4xrFtIxqhPlfVJAj/2FXT/t683PXbdr7t ySUFy1hNe/8kh7aUykUzVA==; Date: Mon, 01 Jan 2024 22:12:10 +0200 Message-Id: <83bka424px.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Mon, 01 Jan 2024 14:39:38 -0500) Subject: Re: bug#68083: 30.0.50; Intermittent build failure with native compilation References: <83le9e743s.fsf@gnu.org> <835y0g5gq8.fsf@gnu.org> <838r5b4me9.fsf@gnu.org> <831qb34jgv.fsf@gnu.org> <83wmsu3n18.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68083-done Cc: 68083-done@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de, aaronjensen@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: Aaron Jensen , 68083@debbugs.gnu.org, > jschmidt4gnu@vodafonemail.de > Date: Mon, 01 Jan 2024 14:39:38 -0500 > > Eli Zaretskii writes: > > >> From: Aaron Jensen > >> Date: Sat, 30 Dec 2023 14:54:53 -0600 > >> Cc: Andrea Corallo , 68083@debbugs.gnu.org, > >> Jens Schmidt > >> > >> Works for me, though is it still an outstanding question as to whether or not we should add macro > >> expand back? > > > > Andrea, WDYT? > > I think we should not re-add it unless there's a specific reason. > > If the proposed patch solves the issue I guess we should be fine with > that. Thanks, so I installed the last patch, and I'm closing this bug. From unknown Sun Sep 07 21:51:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 Jan 2024 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator