GNU bug report logs - #68074
eshell sudo/doas does not work for aliases

Previous Next

Full log

Message #16 received at 68074 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>,
 Alfonso Sanchez-Beato <alfonsosanchezbeato <at> yahoo.es>
Cc: 68074 <at> debbugs.gnu.org
Subject: Re: bug#68074: eshell sudo/doas does not work for aliases
Date: Wed, 24 Jan 2024 18:43:43 -0800

[Message part 1 (text/plain, inline)]

On 1/11/2024 1:15 PM, Jim Porter wrote:
> I've been meaning to look at this in detail, but haven't had time. My 
> gut feeling though is that we shouldn't have a special case in this code 
> for when the alias starts with "cd". I'll have to do some testing with 
> aliases and sudo in order to have a more-helpful answer though.
> 
> At a guess, I think a better place to add code for this is likely in 
> em-tramp.el.

After letting this percolate in my brain for a few weeks, the answer 
revealed itself to me: the functions in "em-tramp.el" shouldn't throw 
'eshell-external', they should throw 'eshell-replace-command'. That 
allows for a two-step command replacement in this case. First, 
'eshell/sudo' (or 'eshell/doas') will do its replacement. Then, Eshell 
will evaluate that and call the inner command, which will do another 
replacement to expand the alias.

Alfonso, does the attached patch work for you? If so, I'll merge it to 
master.

[0001-Fix-command-replacement-with-the-Eshell-builtin-vers.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.