GNU bug report logs -
#68030
29.1; (elisp) `pcase Macro' Reformulation with `pcase' example
Previous Next
Reported by: Drew Adams <drew.adams <at> oracle.com>
Date: Mon, 25 Dec 2023 16:42:01 UTC
Severity: normal
Found in version 29.1
Done: Stefan Kangas <stefankangas <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#68030: 29.1; (elisp) `pcase Macro' Reformulation with `pcase' example
which was filed against the emacs package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 68030 <at> debbugs.gnu.org.
--
68030: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68030
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
Drew Adams <drew.adams <at> oracle.com> writes:
> We shouldn't try to introduce (and perhaps even motivate) the use of
> `pcase' for such a "simple matching task". The `pcase' version is
> many times more complex than the simple `if' version with a
> single-sexp THEN and a single-sexp ELSE.
The purpose is to start with a small example to teach the reader about
pcase. I see nothing that needs changing here.
> Even if the aim is to present `or', `and', `pred' and `app', a better
> example should be used - something where it really _helps_ to use those
> subpatterns. In the example chosen they just add noise.
Without any concrete suggestions, I don't see anything actionable here.
I'm therefore closing this bug report.
> [Not part of this bug report, but you might also want to move the whole
> `Caveats for SYMBOL in Sequencing Patterns' to a separate node (with
> `pcase' somewhere in the node name).]
I don't see any benefit in doing that.
>
> In GNU Emacs 29.1 (build 2, x86_64-w64-mingw32) of 2023-08-02 built on
> AVALON
> Windowing system distributor 'Microsoft Corp.', version 10.0.19045
> System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.3803)
>
> Configured using:
> 'configure --with-modules --without-dbus --with-native-compilation=aot
> --without-compress-install --with-tree-sitter CFLAGS=-O2'
>
> Configured features:
> ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
> NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
> TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB
>
> (NATIVE_COMP present but libgccjit not available)
[Message part 3 (message/rfc822, inline)]
We shouldn't try to introduce (and perhaps even motivate) the use of
`pcase' for such a "simple matching task". The `pcase' version is
many times more complex than the simple `if' version with a
single-sexp THEN and a single-sexp ELSE.
Even if the aim is to present `or', `and', `pred' and `app', a better
example should be used - something where it really _helps_ to use those
subpatterns. In the example chosen they just add noise.
[Not part of this bug report, but you might also want to move the whole
`Caveats for SYMBOL in Sequencing Patterns' to a separate node (with
`pcase' somewhere in the node name).]
In GNU Emacs 29.1 (build 2, x86_64-w64-mingw32) of 2023-08-02 built on
AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.3803)
Configured using:
'configure --with-modules --without-dbus --with-native-compilation=aot
--without-compress-install --with-tree-sitter CFLAGS=-O2'
Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB
(NATIVE_COMP present but libgccjit not available)
This bug report was last modified 1 year and 198 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.