GNU bug report logs - #6803
24.0.50; pc-selection-mode no longer plays nice with dired (or vice versa)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6803 in the body.
You can then email your comments to 6803 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Van Holder <tim.vanholder <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50;
	pc-selection-mode no longer plays nice with dired (or vice versa)
Date: Thu, 05 Aug 2010 13:07:02 +0200

Dired normally has the up and down arrows bound to dired-previous-line
(also bound to [p]) and dired-next-line (also bound to [n]), respectively.
However, when pc-selection-mode is enabled, these bindings are
apparently overridden now, to previous-line-nomark and next-line-nomark,
respectively, breaking the normal dired navigation (point is not
automatically put on the file name).
Looking at 'C-h m' for dired in an older emacs version (a 23.0.60.1
build) and today's bzr head, the cause seems to be that while the older
dired explicitly bound <up> and <down>, the current dired seems to rely
on remapping <next-line> and <previous-line> instead.

In GNU Emacs 24.0.50.10 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2010-08-05 on leeloo
Windowing system distributor `The Cygwin/X Project', version 11.0.10503000
configured using `configure  '--with-x''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Message #8 received at 6803 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Tim Van Holder <tim.vanholder <at> gmail.com>
Cc: 6803 <at> debbugs.gnu.org
Subject: Re: bug#6803: 24.0.50; pc-selection-mode no longer plays nice with 
	dired (or vice versa)
Date: Thu, 5 Aug 2010 22:41:29 +0200

On Thu, Aug 5, 2010 at 13:07, Tim Van Holder <tim.vanholder <at> gmail.com> wrote:
> Dired normally has the up and down arrows bound to dired-previous-line
> (also bound to [p]) and dired-next-line (also bound to [n]), respectively.
> However, when pc-selection-mode is enabled, these bindings are
> apparently overridden now, to previous-line-nomark and next-line-nomark,
> respectively, breaking the normal dired navigation (point is not
> automatically put on the file name).
> Looking at 'C-h m' for dired in an older emacs version (a 23.0.60.1
> build) and today's bzr head, the cause seems to be that while the older
> dired explicitly bound <up> and <down>, the current dired seems to rely
> on remapping <next-line> and <previous-line> instead.

Right, this is a consequence of bug#6632 and revno:100864.

Perhaps it should be reverted, but then, the use case mentioned in the
bug will still be there.

Opinions?

    Juanma

Message #11 received at 6803 <at> debbugs.gnu.org (full text, mbox):

From: Tim Van Holder <tim.vanholder <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6803 <at> debbugs.gnu.org
Subject: Re: bug#6803: 24.0.50; pc-selection-mode no longer plays nice with 
	dired (or vice versa)
Date: Fri, 6 Aug 2010 08:49:57 +0200

On 5 August 2010 22:41, Juanma Barranquero <lekktu <at> gmail.com> wrote:
> On Thu, Aug 5, 2010 at 13:07, Tim Van Holder <tim.vanholder <at> gmail.com> wrote:
>> Dired normally has the up and down arrows bound to dired-previous-line
>> (also bound to [p]) and dired-next-line (also bound to [n]), respectively.
>> However, when pc-selection-mode is enabled, these bindings are
>> apparently overridden now, to previous-line-nomark and next-line-nomark,
>> respectively, breaking the normal dired navigation (point is not
>> automatically put on the file name).
>> Looking at 'C-h m' for dired in an older emacs version (a 23.0.60.1
>> build) and today's bzr head, the cause seems to be that while the older
>> dired explicitly bound <up> and <down>, the current dired seems to rely
>> on remapping <next-line> and <previous-line> instead.
>
> Right, this is a consequence of bug#6632 and revno:100864.
>
> Perhaps it should be reverted, but then, the use case mentioned in the
> bug will still be there.
>
> Opinions?
>
>     Juanma

Do dired-next/previous-line set the mark? If not (or if it's likely
that the distinction does not really matter in dired mode), I suppose
dired could just remap the -nomark variants of next/previous-line too.
If it does, maybe it could add -nomark variants of its own functions?

Message #14 received at 6803 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Tim Van Holder <tim.vanholder <at> gmail.com>, 6803 <at> debbugs.gnu.org
Subject: Re: bug#6803: 24.0.50; pc-selection-mode no longer plays nice with
 dired (or vice versa)
Date: Sun, 18 Jul 2021 14:57:26 +0200

Juanma Barranquero <lekktu <at> gmail.com> writes:

> On Thu, Aug 5, 2010 at 13:07, Tim Van Holder <tim.vanholder <at> gmail.com> wrote:
>> Dired normally has the up and down arrows bound to dired-previous-line
>> (also bound to [p]) and dired-next-line (also bound to [n]), respectively.
>> However, when pc-selection-mode is enabled, these bindings are
>> apparently overridden now, to previous-line-nomark and next-line-nomark,
>> respectively, breaking the normal dired navigation (point is not
>> automatically put on the file name).
>> Looking at 'C-h m' for dired in an older emacs version (a 23.0.60.1
>> build) and today's bzr head, the cause seems to be that while the older
>> dired explicitly bound <up> and <down>, the current dired seems to rely
>> on remapping <next-line> and <previous-line> instead.
>
> Right, this is a consequence of bug#6632 and revno:100864.
>
> Perhaps it should be reverted, but then, the use case mentioned in the
> bug will still be there.
>
> Opinions?

This was ten years ago, and nobody had any opinions.  The patch in
question removed the direct bindings...

We allow modes all over the place to bind `C-n' (there's apparently
around 100 of these in the Emacs tree), so I don't think Dired was doing
anything wrong here.

I haven't looked at pc-selection-mode, though -- is this problem still
present in recent Emacs versions?

diff --git a/lisp/dired.el b/lisp/dired.el
index c3d1435..0e5cc22 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -1380,10 +1380,8 @@ Do so according to the former subdir alist OLD-SUBDIR-ALIST."
     (define-key map ">" 'dired-next-dirline)
     (define-key map "^" 'dired-up-directory)
     (define-key map " "  'dired-next-line)
-    (define-key map "\C-n" 'dired-next-line)
-    (define-key map "\C-p" 'dired-previous-line)
-    (define-key map [down] 'dired-next-line)
-    (define-key map [up] 'dired-previous-line)
+    (define-key map [remap next-line] 'dired-next-line)
+    (define-key map [remap previous-line] 'dired-previous-line)
     ;; hiding
     (define-key map "$" 'dired-hide-subdir)
     (define-key map "\M-$" 'dired-hide-all)
@@ -1393,7 +1391,7 @@ Do so according to the former subdir alist OLD-SUBDIR-ALIST."
     (define-key map (kbd "M-s f C-s")   'dired-isearch-filenames)
     (define-key map (kbd "M-s f M-C-s") 'dired-isearch-filenames-regexp)
     ;; misc
-    (define-key map "\C-x\C-q" 'dired-toggle-read-only)
+    (define-key map [remap toggle-read-only] 'dired-toggle-read-only)
     (define-key map "?" 'dired-summary)
     (define-key map "\177" 'dired-unmark-backward)
     (define-key map [remap undo] 'dired-undo)



-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 6803 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Tim Van Holder <tim.vanholder <at> gmail.com>, 6803 <at> debbugs.gnu.org
Subject: Re: bug#6803: 24.0.50; pc-selection-mode no longer plays nice with
 dired (or vice versa)
Date: Mon, 16 Aug 2021 14:12:39 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> We allow modes all over the place to bind `C-n' (there's apparently
> around 100 of these in the Emacs tree), so I don't think Dired was doing
> anything wrong here.
>
> I haven't looked at pc-selection-mode, though -- is this problem still
> present in recent Emacs versions?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.