From unknown Sun Jun 15 08:53:46 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#68009] home-xdg-user-directories-service-type: Extend it with home-environment-variables service Resent-From: lgcoelho@disroot.org Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 24 Dec 2023 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68009 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 68009@debbugs.gnu.org X-Debbugs-Original-To: Guix Patches Received: via spool by submit@debbugs.gnu.org id=B.170344083926659 (code B ref -1); Sun, 24 Dec 2023 18:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Dec 2023 18:00:39 +0000 Received: from localhost ([127.0.0.1]:53494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHSmE-0006ux-Oy for submit@debbugs.gnu.org; Sun, 24 Dec 2023 13:00:39 -0500 Received: from lists.gnu.org ([2001:470:142::17]:58676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHSmA-0006Tv-NB for submit@debbugs.gnu.org; Sun, 24 Dec 2023 13:00:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHSlu-0003TE-On for guix-patches@gnu.org; Sun, 24 Dec 2023 13:00:19 -0500 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rHSls-0004dI-GH for guix-patches@gnu.org; Sun, 24 Dec 2023 13:00:18 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 4CC0341ABF for ; Sun, 24 Dec 2023 19:00:13 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1iK1IJc_RtSs for ; Sun, 24 Dec 2023 19:00:12 +0100 (CET) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1703440812; bh=Nih+VbT9bhppxN4X0BpGFVseWXDkSvMAIdPtDCwH3rM=; h=Date:From:To:Subject; b=QtcGFMub3NGTPq4GsXwkJs5Ed58dxXTaq5vmWhdumToZI07seHD7w6iKg9ADTTAGh zSH9qZgckJNzf8Z/R9s+eaTQYpOyYfT1DKcjPF/k30+DPoFtKRP1VKZJujXPApCfM4 2Y6MnUH7xuDZXghmFom2tYCah65W48GEmfiFfS5JD7Jn8PpIPboEnB/W1IBisXC7P9 uTbQF3cEVq3m9IYIN+KgrHP5w5sTfq75XF5UbsYHtTd7ayE77p/bGW0DUrQCtvTShM xjZp5uL2y18MAUmrsVxSuw8sFeukp2jzVzaEsmXnyqb+saimFzZozKxdS6lxXkP/tm viZTxhdf5BcYg== Date: Sun, 24 Dec 2023 18:00:12 +0000 From: lgcoelho@disroot.org Message-ID: <1dff17d3ef7bbc11c17b7e614cc96f16@disroot.org> X-Sender: lgcoelho@disroot.org Content-Type: multipart/mixed; boundary="=_3f7ca0519060c03fabba0ba956a7ab75" Received-SPF: pass client-ip=178.21.23.139; envelope-from=lgcoelho@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=_3f7ca0519060c03fabba0ba956a7ab75 Content-Type: multipart/alternative; boundary="=_1f5d5a58bea1160a4f56dd21189e9fbc" --=_1f5d5a58bea1160a4f56dd21189e9fbc Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Current home-xdg-user-directories-service-type creates a ~/.config/user-dirs.dirs which some non posix-compliant shells like fish aren't able to read, this makes necessary to use some external tool like fish-foreign-env, but this solution makes fish startup times really slower in the case fish sources it in a non-login shell. After thinking about it for a bit, I guess it would be proper if guix itself was responsible for setting these environment variables. This could avoid the need for users of other non-posix shells to make their own custom workarounds for this problem. --=_1f5d5a58bea1160a4f56dd21189e9fbc Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Current home-xdg-user-directories-service-type creates a ~/.config/user-= dirs.dirs which some non posix-compliant shells like fish aren't able to re= ad, this makes necessary to use some external tool like fish-foreign-env, b= ut this solution makes fish startup times really slower in the case fish so= urces it in a non-login shell.
After thinking about it for a bit, I gu= ess it would be proper if guix itself was responsible for setting these env= ironment variables. This could avoid the need for users of other non-posix = shells to make their own custom workarounds for this problem.

--=_1f5d5a58bea1160a4f56dd21189e9fbc-- --=_3f7ca0519060c03fabba0ba956a7ab75 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-home-xdg-user-directories-service-type-Extend-it-wit.patch Content-Disposition: attachment; filename=0001-home-xdg-user-directories-service-type-Extend-it-wit.patch; size=2192 RnJvbSBmOTE1ZjA4YzE2NmZmZGVhYWRmZGQyNDM4YTY2ZDhkMGQzNDAxNjI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWlzIEd1aWxoZXJtZSBDb2VsaG8gPGxnY29lbGhvQGRpc3Jv b3Qub3JnPgpEYXRlOiBTdW4sIDI0IERlYyAyMDIzIDE0OjQzOjM4IC0wMzAwClN1YmplY3Q6IFtQ QVRDSF0gaG9tZS14ZGctdXNlci1kaXJlY3Rvcmllcy1zZXJ2aWNlLXR5cGU6IEV4dGVuZCBpdCB3 aXRoCiBob21lLWVudmlyb25tZW50LXNlcnZpY2UtdHlwZQoKLS0tCiBnbnUvaG9tZS9zZXJ2aWNl cy94ZGcuc2NtIHwgMTYgKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDE2IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvaG9tZS9zZXJ2aWNlcy94ZGcuc2NtIGIvZ251L2hv bWUvc2VydmljZXMveGRnLnNjbQppbmRleCA5NTg3NzI2OTZiLi5lMTQ4NzBkZjA1IDEwMDY0NAot LS0gYS9nbnUvaG9tZS9zZXJ2aWNlcy94ZGcuc2NtCisrKyBiL2dudS9ob21lL3NlcnZpY2VzL3hk Zy5zY20KQEAgLTIsNiArMiw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMjEsIDIwMjIgQW5kcmV3 IFRyb3BpbiA8YW5kcmV3QHRyb3AuaW4+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjEgWGluZ2x1IENo ZW4gPHB1YmxpY0B5b2N0b2NlbGwueHl6PgogOzs7IENvcHlyaWdodCDCqSAyMDIzIEJydW5vIFZp Y3RhbCA8bWlyYWlAbWFraW5hdGEuZXU+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjMgTHVpcyBHdWls aGVybWUgQ29lbGhvIDxsZ2NvZWxob0BkaXNyb290Lm9yZz4KIDs7OwogOzs7IFRoaXMgZmlsZSBp cyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0yNTYsMTIgKzI1NywyNyBAQCAoZGVmaW5lICho b21lLXhkZy11c2VyLWRpcmVjdG9yaWVzLWFjdGl2YXRpb24tc2VydmljZSBjb25maWcpCiAgICAg ICAgIChtYXAgZW5zdXJlLWRpciAnIyRkaXJzKQogICAgICAgICAoZGlzcGxheSAiIGRvbmVcbiIp KSkpCiAKKyhkZWZpbmUgKGhvbWUteGRnLXVzZXItZGlyZWN0b3JpZXMtZW52aXJvbm1lbnQtdmFy aWFibGVzLXNlcnZpY2UgY29uZmlnKQorICAobWF0Y2gtcmVjb3JkIGNvbmZpZyA8aG9tZS14ZGct dXNlci1kaXJlY3Rvcmllcy1jb25maWd1cmF0aW9uPgorICAgIChkZXNrdG9wIGRvY3VtZW50cyBt dXNpYyBwaWN0dXJlcyB2aWRlb3MgcHVibGljc2hhcmUgZG93bmxvYWQgdGVtcGxhdGVzKQorICAg IGAoKCJYREdfREVTS1RPUF9ESVIiIC4gLGRlc2t0b3ApCisgICAgICAoIlhER19ET0NVTUVOVFNf RElSIiAuICxkb2N1bWVudHMpCisgICAgICAoIlhER19ET1dOTE9BRF9ESVIiIC4gLGRvd25sb2Fk KQorICAgICAgKCJYREdfTVVTSUNfRElSIiAuICxtdXNpYykKKyAgICAgICgiWERHX1BJQ1RVUkVT X0RJUiIgLiAscGljdHVyZXMpCisgICAgICAoIlhER19QVUJMSUNTSEFSRV9ESVIiIC4gLHB1Ymxp Y3NoYXJlKQorICAgICAgKCJYREdfVEVNUExBVEVTX0RJUiIgLiAsdGVtcGxhdGVzKQorICAgICAg KCJYREdfVklERU9TX0RJUiIgLiAsdmlkZW9zKSkpKQorCiAoZGVmaW5lIGhvbWUteGRnLXVzZXIt ZGlyZWN0b3JpZXMtc2VydmljZS10eXBlCiAgIChzZXJ2aWNlLXR5cGUgKG5hbWUgJ2hvbWUteGRn LXVzZXItZGlyZWN0b3JpZXMpCiAgICAgICAgICAgICAgICAgKGV4dGVuc2lvbnMKICAgICAgICAg ICAgICAgICAgKGxpc3QgKHNlcnZpY2UtZXh0ZW5zaW9uCiAgICAgICAgICAgICAgICAgICAgICAg ICBob21lLXhkZy1jb25maWd1cmF0aW9uLWZpbGVzLXNlcnZpY2UtdHlwZQogICAgICAgICAgICAg ICAgICAgICAgICAgaG9tZS14ZGctdXNlci1kaXJlY3Rvcmllcy1maWxlcy1zZXJ2aWNlKQorICAg ICAgICAgICAgICAgICAgICAgICAoc2VydmljZS1leHRlbnNpb24KKyAgICAgICAgICAgICAgICAg ICAgICAgIGhvbWUtZW52aXJvbm1lbnQtdmFyaWFibGVzLXNlcnZpY2UtdHlwZQorICAgICAgICAg ICAgICAgICAgICAgICAgaG9tZS14ZGctdXNlci1kaXJlY3Rvcmllcy1lbnZpcm9ubWVudC12YXJp YWJsZXMtc2VydmljZSkKICAgICAgICAgICAgICAgICAgICAgICAgKHNlcnZpY2UtZXh0ZW5zaW9u CiAgICAgICAgICAgICAgICAgICAgICAgICBob21lLWFjdGl2YXRpb24tc2VydmljZS10eXBlCiAg ICAgICAgICAgICAgICAgICAgICAgICBob21lLXhkZy11c2VyLWRpcmVjdG9yaWVzLWFjdGl2YXRp b24tc2VydmljZSkpKQotLSAKMi40MS4wCgo= --=_3f7ca0519060c03fabba0ba956a7ab75--