GNU bug report logs - #6799
24.0.50; Please add dired-details.el to Emacs [patch]

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 6799 <at> debbugs.gnu.org
Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch]
Date: Sun, 10 Feb 2013 22:37:53 -0500

> Here is the final patch.  Drew Adams and Michael Heerdegen tested it and
> did not find any problems.

Thanks.  A few nitpicks and comments below.

> +  ;; ignore dired-hide-details-* value of invisible text property by default
> +  (when (eq buffer-invisibility-spec t)
> +    (setq buffer-invisibility-spec (list t)))

Please capitalize and punctuate your comments.

>    (forward-line arg)
> +  (while (and (progn
> +		(while (and (< arg 0)
> +			    (bolp)
> +			    (/= (1+ (point)) (point-max))
> +			    (eq (get-text-property (1+ (point)) 'invisible)
> +				'dired-hide-details-information))
> +		  (forward-char -1))
> +		(invisible-p (point)))
> +	      (let ((p (funcall (if (> arg 0)
> +				    'next-single-property-change
> +				  'previous-single-property-change)
> +				(point)
> +				'invisible)))
> +		(when p
> +		  (goto-char p)
> +		  t))))
>    (dired-move-to-filename))

What is this for?

> +  (if (derived-mode-p 'locate-mode)
> +      (setq dired-hide-details-mode nil)

Could you explain why locate-mode needs such special treatment (here and
in locate-mode-map)?  I'm mostly worried here that maybe some other mode
might require similar treatment.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.