From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Aug 2010 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org Cc: 'Rob Giardina' X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.128102031911674 (code B ref -1); Thu, 05 Aug 2010 14:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Aug 2010 14:58:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oh1u3-00032F-7j for submit@debbugs.gnu.org; Thu, 05 Aug 2010 10:58:39 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oh1u0-00031w-GW for submit@debbugs.gnu.org; Thu, 05 Aug 2010 10:58:37 -0400 Received: from lists.gnu.org ([199.232.76.165]:58372) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Oh1uU-0001Ee-1K for submit@debbugs.gnu.org; Thu, 05 Aug 2010 10:59:06 -0400 Received: from [140.186.70.92] (port=52754 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oh1uL-0006or-DF for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2010 10:59:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oh1uD-0000g1-C4 for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2010 10:58:56 -0400 Received: from rcsinet14.oracle.com ([148.87.113.126]:21846) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oh1uC-0000fC-Ue for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2010 10:58:49 -0400 Received: from rcsinet10.oracle.com (rcsinet10.oracle.com [148.87.113.121]) by rcsinet14.oracle.com (Sentrion-MP-4.0.0/Sentrion-MP-4.0.0) with ESMTP id o75ELPuR007920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Aug 2010 14:21:25 GMT Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o75EKpAf003137 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Aug 2010 14:20:53 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o759ePi1012842; Thu, 5 Aug 2010 14:20:40 GMT Received: from abhmt005.oracle.com by acsmt353.oracle.com with ESMTP id 469184311281018037; Thu, 05 Aug 2010 07:20:37 -0700 Received: from dradamslap1 (/10.159.243.64) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Aug 2010 07:20:37 -0700 From: "Drew Adams" Date: Thu, 5 Aug 2010 07:20:38 -0700 Message-ID: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acs0qWCEIES3+bsXQyuhFnMTUCfaOw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4C5AC8BA.0084:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-08-02 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags = -Ic:/xpm/include' --- Per Juanma's request, this is a another reminder to please add `dired-details.el', with links to the threads that reference Rob = Giardino's patches. -------------------------------------- > From: Juanma Barranquero Sent: Thursday, August 05, 2010 3:19 AM > To: help-gnu-emacs@gnu.org Subject: Re: A "smaller" dired >=20 > On Wed, Aug 4, 2010 at 17:50, Drew Adams wrote > > > [FWIW - This feature was OK'd for addition to vanilla Emacs=20 > > a few years ago, but no one has bothered to add it. > > =A0The author of dired-details.el and myself tried > > several times to get past the inertia, but to no avail so far.] >=20 > A patch, or at least a reminder, to the bug list with a wishlist tag > would help IMO. -------------------------------------- > From: Drew Adams Sent: Sunday, July 19, 2009 7:34 AM > To: emacs-devel@gnu.org Subject: RE: dired-details[+].el >=20 > > I discovered dired-details and dired-details+ and found them useful. > > Could they be added to emacs? > >=20 > > http://www.emacswiki.org/emacs/DiredDetails >=20 > They were supposed to be added. Rob Giardina submitted an=20 > Emacs 23 patch two > years ago that integrates the functionality of both in a=20 > better way even than > the separate libraries dired-details[+].el.=20 >=20 > I don't think any reason was ever given for why the patch=20 > wasn't incorporated > (committed). RMS asked for comment on the merged code, but no=20 > one ever answered > his request (on emacs-devel, at least). The last time I=20 > ping'ed the list about > this was 2008-07 - I never got an answer either. >=20 > Last ping: > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg01152.html >=20 > Rob's change log and RMS's call for comment: > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg01187.html >=20 > Original thread: > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00226.html From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jan 2011 23:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: <6799@debbugs.gnu.org> Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.129625567227732 (code B ref 6799); Fri, 28 Jan 2011 23:02:01 +0000 Received: (at 6799) by debbugs.gnu.org; 28 Jan 2011 23:01:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PixJX-0007DF-OY for submit@debbugs.gnu.org; Fri, 28 Jan 2011 18:01:11 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PixJV-0007D2-N1 for 6799@debbugs.gnu.org; Fri, 28 Jan 2011 18:01:10 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p0SN9KGg025921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <6799@debbugs.gnu.org>; Fri, 28 Jan 2011 23:09:22 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p0SN9K6n005122 for <6799@debbugs.gnu.org>; Fri, 28 Jan 2011 23:09:20 GMT Received: from abhmt003.oracle.com by acsmt353.oracle.com with ESMTP id 1003891251296256102; Fri, 28 Jan 2011 15:08:22 -0800 Received: from dradamslap1 (/10.159.48.205) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 28 Jan 2011 15:08:21 -0800 From: "Drew Adams" References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> Date: Fri, 28 Jan 2011 15:08:18 -0800 Message-ID: <5EA47A0255F8494DB430B52D46876641@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> Thread-Index: Acs0qWCEIES3+bsXQyuhFnMTUCfaOyKlngCQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) PING This code has been agreed to since RMS was in charge, and it was made = available (integrated) by Rob Giardina - years ago. What's the story? > Per Juanma's request, this is a another reminder to please add > `dired-details.el', with links to the threads that reference=20 > Rob Giardino's patches. >=20 > > From: Juanma Barranquero Sent: Thursday, August 05, 2010 3:19 AM > > To: help-gnu-emacs@gnu.org Subject: Re: A "smaller" dired > >=20 > > > [FWIW - This feature was OK'd for addition to vanilla Emacs=20 > > > a few years ago, but no one has bothered to add it. > > > =A0The author of dired-details.el and myself tried > > > several times to get past the inertia, but to no avail so far.] > >=20 > > A patch, or at least a reminder, to the bug list with a wishlist tag > > would help IMO. From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Mar 2011 03:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: 6799@debbugs.gnu.org Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.129998692817242 (code B ref 6799); Sun, 13 Mar 2011 03:29:01 +0000 Received: (at 6799) by debbugs.gnu.org; 13 Mar 2011 03:28:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pybz6-0004U3-IS for submit@debbugs.gnu.org; Sat, 12 Mar 2011 22:28:48 -0500 Received: from mail-yi0-f44.google.com ([209.85.218.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pybz5-0004Ts-IS for 6799@debbugs.gnu.org; Sat, 12 Mar 2011 22:28:48 -0500 Received: by yic13 with SMTP id 13so1760382yic.3 for <6799@debbugs.gnu.org>; Sat, 12 Mar 2011 19:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=epDE2FPDbDtcpnBeDVO1+60xC8zV8bFGful+Za+N1gk=; b=O1EicaA78a0AdEd3Ex6NBaVPofvwA/DOyuQFAY2nEu4s+uK54GesPnTqsaupGOv+W5 UsC8c8pUtNR9g/7uYetBV5N0JWHdCoD7eU9tm1y9Wcfy9GbxF5D9KSCQq758LetDbJwL 2raZbAzcI7WcTUWQxpbi9PWGVOLVYuPcMW628= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=guyNqFuq6WDQMA9fVZyQQFYXQ7nZXHfiAjzAqSET/Ep3lOOkXJENyjoqE8sjVwXRYQ hoHDVIn1eOpRJ3+Guy/YqUgAF1hxIaoccdEK0dah2Nwtvqon1Ynjqi+5BuNVgI5Lf4n3 rnAuHUg2T0UT9ktrUiVD2KccBKI1XbDKVOLfk= Received: by 10.146.225.29 with SMTP id x29mr15953818yag.29.1299986922116; Sat, 12 Mar 2011 19:28:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.147.137.2 with HTTP; Sat, 12 Mar 2011 19:28:02 -0800 (PST) In-Reply-To: <5EA47A0255F8494DB430B52D46876641@us.oracle.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> From: Juanma Barranquero Date: Sun, 13 Mar 2011 04:28:02 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.2 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) On Sat, Jan 29, 2011 at 00:08, Drew Adams wrote: > PING > > This code has been agreed to since RMS was in charge, and it was made ava= ilable > (integrated) by Rob Giardina - years ago. =C2=A0What's the story? Let's move this forward. Which was the intention, adding dired-details.el, or patching dired.el to add the functionality? =C2=A0 =C2=A0 Juanma From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Mar 2011 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Juanma Barranquero'" Cc: 6799@debbugs.gnu.org Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.130003552026213 (code B ref 6799); Sun, 13 Mar 2011 16:59:02 +0000 Received: (at 6799) by debbugs.gnu.org; 13 Mar 2011 16:58:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pyocp-0006oi-5U for submit@debbugs.gnu.org; Sun, 13 Mar 2011 12:58:39 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pyocn-0006oW-To for 6799@debbugs.gnu.org; Sun, 13 Mar 2011 12:58:38 -0400 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p2DGwVL5007898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 13 Mar 2011 16:58:32 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p2DGwURE005440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 13 Mar 2011 16:58:30 GMT Received: from abhmt021.oracle.com (abhmt021.oracle.com [141.146.116.30]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p2DGwUUJ000791; Sun, 13 Mar 2011 11:58:30 -0500 Received: from dradamslap1 (/10.159.54.128) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 13 Mar 2011 09:58:29 -0700 From: "Drew Adams" References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> Date: Sun, 13 Mar 2011 09:58:27 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 Thread-Index: AcvhLsFrD+yLU0bTQRK72sBVfuggewAb9YNg X-Source-IP: acsmt357.oracle.com [141.146.40.157] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4D7CF7B7.005D,ss=1,fgs=0 X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > wrote: > > PING > > > > This code has been agreed to since RMS was in charge, and=20 > > it was made available (integrated) by Rob Giardina - years ago. > >=A0What's the story? >=20 > Let's move this forward. >=20 > Which was the intention, adding dired-details.el, or patching dired.el > to add the functionality? Please contact Rob Giardina. I believe that he patched the existing = Dired code (and some C code? and some other Lisp code?), doing everything that was = needed. Dunno what his current address is. Here are some that have worked in = the past: rob razoo com rob giardina gmail com rob giardina us From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2012 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Drew Adams" Cc: 'Juanma Barranquero' , 6799@debbugs.gnu.org Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.13342579441474 (code B ref 6799); Thu, 12 Apr 2012 19:13:02 +0000 Received: (at 6799) by debbugs.gnu.org; 12 Apr 2012 19:12:24 +0000 Received: from localhost ([127.0.0.1]:54743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPRQ-0000Nj-4X for submit@debbugs.gnu.org; Thu, 12 Apr 2012 15:12:24 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:45865) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIPRM-0000Nb-U3 for 6799@debbugs.gnu.org; Thu, 12 Apr 2012 15:12:22 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SIPQ4-0007ky-LA; Thu, 12 Apr 2012 21:11:00 +0200 From: Lars Magne Ingebrigtsen References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> X-Now-Playing: His Name Is Alive's _ECLIPX_: "For Davin" Date: Thu, 12 Apr 2012 21:10:59 +0200 In-Reply-To: (Drew Adams's message of "Sun, 13 Mar 2011 09:58:27 -0700") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SIPQ4-0007ky-LA X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334862660.77355@xxxiYXSDz27LenFII5aZzg X-Spam-Status: No X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) "Drew Adams" writes: > Please contact Rob Giardina. I believe that he patched the existing > Dired code (and some C code? and some other Lisp code?), doing > everything that was needed. > > Dunno what his current address is. Here are some that have worked in > the past: > > rob razoo com > rob giardina gmail com > rob giardina us If you want this code included in Emacs, please assemble the patch and post it here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2012 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Lars Magne Ingebrigtsen'" Cc: 'Juanma Barranquero' , 6799@debbugs.gnu.org, rob@giardina.us Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.133426118812841 (code B ref 6799); Thu, 12 Apr 2012 20:07:01 +0000 Received: (at 6799) by debbugs.gnu.org; 12 Apr 2012 20:06:28 +0000 Received: from localhost ([127.0.0.1]:54894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIQHj-0003L4-KZ for submit@debbugs.gnu.org; Thu, 12 Apr 2012 16:06:28 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:51008) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIQHg-0003Ku-VQ for 6799@debbugs.gnu.org; Thu, 12 Apr 2012 16:06:26 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3CK58xC018944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Apr 2012 20:05:09 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3CK57rt027282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 12 Apr 2012 20:05:08 GMT Received: from abhmt101.oracle.com (abhmt101.oracle.com [141.146.116.53]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3CK57ux002210; Thu, 12 Apr 2012 15:05:07 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Apr 2012 13:05:07 -0700 From: "Drew Adams" References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com><5EA47A0255F8494DB430B52D46876641@us.oracle.com> Date: Thu, 12 Apr 2012 13:05:06 -0700 Message-ID: <65D921448B0644988BE6445A2EF3E021@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac0Y4EANspXe4sJPTQeVD8GUhihEggABA/3w X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-CT-RefId: str=0001.0A090209.4F873575.008E,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) As I have said several times now, ask Rob Giardina. He made a whole set of changes to various Emacs files, including perhaps C code. I am not aware of what changes he made. Rob has sent mail as recently as 2011/11/29 to emacs-orgmode@gnu.org. His address for that was rob@giardina.us. (No, I do not subscribe to that mailing list. But I know how to use Google.) Please contact Rob. > > Please contact Rob Giardina. I believe that he patched the existing > > Dired code (and some C code? and some other Lisp code?), doing > > everything that was needed. > > If you want this code included in Emacs, please assemble the patch and > post it here. It is not a question of "if I want". It was decided by RMS that this should be included in Emacs. Long, long ago. Rob did the work required for this to happen, but no one ever committed it, AFAIK. What I use, personally, is dired-details.el plus dired-details+.el, and they suffice. But Rob went to the trouble of patching Emacs in various places, integrating the features cleanly at a more basic level etc. I have no idea what Rob's changes were, but if you search the mailing list perhaps you can find references to them. Rob refers to a patch for 2005-07-07 CVS, here: http://comments.gmane.org/gmane.emacs.devel/74172 Here is the last mail from Rob on the subject, AFAIK: http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00215.html Here is my last mail on the subject, with relevant links: > From: Drew Adams Sent: Sunday, July 19, 2009 7:34 AM > > I discovered dired-details and dired-details+ and found them useful. > > Could they be added to emacs? > > > > http://www.emacswiki.org/emacs/DiredDetails > > They were supposed to be added. Rob Giardina submitted an > Emacs 23 patch two years ago that integrates the functionality > of both in a better way even than the separate libraries > dired-details[+].el. > > I don't think any reason was ever given for why the patch > wasn't incorporated (committed). RMS asked for comment on > the merged code, but no one ever answered his request > (on emacs-devel, at least). The last time I ping'ed the > list about this was 2008-07 - I never got an answer either. > > Last ping: > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg01152.html > > Rob's change log and RMS's call for comment: > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg01187.html > > Original thread: > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00226.html From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Rob Giardina Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Apr 2012 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: Juanma Barranquero , Lars Magne Ingebrigtsen , 6799@debbugs.gnu.org Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.133537005315881 (code B ref 6799); Wed, 25 Apr 2012 16:08:02 +0000 Received: (at 6799) by debbugs.gnu.org; 25 Apr 2012 16:07:33 +0000 Received: from localhost ([127.0.0.1]:52913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SN4kd-000484-9Q for submit@debbugs.gnu.org; Wed, 25 Apr 2012 12:07:32 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]:48552) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SN4Rt-0003fh-6u for 6799@debbugs.gnu.org; Wed, 25 Apr 2012 11:48:10 -0400 Received: by yhkk25 with SMTP id k25so221230yhk.3 for <6799@debbugs.gnu.org>; Wed, 25 Apr 2012 08:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=264dKau+DMc2J5TexiGE/15wMFVlWzoaFDYtY1PoPxM=; b=jEstjCJ6nLE7nq+ItkPU1STZvFrBU9nkAkPMKd4jeibdnr0mgIwc3NTJ6QvsCIP8RQ gayqZ06wD4aFT35hRSX0AIIlCVrh0rbQBvKqqqQzRAmhV3ECsIf2knvdNY6WdaV6enYT FSrFPmpMV/+sV9VFQhXGG62gXyjOT1VTYJ17Yrz9uy46VwOnGxcxGCzmabp/FwyLDhh+ 7gwGMjhs+x3YIVunBZN0vtpwYHd4H9YhaG0mcd6Yt75jooXAmbCp/nPMUV7DGdEw55U+ 1rn889AvuRPwEFJhPUHE0zoSzaXNwkZkC1hv3/n4Mh7OphDI327FPaxtRrg+rDKVn0JN Pmww== Received: by 10.236.113.106 with SMTP id z70mr2966529yhg.72.1335368830001; Wed, 25 Apr 2012 08:47:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.34.196 with HTTP; Wed, 25 Apr 2012 08:46:46 -0700 (PDT) In-Reply-To: <65D921448B0644988BE6445A2EF3E021@us.oracle.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> From: Rob Giardina Date: Wed, 25 Apr 2012 11:46:46 -0400 X-Google-Sender-Auth: 3GPONq6vcF4Xc-NHz5eE9QJlka8 Message-ID: Content-Type: multipart/mixed; boundary=20cf3011e06fc1a2ac04be82c8a3 X-Spam-Score: -2.6 (--) X-Mailman-Approved-At: Wed, 25 Apr 2012 12:07:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --20cf3011e06fc1a2ac04be82c8a3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks for remembering this patch Drew. I did work with RMS a long way back but it fell by the wayside in the last phases. The patch is just elisp and doc, no C. The changes are pretty simple and contain all the community enhancements added later (dired-details+). Basically, it adds some bindings to a few functions that will loop over the dired file listing lines to add invisibile overlays to the messiest parts of the lines. Pretty self-contained. It would have to be re-tested at this point. I've attached the old ones if it will help decide if you want the feature. I can test some fresh patches on HEAD in the next few weeks when my biz/personal life calms a bit. Regards, Rob On Thu, Apr 12, 2012 at 4:05 PM, Drew Adams wrote: > > As I have said several times now, ask Rob Giardina. =A0He made a whole se= t of > changes to various Emacs files, including perhaps C code. =A0I am not awa= re of > what changes he made. > > Rob has sent mail as recently as 2011/11/29 to emacs-orgmode@gnu.org. =A0= His > address for that was rob@giardina.us. =A0(No, I do not subscribe to that = mailing > list. =A0But I know how to use Google.) =A0Please contact Rob. > > > > Please contact Rob Giardina. =A0I believe that he patched the existin= g > > > Dired code (and some C code? and some other Lisp code?), doing > > > everything that was needed. > > > > If you want this code included in Emacs, please assemble the patch and > > post it here. > > It is not a question of "if I want". =A0It was decided by RMS that this s= hould be > included in Emacs. =A0Long, long ago. =A0Rob did the work required for th= is to > happen, but no one ever committed it, AFAIK. > > What I use, personally, is dired-details.el plus dired-details+.el, and t= hey > suffice. =A0But Rob went to the trouble of patching Emacs in various plac= es, > integrating the features cleanly at a more basic level etc. > > I have no idea what Rob's changes were, but if you search the mailing lis= t > perhaps you can find references to them. =A0Rob refers to a patch for 200= 5-07-07 > CVS, here: > http://comments.gmane.org/gmane.emacs.devel/74172 > > Here is the last mail from Rob on the subject, AFAIK: > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00215.html > > Here is my last mail on the subject, with relevant links: > > > From: Drew Adams Sent: Sunday, July 19, 2009 7:34 AM > > > I discovered dired-details and dired-details+ and found them useful. > > > Could they be added to emacs? > > > > > > http://www.emacswiki.org/emacs/DiredDetails > > > > They were supposed to be added. Rob Giardina submitted an > > Emacs 23 patch two years ago that integrates the functionality > > of both in a better way even than the separate libraries > > dired-details[+].el. > > > > I don't think any reason was ever given for why the patch > > wasn't incorporated (committed). RMS asked for comment on > > the merged code, but no one ever answered his request > > (on emacs-devel, at least). The last time I ping'ed the > > list about this was 2008-07 - I never got an answer either. > > > > Last ping: > > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg01152.html > > > > Rob's change log and RMS's call for comment: > > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg01187.html > > > > Original thread: > > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00226.html > --20cf3011e06fc1a2ac04be82c8a3 Content-Type: application/octet-stream; name="dired-x.el.patch" Content-Disposition: attachment; filename="dired-x.el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h1gk3ejr0 KioqIG9sZC9kaXJlZC14LmVsCVN1biBKdWwgMTUgMjE6MjU6MzcgMjAwNwotLS0gbmV3L2RpcmVk LXguZWwJU3VuIEp1bCAxNSAyMjowMDoyMyAyMDA3CioqKioqKioqKioqKioqKgoqKiogNzU1LDc2 MSAqKioqCiAgICAoc2V0IChtYWtlLWxvY2FsLXZhcmlhYmxlICdkaXJlZC1zdWJkaXItYWxpc3Qp IG5pbCkKICAgIChkaXJlZC1idWlsZC1zdWJkaXItYWxpc3QpCiAgICAoZ290by1jaGFyIChwb2lu dC1taW4pKQohICAgKGRpcmVkLWluaXRpYWwtcG9zaXRpb24gZGlybmFtZSkpCiAgCiAgKGRlZnVu IGRpcmVkLXZpcnR1YWwtZ3Vlc3MtZGlyICgpCiAgICAiR3Vlc3MgYW5kIHJldHVybiBhcHByb3By aWF0ZSB3b3JraW5nIGRpcmVjdG9yeSBvZiB0aGlzIGJ1ZmZlci4KLS0tIDc1NSw3NjIgLS0tLQog ICAgKHNldCAobWFrZS1sb2NhbC12YXJpYWJsZSAnZGlyZWQtc3ViZGlyLWFsaXN0KSBuaWwpCiAg ICAoZGlyZWQtYnVpbGQtc3ViZGlyLWFsaXN0KQogICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkK ISAgIChkaXJlZC1pbml0aWFsLXBvc2l0aW9uIGRpcm5hbWUpCiEgICAocnVuLWhvb2tzICdkaXJl ZC1hZnRlci1yZWFkaW4taG9vaykpCiAgCiAgKGRlZnVuIGRpcmVkLXZpcnR1YWwtZ3Vlc3MtZGly ICgpCiAgICAiR3Vlc3MgYW5kIHJldHVybiBhcHByb3ByaWF0ZSB3b3JraW5nIGRpcmVjdG9yeSBv ZiB0aGlzIGJ1ZmZlci4K --20cf3011e06fc1a2ac04be82c8a3 Content-Type: application/octet-stream; name="dired.el.patch" Content-Disposition: attachment; filename="dired.el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h1gk3ejv1 KioqIG9sZC9kaXJlZC5lbAlTdW4gSnVsIDE1IDE1OjQyOjMzIDIwMDcKLS0tIG5ldy9kaXJlZC5l bAlTdW4gSnVsIDE1IDIxOjE5OjQ0IDIwMDcKKioqKioqKioqKioqKioqCioqKiAxMDQyLDEwNDcg KioqKgotLS0gMTA0MiwxMDQ4IC0tLS0KICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKICAg ICAgKHNldHEgbWFyay1hbGlzdDs7IG9ubHkgYWZ0ZXIgZGlyZWQtcmVtZW1iZXItaGlkZGVuIHNp bmNlIHRoaXMgdW5oaWRlczoKICAJICAoZGlyZWQtcmVtZW1iZXItbWFya3MgKHBvaW50LW1pbikg KHBvaW50LW1heCkpKQorICAgICAoZGlyZWQtZGV0YWlscy1kZWxldGUtb3ZlcmxheXMpIDs7ZGl0 Y2ggdGhlIGVudGlyZSBvdmVybGF5IGNhY2hlCiAgICAgIDs7IHRyZWF0IHRvcCBsZXZlbCBkaXIg ZXh0cmEgKGl0IG1heSBjb250YWluIHdpbGRjYXJkcykKICAgICAgKGRpcmVkLXVuY2FjaGUKICAg ICAgIChpZiAoY29uc3AgZGlyZWQtZGlyZWN0b3J5KSAoY2FyIGRpcmVkLWRpcmVjdG9yeSkgZGly ZWQtZGlyZWN0b3J5KSkKKioqKioqKioqKioqKioqCioqKiAxMjQyLDEyNDcgKioqKgotLS0gMTI0 MywxMjUxIC0tLS0KICAgICAgKGRlZmluZS1rZXkgbWFwICJcQy1uIiAnZGlyZWQtbmV4dC1saW5l KQogICAgICAoZGVmaW5lLWtleSBtYXAgIlxDLXAiICdkaXJlZC1wcmV2aW91cy1saW5lKQogICAg ICAoZGVmaW5lLWtleSBtYXAgW2Rvd25dICdkaXJlZC1uZXh0LWxpbmUpCisgICAgIChkZWZpbmUt a2V5IG1hcCAiKCIgJ2RpcmVkLWRldGFpbHMtaGlkZSkKKyAgICAgKGRlZmluZS1rZXkgbWFwICIp IiAnZGlyZWQtZGV0YWlscy1zaG93KQorICAgICAoZGVmaW5lLWtleSBtYXAgIjsiICdkaXJlZC1k ZXRhaWxzLXRvZ2dsZSkKICAgICAgKGRlZmluZS1rZXkgbWFwIFt1cF0gJ2RpcmVkLXByZXZpb3Vz LWxpbmUpCiAgICAgIDs7IGhpZGluZwogICAgICAoZGVmaW5lLWtleSBtYXAgIiQiICdkaXJlZC1o aWRlLXN1YmRpcikKKioqKioqKioqKioqKioqCioqKiAzMzM0LDMzMzkgKioqKgotLS0gMzMzOCwz NTA4IC0tLS0KICAJICAgICAnKGRpcmVkLW1vZGUgLiBkaXJlZC1yZXN0b3JlLWRlc2t0b3AtYnVm ZmVyKSkKICAKICAMCisgOzs7IG9wdGlvbmFsbHkgaGlkZSBmaWxlIGRldGFpbHMgYW5kIGxpbmsg dGFyZ2V0cworIAorIChkZWZncm91cCBkaXJlZC1kZXRhaWxzIG5pbAorICAgIlNldHRpbmdzIGZv ciB0byBoaWRlIGZpbGUgZGV0YWlscyBhbmQgc3ltYm9saWMgbGluayB0YXJnZXRzLiIKKyAgIDpn cm91cCAnZGlyZWQKKyAgIDpwcmVmaXggImRpcmVkLWRldGFpbHMtIikKKyAKKyAoZGVmY3VzdG9t IGRpcmVkLWRldGFpbHMtaGlkZGVuLXN0cmluZyAiWy4uLl0iCisgICAiKlRoaXMgc3RyaW5nIHdp bGwgYmUgc2hvd24gaW4gcGxhY2Ugb2YgZmlsZSBkZXRhaWxzIGFuZCBzeW1ib2xpYyBsaW5rcy4i CisgICA6Z3JvdXAgJ2RpcmVkLWRldGFpbHMKKyAgIDp0eXBlICdzdHJpbmcpCisgCisgKGRlZmN1 c3RvbSBkaXJlZC1kZXRhaWxzLWhpZGUtbGluay10YXJnZXRzIHQKKyAgICIqSGlkZSBzeW1ib2xp YyBsaW5rIHRhcmdldCBwYXRocy4iCisgICA6Z3JvdXAgJ2RpcmVkLWRldGFpbHMKKyAgIDp0eXBl ICdib29sZWFuKQorIAorIChkZWZjdXN0b20gZGlyZWQtZGV0YWlscy1pbml0aWFsbHktaGlkZSBu aWwKKyAgICIqSGlkZSBkaXJlZCBkZXRhaWxzIG9uIGVudHJ5IHRvIGRpcmVkIGJ1ZmZlcnMuIgor ICAgOmdyb3VwICdkaXJlZC1kZXRhaWxzCisgICA6dHlwZSAnYm9vbGVhbikKKyAKKyAoZGVmdmFy IGRpcmVkLWRldGFpbHMtaW50ZXJuYWwtb3ZlcmxheS1jYWNoZSBuaWwpCisgKG1ha2UtdmFyaWFi bGUtYnVmZmVyLWxvY2FsICdkaXJlZC1kZXRhaWxzLWludGVybmFsLW92ZXJsYXktY2FjaGUpCisg CisgKGRlZnZhciBkaXJlZC1kZXRhaWxzLXN0YXRlIG5pbAorICAgIlRocmVlIHBvc3NpYmxlIHZh bHVlczogbmlsIChoYXMgbm90IGJlZW4gc2V0KSwgJ2hpZGRlbiAoZGV0YWlscyBhcmUKKyBoaWRk ZW4pLCAnc2hvd24gKGRldGFpbHMgYXJlIHZpc2libGUpLiIpCisgKG1ha2UtdmFyaWFibGUtYnVm ZmVyLWxvY2FsICdkaXJlZC1kZXRhaWxzLXN0YXRlKQorIAorIChkZWZ1biBkaXJlZC1kZXRhaWxz LWFjdGl2YXRlKCkKKyAgICJTZXQgdXAgZGlyZWQtZGV0YWlscyBpbiB0aGUgY3VycmVudCBkaXJl ZCBidWZmZXIuIENhbGxlZCBieQorIGRpcmVkLWFmdGVyLXJlYWRpbi1ob29rIG9uIGluaXRpYWwg ZGlzcGxheSBhbmQgd2hlbiBhIGRpcmVkCisgYnVmZmVyIGlzIG1vZGlmaWVkLiBJZiB0aGUgc3Rh dGUgb2YgZGV0YWlsIGRpc3BsYXkgaGFzIGJlZW4gc2V0CisgaW4gdGhpcyBidWZmZXIgdGhlbiB1 c2UgdGhhdCBzdGF0ZSwgb3RoZXJ3aXNlIHVzZSB0aGUgdmFsdWUgb2YKKyBgZGlyZWQtZGV0YWls cy1pbml0aWFsbHktaGlkZScuIgorICAgKGlmIChlcSAnaGlkZGVuIGRpcmVkLWRldGFpbHMtc3Rh dGUpCisgICAgICAgKGRpcmVkLWRldGFpbHMtaGlkZSkKKyAgICAgICAod2hlbiBkaXJlZC1kZXRh aWxzLWluaXRpYWxseS1oaWRlCisgICAgICAgICAoZGlyZWQtZGV0YWlscy1oaWRlKSkpKQorIChh ZGQtaG9vayAnZGlyZWQtYWZ0ZXItcmVhZGluLWhvb2sgJ2RpcmVkLWRldGFpbHMtYWN0aXZhdGUp CisgCisgKGRlZnVuIGRpcmVkLWRldGFpbHMtZGVsZXRlLW92ZXJsYXlzKCkKKyAgIChkb2xpc3Qg KGRpci1hbmQtb3ZlcmxheXMgZGlyZWQtZGV0YWlscy1pbnRlcm5hbC1vdmVybGF5LWNhY2hlKQor ICAgICAoZG9saXN0IChvdmVybGF5IChjZHIgZGlyLWFuZC1vdmVybGF5cykpCisgICAgICAgKGRl bGV0ZS1vdmVybGF5IG92ZXJsYXkpKSkKKyAgIChzZXRxIGRpcmVkLWRldGFpbHMtaW50ZXJuYWwt b3ZlcmxheS1jYWNoZSBuaWwpKQorIAorIChkZWZ1biBkaXJlZC1kZXRhaWxzLXRvZ2dsZSAoJm9w dGlvbmFsIGFyZyBkZWZhdWx0LXRvbykKKyAgICJUb2dnbGUgdmlzaWJpbGl0eSBvZiBkaXJlZCBk ZXRhaWxzLgorIFdpdGggcG9zaXRpdmUgcHJlZml4IGFyZ3VtZW50IEFSRyBoaWRlIHRoZSBkZXRh aWxzLCB3aXRoIG5lZ2F0aXZlCisgc2hvdyB0aGVtLiIKKyAgIChpbnRlcmFjdGl2ZSAiUCIpCisg ICAobGV0ICgoaGlkZSAoaWYgKG51bGwgYXJnKQorICAgICAgICAgICAgICAgICAgIChub3QgKGVx ICdoaWRkZW4gZGlyZWQtZGV0YWlscy1zdGF0ZSkpCisgICAgICAgICAgICAgICAgICg+IChwcmVm aXgtbnVtZXJpYy12YWx1ZSBhcmcpIDApKSkpCisgICAgIChpZiBkZWZhdWx0LXRvbworICAgICAg ICAgKHNldHEgZGlyZWQtZGV0YWlscy1pbml0aWFsbHktaGlkZSBoaWRlKSkKKyAgICAgKGlmIGhp ZGUgKGRpcmVkLWRldGFpbHMtaGlkZSkKKyAgICAgICAoZGlyZWQtZGV0YWlscy1zaG93KSkpKQor IAorIChkZWZ1biBkaXJlZC1kZXRhaWxzLWhpZGUoKQorICAgIk1ha2UgYW4gaW52aXNpYmxlLCBl dmFwb3JhYmxlIG92ZXJsYXkgZm9yIGVhY2ggdmlzaWJsZSBmaWxlCisgZGV0YWlscyBpbiB0aGlz IGRpcmVkIGJ1ZmZlci4gVGhpcyBpcyBjYWxsZWQgZnJvbQorIGRpcmVkLWFmdGVyLXJlYWRpbi1o b29rIGluIGRpZmZlcmVudCBjb250ZXh0czogKDEpIG5hcnJvd2VkIHRvIGEKKyBzaW5nbGUgZmls ZSAoYWZ0ZXIgY29weSwgbW92ZSwgc3ltbGluayBldGMuKSAgKDIpIG5hcnJvd2VkIHRvIGEKKyBz aW5nbGUgc3ViZGlyIChlLmcuIGFmdGVyIGRpcmVkLWluc2VydC1zdWJkaXIpICgzKSB3aXRoIG11 bHRpcGxlCisgdmlzaWJsZSBzdWJkaXJzIGFuZCBub3QgbmFycm93ZWQgKGUuZy4gYWZ0ZXIgZGly ZWQtcmV2ZXJ0KSIKKyAgIChpbnRlcmFjdGl2ZSkKKyAgICh1bmxlc3MgKG1lbXEgbWFqb3ItbW9k ZSAnKGRpcmVkLW1vZGUgdmMtZGlyZWQtbW9kZSkpCisgICAgIChlcnJvciAiZGlyZWQtZGV0YWls cy1oaWRlIGNhbiBvbmx5IGJlIGNhbGxlZCBpbiBkaXJlZCBtb2RlIikpCisgCisgICAoc2F2ZS1l eGN1cnNpb24KKyAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKKyAgICAgKGlmIChub3QgKGxv b2tpbmctYXQgZGlyZWQtc3ViZGlyLXJlZ2V4cCkpCisgICAgICAgICA7O2Egc2luZ2xlIGZpbGUg b3IgZmlsZXMgLS0ganVzdCBtYWtlIGFuIG92ZXJsYXkgZm9yIGVhY2gKKyAgICAgICAgIChsZXQq ICgocGFyZW50IChkaXJlZC1jdXJyZW50LWRpcmVjdG9yeSkpCisgICAgICAgICAgICAgICAgKGNh Y2hlZC1wYXJlbnQtb3ZlcmxheXMKKyAgICAgICAgICAgICAgICAgKGFzc29jIHBhcmVudCBkaXJl ZC1kZXRhaWxzLWludGVybmFsLW92ZXJsYXktY2FjaGUpKSkKKyAgICAgICAgICAgKHVubGVzcyBj YWNoZWQtcGFyZW50LW92ZXJsYXlzCisgICAgICAgICAgICAgKGVycm9yICJkaXJlZC1kZXRhaWxz IG92ZXJsYXlzIG5vdCBmb3VuZCBmb3IgZGlyZWN0b3J5ICVzIiBwYXJlbnQpKQorICAgICAgICAg ICAoZGlyZWQtZ290by1uZXh0LWZpbGUpCisgICAgICAgICAgICh3aGlsZSAoPCAocG9pbnQpIChw b2ludC1tYXgpKQorICAgICAgICAgICAgIChkaXJlZC1kZXRhaWxzLW1ha2UtY3VycmVudC1saW5l LW92ZXJsYXkgY2FjaGVkLXBhcmVudC1vdmVybGF5cykKKyAgICAgICAgICAgICAoZGlyZWQtbmV4 dC1saW5lIDEpKSkKKyAKKyAgICAgICAgIDs7aGlkZSBlYWNoIHZpc2libGUgc3ViZGlyZWN0b3J5 IChlaXRoZXIgb2YgY2FzZXMgKDIpIG9yICgzKQorICAgICAgICAgOzttZW50aW9uZWQgYWJvdmUp CisgICAgICAgICAoZG9saXN0IChkaXItYW5kLXBvcyBkaXJlZC1zdWJkaXItYWxpc3QpCisgICAg ICAgICAgIChsZXQqICgoZGlyIChjYXIgZGlyLWFuZC1wb3MpKQorICAgICAgICAgICAgICAgICAg KHBvcyAoY2RyIGRpci1hbmQtcG9zKSkKKyAgICAgICAgICAgICAgICAgIChjYWNoZWQtb3Zlcmxh eXMKKyAgICAgICAgICAgICAgICAgICAoYXNzb2MgZGlyIGRpcmVkLWRldGFpbHMtaW50ZXJuYWwt b3ZlcmxheS1jYWNoZSkpKQorICAgICAgICAgICAgIDs7c2tpcCB0aGlzIGRpcmVjdG9yeSBpZiBp dCdzIG91dHNpZGUgb2YgYSBuYXJyb3dlZCByZWdpb24KKyAgICAgICAgICAgICAod2hlbiAoYW5k ICg+PSBwb3MgKHBvaW50LW1pbikpICg8PSBwb3MgKHBvaW50LW1heCkpKQorICAgICAgICAgICAg ICAgKGlmIGNhY2hlZC1vdmVybGF5cworICAgICAgICAgICAgICAgICAgIChkaXJlZC1kZXRhaWxz LWZyb2Itb3ZlcmxheXMgdCkgOztyZXVzZSBleGlzdGluZworICAgICAgICAgICAgICAgICAgIChs ZXQgKChjYWNoZSAobGlzdCBkaXIpKSA7O21ha2UgbmV3IG92ZXJsYXlzCisgICAgICAgICAgICAg ICAgICAgICAgICAgKHN1YmRpci1zdGFydCAobGV0ICgocmVzdCBwb3MpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7O3hlbWFjcyBjb21wYXQ6IGluIHhlbWFjcywg dGhpcyBpcyBhIGxpc3QKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGlmIChhdG9tIHJlc3QpIHJlc3QgKGNhciByZXN0KSkpKQorICAgICAgICAgICAgICAgICAgICAg ICAgIChzdWJkaXItZW5kICgxLSAoZGlyZWQtZ2V0LXN1YmRpci1tYXggZGlyLWFuZC1wb3MpKSkp CisgICAgICAgICAgICAgICAgICAgICAoZ290by1jaGFyIHN1YmRpci1zdGFydCkKKyAgICAgICAg ICAgICAgICAgICAgIChkaXJlZC1nb3RvLW5leHQtZmlsZSkKKyAgICAgICAgICAgICAgICAgICAg ICh3aGlsZSAoPCAocG9pbnQpIHN1YmRpci1lbmQpCisgICAgICAgICAgICAgICAgICAgICAgIDs7 bmI6IHVzZXMgc2V0Y2RyIHRvIHVwZGF0ZSBjYWNoZQorICAgICAgICAgICAgICAgICAgICAgICAo ZGlyZWQtZGV0YWlscy1tYWtlLWN1cnJlbnQtbGluZS1vdmVybGF5IGNhY2hlKQorICAgICAgICAg ICAgICAgICAgICAgICAoZGlyZWQtbmV4dC1saW5lIDEpKQorICAgICAgICAgICAgICAgICAgICAg KHNldHEgZGlyZWQtZGV0YWlscy1pbnRlcm5hbC1vdmVybGF5LWNhY2hlCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAoY29ucyBjYWNoZSBkaXJlZC1kZXRhaWxzLWludGVybmFsLW92ZXJsYXkt Y2FjaGUpKSkpKSkpCisgICAgICAgICAoc2V0cSBkaXJlZC1kZXRhaWxzLXN0YXRlICdoaWRkZW4p KSkpCisgICAgIAorIChkZWZ1biBkaXJlZC1kZXRhaWxzLXNob3coKQorICAgIlNob3cgd2hhdGV2 ZXIgZGV0YWlscyBhIGNhbGwgdG8gYGRpcmVkLWRldGFpbHMtaGlkZScgbWF5IGhhdmUKKyBoaWRk ZW4gaW4gdGhpcyBidWZmZXIuIgorICAgKGludGVyYWN0aXZlKQorICAgKGRpcmVkLWRldGFpbHMt ZnJvYi1vdmVybGF5cyBuaWwpCisgICAoc2V0cSBkaXJlZC1kZXRhaWxzLXN0YXRlICdzaG93bikp CisgCisgKGRlZnVuIGRpcmVkLWRldGFpbHMtbWFrZS1jdXJyZW50LWxpbmUtb3ZlcmxheSAoY2Fj aGUpCisgICAobGV0ICgoZGV0YWlsLW92ZXJsYXkgO2hpZGUgdGhlIGZsYWdzLCBzaXplLCBvd25l ciwgZGF0ZSwgZXRjLgorICAgICAgICAgIChtYWtlLW92ZXJsYXkKKyAgICAgICAgICAgKCsgMiAo cHJvZ24gKGJlZ2lubmluZy1vZi1saW5lKSAocG9pbnQpKSkKKyAgICAgICAgICAgKHByb2duIChk aXJlZC1tb3ZlLXRvLWZpbGVuYW1lKShwb2ludCkpKSkKKyAgICAgICAgICAKKyAgICAgICAgIChs bi10YXJnZXQgO2hpZGUgdGhlIGRlc3RpbmF0aW9uIG9mIGEgc3ltYm9saWMgd2hlbgorICAgICAg ICAgICh3aGVuIGRpcmVkLWRldGFpbHMtaGlkZS1saW5rLXRhcmdldHMKKyAgICAgICAgICAgIChp ZiAocHJvZ24gKGJlZ2lubmluZy1vZi1saW5lKQorICAgICAgICAgICAgICAgICAgICAgICAoc2Vh cmNoLWZvcndhcmQtcmVnZXhwCisgICAgICAgICAgICAgICAgICAgICAgICAiLT4gXFwoLipcXCki CisgICAgICAgICAgICAgICAgICAgICAgICAoc2F2ZS1leGN1cnNpb24gKGVuZC1vZi1saW5lKShw b2ludCkpIHQpKQorICAgICAgICAgICAgICAgIChtYWtlLW92ZXJsYXkgKG1hdGNoLWJlZ2lubmlu ZyAxKSAobWF0Y2gtZW5kIDEpKSkpKSkKKyAKKyAgICAgOztkZWxldGUgdGhlIG92ZXJsYXkgd2hl biB0aGUgZGlyZWQgbGluZSBnb2VzIGF3YXkKKyAgICAgKG92ZXJsYXktcHV0IGRldGFpbC1vdmVy bGF5ICdldmFwb3JhdGUgdCkKKyAgICAgKGRpcmVkLWRldGFpbHMtaGlkZS1vdmVybGF5IGRldGFp bC1vdmVybGF5KQorIAorICAgICAod2hlbiBsbi10YXJnZXQKKyAgICAgICAob3ZlcmxheS1wdXQg bG4tdGFyZ2V0ICdldmFwb3JhdGUgdCkKKyAgICAgICAoZGlyZWQtZGV0YWlscy1oaWRlLW92ZXJs YXkgbG4tdGFyZ2V0KSkKKyAKKyAgICAgKHNldGNkciBjYWNoZSAoYXBwZW5kIChpZiBsbi10YXJn ZXQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCBsbi10YXJnZXQgZGV0YWls LW92ZXJsYXkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0IGRldGFpbC1vdmVy bGF5KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChjZHIgY2FjaGUpKSkKKyAgICAgZGV0 YWlsLW92ZXJsYXkpKQorIAorIChkZWZ1biBkaXJlZC1kZXRhaWxzLWhpZGUtb3ZlcmxheSAobykK KyAgIChvdmVybGF5LXB1dCBvICdpbnZpc2libGUgdCkKKyAgIChvdmVybGF5LXB1dCBvICdiZWZv cmUtc3RyaW5nIGRpcmVkLWRldGFpbHMtaGlkZGVuLXN0cmluZykpCisgCisgKGRlZnVuIGRpcmVk LWRldGFpbHMtc2hvdy1vdmVybGF5IChvKQorICAgKG92ZXJsYXktcHV0IG8gJ2ludmlzaWJsZSBu aWwpCisgICAob3ZlcmxheS1wdXQgbyAnYmVmb3JlLXN0cmluZyAiIikpCisgCisgKGRlZnVuIGRp cmVkLWRldGFpbHMtZnJvYi1vdmVybGF5cyAoaGlkZSkKKyAgICh3aGVuIGRpcmVkLWRldGFpbHMt aW50ZXJuYWwtb3ZlcmxheS1jYWNoZQorICAgICAobGV0ICgoZnJvYmJlciAoaWYgaGlkZSAnZGly ZWQtZGV0YWlscy1oaWRlLW92ZXJsYXkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Rp cmVkLWRldGFpbHMtc2hvdy1vdmVybGF5KSkpCisgICAgICAgKGRvbGlzdCAoZGlyLWFuZC1vdmVy bGF5cyBkaXJlZC1kZXRhaWxzLWludGVybmFsLW92ZXJsYXktY2FjaGUpCisgICAgICAgICAoZG9s aXN0IChvdmVybGF5IChjZHIgZGlyLWFuZC1vdmVybGF5cykpCisgICAgICAgICAgIChmdW5jYWxs IGZyb2JiZXIgb3ZlcmxheSkpKSkpKQorICAgCisgDAorIAogIChpZiAoZXEgc3lzdGVtLXR5cGUg J3ZheC12bXMpCiAgICAgIChsb2FkICJkaXJlZC12bXMiKSkKICAK --20cf3011e06fc1a2ac04be82c8a3 Content-Type: application/octet-stream; name="dired.texi.patch" Content-Disposition: attachment; filename="dired.texi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h1gk3ejx2 KioqIG9sZC9kaXJlZC50ZXhpCVN1biBKdWwgMTUgMTg6MDA6MjIgMjAwNwotLS0gbmV3L2RpcmVk LnRleGkJU3VuIEp1bCAxNSAxODowMDoxMCAyMDA3CioqKioqKioqKioqKioqKgoqKiogNDEsNDYg KioqKgotLS0gNDEsNDcgLS0tLQogIEBlbmQgaWZub3R0ZXgKICAqIFN1YmRpcmVjdG9yeSBNb3Rp b246OgkgICAgICBNb3ZpbmcgYWNyb3NzIHN1YmRpcmVjdG9yaWVzLCBhbmQgdXAgYW5kIGRvd24u CiAgKiBIaWRpbmcgU3ViZGlyZWN0b3JpZXM6OiAgICAgTWFraW5nIHN1YmRpcmVjdG9yaWVzIHZp c2libGUgb3IgaW52aXNpYmxlLgorICogSGlkaW5nIEZpbGUgRGV0YWlsczo6ICAgICAgIE1ha2lu ZyBmaWxlIGF0dHJpYnV0ZXMgdmlzaWJsZSBvciBpbnZpc2libGUuCiAgKiBVcGRhdGluZzogRGly ZWQgVXBkYXRpbmcuICAgRGlzY2FyZGluZyBsaW5lcyBmb3IgZmlsZXMgb2Ygbm8gaW50ZXJlc3Qu CiAgKiBGaW5kOiBEaXJlZCBhbmQgRmluZC4JICAgICAgVXNpbmcgYGZpbmQnIHRvIGNob29zZSB0 aGUgZmlsZXMgZm9yIERpcmVkLgogICogV2RpcmVkOjogICAgICAgICAgICAgICAgICAgIE9wZXJh dGluZyBvbiBmaWxlcyBieSBlZGl0aW5nIHRoZSBEaXJlZCBidWZmZXIuCioqKioqKioqKioqKioq KgoqKiogMTAxMSwxMDE2ICoqKioKLS0tIDEwMTIsMTA1NiAtLS0tCiAgd2l0aG91dCBoYXZpbmcg dG8gcmVtb3ZlIHRoZSBEaXJlZCBtYXJrcyBvbiBmaWxlcyBpbiB0aG9zZQogIHN1YmRpcmVjdG9y aWVzLgogIAorIEBub2RlIEhpZGluZyBGaWxlIERldGFpbHMKKyBAc2VjdGlvbiBIaWRpbmcgRmls ZSBEZXRhaWxzCisgCisgQGNpbmRleCBoaWRpbmcgaW4gRGlyZWQgKERpcmVkKQorICAgQGRmbntI aWRpbmd9IGZpbGUgZGV0YWlscyBtZWFucyBtYWtpbmcgZmlsZSBhdHRyaWJ1dGVzIGFuZCBzeW1i b2xpYworIGxpbmsgdGFyZ2V0cyBpbnZpc2libGUgdXNpbmcgb3ZlcmxheXMgKEBweHJlZntPdmVy bGF5cywsLCBlbGlzcCwgdGhlCisgRW1hY3MgTGlzcCBSZWZlcmVuY2UgTWFudWFsfSkuIFRoaXMg Y29udmVydHMgdGhlIGRpcmVkIGRpc3BsYXkgdG8gYQorIHRlcnNlIGxpc3Qgb2YgZmlsZW5hbWVz IHdoaWxlIGNvbnRpbnVpbmcgdG8gc3VwcG9ydCBhbGwgbm9ybWFsIGRpcmVkCisgY29tbWFuZHMu CisgCisgQHRhYmxlIEBrYmQKKyBAaXRlbSBAa2Jkezt9CisgQGZpbmRleCBkaXJlZC1kZXRhaWxz LXRvZ2dsZQorIEBraW5kZXggQGtiZHs7fSBAcnsoRGlyZWQpfQorIEhpZGUgb3IgcmV2ZWFsIGZp bGUgZGV0YWlscyBpbiB0aGUgY3VycmVudCBEaXJlZCBidWZmZXIuCisgCisgQGl0ZW0gQGtiZHso fQorIEBmaW5kZXggZGlyZWQtZGV0YWlscy1oaWRlCisgQGtpbmRleCBAa2Jkeyh9IEByeyhEaXJl ZCl9CisgSGlkZSBmaWxlIGRldGFpbHMgaW4gdGhlIGN1cnJlbnQgRGlyZWQgYnVmZmVyLgorIAor IEBpdGVtIEBrYmR7KX0KKyBAZmluZGV4IGRpcmVkLWRldGFpbHMtaGlkZQorIEBraW5kZXggQGti ZHspfSBAcnsoRGlyZWQpfQorIFNob3cgZmlsZSBkZXRhaWxzIGluIHRoZSBjdXJyZW50IERpcmVk IGJ1ZmZlci4KKyBAZW5kIHRhYmxlCisgCisgICAgWW91IGNhbiBjdXN0b21pemUgQGNvZGV7ZGly ZWQtZGV0YWlscy1oaWRkZW4tc3RyaW5nfSB0byBkaXNwbGF5IGFueQorIHN0cmluZyBpbiBwbGFj ZSBvZiBoaWRkZW4gZGV0YWlscyBhbmQgbGluayB0YXJnZXRzICh0aGUgZGVmYXVsdCBpcworICJb Li4uXSIpLgorIAorICAgIFRoZSBvcHRpb24gQGNvZGV7ZGlyZWQtZGV0YWlscy1oaWRlLWxpbmst dGFyZ2V0c30gY2FuIGJlIHNldCB0bworIEBjb2Rle25pbH0gdG8gc2hvdyBsaW5rIHRhcmdldHMg d2hlbiBkZXRhaWxzIGFyZSBoaWRkZW4uIFRoZSBkZWZhdWx0IGlzIHRvCisgaGlkZSBsaW5rIHRh cmdldHMuCisgCisgICAgQ3VycmVudGx5LCB0aGUgZGlyZWQtc29ydC0qIGZhbWlseSBvZiBmdW5j dGlvbnMgZG8gbm90IGNhbGwKKyBAY29kZXtkaXJlZC1hZnRlci1yZWFkaW4taG9va30gYW5kIHRo dXMgd2lsbCBub3QgaGlkZSBkZXRhaWxzIHVudGlsCisgdGhlIG5leHQgY2FsbCB0byBAY29kZXtk aXJlZC1yZXZlcnR9IChAa2Jke2d9KS4KKyAKICBAbm9kZSBEaXJlZCBVcGRhdGluZwogIEBzZWN0 aW9uIFVwZGF0aW5nIHRoZSBEaXJlZCBCdWZmZXIKICBAY2luZGV4IHVwZGF0aW5nIERpcmVkIGJ1 ZmZlcgo= --20cf3011e06fc1a2ac04be82c8a3-- From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: dired-details[+].el Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 May 2012 22:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Drew Adams" Cc: rob@giardina.us, rob.giardina@gmail.com, 6799@debbugs.gnu.org, joakim@verona.se Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.133720907225537 (code B ref 6799); Wed, 16 May 2012 22:58:01 +0000 Received: (at 6799) by debbugs.gnu.org; 16 May 2012 22:57:52 +0000 Received: from localhost ([127.0.0.1]:58226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUnAF-0006dq-Me for submit@debbugs.gnu.org; Wed, 16 May 2012 18:57:52 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:20351) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUnAE-0006de-75 for 6799@debbugs.gnu.org; Wed, 16 May 2012 18:57:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApYIACxOgk9FpZcD/2dsb2JhbABDuCMDgQyBCIIJAQEEAVYjBQsLNBIUDQsNJBOIAAMGBQu0Lw2Ba4otgTSEeQSWfYoogyCBXYMDgUA X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="180634533" Received: from 69-165-151-3.dsl.teksavvy.com (HELO pastel.home) ([69.165.151.3]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 May 2012 18:57:32 -0400 Received: by pastel.home (Postfix, from userid 20848) id 80ED859577; Wed, 16 May 2012 18:57:31 -0400 (EDT) From: Stefan Monnier Message-ID: References: <84D7419516B540509BB1B3B94D1CA7C2@us.oracle.com> Date: Wed, 16 May 2012 18:57:31 -0400 In-Reply-To: (Drew Adams's message of "Wed, 16 May 2012 09:10:40 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> A technical reason is lack of copyright paperwork. I'm not >> sure if the email I used in the Cc is valid. If so, Rob, >> could you contact me to get this copyright business out of the way? > Hopefully Rob will answer, but I'm pretty sure he already took care of > the copyright stuff. At least I can't find him in the FSF's copyright-list. Sometimes some entries are missing, so if he says he did sign the papers, I'll ask the copyright clerk to investigate. > The most recent reply we have from Rob is from > this address: rob.giardina@gmail.com. Thanks, I added it to the Cc. > This is that reply: > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6799#23. Note too that > he included the latest patches in that message. Thanks. Moved this thread to the bug. The patch there looks very similar to the one I just reviewed. >> > + (define-key map "(" 'dired-details-hide) >> > + (define-key map ")" 'dired-details-show) >> > + (define-key map ";" 'dired-details-toggle) >> I'd rather place the bindings on a "dired-details" prefix. > FWIW, I think we need only one keybinding, for just `dired-details-toggle'. Actually, I think you're right. >> > +(defcustom dired-details-hide-link-targets t >> > + "*Hide symbolic link target paths." >> > + :group 'dired-details >> > + :type 'boolean) >> FWIW I find something like (setq truncate-lines t) to be better. > Not the same thing. And not better, IMO - less specific. Hiding symlink > targets should apply regardless of line length. Truncating is only about > handling long lines. (But I don't really care about this matter.) Not the same thing indeed, but in many cases, truncation makes hiding unnecessary. >> Since line truncation is the default in tabulated-list-mode, maybe we >> should also make it the default in dired. > Egads, no, please. > No, I won't fight over the default value, but I think truncated lines as the > default is nearly always a bad idea. I find truncated lines to be the only good choice for text displayed in columns, where wrapping breaks the clean visual display. I don't claim it's perfect, but I think it's a generally better default. > An extra reason is that some users will have no clue what's going on > and how to show the missing info. If that's really a problem, it's a general one that needs to be fixed in general (e.g. by adding horizontal scroll bars and/or supporting horizontal scrolling via two-finger gestures or things like that). > Truncating lines is nearly a barbarism that should go the way of the > dinosaurs. No, just kidding. It can be handy if you know how to > toggle it, but truncation should not be the default (anywhere), IMHO. Obviously a matter of taste. > Again though, not very important. >> > +(defun dired-details-toggle (&optional arg default-too) >> > + "Toggle visibility of dired details. >> > +With positive prefix argument ARG hide the details, with negative >> > +show them." >> > + (interactive "P") >> > + (let ((hide (if (null arg) >> > + (not (eq 'hidden dired-details-state)) >> > + (> (prefix-numeric-value arg) 0)))) >> > + (if default-too >> > + (setq dired-details-initially-hide hide)) >> > + (if hide (dired-details-hide) >> > + (dired-details-show)))) >> Use define-minor-mode. > I think I disagree, and I feel more strongly about this point. > The current behavior is what I like, and I'm not sure how using > a minor mode would provide it. This is the behavior: > Toggling affects only the current Dired buffer and subsequently > created Dired buffers. It does not affect other existing Dired buffers. I don't see why using define-minor-mode would prevent this behavior. > A local minor mode would affect only the current Dired buffer and not > subsequently created ones. A global minor mode would affect all Dired > buffers at the same time. A local minor mode can change global defaults as well. >> > +(defun dired-details-hide-overlay (o) >> > + (overlay-put o 'invisible t) >> > + (overlay-put o 'before-string dired-details-hidden-string)) >> Why use dired-details-hidden-string rather than just using the >> traditional ellipsis with buffer-invisibility-spec? > The first thing I did when getting dired-details.el was change the > string to "", and I've never looked back. In my use of it, hiding the > details means showing nothing in their place. And in the commentary > of dired-details+.el I recommended that others do the same. You could still get this result by changing buffer-invisibility-spec, so it's not an objection. Stefan From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: dired-details[+].el Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 May 2012 23:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Stefan Monnier'" Cc: rob@giardina.us, rob.giardina@gmail.com, 6799@debbugs.gnu.org, joakim@verona.se Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.13372124054364 (code B ref 6799); Wed, 16 May 2012 23:54:01 +0000 Received: (at 6799) by debbugs.gnu.org; 16 May 2012 23:53:25 +0000 Received: from localhost ([127.0.0.1]:58262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUo20-00018L-M6 for submit@debbugs.gnu.org; Wed, 16 May 2012 19:53:24 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:24897) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUo1y-000188-2E for 6799@debbugs.gnu.org; Wed, 16 May 2012 19:53:22 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4GNqvat022743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 May 2012 23:52:57 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4GNqmWZ005597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 May 2012 23:52:49 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4GNqkQx004850; Wed, 16 May 2012 18:52:46 -0500 Received: from dradamslap1 (/10.159.173.230) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 16 May 2012 16:52:46 -0700 From: "Drew Adams" References: <84D7419516B540509BB1B3B94D1CA7C2@us.oracle.com> Date: Wed, 16 May 2012 16:52:43 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac0zt1V+VCWbj0OHS1GWjLGbUbmJtQABd09Q X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > I don't see why using define-minor-mode would prevent this behavior. How, for example? Or I can wait and see. ;-) My main point here was to get the behavior, not how to get it. My limited use of `define-minor-mode' didn't suggest to me how to do it. > > A local minor mode would affect only the current Dired > > buffer and not subsequently created ones. A global minor mode would > > affect all Dired buffers at the same time. > > A local minor mode can change global defaults as well. Ah, yes. So we can have the same behavior with `define-minor-mode' - great. > >> Why use dired-details-hidden-string rather than just using the > >> traditional ellipsis with buffer-invisibility-spec? > > > > The first thing I did when getting dired-details.el was change the > > string to "", and I've never looked back. In my use of it, > > hiding the details means showing nothing in their place. And in > > the commentary of dired-details+.el I recommended that others do the same. > > You could still get this result by changing > buffer-invisibility-spec, so it's not an objection. To me, it's a cop-out to tell users to go fiddle with `buffer-invisibility-spec'. To me, the most Lisp-averse Emacs newbie should be able to easily get rid of the useless `...'. S?he (including I) should not have to go look up `buffer-invisibility-spec' in the Elisp manual. Or even have to scan a Dired mode doc string to find something about how to use `buffer-invisibility-spec' to get rid of it... But maybe I'm misunderstanding your suggestion. I say "useless" because I see no good reason why we should _ever_ show `...' for this feature. `...' indicates a particular position where something is elided, but the same columns are elided from each row. The position indicates nothing - the column of repeated ellipses just constitutes noise and wastes space. To me, it's just as clear, and simpler, for the toggle to simply remove those columns, without replacing them by `...'. To me. Try it - and see if it isn't clear enough, and cleaner & simpler for users. From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2012 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Rob Giardina'" Cc: 'Juanma Barranquero' , 'Lars Magne Ingebrigtsen' , 6799@debbugs.gnu.org, 'Stefan Monnier' Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.134290196331687 (code B ref 6799); Sat, 21 Jul 2012 20:20:02 +0000 Received: (at 6799) by debbugs.gnu.org; 21 Jul 2012 20:19:23 +0000 Received: from localhost ([127.0.0.1]:56199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ssg95-0008F1-04 for submit@debbugs.gnu.org; Sat, 21 Jul 2012 16:19:23 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:35346) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ssg91-0008Et-9x for 6799@debbugs.gnu.org; Sat, 21 Jul 2012 16:19:20 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q6LKCr0t026707 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 21 Jul 2012 20:12:54 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q6LKCodu021510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 21 Jul 2012 20:12:51 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q6LKCoJw014037; Sat, 21 Jul 2012 15:12:50 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 21 Jul 2012 13:12:49 -0700 From: "Drew Adams" References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> Date: Sat, 21 Jul 2012 13:12:40 -0700 Message-ID: <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac0i+q1nZa+/ykPiSESSpjuKwuq3fhEgWhrw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) ping. Still hoping, after all these years... The replies from Emacs Dev have varied from = gee-we-don't-know-how-to-find-Rob (even though he has replied to this bug list and his email address = works) to gee-we-don't-know-whether-he-has-signed-papers (even though he has = replied here indicating that he has). What's the problem? (Again, this is for Emacs, not for me. I am content with loading dired-details(+).el for my own use. But it's a shame that Emacs users = do not have this great feature as part of Emacs.) > From: rob.giardina@gmail.com [mailto:rob.giardina@gmail.com]=20 > Sent: Wednesday, April 25, 2012 8:47 AM >=20 > Thanks for remembering this patch Drew. I did work with RMS a long way > back but it fell by the wayside in the last phases. >=20 > The patch is just elisp and doc, no C. The changes are pretty simple > and contain all the community enhancements added later > (dired-details+). >=20 > Basically, it adds some bindings to a few functions that will loop > over the dired file listing lines to add invisibile overlays to the > messiest parts of the lines. Pretty self-contained. >=20 > It would have to be re-tested at this point. I've attached the old > ones if it will help decide if you want the feature. I can test some > fresh patches on HEAD in the next few weeks when my biz/personal life > calms a bit. >=20 > Regards, > Rob >=20 > On Thu, Apr 12, 2012 at 4:05 PM, Drew Adams=20 > wrote: > > > > As I have said several times now, ask Rob Giardina. =A0He=20 > > made a whole set of changes to various Emacs files, > > including perhaps C code. I am not aware of > > what changes he made. > > > > Rob has sent mail as recently as 2011/11/29 to=20 > > emacs-orgmode@gnu.org. =A0His address for that was > > rob@giardina.us. =A0(No, I do not subscribe to that mailing > > list. =A0But I know how to use Google.) =A0Please contact Rob. > > > > > > Please contact Rob Giardina. =A0I believe that he patched=20 > > > > the existing > > > > Dired code (and some C code? and some other Lisp code?), doing > > > > everything that was needed. > > > > > > If you want this code included in Emacs, please assemble=20 > > > the patch and post it here. > > > > It is not a question of "if I want". =A0It was decided by RMS=20 > > that this should be included in Emacs. =A0Long, long ago. > >=A0Rob did the work required for this to > > happen, but no one ever committed it, AFAIK. > > > > What I use, personally, is dired-details.el plus=20 > > dired-details+.el, and they > > suffice. =A0But Rob went to the trouble of patching Emacs in=20 > > various places, > > integrating the features cleanly at a more basic level etc. > > > > I have no idea what Rob's changes were, but if you search=20 > > the mailing list > > perhaps you can find references to them. =A0Rob refers to a=20 > > patch for 2005-07-07 > > CVS, here: > > http://comments.gmane.org/gmane.emacs.devel/74172 > > > > Here is the last mail from Rob on the subject, AFAIK: > > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00215.html > > > > Here is my last mail on the subject, with relevant links: > > > > > From: Drew Adams Sent: Sunday, July 19, 2009 7:34 AM > > > > I discovered dired-details and dired-details+ and found=20 > > > > them useful. > > > > Could they be added to emacs? > > > > > > > > http://www.emacswiki.org/emacs/DiredDetails > > > > > > They were supposed to be added. Rob Giardina submitted an > > > Emacs 23 patch two years ago that integrates the functionality > > > of both in a better way even than the separate libraries > > > dired-details[+].el. > > > > > > I don't think any reason was ever given for why the patch > > > wasn't incorporated (committed). RMS asked for comment on > > > the merged code, but no one ever answered his request > > > (on emacs-devel, at least). The last time I ping'ed the > > > list about this was 2008-07 - I never got an answer either. > > > > > > Last ping: > > >=20 > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg01152.html > > > > > > Rob's change log and RMS's call for comment: > > >=20 > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg01187.html > > > > > > Original thread: > > >=20 > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00226.html From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Dec 2012 21:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org Cc: Michael Heerdegen , Drew Adams X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135560620231879 (code B ref -1); Sat, 15 Dec 2012 21:17:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Dec 2012 21:16:42 +0000 Received: from localhost ([127.0.0.1]:44437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjz69-0008I7-Pk for submit@debbugs.gnu.org; Sat, 15 Dec 2012 16:16:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46300) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tjz66-0008I0-W1 for submit@debbugs.gnu.org; Sat, 15 Dec 2012 16:16:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjz50-0006lA-V1 for submit@debbugs.gnu.org; Sat, 15 Dec 2012 16:15:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:46668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjz50-0006l6-RT for submit@debbugs.gnu.org; Sat, 15 Dec 2012 16:15:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjz4x-00067J-3y for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 16:15:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjz4s-0006kP-K4 for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 16:15:26 -0500 Received: from ristopher.com ([146.185.21.93]:36906 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjz4r-0006jQ-Kj for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 16:15:22 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id AC1F120168; Sat, 15 Dec 2012 21:15:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1355606116; bh=x8kraqhK8Ckx85cdrrQQcz6Y+vqvQB4n3nqVetTqUW0=; h=From:To:Cc:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=gts8wNxZ/fyOepuSQnJk1b97bm/av+/ALCxipSypBZhFqmyYn6Vo2MIKf5HFYHG09 sCTVMp1eCQy/TxYo9Sc27Ow6zg7T1fnduF6r4Aytiq1QlGH5hT/g/dZLHMz7I9USuK mdWEG/tmSjdHMGbi2QOB7DZrPP1ehOkI6hVaDJNE= From: Christopher Schmidt In-Reply-To: <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> (Drew Adams's message of "Sat, 21 Jul 2012 13:12:40 -0700") Message-ID: <878v8zow44@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> Mail-Followup-To: bug-gnu-emacs@gnu.org, Drew Adams , Michael Heerdegen MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Sat, 15 Dec 2012 21:15:16 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) --=-=-= Content-Type: text/plain "Drew Adams" writes: > ping. > > Still hoping, after all these years... > > The replies from Emacs Dev have varied from > gee-we-don't-know-how-to-find-Rob (even though he has replied to this > bug list and his email address works) to > gee-we-don't-know-whether-he-has-signed-papers (even though he has > replied here indicating that he has). > > What's the problem? > > (Again, this is for Emacs, not for me. I am content with loading > dired-details(+).el for my own use. But it's a shame that Emacs users > do not have this great feature as part of Emacs.) Here is my attempt. --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=my-dired-hide-details-mode.el Content-Transfer-Encoding: quoted-printable (define-minor-mode my-dired-hide-details-mode "" nil nil nil (cl-assert (derived-mode-p 'dired-mode)) (save-restriction (widen) (save-excursion (goto-char (point-min)) (unless (get-text-property (point) 'dired-details-to-hide) (goto-char (next-single-property-change (point) 'dired-details-to-hide nil (point-max)))) (unless (and (eobp) (not (eq (get-text-property (point) 'invisible) my-dired-hide-details-mode))) (cl-loop until (eobp) do (get-text-property (point) 'dired-details-to-hide) for end =3D (next-single-property-change (point) 'dired-details-to-hide nil (point-max)) do (let ((buffer-read-only)) (put-text-property (point) end 'invisible my-dired-hide-details-mode)) (get-text-property (1+ end) 'dired-details-to-hide) for next =3D (next-single-property-change (1+ end) 'dired-details-to-hide) while next do (goto-char next)))))) (defadvice dired-insert-set-properties (after my-add-hide-props (beg end) activate) (save-restriction (narrow-to-region beg end) (save-excursion (goto-char (point-min)) (unless (get-text-property (point) 'dired-filename) (let ((from (point))) (unless (let ((c (next-single-property-change (point) 'dired-filename))) (when c (goto-char c) (move-beginning-of-line nil) t)) (forward-line 1)) (let ((buffer-read-only)) (add-text-properties from (point) `(invisible ,my-dired-hide-details-mode dired-details-to-hide t))))) (cl-loop for p =3D (next-single-property-change (point) 'dired-filename) while p do (goto-char p) (when (get-text-property (point) 'dired-filename) (let ((buffer-read-only)) (add-text-properties (+ (line-beginning-position) 2) (point) `(invisible ,my-dired-hide-details-mode dired-details-to-hide t))) (save-restriction (narrow-to-region (point) (line-end-position)) (let ((link (next-single-property-change (point) 'dired-filename))) (when link (let ((buffer-read-only)) (add-text-properties (+ link 4) (point-max) `(invisible ,my-dired-hide-details-mode dired-details-to-hide t))))))))))) (defadvice find-dired (after my-fix-move-process-mark-to-arg activate) (move-marker (process-mark (get-buffer-process (current-buffer))) (save-excursion (goto-char (point-min)) (forward-line 1) (point)))) (define-key dired-mode-map "(" 'my-dired-hide-details-mode) (provide 'my-dired-hide-details-mode) --=-=-= Content-Type: text/plain Usage: (progn (require 'cl-lib) (require 'dired) (require 'my-dired-hide-details-mode)) Press `(' in any dired buffer to toggle details. Other than dired-details by Rob this implementation does not use overlays but text properties which is a lot faster. I just wrote this a few minutes ago but the code seems to work fine with dired, wdired and find-dired. If there is interest, I can polish the code, add documentation and customisation options and come up with a full patch for the trunk. I think, due to the way my-dired-hide-details-mode is designed, it would be best to add the code directly to dired.el - that is add new code to dired-insert-set-properties add new minor mode dired-hide-details-mode bind dired-hide-details-mode in dired-mode-map It would be necessary to fix a few bugs find-dired as well. Nothing fancy, though. WDYT? Christopher --=-=-=-- From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Dec 2012 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org Cc: Michael Heerdegen , Drew Adams X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13556099334815 (code B ref -1); Sat, 15 Dec 2012 22:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Dec 2012 22:18:53 +0000 Received: from localhost ([127.0.0.1]:44447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tk04K-0001Fb-JA for submit@debbugs.gnu.org; Sat, 15 Dec 2012 17:18:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51513) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tk04H-0001FT-QG for submit@debbugs.gnu.org; Sat, 15 Dec 2012 17:18:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tk03B-0003j6-Jb for submit@debbugs.gnu.org; Sat, 15 Dec 2012 17:17:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:56582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk03B-0003j2-GS for submit@debbugs.gnu.org; Sat, 15 Dec 2012 17:17:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk038-00007e-Vg for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 17:17:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tk036-0003ip-Iv for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 17:17:38 -0500 Received: from ristopher.com ([146.185.21.93]:36910 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk036-0003ij-6Y for bug-gnu-emacs@gnu.org; Sat, 15 Dec 2012 17:17:36 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id BF56620168; Sat, 15 Dec 2012 22:17:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1355609853; bh=YaB6P3vTfveBxvTTq25vJQWmUgZbs59bXGh6SMqq5ig=; h=From:To:Cc:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=2amBBDUUgZSPD0ZA3i2NlNBTNhTZ+0OTdy67Ogga3IdJQ+nB5dONeeeLv37sxn6vm F3kh7lqPtsEOPNNem1AN+AU8jx3GQ7fduG54nARSQ2xuoMBzuIpcMww7vEB9Bf740L arEjFwGbcL3E4x6brzvBx6rHWxhw16ht6lIqaSRY= From: Christopher Schmidt In-Reply-To: <878v8zow44@ch.ristopher.com> (Christopher Schmidt's message of "Sat, 15 Dec 2012 21:15:16 +0000 (GMT)") Message-ID: <87k3sj6juj@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org, Drew Adams , Michael Heerdegen MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Sat, 15 Dec 2012 22:17:33 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Christopher Schmidt writes: > Here is my attempt. Here is a better one. --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=my-dired-hide-details-mode.el Content-Transfer-Encoding: quoted-printable (define-minor-mode my-dired-hide-details-mode "" nil nil nil (cl-assert (derived-mode-p 'dired-mode)) (save-restriction (widen) (save-excursion (goto-char (point-min)) (unless (or (eobp) (unless (get-text-property (point) 'dired-details-to-hide) (goto-char (next-single-property-change (point) 'dired-details-to-hide nil (point-max))) (eobp)) (eq (get-text-property (point) 'invisible) my-dired-hide-details-mode)) (cl-loop until (eobp) for end =3D (next-single-property-change (point) 'dired-details-to-hide nil (point-max)) do (let ((buffer-read-only)) (put-text-property (point) end 'invisible my-dired-hide-details-mode)) (goto-char (1+ end)) until (eobp) for next =3D (next-single-property-change (1+ end) 'dired-details-to-hide) while next do (goto-char next)))))) (defadvice dired-insert-set-properties (after my-add-hide-props (beg end) activate) (save-restriction (narrow-to-region beg end) (save-excursion (goto-char (point-min)) (unless (get-text-property (point) 'dired-filename) (let ((from (point))) (unless (let ((c (next-single-property-change (point) 'dired-filename))) (when c (goto-char c) (move-beginning-of-line nil) t)) (forward-line 1)) (let ((buffer-read-only)) (add-text-properties from (point) `(invisible ,my-dired-hide-details-mode dired-details-to-hide t))))) (cl-loop for p =3D (next-single-property-change (point) 'dired-filename) while p do (goto-char p) (when (get-text-property (point) 'dired-filename) (let ((buffer-read-only)) (add-text-properties (+ (line-beginning-position) 2) (point) `(invisible ,my-dired-hide-details-mode dired-details-to-hide t))) (save-restriction (narrow-to-region (point) (line-end-position)) (let ((link (next-single-property-change (point) 'dired-filename))) (when link (let ((buffer-read-only)) (add-text-properties (+ link 4) (point-max) `(invisible ,my-dired-hide-details-mode dired-details-to-hide t))))))))))) (defadvice find-dired (after my-fix-move-process-mark-to-arg activate) (move-marker (process-mark (get-buffer-process (current-buffer))) (save-excursion (goto-char (point-min)) (forward-line 1) (point)))) (define-key dired-mode-map "(" 'my-dired-hide-details-mode) (provide 'my-dired-hide-details-mode) --=-=-= Content-Type: text/plain Christopher --=-=-=-- From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Dec 2012 22:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org Cc: Michael Heerdegen , Drew Adams X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13556971798096 (code B ref -1); Sun, 16 Dec 2012 22:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Dec 2012 22:32:59 +0000 Received: from localhost ([127.0.0.1]:45752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TkMlW-00026X-Kq for submit@debbugs.gnu.org; Sun, 16 Dec 2012 17:32:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35879) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TkMlT-00026N-IV for submit@debbugs.gnu.org; Sun, 16 Dec 2012 17:32:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkMkI-0003aC-Qs for submit@debbugs.gnu.org; Sun, 16 Dec 2012 17:31:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:55918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkMkI-0003a8-Ni for submit@debbugs.gnu.org; Sun, 16 Dec 2012 17:31:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkMkH-0004Nx-Oq for bug-gnu-emacs@gnu.org; Sun, 16 Dec 2012 17:31:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkMkG-0003Zn-PU for bug-gnu-emacs@gnu.org; Sun, 16 Dec 2012 17:31:41 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:9428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkMkG-0003Zj-Lo for bug-gnu-emacs@gnu.org; Sun, 16 Dec 2012 17:31:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxIps/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA2IQAW6CY0mgx4DiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210039646" Received: from 69-196-138-108.dsl.teksavvy.com (HELO pastel.home) ([69.196.138.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Dec 2012 17:31:39 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6F5A959150; Sun, 16 Dec 2012 17:31:39 -0500 (EST) From: Stefan Monnier Message-ID: References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> Date: Sun, 16 Dec 2012 17:31:39 -0500 In-Reply-To: <87k3sj6juj@ch.ristopher.com> (Christopher Schmidt's message of "Sat, 15 Dec 2012 22:17:33 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > (save-restriction > (widen) Please add a comment explaining why widening should be used here. > do (let ((buffer-read-only)) > (put-text-property (point) end > 'invisible my-dired-hide-details-mode)) Better bind inhibit-read-only to t. Or better yet, use with-silent-modifications (but move it outside the loop). Also, rather than set the invisible property to nil or t, better set it to another symbol (e.g. `dired-details'), whose meaning is then controlled by add-to-invisibility-spec. > (defadvice dired-insert-set-properties > (after my-add-hide-props (beg end) activate) Obviously, this would have to be turned into a patch, and since it's not small, it would need to be moved to its own function (which would be called from dired-insert-set-properties). > (defadvice find-dired (after my-fix-move-process-mark-to-arg activate) > (move-marker (process-mark (get-buffer-process (current-buffer))) > (save-excursion > (goto-char (point-min)) > (forward-line 1) > (point)))) How is that related to dired-details? Stefan From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2012 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org Cc: Michael Heerdegen , Stefan Monnier , Drew Adams X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.135575079930191 (code B ref -1); Mon, 17 Dec 2012 13:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Dec 2012 13:26:39 +0000 Received: from localhost ([127.0.0.1]:46880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkai1-0007qW-8L for submit@debbugs.gnu.org; Mon, 17 Dec 2012 08:26:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50586) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkahr-0007qI-TE for submit@debbugs.gnu.org; Mon, 17 Dec 2012 08:26:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tkaga-0000qO-Hc for submit@debbugs.gnu.org; Mon, 17 Dec 2012 08:24:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkaga-0000qJ-EZ for submit@debbugs.gnu.org; Mon, 17 Dec 2012 08:24:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkagW-0004S4-24 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 08:24:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkagN-0000mS-2m for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 08:24:43 -0500 Received: from ristopher.com ([146.185.21.93]:37266 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkagM-0000lt-N1 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 08:24:34 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id BCF352016E; Mon, 17 Dec 2012 13:24:31 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1355750671; bh=jHxaSIdUrngFsrCCc8sHGdWdaE4qqO4+qclL0rAfSj0=; h=From:To:Cc:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=WRL6Hdp4mblT2S9FjYTdN4fD0+8wlQRaqsOR0uqP8tA4DL2Mix343LFcW2Z1XRvA4 5EcM7Mo4ERa4+KvtTWZo7emEkVav1fF8Ii+J0s+Wc0gpBcfSik3DzcGkEcYMUOCD2K hNTwHHiPqFRfkpsCVsLTGlRxJxD0AbtZq9vRxGg4= From: Christopher Schmidt In-Reply-To: (Stefan Monnier's message of "Sun, 16 Dec 2012 17:31:39 -0500") Message-ID: <87mwxcx149@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org, Stefan Monnier , Drew Adams , Michael Heerdegen MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Mon, 17 Dec 2012 13:24:31 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Stefan Monnier writes: Hi Stefan, thanks for your input. Here is a preliminary patch for the trunk. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dired-dired-hide-details-mode.diff --- lisp/dired.el +++ lisp/dired.el @@ -230,6 +230,12 @@ :version "22.1" :group 'dired) +(defcustom dired-hide-details-hide-symlink-targets t + "If non-nil, `dired-hide-details-mode' hides symbolic link targets." + :type 'boolean + :version "24.4" + :group 'dired) + ;; Internal variables (defvar dired-marker-char ?* ; the answer is 42 @@ -1222,15 +1228,22 @@ (goto-char beg) (while (< (point) end) (condition-case nil - (if (dired-move-to-filename) - (add-text-properties - (point) - (save-excursion - (dired-move-to-end-of-filename) - (point)) - '(mouse-face highlight - dired-filename t - help-echo "mouse-2: visit this file in other window"))) + (when (dired-move-to-filename) + (put-text-property (+ (line-beginning-position) 2) (point) + 'invisible 'dired-detail) + (add-text-properties + (point) + (progn + (dired-move-to-end-of-filename) + (point)) + '(mouse-face + highlight + dired-filename t + help-echo "mouse-2: visit this file in other window")) + (when (and dired-hide-details-hide-symlink-targets + (< (+ (point) 4) (line-end-position))) + (put-text-property (+ (point) 4) (line-end-position) + 'invisible 'dired-detail))) (error nil)) (forward-line 1)))) @@ -1494,6 +1507,7 @@ ;; hiding (define-key map "$" 'dired-hide-subdir) (define-key map "\M-$" 'dired-hide-all) + (define-key map "(" 'dired-hide-details-mode) ;; isearch (define-key map (kbd "M-s a C-s") 'dired-do-isearch) (define-key map (kbd "M-s a M-C-s") 'dired-do-isearch-regexp) @@ -1584,6 +1598,14 @@ '(menu-item "Toggle Image Thumbnails in This Buffer" image-dired-dired-toggle-marked-thumbs :help "Add or remove image thumbnails in front of marked file names")) + (define-key map [menu-bar immediate unhide-details] + '(menu-item "UnHide Details" dired-hide-details-mode + :help "Unhide details in buffer" + :visible dired-hide-details-mode)) + (define-key map [menu-bar immediate hide-details] + '(menu-item "Hide Details" dired-hide-details-mode + :help "Hide details in buffer" + :visible (not dired-hide-details-mode))) (define-key map [menu-bar immediate revert-buffer] '(menu-item "Refresh" revert-buffer :help "Update contents of shown directories")) @@ -1912,6 +1934,9 @@ selective-display t ; for subdirectory hiding mode-line-buffer-identification (propertized-buffer-identification "%17b")) + ;; ignore dired-detail value of invisible text property by default + (when (eq buffer-invisibility-spec t) + (setq buffer-invisibility-spec (list t))) (set (make-local-variable 'revert-buffer-function) (function dired-revert)) (set (make-local-variable 'buffer-stale-function) @@ -2228,6 +2253,20 @@ (substring file (match-end 0)) file)) +;;; Minor mode for hiding details +;;;###autoload +(define-minor-mode dired-hide-details-mode + "Hide details in `dired-mode'." + :group 'dired + (unless (derived-mode-p 'dired-mode) + (error "Not a Dired buffer")) + (funcall (if dired-hide-details-mode + 'add-to-invisibility-spec + 'remove-from-invisibility-spec) + 'dired-detail)) + +(put 'dired-hide-details-mode 'safe-local-variable 'booleanp) + ;;; Functions for finding the file name in a dired buffer line. (defvar dired-permission-flags-regexp --=-=-= Content-Type: text/plain I would love to hear your feedback. >> (save-restriction >> (widen) > > Please add a comment explaining why widening should be used here. Widening is not necessary any more. >> do (let ((buffer-read-only)) >> (put-text-property (point) end >> 'invisible my-dired-hide-details-mode)) > > Better bind inhibit-read-only to t. Or better yet, use > with-silent-modifications (but move it outside the loop). > > Also, rather than set the invisible property to nil or t, better set > it to another symbol (e.g. `dired-details'), whose meaning is then > controlled by add-to-invisibility-spec. Right. Obviously this simplifies the implementation. >> (defadvice dired-insert-set-properties >> (after my-add-hide-props (beg end) activate) > > Obviously, this would have to be turned into a patch, and since it's > not small, it would need to be moved to its own function (which would > be called from dired-insert-set-properties). Check the new patch. Altogether 7 new lines are added to dired-insert-set-properties. >> (defadvice find-dired (after my-fix-move-process-mark-to-arg activate) >> (move-marker (process-mark (get-buffer-process (current-buffer))) >> (save-excursion >> (goto-char (point-min)) >> (forward-line 1) >> (point)))) > > How is that related to dired-details? This is not necessary any more. My former implementation hid every non-file line that dired-insert-set-properties is called upon. Vanilla dired calls dired-insert-set-properties on every line except the directory headerline so my-dired-hide-details-mode hid the information line. total used in directory RMS available VI Initially find-dired inserts the directory headerline, newline and the find arguments and set the process mark is set to 1. In the process filter of find find-dired evals (dired-insert-set-properties (process-mark proc) (1+ (point))) (move-marker (process-mark proc) (1+ (point))) with (point) being right before the end of the last complete line added by find. That is dired-insert-set-properties is called on the first and second line so my former code added the invisible property to the directory headerline as well. This is why I added that advice - just move the process mark to the second line so dired-insert-set-properties is not called on the directory headerline. I removed the hiding of non-file lines. Hiding full lines via text properties might cause confusion when it comes to interactive line movement. There are no changed to find-dired.el now. Christopher --=-=-=-- From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Feb 2013 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136050858017019 (code B ref -1); Sun, 10 Feb 2013 15:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Feb 2013 15:03:00 +0000 Received: from localhost ([127.0.0.1]:49096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4YQl-0004QQ-3u for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:03:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36309) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4YQh-0004QF-Cs for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:02:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4YQM-0007Fg-Sx for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:02:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4YQM-0007Fc-Q9 for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:02:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4YQI-0005JE-Ba for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 10:02:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4YQC-0007DZ-KJ for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 10:02:30 -0500 Received: from ristopher.com ([146.185.21.93]:55145 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4YQC-0007DL-8m for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 10:02:24 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 618F720AA1; Sun, 10 Feb 2013 15:02:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360508541; bh=yM6swz/IdDJf/UZQI0uNlYYUTH6SGegFmST9R2FeUwU=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=FJoYtmehDuU6G77T/l0X8ourSk0+UfWeU2aYbEdxTCNH93YHzOvibfRf5AhILqUTJ MhY7yGQU7gxYKNWWQfNczhEg1WWf9UwBArnccBjiXBrSyW3GTp6i1objxkGNK0gOoB xZLEj6A7+BagLJL2woLAK1UYtSzeddIBPySJEkQo= From: Christopher Schmidt In-Reply-To: <87mwxcx149@ch.ristopher.com> (Christopher Schmidt's message of "Mon, 17 Dec 2012 13:24:31 +0000 (GMT)") Message-ID: <87wqugmcu8@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Date: Sun, 10 Feb 2013 15:02:21 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Christopher Schmidt writes: > Here is a preliminary patch for the trunk. Here is the final patch. Drew Adams and Michael Heerdegen tested it and did not find any problems. --=-=-= Content-Type: text/x-diff Content-Disposition: inline --- lisp/ChangeLog +++ lisp/ChangeLog @@ -1,5 +1,25 @@ 2013-02-10 Christopher Schmidt + * locate.el (locate-mode-map): Disable dired-hide-details-mode. + + * find-dired.el (find-dired): Call dired-insert-set-properties on + initial information line. Set process mark on end of buffer. + (find-dired-sentinel): Call dired-insert-set-properties on + summary. + + * dired.el (dired-hide-details-hide-symlink-targets) + (dired-hide-details-hide-information-lines): New options. + (dired-insert-directory): Set properties after final treatment of + output. + (dired-insert-set-properties): Set dired-hide-details-* + properties. + (dired-mode-map): Bind dired-hide-details-mode. + (dired-mode): Set buffer-invisibility-spec to a list. + (dired-next-line): Skip hidden lines. + (dired-previous-line): Use dired-next-line. + (dired-hide-details-mode): New minor mode. + (dired-hide-details-update-invisibility-spec): New function. + * minibuf-eldef.el (minibuffer-default--in-prompt-regexps): Handle "foo (bar, default: xxx): " prompts. --- lisp/dired.el +++ lisp/dired.el @@ -230,6 +230,18 @@ :version "22.1" :group 'dired) +(defcustom dired-hide-details-hide-symlink-targets t + "If non-nil, `dired-hide-details-mode' hides symbolic link targets." + :type 'boolean + :version "24.4" + :group 'dired) + +(defcustom dired-hide-details-hide-information-lines t + "Non-nil means hide lines other than header and file/dir lines." + :type 'boolean + :version "24.4" + :group 'dired) + ;; Internal variables (defvar dired-marker-char ?* ; the answer is 42 @@ -1196,7 +1208,6 @@ ;; Note: adjust dired-build-subdir-alist if you change this. (setq dir (replace-regexp-in-string "\\\\" "\\\\" dir nil t) dir (replace-regexp-in-string "\n" "\\n" dir nil t))) - (dired-insert-set-properties opoint (point)) ;; If we used --dired and it worked, the lines are already indented. ;; Otherwise, indent them. (unless (save-excursion @@ -1205,18 +1216,21 @@ (let ((indent-tabs-mode nil)) (indent-rigidly opoint (point) 2))) ;; Insert text at the beginning to standardize things. - (save-excursion - (goto-char opoint) - (if (and (or hdr wildcard) - (not (and (looking-at "^ \\(.*\\):$") - (file-name-absolute-p (match-string 1))))) + (let ((content-point opoint)) + (save-excursion + (goto-char opoint) + (when (and (or hdr wildcard) + (not (and (looking-at "^ \\(.*\\):$") + (file-name-absolute-p (match-string 1))))) ;; Note that dired-build-subdir-alist will replace the name ;; by its expansion, so it does not matter whether what we insert ;; here is fully expanded, but it should be absolute. - (insert " " (directory-file-name (file-name-directory dir)) ":\n")) - (when wildcard - ;; Insert "wildcard" line where "total" line would be for a full dir. - (insert " wildcard " (file-name-nondirectory dir) "\n"))))) + (insert " " (directory-file-name (file-name-directory dir)) ":\n") + (setq content-point (point))) + (when wildcard + ;; Insert "wildcard" line where "total" line would be for a full dir. + (insert " wildcard " (file-name-nondirectory dir) "\n"))) + (dired-insert-set-properties content-point (point))))) (defun dired-insert-set-properties (beg end) "Add various text properties to the lines in the region." @@ -1224,15 +1238,24 @@ (goto-char beg) (while (< (point) end) (condition-case nil - (if (dired-move-to-filename) - (add-text-properties - (point) - (save-excursion - (dired-move-to-end-of-filename) - (point)) - '(mouse-face highlight - dired-filename t - help-echo "mouse-2: visit this file in other window"))) + (if (not (dired-move-to-filename)) + (put-text-property (line-beginning-position) + (1+ (line-end-position)) + 'invisible 'dired-hide-details-information) + (put-text-property (+ (line-beginning-position) 1) (1- (point)) + 'invisible 'dired-hide-details-detail) + (add-text-properties + (point) + (progn + (dired-move-to-end-of-filename) + (point)) + '(mouse-face + highlight + dired-filename t + help-echo "mouse-2: visit this file in other window")) + (when (< (+ (point) 4) (line-end-position)) + (put-text-property (+ (point) 4) (line-end-position) + 'invisible 'dired-hide-details-link))) (error nil)) (forward-line 1)))) @@ -1496,6 +1519,7 @@ ;; hiding (define-key map "$" 'dired-hide-subdir) (define-key map "\M-$" 'dired-hide-all) + (define-key map "(" 'dired-hide-details-mode) ;; isearch (define-key map (kbd "M-s a C-s") 'dired-do-isearch) (define-key map (kbd "M-s a M-C-s") 'dired-do-isearch-regexp) @@ -1586,6 +1610,14 @@ '(menu-item "Toggle Image Thumbnails in This Buffer" image-dired-dired-toggle-marked-thumbs :help "Add or remove image thumbnails in front of marked file names")) + (define-key map [menu-bar immediate unhide-details] + '(menu-item "UnHide Details" dired-hide-details-mode + :help "Unhide details in buffer" + :visible dired-hide-details-mode)) + (define-key map [menu-bar immediate hide-details] + '(menu-item "Hide Details" dired-hide-details-mode + :help "Hide details in buffer" + :visible (not dired-hide-details-mode))) (define-key map [menu-bar immediate revert-buffer] '(menu-item "Refresh" revert-buffer :help "Update contents of shown directories")) @@ -1914,6 +1946,9 @@ selective-display t ; for subdirectory hiding mode-line-buffer-identification (propertized-buffer-identification "%17b")) + ;; ignore dired-hide-details-* value of invisible text property by default + (when (eq buffer-invisibility-spec t) + (setq buffer-invisibility-spec (list t))) (set (make-local-variable 'revert-buffer-function) (function dired-revert)) (set (make-local-variable 'buffer-stale-function) @@ -1978,15 +2013,32 @@ "Move down lines then position at filename. Optional prefix ARG says how many lines to move; default is one line." (interactive "p") + (unless arg + (setq arg 1)) (forward-line arg) + (while (and (progn + (while (and (< arg 0) + (bolp) + (/= (1+ (point)) (point-max)) + (eq (get-text-property (1+ (point)) 'invisible) + 'dired-hide-details-information)) + (forward-char -1)) + (invisible-p (point))) + (let ((p (funcall (if (> arg 0) + 'next-single-property-change + 'previous-single-property-change) + (point) + 'invisible))) + (when p + (goto-char p) + t)))) (dired-move-to-filename)) -(defun dired-previous-line (arg) +(defun dired-previous-linel (arg) "Move up lines then position at filename. Optional prefix ARG says how many lines to move; default is one line." (interactive "p") - (forward-line (- arg)) - (dired-move-to-filename)) + (dired-next-line (- (or arg 1)))) (defun dired-next-dirline (arg &optional opoint) "Goto ARG'th next directory file line." @@ -2230,6 +2282,42 @@ (substring file (match-end 0)) file)) +;;; Minor mode for hiding details +;;;###autoload +(define-minor-mode dired-hide-details-mode + "Hide details in `dired-mode'." + :group 'dired + (if (derived-mode-p 'locate-mode) + (setq dired-hide-details-mode nil) + (unless (derived-mode-p 'dired-mode) + (error "Not a Dired buffer")) + (dired-hide-details-update-invisibility-spec) + (if dired-hide-details-mode + (add-hook 'wdired-mode-hook + 'dired-hide-details-update-invisibility-spec + nil + t) + (remove-hook 'wdired-mode-hook + 'dired-hide-details-update-invisibility-spec + t)))) + +(defun dired-hide-details-update-invisibility-spec () + (funcall (if dired-hide-details-mode + 'add-to-invisibility-spec + 'remove-from-invisibility-spec) + 'dired-hide-details-detail) + (funcall (if (and dired-hide-details-mode + dired-hide-details-hide-information-lines) + 'add-to-invisibility-spec + 'remove-from-invisibility-spec) + 'dired-hide-details-information) + (funcall (if (and dired-hide-details-mode + dired-hide-details-hide-symlink-targets + (not (derived-mode-p 'wdired-mode))) + 'add-to-invisibility-spec + 'remove-from-invisibility-spec) + 'dired-hide-details-link)) + ;;; Functions for finding the file name in a dired buffer line. (defvar dired-permission-flags-regexp --- lisp/find-dired.el +++ lisp/find-dired.el @@ -210,13 +210,15 @@ (insert " " dir ":\n") ;; Make second line a ``find'' line in analogy to the ``total'' or ;; ``wildcard'' line. - (insert " " args "\n") + (let ((point (point))) + (insert " " args "\n") + (dired-insert-set-properties point (point))) (setq buffer-read-only t) (let ((proc (get-buffer-process (current-buffer)))) (set-process-filter proc (function find-dired-filter)) (set-process-sentinel proc (function find-dired-sentinel)) ;; Initialize the process marker; it is used by the filter. - (move-marker (process-mark proc) 1 (current-buffer))) + (move-marker (process-mark proc) (point) (current-buffer))) (setq mode-line-process '(":%s")))) (defun kill-find () @@ -337,10 +339,11 @@ (let ((buffer-read-only nil)) (save-excursion (goto-char (point-max)) - (insert "\n find " state) - (forward-char -1) ;Back up before \n at end of STATE. - (insert " at " (substring (current-time-string) 0 19)) - (forward-char 1) + (let ((point (point))) + (insert "\n find " state) + (forward-char -1) ;Back up before \n at end of STATE. + (insert " at " (substring (current-time-string) 0 19)) + (dired-insert-set-properties point (point))) (setq mode-line-process (concat ":" (symbol-name (process-status proc)))) --- lisp/locate.el +++ lisp/locate.el @@ -382,6 +382,7 @@ (define-key map "l" 'locate-do-redisplay) (define-key map "U" 'dired-unmark-all-files) (define-key map "V" 'locate-find-directory) + (define-key map [remap dired-hide-details-mode] nil) map) "Local keymap for Locate mode buffers.") --=-=-= Content-Type: text/plain Should the key bindings and definition of dired-hide-details-mode go into dired-x.el? Christopher --=-=-=-- From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Feb 2013 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136050892917523 (code B ref -1); Sun, 10 Feb 2013 15:09:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Feb 2013 15:08:49 +0000 Received: from localhost ([127.0.0.1]:49106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4YWN-0004YY-SC for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:08:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37432) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4YWL-0004YR-7p for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:08:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4YW4-0000FS-0u for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:08:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4YW3-0000FN-UK for submit@debbugs.gnu.org; Sun, 10 Feb 2013 10:08:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4YW1-0006P9-60 for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 10:08:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4YVy-0000Dy-Av for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 10:08:25 -0500 Received: from ristopher.com ([146.185.21.93]:55149 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4YVy-0000Dt-5b for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 10:08:22 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 3D4C520AA1; Sun, 10 Feb 2013 15:08:20 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360508900; bh=Jcsp94+q9KGRQ31UaXGI3P2APQYJsT9mDIBaIwe13M4=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=HN0X1gJpNpY9+2igYNp+1Q6V+9fI5FZQCi6fwoFyvXlKM73lD74lcQBNZBmRnQlYC yz/XJ9ShVYe8ReommISxV5DlZG+yRama+/oeYBZY3fOgzI3X4lm8x0DlqcM9OEufRy C/QK+Htfeeop4apfKmRR4JkYad1PD9J3of9FQIn8= From: Christopher Schmidt In-Reply-To: <87wqugmcu8@ch.ristopher.com> (Christopher Schmidt's message of "Sun, 10 Feb 2013 15:02:21 +0000 (GMT)") Message-ID: <87liawmcka@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Sun, 10 Feb 2013 15:08:20 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Christopher Schmidt writes: > -(defun dired-previous-line (arg) > +(defun dired-previous-linel (arg) That's a typo. Christopher From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Feb 2013 03:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13605539053098 (code B ref -1); Mon, 11 Feb 2013 03:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2013 03:38:25 +0000 Received: from localhost ([127.0.0.1]:49656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4kDo-0000nu-MS for submit@debbugs.gnu.org; Sun, 10 Feb 2013 22:38:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37167) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4kDg-0000ni-Ub for submit@debbugs.gnu.org; Sun, 10 Feb 2013 22:38:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4kDO-0001ng-9D for submit@debbugs.gnu.org; Sun, 10 Feb 2013 22:37:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:50431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4kDO-0001nc-6b for submit@debbugs.gnu.org; Sun, 10 Feb 2013 22:37:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4kDM-0002rP-TJ for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 22:37:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4kDK-0001nI-PN for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 22:37:56 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:28120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4kDK-0001nC-L8 for bug-gnu-emacs@gnu.org; Sun, 10 Feb 2013 22:37:54 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtjWGDKQOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtjWGDKQOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="942319" Received: from 69-165-153-237.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Feb 2013 22:37:53 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id AE808AE2BE; Sun, 10 Feb 2013 22:37:53 -0500 (EST) From: Stefan Monnier Message-ID: References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> Date: Sun, 10 Feb 2013 22:37:53 -0500 In-Reply-To: <87wqugmcu8@ch.ristopher.com> (Christopher Schmidt's message of "Sun, 10 Feb 2013 15:02:21 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.8 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > Here is the final patch. Drew Adams and Michael Heerdegen tested it and > did not find any problems. Thanks. A few nitpicks and comments below. > + ;; ignore dired-hide-details-* value of invisible text property by default > + (when (eq buffer-invisibility-spec t) > + (setq buffer-invisibility-spec (list t))) Please capitalize and punctuate your comments. > (forward-line arg) > + (while (and (progn > + (while (and (< arg 0) > + (bolp) > + (/= (1+ (point)) (point-max)) > + (eq (get-text-property (1+ (point)) 'invisible) > + 'dired-hide-details-information)) > + (forward-char -1)) > + (invisible-p (point))) > + (let ((p (funcall (if (> arg 0) > + 'next-single-property-change > + 'previous-single-property-change) > + (point) > + 'invisible))) > + (when p > + (goto-char p) > + t)))) > (dired-move-to-filename)) What is this for? > + (if (derived-mode-p 'locate-mode) > + (setq dired-hide-details-mode nil) Could you explain why locate-mode needs such special treatment (here and in locate-mode-map)? I'm mostly worried here that maybe some other mode might require similar treatment. Stefan From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Feb 2013 08:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136057083328953 (code B ref -1); Mon, 11 Feb 2013 08:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2013 08:20:33 +0000 Received: from localhost ([127.0.0.1]:49779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4ocq-0007Wv-Lc for submit@debbugs.gnu.org; Mon, 11 Feb 2013 03:20:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51214) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4ocn-0007Wl-Gn for submit@debbugs.gnu.org; Mon, 11 Feb 2013 03:20:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4ocN-0003jp-KV for submit@debbugs.gnu.org; Mon, 11 Feb 2013 03:20:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4ocN-0003jh-Hp for submit@debbugs.gnu.org; Mon, 11 Feb 2013 03:20:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4ocI-0001So-PZ for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 03:20:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4ocF-0003e4-S4 for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 03:19:58 -0500 Received: from ristopher.com ([146.185.21.93]:55288 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4ocF-0003du-Gk for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 03:19:55 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id F418820AA2; Mon, 11 Feb 2013 08:19:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360570793; bh=p8lcPxTYq492OwUp5rRgfJ7cp1dO8CMsQFq3w8fQQG4=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=DNPmf91Nhqc60SvrJ5LKt4wwA+/Gpsaak+JOM4oMCdZt88TcQkZgQ8q4BB7G4EFHi ZW7lNY6BplnvN1rb21LwQS5kz22ts5uiKWQ6bbbF1+UFkvcunv2w6tXBpyLgYrj03p 84ugI2I5BHsRTb8qNnYmFLxoySJcIqBV9nKbkeqg= From: Christopher Schmidt In-Reply-To: (Stefan Monnier's message of "Sun, 10 Feb 2013 22:37:53 -0500") Message-ID: <87mwvbuus2@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Mon, 11 Feb 2013 08:19:52 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier writes: >> (forward-line arg) >> + (while (and (progn >> + (while (and (< arg 0) >> + (bolp) >> + (/= (1+ (point)) (point-max)) >> + (eq (get-text-property (1+ (point)) 'invisible) >> + 'dired-hide-details-information)) >> + (forward-char -1)) >> + (invisible-p (point))) >> + (let ((p (funcall (if (> arg 0) >> + 'next-single-property-change >> + 'previous-single-property-change) >> + (point) >> + 'invisible))) >> + (when p >> + (goto-char p) >> + t)))) >> (dired-move-to-filename)) > > What is this for? dired-(next|previous)-line use (forward|backward)-line for point movement. These functions ignore hidden lines and subsequent point movement by the editing loop does not do the right thing when point moves backwards over a hidden line. (defvar use-case 0) (with-selected-window (or (get-buffer-window "*moose*") (progn (split-window-below))) (switch-to-buffer (get-buffer-create "*moose*")) (erase-buffer) (insert "Header\n" (propertize "Hidden\n" 'invisible t) "Stuff") (cl-ecase use-case (0 (goto-char (point-min)) (forward-line 1)) (1 (goto-char (point-max)) (forward-line -1)) (2 (goto-char (point-min)) (next-line 1)) (3 (goto-char (point-max)) (next-line -1))) (prog1 use-case (setq use-case (% (1+ use-case) 4)))) Put that in scratch, eval the first form, eval the second form four times in a row. Use case 1 does not work. The change you cited tries to work around this problem in dired. I do not know whether dired-(next|previous)-line should use (next|previous)-line with nil-bound line-move-visual. AFAICT (next|previous)-line do not do the right thing either. >> + (if (derived-mode-p 'locate-mode) >> + (setq dired-hide-details-mode nil) > > Could you explain why locate-mode needs such special treatment (here > and in locate-mode-map)? I'm mostly worried here that maybe some > other mode might require similar treatment. The buffer generated by M-x locate RET does not contain any "details" to hide. dired-hide-details-mode would be a no-op there. Locate buffers are not real dired buffer. locate-mode is an independent major mode whose keymap derives from dired-mode-map. locate runs dired-mode-hook despite the current buffer not being derived from dired-mode. I think ignoring locate is better than complaining that dired-hide-details-mode is enabled in a buffer that is not derived from dired-mode. I am not aware of any other mode that behaves that way. Christopher From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Feb 2013 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13605927763140 (code B ref -1); Mon, 11 Feb 2013 14:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2013 14:26:16 +0000 Received: from localhost ([127.0.0.1]:50195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4uKl-0000oa-74 for submit@debbugs.gnu.org; Mon, 11 Feb 2013 09:26:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35306) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4uKe-0000oP-KY for submit@debbugs.gnu.org; Mon, 11 Feb 2013 09:26:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4uKI-0002c3-B4 for submit@debbugs.gnu.org; Mon, 11 Feb 2013 09:25:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4uKI-0002bw-6U for submit@debbugs.gnu.org; Mon, 11 Feb 2013 09:25:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4uKG-0002H3-Eq for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 09:25:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4uKF-0002bf-0R for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 09:25:44 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:9683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4uKE-0002bT-Lg for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 09:25:42 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="963442" Received: from 69-165-153-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Feb 2013 09:25:41 -0500 Received: by pastel.home (Postfix, from userid 20848) id AAE7159527; Mon, 11 Feb 2013 09:25:40 -0500 (EST) From: Stefan Monnier Message-ID: References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> Date: Mon, 11 Feb 2013 09:25:40 -0500 In-Reply-To: <87mwvbuus2@ch.ristopher.com> (Christopher Schmidt's message of "Mon, 11 Feb 2013 08:19:52 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.2 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > dired-(next|previous)-line use (forward|backward)-line for point > movement. These functions ignore hidden lines and subsequent point > movement by the editing loop does not do the right thing when point > moves backwards over a hidden line. Thanks. Then the code needs a clear comment about it, citing the specific concrete case that it's trying to fix. > (defvar use-case 0) > (with-selected-window > (or (get-buffer-window "*moose*") > (progn > (split-window-below))) > (switch-to-buffer (get-buffer-create "*moose*")) > (erase-buffer) > (insert "Header\n" > (propertize "Hidden\n" 'invisible t) > "Stuff") > (cl-ecase use-case > (0 > (goto-char (point-min)) > (forward-line 1)) > (1 > (goto-char (point-max)) > (forward-line -1)) > (2 > (goto-char (point-min)) > (next-line 1)) > (3 > (goto-char (point-max)) > (next-line -1))) > (prog1 use-case > (setq use-case (% (1+ use-case) 4)))) > Put that in scratch, eval the first form, eval the second form four > times in a row. Use case 1 does not work. The change you cited tries > to work around this problem in dired. I'm not sure what this shows: I get a buffer with two visible lines ("Header" and "Stuff"); case 0 moves point to just before "Stuff" and so does case 1, and both seem right to my understanding of the code you provided. > I do not know whether dired-(next|previous)-line should use > (next|previous)-line with nil-bound line-move-visual. AFAICT > (next|previous)-line do not do the right thing either. >>> + (if (derived-mode-p 'locate-mode) >>> + (setq dired-hide-details-mode nil) >> Could you explain why locate-mode needs such special treatment (here >> and in locate-mode-map)? I'm mostly worried here that maybe some >> other mode might require similar treatment. > The buffer generated by M-x locate RET does not contain any "details" to > hide. dired-hide-details-mode would be a no-op there. A no-op doesn't sound like a bad thing. > Locate buffers are not real dired buffer. locate-mode is an independent > major mode whose keymap derives from dired-mode-map. locate runs > dired-mode-hook despite the current buffer not being derived from > dired-mode. Indeed, it looks messy: it runs dired-mode-hook but not from locate-mode. Of course, part of it is because dired-mode is still not written as a proper mode function (e.g. it requires a `dir' argument), so locate can't use it to derive from it. > I think ignoring locate is better than complaining that > dired-hide-details-mode is enabled in a buffer that is not derived > from dired-mode. If, as you say, dired-details would simply be a no-op in locate, then I think the better option is to simply ignore locate, in the sense of not doing anything special about, rather than write code that tries to actively avoid running dired-details code in locate. > I am not aware of any other mode that behaves that way. I was thinking of virtual-dired (in dired-x), vc-dired (which doesn't exist any more in Emacs, but there might still be similar thingies out there), ... Stefan From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Feb 2013 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136059897219583 (code B ref -1); Mon, 11 Feb 2013 16:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2013 16:09:32 +0000 Received: from localhost ([127.0.0.1]:51051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4vwh-00055n-CO for submit@debbugs.gnu.org; Mon, 11 Feb 2013 11:09:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34586) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4vwZ-00055a-Tf for submit@debbugs.gnu.org; Mon, 11 Feb 2013 11:09:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4vw8-0004Kt-Ci for submit@debbugs.gnu.org; Mon, 11 Feb 2013 11:09:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4vw8-0004Kp-9r for submit@debbugs.gnu.org; Mon, 11 Feb 2013 11:08:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4vw4-0003pi-5i for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 11:08:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4vvx-0004GT-UF for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 11:08:52 -0500 Received: from ristopher.com ([146.185.21.93]:55334 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4vvx-0004Fu-Jd for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 11:08:45 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id B502E20AA9; Mon, 11 Feb 2013 16:08:42 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360598922; bh=Brt+5aTDqmABWtIGYuiQ8WJcWgqu32NSIOb2QrOqTIg=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=UmWhRmpDBmwvABx0EzTblKfHU3Wz4pBZ9jJzE8fdwdQaLWyeX0ZgHSchKOBDByGmJ ITN9DtDVJ0Suq8G53LP4+MEukIb+O8xxQgZObrD8Pvqjz4aFcBVkLOgAmRng8GsbZe xJoAiKth12ZNkRJslIEmGa327YbjDmteV7iEDEDU= From: Christopher Schmidt In-Reply-To: (Stefan Monnier's message of "Mon, 11 Feb 2013 09:25:40 -0500") Message-ID: <87k3qeestt@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Mon, 11 Feb 2013 16:08:42 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier writes: Hi Stefan, thank you very much for your feedback. >> dired-(next|previous)-line use (forward|backward)-line for point >> movement. These functions ignore hidden lines and subsequent point >> movement by the editing loop does not do the right thing when point >> moves backwards over a hidden line. > > Thanks. Then the code needs a clear comment about it, citing the > specific concrete case that it's trying to fix. [...] >> Put that in scratch, eval the first form, eval the second form four >> times in a row. Use case 1 does not work. The change you cited >> tries to work around this problem in dired. > > I'm not sure what this shows: I get a buffer with two visible lines > ("Header" and "Stuff"); case 0 moves point to just before "Stuff" and > so does case 1, and both seem right to my understanding of the code > you provided. Emacs behaves correctly. (forward-line -1) is executed but the point does not move across one visible line. (dired-next-line -1) should skip hidden lines, though. (next-line -1) does the right thing. Unfortunately next-line has some quirks, such as goal-column, next-line-add-newlines, etc. What about using line-move directly? The workaround is less cumbersome. (defun dired-next-line (arg) "Move down lines then position at filename. Optional prefix ARG says how many lines to move; default is one line." (interactive "p") (let ((line-move-visual) (goal-column)) (line-move arg t)) ;; We never want to move point into an invisible line. (while (and (invisible-p (point)) (not (if (and arg (< arg 0)) (bobp) (eobp)))) (forward-char (if (and arg (< arg 0)) -1 1))) (dired-move-to-filename)) >>>> + (if (derived-mode-p 'locate-mode) >>>> + (setq dired-hide-details-mode nil) >>> Could you explain why locate-mode needs such special treatment (here >>> and in locate-mode-map)? I'm mostly worried here that maybe some >>> other mode might require similar treatment. >> The buffer generated by M-x locate RET does not contain any "details" >> to hide. dired-hide-details-mode would be a no-op there. > > A no-op doesn't sound like a bad thing. There is the message "Dired-Hide-Details mode (disabled|enabled)". Is there any reason for locate-filename-indentation to be 4 rather than 2 by default? Dired-hide-details-mode considers everything from the third character to the file name to be a detail. That is dired-hide-details-mode hides these two spaces if enabled. This is either a bug or a feature. I do not know. Other than that, dired-hide-details-mode it is a no-op in locate-mode buffers. >> Locate buffers are not real dired buffer. locate-mode is an >> independent major mode whose keymap derives from dired-mode-map. >> locate runs dired-mode-hook despite the current buffer not being >> derived from dired-mode. > > Indeed, it looks messy: it runs dired-mode-hook but not from > locate-mode. Of course, part of it is because dired-mode is still not > written as a proper mode function (e.g. it requires a `dir' argument), > so locate can't use it to derive from it. Could we set the derived-mode-parent property of locate-mode to dired-mode? One way or another, (derived-mode-p 'dired-mode) should return non-nil in locate-mode buffers. >> I think ignoring locate is better than complaining that >> dired-hide-details-mode is enabled in a buffer that is not derived >> from dired-mode. > > If, as you say, dired-details would simply be a no-op in locate, then > I think the better option is to simply ignore locate, in the sense of > not doing anything special about, rather than write code that tries to > actively avoid running dired-details code in locate. Ok. >> I am not aware of any other mode that behaves that way. > > I was thinking of virtual-dired (in dired-x), vc-dired (which doesn't > exist any more in Emacs, but there might still be similar thingies out > there), ... As long as these modes use dired-insert-set-properties in the way it is meant to be there should not be a problem. Christopher From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Feb 2013 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1360605544342 (code B ref -1); Mon, 11 Feb 2013 18:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2013 17:59:04 +0000 Received: from localhost ([127.0.0.1]:51114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4xeh-00005T-MD for submit@debbugs.gnu.org; Mon, 11 Feb 2013 12:59:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34955) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4xed-000053-7P for submit@debbugs.gnu.org; Mon, 11 Feb 2013 12:59:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4xeG-0000Dh-Lf for submit@debbugs.gnu.org; Mon, 11 Feb 2013 12:58:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:54376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4xeG-0000Dc-IW for submit@debbugs.gnu.org; Mon, 11 Feb 2013 12:58:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4xeF-0003Q9-CD for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 12:58:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4xeC-0000CP-Kx for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 12:58:35 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:12262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4xeC-0000CE-Hd for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 12:58:32 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDVGHcQbBLY1hgykDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFFFpZnt/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDVGHcQbBLY1hgykDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="989970" Received: from 69-165-153-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Feb 2013 12:58:31 -0500 Received: by pastel.home (Postfix, from userid 20848) id 2F55459255; Mon, 11 Feb 2013 12:58:31 -0500 (EST) From: Stefan Monnier Message-ID: References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> Date: Mon, 11 Feb 2013 12:58:30 -0500 In-Reply-To: <87k3qeestt@ch.ristopher.com> (Christopher Schmidt's message of "Mon, 11 Feb 2013 16:08:42 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.2 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) >> I'm not sure what this shows: I get a buffer with two visible lines >> ("Header" and "Stuff"); case 0 moves point to just before "Stuff" and >> so does case 1, and both seem right to my understanding of the code >> you provided. > Emacs behaves correctly. (forward-line -1) is executed but the point > does not move across one visible line. I'm sorry if I'm maybe a bit dense, but I don't understand what you're saying. Please be more specific (and feel free to use a concrete example from dired-details rather than from your test case). I especially don't understand because IIUC dired-details only ever hides parts of a line (i.e. it never hides an LF) and it never hides the filename itself, so it neither affects what (forward-char arg) should do nor what (dired-move-to-filename) should do and after those two, the cursor should be placed in a visible spot, so there's no need to move the cursor. > Is there any reason for locate-filename-indentation to be 4 rather than > 2 by default? I have no idea, sorry. > Other than that, dired-hide-details-mode it is a no-op in locate-mode > buffers. Then let's not do anything special for locate-mode. BTW, I saw another detail in your code that should be improved: + (define-key map [menu-bar immediate unhide-details] + '(menu-item "UnHide Details" dired-hide-details-mode + :help "Unhide details in buffer" + :visible dired-hide-details-mode)) + (define-key map [menu-bar immediate hide-details] + '(menu-item "Hide Details" dired-hide-details-mode + :help "Hide details in buffer" + :visible (not dired-hide-details-mode))) this should use a single entry with a toggle box. Example from the elisp manual: (menu-item "Debug on Error" toggle-debug-on-error :button (:toggle . (and (boundp 'debug-on-error) debug-on-error))) >>> Locate buffers are not real dired buffer. locate-mode is an >>> independent major mode whose keymap derives from dired-mode-map. >>> locate runs dired-mode-hook despite the current buffer not being >>> derived from dired-mode. >> Indeed, it looks messy: it runs dired-mode-hook but not from >> locate-mode. Of course, part of it is because dired-mode is still not >> written as a proper mode function (e.g. it requires a `dir' argument), >> so locate can't use it to derive from it. > Could we set the derived-mode-parent property of locate-mode to > dired-mode? One way or another, (derived-mode-p 'dired-mode) should > return non-nil in locate-mode buffers. That sounds right, yes. >> I was thinking of virtual-dired (in dired-x), vc-dired (which doesn't >> exist any more in Emacs, but there might still be similar thingies out >> there), ... > As long as these modes use dired-insert-set-properties in the way it is > meant to be there should not be a problem. OK, great. Then feel free to install at your convenience (with a note in etc/NEWS as well), Stefan From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Feb 2013 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Stefan Monnier'" , <6799@debbugs.gnu.org> Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.13606060691151 (code B ref 6799); Mon, 11 Feb 2013 18:08:02 +0000 Received: (at 6799) by debbugs.gnu.org; 11 Feb 2013 18:07:49 +0000 Received: from localhost ([127.0.0.1]:51119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4xn8-0000IU-AT for submit@debbugs.gnu.org; Mon, 11 Feb 2013 13:07:48 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:19945) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4xn6-0000IM-AF for 6799@debbugs.gnu.org; Mon, 11 Feb 2013 13:07:45 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1BI7LkG019085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Feb 2013 18:07:22 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1BI7KLF016093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Feb 2013 18:07:20 GMT Received: from abhmt101.oracle.com (abhmt101.oracle.com [141.146.116.53]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1BI7Jhg020590; Mon, 11 Feb 2013 12:07:19 -0600 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 11 Feb 2013 10:07:19 -0800 From: "Drew Adams" References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com><5EA47A0255F8494DB430B52D46876641@us.oracle.com><65D921448B0644988BE6445A2EF3E021@us.oracle.com><21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com><878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com><87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> Date: Mon, 11 Feb 2013 10:07:18 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac4IgZX1e4pp6fL8Q6utgJjVVL7U7QAAFSRQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > Please be more specific (and feel free to use > a concrete example from dired-details rather than from your > test case). Just a nit. To be fair and to avoid confusion, let's please not refer to these enhancements using the name `dired-details'. That name was taken by Rob Giardina for his library dired-details.el (see the Subject line). If this enhancement implements `dired-hide-details-mode', then please call it that, or speak of "dired-hide-details". From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Feb 2013 19:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136061237710189 (code B ref -1); Mon, 11 Feb 2013 19:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2013 19:52:57 +0000 Received: from localhost ([127.0.0.1]:51151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4zQv-0002eI-6C for submit@debbugs.gnu.org; Mon, 11 Feb 2013 14:52:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41121) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4zQr-0002eA-LZ for submit@debbugs.gnu.org; Mon, 11 Feb 2013 14:52:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4zQT-000685-E5 for submit@debbugs.gnu.org; Mon, 11 Feb 2013 14:52:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4zQT-000681-Au for submit@debbugs.gnu.org; Mon, 11 Feb 2013 14:52:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4zQQ-0005d9-Ib for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 14:52:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4zQJ-00066S-OH for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 14:52:26 -0500 Received: from ristopher.com ([146.185.21.93]:55371 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4zQJ-00066G-HI for bug-gnu-emacs@gnu.org; Mon, 11 Feb 2013 14:52:19 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id DBC7D20AA9; Mon, 11 Feb 2013 19:52:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360612336; bh=xju/9kgU5nhm0DuiBouaUYIVqRf3aLDMrpNQp/92lZ4=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=J5Nn+nItv4U/u2NiqHSb9phz0oyEh6CAGdYixMkbTqEYoC6pZ/N7vDw2CPa92JpuT hbQ18Rwk7el83nX1HvFUFb2/tr3g+RxE1YTf7vuuCUFei5aWT6DTuFre+PDZDwg+p+ bJ/2oJLm87gOKfa02XK7LYrcwiyTxciqIHgGQERo= From: Christopher Schmidt In-Reply-To: (Stefan Monnier's message of "Mon, 11 Feb 2013 12:58:30 -0500") Message-ID: <87ehgm7hmx@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Mon, 11 Feb 2013 19:52:16 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier writes: > I'm sorry if I'm maybe a bit dense, but I don't understand what you're > saying. Please be more specific (and feel free to use a concrete > example from dired-details rather than from your test case). I am sorry for not being on point and specific. > I especially don't understand because IIUC dired-details only ever > hides parts of a line (i.e. it never hides an LF) and it never hides > the filename itself, so it neither affects what (forward-char arg) > nshould do nor what (dired-move-to-filename) should do and after those > two, the cursor should be placed in a visible spot, so there's no need > to move the cursor. dired-hide-details-mode also hides full lines other than header and file/directory lines. This includes the informational line right after the header line. /my/directory: total used in directory 1M available 1.0G <-- drwx------ 2 me me 4.0K Feb 11 17:35 file Apply the patch, revert all hunks to dired-(next|previous)-line and move point around the first lines of a dired buffer with hidden details. Use C-n and C-p for point movement. > OK, great. Then feel free to install at your convenience (with a note > in etc/NEWS as well), Thank you very much. I am going to do that after I incorporate your feedback and give the code another round of testing. Thank you so much for your feedback and your help. Christopher From unknown Sun Jun 22 03:55:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Drew Adams" Subject: bug#6799: closed (Re: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch]) Message-ID: References: <87fw10fsjk@ch.ristopher.com> <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> X-Gnu-PR-Message: they-closed 6799 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 6799@debbugs.gnu.org Date: Wed, 13 Feb 2013 09:55:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1360749302-8775-1" This is a multi-part message in MIME format... ------------=_1360749302-8775-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6799: 24.0.50; Please add dired-details.el to Emacs [patch] which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6799@debbugs.gnu.org. --=20 6799: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6799 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1360749302-8775-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6799-done) by debbugs.gnu.org; 13 Feb 2013 09:54:36 +0000 Received: from localhost ([127.0.0.1]:53289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5Z2y-0002Gt-Jg for submit@debbugs.gnu.org; Wed, 13 Feb 2013 04:54:36 -0500 Received: from ristopher.com ([146.185.21.93]:38689 helo=saturn.ch.ristopher.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5Z2w-0002Gm-Jv for 6799-done@debbugs.gnu.org; Wed, 13 Feb 2013 04:54:35 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id CA4A120AAE; Wed, 13 Feb 2013 09:54:01 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360749241; bh=0JdhSPQSYzuoNTvJrHg6v2WCCbfxHeDmAkUTB9oymeg=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=wHZwJ5lmGhX7q6otBgpu2g/jd8P6ppfHKGdTK/HxMIWnis6hgYtJPdxWmLSt8ARzf w3D2Kfv75B3k/zIuuGtxe+atHqodzoHxw4PwkiIQzgXcxFolA/Scwk2WXF9qKj05P8 xQsTPpa8aH0QqdT6MvGg3eaRHFtGzSxDyOj49Pmg= From: Christopher Schmidt To: 6799-done@debbugs.gnu.org Subject: Re: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] In-Reply-To: <87ehgm7hmx@ch.ristopher.com> (Christopher Schmidt's message of "Mon, 11 Feb 2013 19:52:16 +0000 (GMT)") Message-ID: <87fw10fsjk@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> MIME-Version: 1.0 Content-Type: text/plain Date: Wed, 13 Feb 2013 09:54:01 +0000 (GMT) X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 6799-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Christopher Schmidt writes: > Thank you very much. I am going to do that after I incorporate your > feedback and give the code another round of testing. Thank you so > much for your feedback and your help. I applied the patch (r111768). Christopher ------------=_1360749302-8775-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Aug 2010 14:58:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oh1u3-00032F-7j for submit@debbugs.gnu.org; Thu, 05 Aug 2010 10:58:39 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oh1u0-00031w-GW for submit@debbugs.gnu.org; Thu, 05 Aug 2010 10:58:37 -0400 Received: from lists.gnu.org ([199.232.76.165]:58372) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Oh1uU-0001Ee-1K for submit@debbugs.gnu.org; Thu, 05 Aug 2010 10:59:06 -0400 Received: from [140.186.70.92] (port=52754 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oh1uL-0006or-DF for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2010 10:59:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oh1uD-0000g1-C4 for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2010 10:58:56 -0400 Received: from rcsinet14.oracle.com ([148.87.113.126]:21846) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oh1uC-0000fC-Ue for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2010 10:58:49 -0400 Received: from rcsinet10.oracle.com (rcsinet10.oracle.com [148.87.113.121]) by rcsinet14.oracle.com (Sentrion-MP-4.0.0/Sentrion-MP-4.0.0) with ESMTP id o75ELPuR007920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Aug 2010 14:21:25 GMT Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o75EKpAf003137 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Aug 2010 14:20:53 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o759ePi1012842; Thu, 5 Aug 2010 14:20:40 GMT Received: from abhmt005.oracle.com by acsmt353.oracle.com with ESMTP id 469184311281018037; Thu, 05 Aug 2010 07:20:37 -0700 Received: from dradamslap1 (/10.159.243.64) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Aug 2010 07:20:37 -0700 From: "Drew Adams" To: Subject: 24.0.50; Please add dired-details.el to Emacs [patch] Date: Thu, 5 Aug 2010 07:20:38 -0700 Message-ID: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acs0qWCEIES3+bsXQyuhFnMTUCfaOw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4C5AC8BA.0084:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: submit Cc: 'Rob Giardina' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-08-02 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags = -Ic:/xpm/include' --- Per Juanma's request, this is a another reminder to please add `dired-details.el', with links to the threads that reference Rob = Giardino's patches. -------------------------------------- > From: Juanma Barranquero Sent: Thursday, August 05, 2010 3:19 AM > To: help-gnu-emacs@gnu.org Subject: Re: A "smaller" dired >=20 > On Wed, Aug 4, 2010 at 17:50, Drew Adams wrote > > > [FWIW - This feature was OK'd for addition to vanilla Emacs=20 > > a few years ago, but no one has bothered to add it. > > =A0The author of dired-details.el and myself tried > > several times to get past the inertia, but to no avail so far.] >=20 > A patch, or at least a reminder, to the bug list with a wishlist tag > would help IMO. -------------------------------------- > From: Drew Adams Sent: Sunday, July 19, 2009 7:34 AM > To: emacs-devel@gnu.org Subject: RE: dired-details[+].el >=20 > > I discovered dired-details and dired-details+ and found them useful. > > Could they be added to emacs? > >=20 > > http://www.emacswiki.org/emacs/DiredDetails >=20 > They were supposed to be added. Rob Giardina submitted an=20 > Emacs 23 patch two > years ago that integrates the functionality of both in a=20 > better way even than > the separate libraries dired-details[+].el.=20 >=20 > I don't think any reason was ever given for why the patch=20 > wasn't incorporated > (committed). RMS asked for comment on the merged code, but no=20 > one ever answered > his request (on emacs-devel, at least). The last time I=20 > ping'ed the list about > this was 2008-07 - I never got an answer either. >=20 > Last ping: > http://lists.gnu.org/archive/html/emacs-devel/2008-07/msg01152.html >=20 > Rob's change log and RMS's call for comment: > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg01187.html >=20 > Original thread: > http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg00226.html ------------=_1360749302-8775-1-- From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Feb 2013 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13609420189382 (code B ref -1); Fri, 15 Feb 2013 15:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Feb 2013 15:26:58 +0000 Received: from localhost ([127.0.0.1]:57777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6NBh-0002RH-RM for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59820) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6NBd-0002R8-SL for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6NAq-0001go-4g for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, T_MANY_HDRS_LCASE, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NAq-0001gk-1K for submit@debbugs.gnu.org; Fri, 15 Feb 2013 10:26:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NAk-0001EB-49 for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:26:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6NAe-0001eJ-4X for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:25:58 -0500 Received: from relais.videotron.ca ([24.201.245.36]:53485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6NAd-0001e9-Sd for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:25:52 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.208.110]) by VL-VM-MR002.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MI9004B8PJ2S050@VL-VM-MR002.ip.videotron.ca> for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 10:25:51 -0500 (EST) Received: by ceviche.home (Postfix, from userid 20848) id BD8BB66109; Fri, 15 Feb 2013 10:25:50 -0500 (EST) From: Stefan Monnier Message-id: References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> Date: Fri, 15 Feb 2013 10:25:50 -0500 In-reply-to: <87ehgm7hmx@ch.ristopher.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > dired-hide-details-mode also hides full lines other than header and > file/directory lines. This includes the informational line right after > the header line. > /my/directory: > total used in directory 1M available 1.0G <-- > drwx------ 2 me me 4.0K Feb 11 17:35 file Is that the only full line that it hides, or are there others? > Apply the patch, revert all hunks to dired-(next|previous)-line and move > point around the first lines of a dired buffer with hidden details. Use > C-n and C-p for point movement. AFAICT, the resulting behavior (when replacing dired-next-line's body with forward-line plus dired-move-to-filename) is slightly suboptimal, but only for that one "hidden usage line" at the top, and even then it's nothing too terrible. Thinking of how to "fix it right", I think we'd need to introduce something like a point-adjustment-function which dired-next-line could set, and would take a "direction" argument. So keyboard.c's adjust_point_for_property would call this function after adjusting point. But it seems difficult to introduce such a thing in a robust way: - We could have it as a variable, which gets cleared before running the next command, but then dired-next-line should only set it when called interactively (otherwise if the caller calls dired-next-line within, say, a save-excursion, you'd get surprising side-effects). - We could have it as a property on the `dired-next-line' symbol, but then we get the reverse problem, that a wrapper command that just calls dired-next-line and not much else would fail to get this part of dired-next-line's behavior. Maybe a cleaner solution is to export keyboard.c's adjust_point_for_property to Elisp so that dired-next-line can call it explicitly (to replace your "(while (and (invisible-p (point))) ...)" loop). Stefan From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Feb 2013 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136095392730928 (code B ref -1); Fri, 15 Feb 2013 18:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Feb 2013 18:45:27 +0000 Received: from localhost ([127.0.0.1]:57998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6QHm-00082k-BK for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:45:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54680) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6QHk-00082d-9h for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:45:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6QGz-000167-90 for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:44:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QGz-000161-57 for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:44:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QGt-0000kU-UU for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:44:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6QGq-00013P-Qi for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:44:31 -0500 Received: from ristopher.com ([146.185.21.93]:56144 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QGq-00012z-J8 for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:44:28 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id E00E8213F3; Fri, 15 Feb 2013 18:44:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360953864; bh=rCYXBwLjugaDzgK2U0zHyP4OT6dTaIk7wGeMGLpeTvY=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=yyhOZJils8xKiEpv1M4iUZ6awHRJutN6wievOZZ8fBo2No8wFWsSI8oC7TQfjebOl 1KXMhnwvjwSkzHRBbIM+BWVSj7pumM2gWJUGCHhcO3doKDTdGQzXLjoyzGT6SDngly ngQNFVhOpCG08YC7lXfYUf5l3LBZoY2yaY43vqbg= From: Christopher Schmidt In-Reply-To: (Stefan Monnier's message of "Fri, 15 Feb 2013 10:25:50 -0500") Message-ID: <87ip5tquwi@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Fri, 15 Feb 2013 18:44:24 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier writes: >> dired-hide-details-mode also hides full lines other than header and >> file/directory lines. This includes the informational line right >> after >> the header line. >> /my/directory: >> total used in directory 1M available 1.0G <-- >> drwx------ 2 me me 4.0K Feb 11 17:35 file > > Is that the only full line that it hides, or are there others? Each and every line that is not a file line and that dired-insert-set-properties is called upon. In dired it is only this informational line. In find-dired the footer is hidden as well. find finished at Fri Feb 15 20:00:00 > Thinking of how to "fix it right", I think we'd need to introduce > something like a point-adjustment-function which dired-next-line could > set, and would take a "direction" argument. So keyboard.c's > adjust_point_for_property would call this function after adjusting > point. But it seems difficult to introduce such a thing in > a robust way: > - We could have it as a variable, which gets cleared before running > the next command, but then dired-next-line should only set it when > called interactively (otherwise if the caller calls dired-next-line > within, say, a save-excursion, you'd get surprising side-effects). > - We could have it as a property on the `dired-next-line' symbol, but > then we get the reverse problem, that a wrapper command that just > calls dired-next-line and not much else would fail to get this part > of dired-next-line's behavior. > > Maybe a cleaner solution is to export keyboard.c's > adjust_point_for_property to Elisp so that dired-next-line can call > it explicitly (to replace your "(while (and (invisible-p (point))) ...)" > loop). Yes, that would be great. Christopher From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Feb 2013 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.136105381013893 (code B ref 6799); Sat, 16 Feb 2013 22:31:02 +0000 Received: (at 6799) by debbugs.gnu.org; 16 Feb 2013 22:30:10 +0000 Received: from localhost ([127.0.0.1]:59555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6qGn-0003c2-SZ for submit@debbugs.gnu.org; Sat, 16 Feb 2013 17:30:10 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:38481 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6qGi-0003bZ-P6 for 6799@debbugs.gnu.org; Sat, 16 Feb 2013 17:30:05 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7CF04201A15907 for <6799@debbugs.gnu.org>; Sat, 16 Feb 2013 14:29:13 -0800 (PST) From: Juri Linkov Organization: JURTA References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> <87ip5tquwi@ch.ristopher.com> Date: Sat, 16 Feb 2013 23:52:12 +0200 In-Reply-To: <87ip5tquwi@ch.ristopher.com> (Christopher Schmidt's message of "Fri, 15 Feb 2013 18:44:24 +0000 (GMT)") Message-ID: <87halc3tne.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Usually I don't do this but when I called in a dired buffer `M-x text-mode RET' it unexpectedly removed from display all text except filenames (i.e. made other text invisible). I wonder should such cases be handled e.g. by disabling `dired-hide-details-mode' in the hook `after-change-major-mode-hook'? From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Feb 2013 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Juri Linkov'" , <6799@debbugs.gnu.org> Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.136105558516378 (code B ref 6799); Sat, 16 Feb 2013 23:00:02 +0000 Received: (at 6799) by debbugs.gnu.org; 16 Feb 2013 22:59:45 +0000 Received: from localhost ([127.0.0.1]:59574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6qjR-0004G6-Ed for submit@debbugs.gnu.org; Sat, 16 Feb 2013 17:59:45 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:19133) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6qjO-0004Fy-VR for 6799@debbugs.gnu.org; Sat, 16 Feb 2013 17:59:44 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1GMwoGj014519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 16 Feb 2013 22:58:51 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1GMwnBY029142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 16 Feb 2013 22:58:50 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1GMwnAm017993; Sat, 16 Feb 2013 16:58:49 -0600 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 16 Feb 2013 14:58:48 -0800 From: "Drew Adams" References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com><5EA47A0255F8494DB430B52D46876641@us.oracle.com><65D921448B0644988BE6445A2EF3E021@us.oracle.com><21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com><878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com><87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> <87ip5tquwi@ch.ristopher.com> <87halc3tne.fsf@mail.jurta.org> Date: Sat, 16 Feb 2013 14:58:41 -0800 Message-ID: <309C1F199E484184BCCAB1F685A61C79@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87halc3tne.fsf@mail.jurta.org> Thread-Index: Ac4MlgzR0+SvE29FSzmR93Gj3/vUcQAAhMDQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > Usually I don't do this but when I called in a dired buffer > `M-x text-mode RET' it unexpectedly removed from display all text > except filenames (i.e. made other text invisible). > > I wonder should such cases be handled e.g. by disabling > `dired-hide-details-mode' in the hook `after-change-major-mode-hook'? They should definitely be handled, one way or another. `dired-hide-details-mode' makes sense only in a mode derived from Dired mode. Your suggested fix sounds like the right approach in general, but I think turning off `dired-hide-details-mode' should somehow be done BEFORE changing to a mode that is not dired-derived, not afterward. Can you use `change-major-mode-hook' instead, to do this before changing the mode? Is it possible at that point to test whether the target mode is (derived-mode-p dired-mode)? From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Feb 2013 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "Drew Adams" Cc: 6799@debbugs.gnu.org Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.1361095893397 (code B ref 6799); Sun, 17 Feb 2013 10:12:01 +0000 Received: (at 6799) by debbugs.gnu.org; 17 Feb 2013 10:11:33 +0000 Received: from localhost ([127.0.0.1]:60080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U71DZ-00006M-6F for submit@debbugs.gnu.org; Sun, 17 Feb 2013 05:11:33 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:37089 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U71DU-000062-9F for 6799@debbugs.gnu.org; Sun, 17 Feb 2013 05:11:29 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 154A6201F82E3E; Sun, 17 Feb 2013 02:10:33 -0800 (PST) From: Juri Linkov Organization: JURTA References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> <87ip5tquwi@ch.ristopher.com> <87halc3tne.fsf@mail.jurta.org> <309C1F199E484184BCCAB1F685A61C79@us.oracle.com> Date: Sun, 17 Feb 2013 12:05:53 +0200 In-Reply-To: <309C1F199E484184BCCAB1F685A61C79@us.oracle.com> (Drew Adams's message of "Sat, 16 Feb 2013 14:58:41 -0800") Message-ID: <87obfjw966.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Can you use `change-major-mode-hook' instead, to do this before > changing the mode? Is it possible at that point to test whether > the target mode is (derived-mode-p dired-mode)? Yes, it seems `change-major-mode-hook' is more suitable. This is what `outline-mode' does to remove invisibility by using: (add-hook 'change-major-mode-hook 'show-all nil t) From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Feb 2013 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136111310529506 (code B ref -1); Sun, 17 Feb 2013 14:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Feb 2013 14:58:25 +0000 Received: from localhost ([127.0.0.1]:33155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U75h4-0007fk-G6 for submit@debbugs.gnu.org; Sun, 17 Feb 2013 09:58:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49054) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U75gv-0007fY-0r for submit@debbugs.gnu.org; Sun, 17 Feb 2013 09:58:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U75g0-00071Q-05 for submit@debbugs.gnu.org; Sun, 17 Feb 2013 09:57:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U75fz-00071M-T6 for submit@debbugs.gnu.org; Sun, 17 Feb 2013 09:57:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U75fw-0008DU-KT for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 09:57:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U75ft-000703-J3 for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 09:57:08 -0500 Received: from ristopher.com ([146.185.21.93]:56418 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U75ft-0006zp-A7 for bug-gnu-emacs@gnu.org; Sun, 17 Feb 2013 09:57:05 -0500 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 26C33213F3; Sun, 17 Feb 2013 14:57:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1361113022; bh=MJv+MOWCPMLcAtSdAI4zcYAkq3utzgVC7DRsw53VdJg=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=PvrgOAbCk2No3sxkOUp4lp4UVuNLG0o5ZmKO9CmcJQ2maS7+LV7mMIx/QJUEFJjma dBCi9zffK7k6fHwKqSeMyXouQLD1QylWKD+70tGQd0wqjdY6IhYvL8gosinZvqMSPK 8srRzqwVw7qaTd3V9fz0SQXPXTIWZPC32usgtCfY= From: Christopher Schmidt In-Reply-To: <87halc3tne.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 16 Feb 2013 23:52:12 +0200") Message-ID: <87ppzz6lar@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> <87ip5tquwi@ch.ristopher.com> <87halc3tne.fsf@mail.jurta.org> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Sun, 17 Feb 2013 14:57:02 +0000 (GMT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Juri Linkov writes: > Usually I don't do this but when I called in a dired buffer `M-x > text-mode RET' it unexpectedly removed from display all text except > filenames (i.e. made other text invisible). buffer-invisibility-spec is being set back to t. I.e. all text with a non-nil invisible text property is hidden. > I wonder should such cases be handled e.g. by disabling > `dired-hide-details-mode' in the hook `after-change-major-mode-hook'? Disabling dired-hide-details-mode just modifies buffer-invisibility-spec. This will not change anything. I guess the invisible text property should be set back to nil. dired-hide-details-mode will not work from thereon in this buffer. Is this a real issue? Christopher From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Feb 2013 10:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 6799@debbugs.gnu.org Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.136118254721277 (code B ref 6799); Mon, 18 Feb 2013 10:16:01 +0000 Received: (at 6799) by debbugs.gnu.org; 18 Feb 2013 10:15:47 +0000 Received: from localhost ([127.0.0.1]:33884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7NlD-0005X7-9T for submit@debbugs.gnu.org; Mon, 18 Feb 2013 05:15:47 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:58964 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7NlA-0005Wz-Fp for 6799@debbugs.gnu.org; Mon, 18 Feb 2013 05:15:45 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id C61C2201F4D710 for <6799@debbugs.gnu.org>; Mon, 18 Feb 2013 02:14:43 -0800 (PST) From: Juri Linkov Organization: JURTA References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> <87ip5tquwi@ch.ristopher.com> <87halc3tne.fsf@mail.jurta.org> <87ppzz6lar@ch.ristopher.com> Date: Mon, 18 Feb 2013 11:49:02 +0200 In-Reply-To: <87ppzz6lar@ch.ristopher.com> (Christopher Schmidt's message of "Sun, 17 Feb 2013 14:57:02 +0000 (GMT)") Message-ID: <87ehgehrcm.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.5 (/) > I guess the invisible text property should be set back to nil. > dired-hide-details-mode will not work from thereon in this buffer. > > Is this a real issue? It's not an issue to me, I just accidentally noticed that effect. I don't know how likely is that someone does this routinely that requires adding a function to remove invisible text property to be called from `change-major-mode-hook'. From unknown Sun Jun 22 03:55:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Feb 2013 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Juri Linkov'" , <6799@debbugs.gnu.org> Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.136119841816296 (code B ref 6799); Mon, 18 Feb 2013 14:41:01 +0000 Received: (at 6799) by debbugs.gnu.org; 18 Feb 2013 14:40:18 +0000 Received: from localhost ([127.0.0.1]:34058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7RtA-0004Ek-J4 for submit@debbugs.gnu.org; Mon, 18 Feb 2013 09:40:17 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33599) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7Rt7-0004EZ-LV for 6799@debbugs.gnu.org; Mon, 18 Feb 2013 09:40:14 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1IEdBmK009475 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Feb 2013 14:39:12 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1IEdBJs022037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 18 Feb 2013 14:39:11 GMT Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1IEdB2D012412; Mon, 18 Feb 2013 08:39:11 -0600 Received: from dradamslap1 (/10.159.168.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Feb 2013 06:39:10 -0800 From: "Drew Adams" References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com><65D921448B0644988BE6445A2EF3E021@us.oracle.com><21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com><878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com><87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> <87ip5tquwi@ch.ristopher.com> <87halc3tne.fsf@mail.jurta.org><87ppzz6lar@ch.ristopher.com> <87ehgehrcm.fsf@mail.jurta.org> Date: Mon, 18 Feb 2013 06:38:58 -0800 Message-ID: <1B82924F14D0491E95449B9246C47848@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehgehrcm.fsf@mail.jurta.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac4NwNw6qD6YpPphQ1+g3pByF0l0hQAJDIWw X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) > > I guess the invisible text property should be set back to nil. > > dired-hide-details-mode will not work from thereon in this buffer. > > > > Is this a real issue? > > It's not an issue to me, I just accidentally noticed that effect. > I don't know how likely is that someone does this routinely > that requires adding a function to remove invisible text property > to be called from `change-major-mode-hook'. IMO, it is a real issue, of course. We are breaking a reasonable use of our editor: to change the mode and do something different with the same text. Users should be able to change the mode and then act on the text in various ways - e.g., treating it as just a file listing. Yes, there is also `list-directory' that could be used for that, but that's not a reason not to fix this, at least if the fix is straightforward. Is the fix onerous or something?