Subject: Re: bug#67974: [PATCH 0/3 rust-team] gnu: Add rust-databake-0.1

From: Maxim Cournoyer <[email-masked]>
Date: Wed, 03 Jan 2024 22:55:18 -0500

Hi,

Jaeme Sifat <[email-masked]> writes:

> * gnu/packages/crates-io.scm (rust-databake-0.1): New variable.
>
> Change-Id: I8cd9208d9ac904c66de451d4a6f480d7eb1f4d73
> ---
>  gnu/packages/crates-io.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
> index 7e0517e967..3eda22f0ee 100644
> --- a/gnu/packages/crates-io.scm
> +++ b/gnu/packages/crates-io.scm
> @@ -20498,6 +20498,34 @@ (define-public rust-dashmap-3
>               (setenv "RUSTC_BOOTSTRAP" "1")
>               #t)))))))
>  
> +(define-public rust-databake-0.1
> +  (package
> +    (name "rust-databake")
> +    (version "0.1.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "databake" version))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "0flmvn7ym0sz6mkh5mg08vcbxa6kjiknhj9bpspww54lwrr5s5w2"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +     `(#:cargo-test-flags '("--release" "--"
> +                            "--skip=src/lib.rs - (line 27)"
> +                            "--skip=src/lib.rs - (line 46)")

Why are the above tests skipped?  Presumably, they failed, but for what
reason?  An explanatory comment would help.

> +       #:cargo-inputs (("rust-databake-derive" ,rust-databake-derive-0.1)
> +                       ("rust-proc-macro2" ,rust-proc-macro2-1)
> +                       ("rust-quote" ,rust-quote-1))))
> +    (home-page "https://github.com/unicode-org/icu4x")
> +    (synopsis
> +     "Trait that lets structs represent themselves as (const) Rust
> +expressions")

That's a bit on the verbose side of things for a synopsis; I'd reword to
something like: "Library for representing structs as const expressions".

The rest LGTM.

-- 
Thanks,
Maxim