From unknown Fri Jun 20 07:18:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67971 <67971@debbugs.gnu.org> To: bug#67971 <67971@debbugs.gnu.org> Subject: Status: [PATCH] Sync shared files from Autoconf Reply-To: bug#67971 <67971@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:12 +0000 retitle 67971 [PATCH] Sync shared files from Autoconf reassign 67971 automake-patches submitter 67971 Zack Weinberg severity 67971 normal tag 67971 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 22 13:10:36 2023 Received: (at submit) by debbugs.gnu.org; 22 Dec 2023 18:10:36 +0000 Received: from localhost ([127.0.0.1]:47860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGjym-0001Hf-2K for submit@debbugs.gnu.org; Fri, 22 Dec 2023 13:10:36 -0500 Received: from lists.gnu.org ([2001:470:142::17]:37726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGjyk-0001HK-Cr for submit@debbugs.gnu.org; Fri, 22 Dec 2023 13:10:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGjyZ-00086M-7I for automake-patches@gnu.org; Fri, 22 Dec 2023 13:10:23 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGjyT-0007FM-O6 for automake-patches@gnu.org; Fri, 22 Dec 2023 13:10:22 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 99ECA3200A68 for ; Fri, 22 Dec 2023 13:10:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 22 Dec 2023 13:10:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm1; t=1703268615; x=1703355015; bh=67mig4uGd+ 1XQBsyh+VD4H/Lytqw+FIUORW2eQJ/30o=; b=XTp1HdmcHP4z08v8tFO+e09kOp 8TAe7uOIXKv77EI5cvqm7PKZOgYaAMeiQxK2/Ds9vA9H6R8Ig97aXGdJn7HROIFh YGmUMu+ZRATg/cZMXIqRdeVkrIpkNRjNSxo/1e7+JJfTV4td28gsa1IQDFjFFfMa o2/TGqRr6eA1NP40wQvqYZZsl1jfHoJxEbCp2xg2TYvpd1t45eLal9pDfCiFpEId CjJiVUmzs7wqn3j/xmHdmiNaxIk1K/v3gpiBefqwCcY0X+WZuEeU7Lben3dgAmox FZT7ERt71tFloLUicyYpI0wi1YQOY+jBJIKx9PXmV+DHbiqRTjCpuPRXyLlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703268615; x=1703355015; bh=67mig4uGd+1XQBsyh+VD4H/Lytqw +FIUORW2eQJ/30o=; b=I5IjA3NFZLb25D1dF3C4FDgVUuJjDkWvUT7w23Va0tDI Wf+5hPqnq6UbIAMfJz+IaaO4SMmNhE75WfZDqdGj54JgEvMi3zasAwhpf5K/JmFH vVSUZs1wYbx0wlaVLDaidBc0dMj/sYP/U14S+eHtzYF/dDkE3CBzncpB9n62hubc znCc1+xye+9pw+tDyfrb5oHj+aw7FOFIsjsIAK11xnHk8HbwVPlU5410Dqy8M5L4 NGTBLv2cpmQr7tKZZEnHOswDtVpCmLqgKRUvKu02ZbHalgocw+0Lg7tQckT9FHBd uC82or/2hZunNs+CtimX5C2kbfxZc9VCJJI5aZjMwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddujedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffogggtgfesthekre dtredtjeenucfhrhhomhepkggrtghkucghvghinhgsvghrghcuoeiirggtkhesohiflhhf ohhlihhordhorhhgqeenucggtffrrghtthgvrhhnpedviedtudekheeffedugeetteduve eukedtheeugeeuleduleefvdduhfeufefgkeenucffohhmrghinhepghhnuhdrohhrghen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiirggtkh esohiflhhfohhlihhordhorhhg X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 22 Dec 2023 13:10:13 -0500 (EST) Received: by moxana.owlfolio.org (sSMTP sendmail emulation); Fri, 22 Dec 2023 13:10:13 -0500 From: Zack Weinberg To: automake-patches@gnu.org Subject: [PATCH] Sync shared files from Autoconf Date: Fri, 22 Dec 2023 13:10:12 -0500 Message-ID: <20231222181013.756084-1-zack@owlfolio.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.24; envelope-from=zack@owlfolio.org; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) lib/Automake/ChannelDefs.pm and lib/Automake/Channels.pm were updated in Autoconf to address . Bring over the changes. It *should* be impossible to reach report_bad_channel from code in Automake. * lib/Automake/Channels.pm (msg): If the channel argument is invalid, don’t crash; report the mistake and use the ‘syntax’ channel. (report_bad_channel): New function for reporting invalid channels. * lib/Automake/ChannelDefs.pm (usage): Clarify that the list of warning categories is exhaustive, and that “all”, “none”, “no-CATEGORY”, and “error” are not warning categories. --- lib/Automake/ChannelDefs.pm | 10 ++++---- lib/Automake/Channels.pm | 47 ++++++++++++++++++++++++++++++++++++- 2 files changed, 52 insertions(+), 5 deletions(-) diff --git a/lib/Automake/ChannelDefs.pm b/lib/Automake/ChannelDefs.pm index 1c436645e..8b334ee93 100644 --- a/lib/Automake/ChannelDefs.pm +++ b/lib/Automake/ChannelDefs.pm @@ -197,7 +197,7 @@ Return the warning category descriptions. sub usage () { - return "Warning categories include: + return "Warning categories are: cross cross compilation issues gnu GNU coding standards (default in gnu and gnits modes) obsolete obsolete features or constructions (default) @@ -207,10 +207,12 @@ sub usage () extra-portability extra portability issues related to obscure tools syntax dubious syntactic constructs (default) unsupported unsupported or incomplete features (default) - all all the warnings - no-CATEGORY turn off warnings in CATEGORY + +-W also understands: + all turn on all the warnings none turn off all the warnings - error treat warnings as errors"; + no-CATEGORY turn off warnings in CATEGORY + error treat all enabled warnings as errors"; } =item C diff --git a/lib/Automake/Channels.pm b/lib/Automake/Channels.pm index b4563d36e..84e93d106 100644 --- a/lib/Automake/Channels.pm +++ b/lib/Automake/Channels.pm @@ -628,7 +628,13 @@ sub msg ($$;$%) $location = ''; } - confess "unknown channel $channel" unless exists $channels{$channel}; + if (!exists $channels{$channel}) + { + # This can happen as a result of e.g. m4_warn([nonsense], [message]) + # so it should not crash. + report_bad_channel($channel, $location); + $channel = 'syntax'; + } my %opts = %{$channels{$channel}}; _merge_options (%opts, %options); @@ -662,6 +668,45 @@ sub msg ($$;$%) } } +sub report_bad_channel ($$) +{ + my ($channel, $location) = @_; + my $message; + my $report_as = 'error'; + + # quotemeta is both too aggressive (e.g. it escapes '-') and + # too generous (it turns control characters into \ + themselves, + # not into symbolic escapes). + my $q_channel = $channel; + $q_channel =~ s/(?=[\"\$\'\@\`\\])/\\/g; + $q_channel =~ s/([^\x20-\x7e])/sprintf('\\x%02X', ord $1)/eg; + $q_channel = '"' . $q_channel . '"'; + + if ($channel eq '' || $channel eq 'all') + { + # Prior to version 2.70, the Autoconf manual said it was valid to use + # "all" and the empty string as the category argument to m4_warn, so + # don't treat those cases as errors. + $report_as = 'obsolete'; + $message = "use of $q_channel as a diagnostic category is obsolete\n"; + $message .= "(see automake --help for a list of valid categories)"; + } + elsif ($channel eq 'none' + || ($channel =~ /^no-/ && exists $channels{substr($channel, 3)})) + { + # Also recognize "none" and "no-[category]", as someone might have + # thought anything acceptable to -W is also acceptable to m4_warn. + # Note: m4_warn([error], [...]) does actually issue an error. + $message = "-W accepts $q_channel, but it is not a diagnostic category"; + } + else + { + $message = "unknown diagnostic category " . $q_channel; + } + + msg $report_as, $location, $message; +} + =item C -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 22 20:46:36 2023 Received: (at 67971) by debbugs.gnu.org; 23 Dec 2023 01:46:36 +0000 Received: from localhost ([127.0.0.1]:48116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGr64-0001Us-DW for submit@debbugs.gnu.org; Fri, 22 Dec 2023 20:46:36 -0500 Received: from frenzy.freefriends.org ([198.99.81.75]:38536 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGr60-0001Ub-Cr; Fri, 22 Dec 2023 20:46:35 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 3BN1kQrE022059 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Dec 2023 18:46:26 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 3BN1kQ9A022058; Fri, 22 Dec 2023 18:46:26 -0700 Date: Fri, 22 Dec 2023 18:46:26 -0700 Message-Id: <202312230146.3BN1kQ9A022058@freefriends.org> From: Karl Berry To: zack@owlfolio.org Subject: Re: [bug#67971] [PATCH] Sync shared files from Autoconf In-Reply-To: <20231222181013.756084-1-zack@owlfolio.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67971 Cc: 67971@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) lib/Automake/ChannelDefs.pm and lib/Automake/Channels.pm were updated in Autoconf to address . Thanks Zack. Installed. BTW, the automake THANKS file has your panix.com address. Is that still ok, or should I update it to owlfolio? (Not that it really matters.) -k From unknown Fri Jun 20 07:18:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Jan 2024 12:24:20 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator