GNU bug report logs - #67946
30.0.50; [RFC PATCH] Add an option to not report "Wrote ..." when saving recentf.

Previous Next

Full log

View this message in rfc822 format

From: Lockywolf <for_emacs-recentf-patch_2023-12-21 <at> lockywolf.net>
To: Stefan Kangas <stefankangas <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>, 67946 <at> debbugs.gnu.org, shipmints <at> gmail.com
Subject: bug#67946: [PATCH v3] lisp/recentf.el: Add verbosity option
Date: Thu, 13 Feb 2025 21:34:05 +0800

[Message part 1 (text/plain, inline)]

Ship Mints <rewrite-shipmints==gmail.com> writes:

> I'll patch saveplace in harmony with savehist and leave recentf up to you and the OP.

Okay, I actually had a look at savehist, and it quite makes sense.

I am attaching a new patch, with the following contents:
(write-region (point-min) (point-max) (expand-file-name recentf-save-file) nil
   (unless (or (called-interactively-p 'interactive) recentf-show-messages) 'quiet)))

This is almost like what savehist does, but with an additional check for
explicitly enabling messages for people who are I/O bound and want to
save recentf rarely.

[signature.asc (application/pgp-signature, inline)]

[0001-lisp-recentf.el-Add-verbosity-option.patch (text/x-patch, inline)]

From 1290f7b57d343b28f98a96cc11865bda5bf3ae1d Mon Sep 17 00:00:00 2001
From: Lockywolf <for_emacs-recentf-patch_2023-12-21 <at> lockywolf.net>
Date: Thu, 13 Feb 2025 11:51:50 +0800
Subject: [PATCH] lisp/recentf.el: Add verbosity option

* lisp/recentf.el: add verbosity (bug#67946)
  recentf-verbosity: add defcustom to control verbosity
  (recentf-save-list): make use of recentf-verbosity
---
 etc/NEWS        |  7 +++++++
 lisp/recentf.el | 12 ++++++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 33f5df84d4b..c00dc987257 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -500,6 +500,13 @@ This user option controls the width of the type column on the bookmark
 menu 'bookmark-bmenu-list'.  The default value is 8 which is backwards
 compatible.
 
+** Recentf
+
+---
+*** New user option 'recentf-show-messages'.
+'recentf-save-list' can print a message when saving the recentf list.
+The new option, if set to nil, suppresses this message.
+
 ** Saveplace
 
 ---
diff --git a/lisp/recentf.el b/lisp/recentf.el
index a282fbee3b1..e8fc1928713 100644
--- a/lisp/recentf.el
+++ b/lisp/recentf.el
@@ -320,6 +320,14 @@ recentf-show-file-shortcuts-flag
 used as shortcuts to open the Nth file."
   :group 'recentf
   :type 'boolean)
+
+(defcustom recentf-show-messages nil
+  "Whether to show verbose messages about low-level recentf actions.
+nil means to not show messages related to the recentf machinery.
+t means show messages that were printed by default on Emacs <= 30.1."
+  :group 'recentf
+  :type 'boolean
+  :version "30.1")
 
 ;;; Utilities
 ;;
@@ -1330,8 +1338,8 @@ recentf-save-list
         (insert "\n\n;; Local Variables:\n"
                 (format ";; coding: %s\n" recentf-save-file-coding-system)
                 ";; End:\n")
-        (write-region (point-min) (point-max)
-                      (expand-file-name recentf-save-file))
+        (write-region (point-min) (point-max) (expand-file-name recentf-save-file) nil
+              (unless (or (called-interactively-p 'interactive) recentf-show-messages) 'quiet)))
         (when recentf-save-file-modes
           (set-file-modes recentf-save-file recentf-save-file-modes))
         nil)
-- 
2.46.3

[Message part 4 (text/plain, inline)]

-- 
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.