GNU bug report logs - #67941
[PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67941 in the body.
You can then email your comments to 67941 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: guix-patches <at> gnu.org
Cc: Clément Lassieur <clement <at> lassieur.org>
Subject: [PATCH] gnu: icecat-minimal: Fix dependency to libcanberra.
Date: Wed, 20 Dec 2023 20:50:59 +0100

* gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
phase.

Change-Id: I508dbf0a8133634c329c4c1ff20088752311ff91
---
 gnu/packages/gnuzilla.scm | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index b268ae8b7c6d..e0fbabfb68eb 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1092,18 +1092,22 @@ (define-public icecat-minimal
               (let* ((lib (string-append #$output "/lib"))
                      (gtk #$(this-package-input "gtk+"))
                      (gtk-share (string-append gtk "/share"))
-                     (ld-libs '#$(map (lambda (label)
-                                        (file-append (this-package-input label) "/lib"))
-                                      '("libpng-apng"
-                                        "libxscrnsaver"
-                                        "mesa"
-                                        "pciutils"
-                                        "mit-krb5"
-                                        "eudev"
-                                        "pulseaudio"
-                                        ;; For the integration of native notifications
-                                        ;; (same reason as icedove)
-                                        "libnotify"))))
+                     (ld-libs '#$(cons
+                                  (file-append
+                                   (this-package-input "libcanberra")
+                                   "/lib/gtk-3.0/modules")
+                                  (map (lambda (label)
+                                         (file-append (this-package-input label) "/lib"))
+                                       '("libpng-apng"
+                                         "libxscrnsaver"
+                                         "mesa"
+                                         "pciutils"
+                                         "mit-krb5"
+                                         "eudev"
+                                         "pulseaudio"
+                                         ;; For the integration of native notifications
+                                         ;; (same reason as icedove)
+                                         "libnotify")))))
                 (wrap-program (car (find-files lib "^icecat$"))
                   `("XDG_DATA_DIRS" prefix (,gtk-share))
                   ;; The following line is commented out because the icecat

base-commit: bb3ab24a296ffa5273b2e82a02ed057e90c095f3
prerequisite-patch-id: 51e2c2aaf5262d0d9001b0b5c37836060291f55d
prerequisite-patch-id: ea15ff59ebfaff0fce3c9a1d42a3c345f8618aab
prerequisite-patch-id: 459d954ba63d5c0c15f8b519aa5aef331f218cc6
prerequisite-patch-id: cc5c8cd318ced4bb10d30f2e00b41b1be1309226
prerequisite-patch-id: 32045c6f50d674987ad6be5b15b8f4f010123c37
prerequisite-patch-id: c0b3ddac8628924c3db8daf2d9694e0de9fb7e5e
prerequisite-patch-id: 9c1d2bed61258b47220ac60fbb889348877ebfb7
prerequisite-patch-id: 4d717985fc3ba49304969527f92f2d854b677fae
-- 
2.41.0

Message #8 received at 67941 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Clément Lassieur <clement <at> lassieur.org>,
 67941 <at> debbugs.gnu.org
Subject: Re: [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to
 libcanberra.
Date: Thu, 21 Dec 2023 12:23:11 +0100

Salut Clément,

Am 20.12.23 um 20:50 schrieb Clément Lassieur:
> * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
> 'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
> phase.

I assume this fixes some problems with sound themes of Icecat? If I
understand correctly what "libcanberra" is supposed to do...

~Jonathan

Message #11 received at 67941 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: "Jonathan Brielmaier" <jonathan.brielmaier <at> web.de>, 67941 <at> debbugs.gnu.org
Subject: Re: [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to
 libcanberra.
Date: Thu, 21 Dec 2023 12:07:18 +0000

On Thu, Dec 21, 2023, at 11:23 AM, Jonathan Brielmaier wrote:
> Salut Clément,

Hey Jonathan :)

> Am 20.12.23 um 20:50 schrieb Clément Lassieur:
> > * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
> > 'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
> > phase.
> 
> I assume this fixes some problems with sound themes of Icecat? If I
> understand correctly what "libcanberra" is supposed to do...

It fixes this message on Icecat startup:

Gtk-Message: 13:05:56.635: Failed to load module "canberra-gtk-module"
Gtk-Message: 13:05:56.636: Failed to load module "canberra-gtk-module"

I'll add this to the commit message.

Message #14 received at 67941 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 67941 <at> debbugs.gnu.org, Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to
 libcanberra.
Date: Wed, 03 Jan 2024 22:39:19 -0500

Hello,

Clément Lassieur <clement <at> lassieur.org> writes:

> On Thu, Dec 21, 2023, at 11:23 AM, Jonathan Brielmaier wrote:
>> Salut Clément,
>
> Hey Jonathan :)
>
>> Am 20.12.23 um 20:50 schrieb Clément Lassieur:
>> > * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Add
>> > 'libcanberra/lib/gtk-3.0/modules' to LD_LIBRARY_PATH in the 'wrap-program'
>> > phase.
>> 
>> I assume this fixes some problems with sound themes of Icecat? If I
>> understand correctly what "libcanberra" is supposed to do...
>
> It fixes this message on Icecat startup:
>
> Gtk-Message: 13:05:56.635: Failed to load module "canberra-gtk-module"
> Gtk-Message: 13:05:56.636: Failed to load module "canberra-gtk-module"
>
> I'll add this to the commit message.

Ping :-).  LGTM.

-- 
Thanks,
Maxim

Message #19 received at 67941-done <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 67941-done <at> debbugs.gnu.org,
 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: [bug#67941] [PATCH] gnu: icecat-minimal: Fix dependency to
 libcanberra.
Date: Thu, 04 Jan 2024 11:12:53 +0100

On Wed, Jan 03 2024, Maxim Cournoyer wrote:

>> It fixes this message on Icecat startup:
>>
>> Gtk-Message: 13:05:56.635: Failed to load module "canberra-gtk-module"
>> Gtk-Message: 13:05:56.636: Failed to load module "canberra-gtk-module"
>>
>> I'll add this to the commit message.
>
> Ping :-).  LGTM.

Pushed, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.