GNU bug report logs - #67933
[PATCH] gnu: icecat-minimal: Fix WM Class.

Previous Next

Package: guix-patches;

Reported by: Clément Lassieur <clement <at> lassieur.org>

Date: Wed, 20 Dec 2023 16:07:01 UTC

Severity: normal

Tags: patch

Done: Clément Lassieur <clement <at> lassieur.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67933 in the body.
You can then email your comments to 67933 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to jonathan.brielmaier <at> web.de, guix-patches <at> gnu.org:
bug#67933; Package guix-patches. (Wed, 20 Dec 2023 16:07:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Clément Lassieur <clement <at> lassieur.org>:
New bug report received and forwarded. Copy sent to jonathan.brielmaier <at> web.de, guix-patches <at> gnu.org. (Wed, 20 Dec 2023 16:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: guix-patches <at> gnu.org
Cc: Clément Lassieur <clement <at> lassieur.org>
Subject: [PATCH] gnu: icecat-minimal: Fix WM Class.
Date: Wed, 20 Dec 2023 17:04:39 +0100
* gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Set the
MOZ_APP_REMOTINGNAME environment variable and replace "Navigator" with
"Icecat" in icecat.desktop.

The WM Class should be "Navigator, Icecat" instead of "Navigator,
icecat-default".  StartupWMClass in icecat.desktop should be "Icecat" instead
of "Navigator" so that other browsers (they often have the "Navigator" class)
won't be associated with Icecat.

Change-Id: I57bec957938c56e8acf9cd5c955e57dbad081678
---
 gnu/packages/gnuzilla.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 9dfc61a7d7a6..b268ae8b7c6d 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1034,6 +1034,9 @@ (define-public icecat-minimal
                 (setenv "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE" "system")
                 (setenv "MOZ_BUILD_DATE" #$%icecat-build-id) ; avoid timestamp
 
+                ;; WM_CLASS (default is "$MOZ_APP_NAME-$MOZ_UPDATE_CHANNEL").
+                (setenv "MOZ_APP_REMOTINGNAME" "Icecat")
+
                 ;; XXX TODO: Fix this to work on systems other than x86_64-linux.
                 (setenv "GUIX_PYTHONPATH"
                         (string-append (getcwd)
@@ -1120,7 +1123,7 @@ (define-public icecat-minimal
                   (("NewWindow")        "new-window")
                   (("NewPrivateWindow") "new-private-window")
                   (("StartupNotify=true")
-                   "StartupNotify=true\nStartupWMClass=Navigator"))
+                   "StartupNotify=true\nStartupWMClass=Icecat"))
                 (install-file desktop-file applications))))
           (add-after 'install-desktop-entry 'install-icons
             (lambda _

base-commit: bb3ab24a296ffa5273b2e82a02ed057e90c095f3
prerequisite-patch-id: 51e2c2aaf5262d0d9001b0b5c37836060291f55d
prerequisite-patch-id: ea15ff59ebfaff0fce3c9a1d42a3c345f8618aab
prerequisite-patch-id: 459d954ba63d5c0c15f8b519aa5aef331f218cc6
prerequisite-patch-id: cc5c8cd318ced4bb10d30f2e00b41b1be1309226
prerequisite-patch-id: 32045c6f50d674987ad6be5b15b8f4f010123c37
-- 
2.41.0





Reply sent to Clément Lassieur <clement <at> lassieur.org>:
You have taken responsibility. (Thu, 04 Jan 2024 22:53:02 GMT) Full text and rfc822 format available.

Notification sent to Clément Lassieur <clement <at> lassieur.org>:
bug acknowledged by developer. (Thu, 04 Jan 2024 22:53:02 GMT) Full text and rfc822 format available.

Message #10 received at 67933-done <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: 67933-done <at> debbugs.gnu.org
Subject: Re: [bug#67933] [PATCH] gnu: icecat-minimal: Fix WM Class.
Date: Thu, 04 Jan 2024 23:52:04 +0100
On Wed, Dec 20 2023, Clément Lassieur wrote:

> * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Set the
> MOZ_APP_REMOTINGNAME environment variable and replace "Navigator" with
> "Icecat" in icecat.desktop.
>
> The WM Class should be "Navigator, Icecat" instead of "Navigator,
> icecat-default".  StartupWMClass in icecat.desktop should be "Icecat" instead
> of "Navigator" so that other browsers (they often have the "Navigator" class)
> won't be associated with Icecat.
>
> Change-Id: I57bec957938c56e8acf9cd5c955e57dbad081678

Pushed.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 02 Feb 2024 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 133 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.