GNU bug report logs - #67905
[PATCH] gnu: Add emacs-golden-ratio.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67905 in the body.
You can then email your comments to 67905 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: guix-patches <at> gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add emacs-golden-ratio.
Date: Tue, 19 Dec 2023 09:19:42 -0500

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.

Change-Id: I34fe0c67e8776083a9ae448d834eed8f4105d176
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f8bd9a111e..e452e88283 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1374,6 +1374,27 @@ (define-public emacs-project-mode-line-tag
 its mode line.")
       (license license:gpl3+))))
 
+(define-public emacs-golden-ratio
+  (package
+    (name "emacs-golden-ratio")
+    (version "20230912.1825")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/roman/golden-ratio.el.git")
+             (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
+       (sha256
+        (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/roman/golden-ratio.el")
+    (synopsis "Automatic resizing of Emacs windows to the golden ratio")
+    (description "This package provides an Emacs mode for automatically
+resizing the window that has main focus to be more convenient for editing,
+while the ones that are not being actively edited will be reduced to a smaller
+size.")
+    (license license:expat)))
+
 (define-public emacs-git-modes
   (package
     (name "emacs-git-modes")

base-commit: ee93015b54a2abfe59bc2270c09ea4f7624488e5
-- 
2.41.0

Message #8 received at 67905 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: peter <at> polidoro.io
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 67905 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
Date: Mon, 25 Dec 2023 17:40:07 +0100

Hello,

There are two linter warnings here:

--8<---------------cut here---------------start------------->8---
/home/mathieu/guix/gnu/packages/emacs-xyz.scm:1382:5:
emacs-golden-ratio <at> 20230912.1825: the source file name should contain
the package name

/home/mathieu/guix/gnu/packages/emacs-xyz.scm:1382:5:
emacs-golden-ratio <at> 20230912.1825: permanent redirect from
https://github.com/roman/golden-ratio.el.git to
https://github.com/roman/golden-ratio.el
--8<---------------cut here---------------end--------------->8---

> +       (uri (git-reference
> +             (url "https://github.com/roman/golden-ratio.el.git")
> +             (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))

The first one can probably be resolved by adding the following line
here:

         (file-name (git-file-name name version))

> +       (sha256
> +        (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/roman/golden-ratio.el")

And the second one by updating this URL.

Could you please send an updated patch?

Thanks,

Mathieu

Message #11 received at 67905 <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: 67905 <at> debbugs.gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add emacs-golden-ratio.
Date: Wed,  3 Jan 2024 14:48:38 -0500

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.

Change-Id: I44de02989b8dadd4a395374fe078d4255a210028
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb3c905252..3937e209b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1374,6 +1374,28 @@ (define-public emacs-project-mode-line-tag
 its mode line.")
       (license license:gpl3+))))
 
+(define-public emacs-golden-ratio
+  (package
+    (name "emacs-golden-ratio")
+    (version "20230912.1825")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/roman/golden-ratio.el")
+             (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/roman/golden-ratio.el")
+    (synopsis "Automatic resizing of Emacs windows to the golden ratio")
+    (description "This package provides an Emacs mode for automatically
+resizing the window that has main focus to be more convenient for editing,
+while the ones that are not being actively edited will be reduced to a smaller
+size.")
+    (license license:expat)))
+
 (define-public emacs-git-modes
   (package
     (name "emacs-git-modes")

base-commit: 2f642b602398ab32b18faceecd074f49da92e95e
-- 
2.41.0

Message #14 received at 67905 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: peter <at> polidoro.io
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 67905 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
Date: Thu, 04 Jan 2024 11:28:43 +0100

Hello,

peter <at> polidoro.io writes:

> From: Peter Polidoro <peter <at> polidoro.io>
>
> * gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.

Thank you.

> +(define-public emacs-golden-ratio
> +  (package
> +    (name "emacs-golden-ratio")
> +    (version "20230912.1825")

The version is "1.0.1", plus a few commits. Therefore, the line above
should be:

  (version (git-version "1.0.1" revision commit))

where `revision' is bound to "1" (or "0", it all depends on your
beliefs), and `commit' to "375c9f287dfad68829582c1e0a67d0c18119dab9".

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/roman/golden-ratio.el")
> +             (commit "375c9f287dfad68829582c1e0a67d0c18119dab9")))

Per above, this should be bound to `revision'

Regards,
-- 
Nicolas Goaziou

Message #17 received at 67905 <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: 67905 <at> debbugs.gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add emacs-golden-ratio.
Date: Thu,  4 Jan 2024 09:16:49 -0500

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.

Change-Id: I44de02989b8dadd4a395374fe078d4255a210028
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bb3c905252..4f5aa5d1f7 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1374,6 +1374,30 @@ (define-public emacs-project-mode-line-tag
 its mode line.")
       (license license:gpl3+))))
 
+(define-public emacs-golden-ratio
+  (let ((commit "375c9f287dfad68829582c1e0a67d0c18119dab9")
+        (revision "0"))
+    (package
+      (name "emacs-golden-ratio")
+      (version (git-version "1.0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/roman/golden-ratio.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0a635a3h6jx0clgwmhwc48i14y3xy5q29y37lp2sjnbxx1hlmkli"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/roman/golden-ratio.el")
+      (synopsis "Automatic resizing of Emacs windows to the golden ratio")
+      (description "This package provides an Emacs mode for automatically
+resizing the window that has main focus to be more convenient for editing,
+while the ones that are not being actively edited will be reduced to a smaller
+size.")
+      (license license:expat))))
+
 (define-public emacs-git-modes
   (package
     (name "emacs-git-modes")

base-commit: 2f642b602398ab32b18faceecd074f49da92e95e
-- 
2.41.0

Message #22 received at 67905-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: peter <at> polidoro.io
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 67905-done <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#67905] [PATCH] gnu: Add emacs-golden-ratio.
Date: Mon, 22 Jan 2024 00:29:02 +0100

Hello,

peter <at> polidoro.io writes:

> From: Peter Polidoro <peter <at> polidoro.io>
>
> * gnu/packages/emacs-xyz.scm (emacs-golden-ratio): New variable.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.