Subject: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.

From: Hilton Chain <[email-masked]>
Date: Sat, 13 Jan 2024 16:04:31 +0800

Hi,

On Fri, 05 Jan 2024 13:45:36 +0800,
Zheng Junjie wrote:
>
> Hilton Chain <[email-masked]> writes:
> >
> > On Sun, 24 Dec 2023 13:27:13 +0800,
> > 郑俊杰 wrote:
> >>
> >> > 在 2023年12月19日，22:51，Hilton Chain 写道：
> >> >
> >> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
> >> > [arguments]<#:configure-flags>: Disable systemd.
> >> >
> >> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
> >> > ---
> >> > gnu/packages/linux.scm | 7 ++++---
> >> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> > index 3ca756dead..c4c366e21f 100644
> >> > --- a/gnu/packages/linux.scm
> >> > +++ b/gnu/packages/linux.scm
> >> > @@ -8798,7 +8798,7 @@ (define-public fbgrab
> >> > (define-public libcgroup
> >> >   (package
> >> >     (name "libcgroup")
> >> > -    (version "2.0.2")
> >> > +    (version "3.1.0")
> >> >     (home-page "https://github.com/libcgroup/libcgroup")
> >> >     (source
> >> >      (origin
> >> > @@ -8806,14 +8806,15 @@ (define-public libcgroup
> >> >        (uri (string-append home-page "/releases/download/v"
> >> >                            version "/" name "-" version ".tar.gz"))
> >>
> >> Can we switch to git-fetch?
> >
> > Is there any good reason?
>
> if use git-fetch, allow `guix build libcgroup
> --with-{branch,commit,git-url} ...` work.

Yes, that makes sense, but we still have ‘--with-version’, right?  It seems that
libcgroup's release tarball is created by ‘make dist’ and for this specific case
these options are of less use, I'd prefer not switching to git-fetch.

Thanks