GNU bug report logs - #67903
[PATCH] gnu: libcgroup: Update to 3.1.0.

Previous Next

Package: guix-patches;

Reported by: Hilton Chain <hako <at> ultrarare.space>

Date: Tue, 19 Dec 2023 14:23:02 UTC

Severity: normal

Tags: patch

Done: Hilton Chain <hako <at> ultrarare.space>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 67903 in the body.
You can then email your comments to 67903 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to leo <at> famulari.name, me <at> tobias.gr, guix-patches <at> gnu.org:
bug#67903; Package guix-patches. (Tue, 19 Dec 2023 14:23:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Hilton Chain <hako <at> ultrarare.space>:
New bug report received and forwarded. Copy sent to leo <at> famulari.name, me <at> tobias.gr, guix-patches <at> gnu.org. (Tue, 19 Dec 2023 14:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH] gnu: libcgroup: Update to 3.1.0.
Date: Tue, 19 Dec 2023 22:21:36 +0800

* gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
[arguments]<#:configure-flags>: Disable systemd.

Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
---
 gnu/packages/linux.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 3ca756dead..c4c366e21f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8798,7 +8798,7 @@ (define-public fbgrab
 (define-public libcgroup
   (package
     (name "libcgroup")
-    (version "2.0.2")
+    (version "3.1.0")
     (home-page "https://github.com/libcgroup/libcgroup")
     (source
      (origin
@@ -8806,14 +8806,15 @@ (define-public libcgroup
        (uri (string-append home-page "/releases/download/v"
                            version "/" name "-" version ".tar.gz"))
        (sha256
-        (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
+        (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp"))))
     (build-system gnu-build-system)
     (arguments
      ;; Tests are virtualized with lxc, it is not very feasible
      ;; to make them executable under guix build. Also, note that
      ;; origin is using source tarball release which is prepared
      ;; after testing.
-     `(#:tests? #f))
+     `(#:tests? #f
+       #:configure-flags '("--disable-systemd")))
     (native-inputs
      (list bison flex))
     (inputs

base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#67903; Package guix-patches. (Sun, 24 Dec 2023 05:28:01 GMT) Full text and rfc822 format available.

Message #8 received at 67903 <at> debbugs.gnu.org (full text, mbox):

From: 郑俊杰 <zhengjunjie <at> yandex.com>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 67903 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.
Date: Sun, 24 Dec 2023 13:27:13 +0800


> 在 2023年12月19日，22:51，Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> 写道：
> 
> * gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
> [arguments]<#:configure-flags>: Disable systemd.
> 
> Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
> ---
> gnu/packages/linux.scm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 3ca756dead..c4c366e21f 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -8798,7 +8798,7 @@ (define-public fbgrab
> (define-public libcgroup
>   (package
>     (name "libcgroup")
> -    (version "2.0.2")
> +    (version "3.1.0")
>     (home-page "https://github.com/libcgroup/libcgroup")
>     (source
>      (origin
> @@ -8806,14 +8806,15 @@ (define-public libcgroup
>        (uri (string-append home-page "/releases/download/v"
>                            version "/" name "-" version ".tar.gz"))

Can we switch to git-fetch? 
And don’t use home-page in source.

>        (sha256
> -        (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
> +        (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp"))))
>     (build-system gnu-build-system)
>     (arguments
>      ;; Tests are virtualized with lxc, it is not very feasible
>      ;; to make them executable under guix build. Also, note that
>      ;; origin is using source tarball release which is prepared
>      ;; after testing.
> -     `(#:tests? #f))
> +     `(#:tests? #f
> +       #:configure-flags '("--disable-systemd")))

Maybe use gexp. 

>     (native-inputs
>      (list bison flex))
>     (inputs
> 
> base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66
> --
> 2.41.0

Other LGTM 

> 
> 
> 
>
Information forwarded to guix-patches <at> gnu.org:
bug#67903; Package guix-patches. (Fri, 05 Jan 2024 05:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 67903 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 郑俊杰 <zhengjunjie <at> yandex.com>
Cc: 67903 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.
Date: Fri, 05 Jan 2024 13:24:58 +0800

Hi,

On Sun, 24 Dec 2023 13:27:13 +0800,
郑俊杰 wrote:
>
>
>
> > 在 2023年12月19日，22:51，Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> 写道：
> >
> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
> > [arguments]<#:configure-flags>: Disable systemd.
> >
> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
> > ---
> > gnu/packages/linux.scm | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> > index 3ca756dead..c4c366e21f 100644
> > --- a/gnu/packages/linux.scm
> > +++ b/gnu/packages/linux.scm
> > @@ -8798,7 +8798,7 @@ (define-public fbgrab
> > (define-public libcgroup
> >   (package
> >     (name "libcgroup")
> > -    (version "2.0.2")
> > +    (version "3.1.0")
> >     (home-page "https://github.com/libcgroup/libcgroup")
> >     (source
> >      (origin
> > @@ -8806,14 +8806,15 @@ (define-public libcgroup
> >        (uri (string-append home-page "/releases/download/v"
> >                            version "/" name "-" version ".tar.gz"))
>
> Can we switch to git-fetch?

Is there any good reason?

> And don’t use home-page in source.

No problem.

> >        (sha256
> > -        (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
> > +        (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp"))))
> >     (build-system gnu-build-system)
> >     (arguments
> >      ;; Tests are virtualized with lxc, it is not very feasible
> >      ;; to make them executable under guix build. Also, note that
> >      ;; origin is using source tarball release which is prepared
> >      ;; after testing.
> > -     `(#:tests? #f))
> > +     `(#:tests? #f
> > +       #:configure-flags '("--disable-systemd")))
>
> Maybe use gexp.

Will add in a later commit.

> >     (native-inputs
> >      (list bison flex))
> >     (inputs
> >
> > base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66
> > --
> > 2.41.0
>
> Other LGTM

Thanks for the review!
Information forwarded to guix-patches <at> gnu.org:
bug#67903; Package guix-patches. (Fri, 05 Jan 2024 05:57:02 GMT) Full text and rfc822 format available.

Message #14 received at 67903 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 67903 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.
Date: Fri, 05 Jan 2024 13:45:36 +0800

Hilton Chain <hako <at> ultrarare.space> writes:

> Hi,
>
> On Sun, 24 Dec 2023 13:27:13 +0800,
> 郑俊杰 wrote:
>>
>>
>>
>> > 在 2023年12月19日，22:51，Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> 写道：
>> >
>> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
>> > [arguments]<#:configure-flags>: Disable systemd.
>> >
>> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
>> > ---
>> > gnu/packages/linux.scm | 7 ++++---
>> > 1 file changed, 4 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> > index 3ca756dead..c4c366e21f 100644
>> > --- a/gnu/packages/linux.scm
>> > +++ b/gnu/packages/linux.scm
>> > @@ -8798,7 +8798,7 @@ (define-public fbgrab
>> > (define-public libcgroup
>> >   (package
>> >     (name "libcgroup")
>> > -    (version "2.0.2")
>> > +    (version "3.1.0")
>> >     (home-page "https://github.com/libcgroup/libcgroup")
>> >     (source
>> >      (origin
>> > @@ -8806,14 +8806,15 @@ (define-public libcgroup
>> >        (uri (string-append home-page "/releases/download/v"
>> >                            version "/" name "-" version ".tar.gz"))
>>
>> Can we switch to git-fetch?
>
> Is there any good reason?

if use git-fetch, allow `guix build libcgroup
--with-{branch,commit,git-url} ...` work.



>
>> And don’t use home-page in source.
>
> No problem.
>
>> >        (sha256
>> > -        (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
>> > +        (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp"))))
>> >     (build-system gnu-build-system)
>> >     (arguments
>> >      ;; Tests are virtualized with lxc, it is not very feasible
>> >      ;; to make them executable under guix build. Also, note that
>> >      ;; origin is using source tarball release which is prepared
>> >      ;; after testing.
>> > -     `(#:tests? #f))
>> > +     `(#:tests? #f
>> > +       #:configure-flags '("--disable-systemd")))
>>
>> Maybe use gexp.
>
> Will add in a later commit.
>
>> >     (native-inputs
>> >      (list bison flex))
>> >     (inputs
>> >
>> > base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66
>> > --
>> > 2.41.0
>>
>> Other LGTM
>
> Thanks for the review!
Information forwarded to guix-patches <at> gnu.org:
bug#67903; Package guix-patches. (Sat, 13 Jan 2024 08:05:02 GMT) Full text and rfc822 format available.

Message #17 received at 67903 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 67903 <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.
Date: Sat, 13 Jan 2024 16:04:31 +0800

Hi,

On Fri, 05 Jan 2024 13:45:36 +0800,
Zheng Junjie wrote:
>
> Hilton Chain <hako <at> ultrarare.space> writes:
> >
> > On Sun, 24 Dec 2023 13:27:13 +0800,
> > 郑俊杰 wrote:
> >>
> >> > 在 2023年12月19日，22:51，Hilton Chain 写道：
> >> >
> >> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
> >> > [arguments]<#:configure-flags>: Disable systemd.
> >> >
> >> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
> >> > ---
> >> > gnu/packages/linux.scm | 7 ++++---
> >> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> > index 3ca756dead..c4c366e21f 100644
> >> > --- a/gnu/packages/linux.scm
> >> > +++ b/gnu/packages/linux.scm
> >> > @@ -8798,7 +8798,7 @@ (define-public fbgrab
> >> > (define-public libcgroup
> >> >   (package
> >> >     (name "libcgroup")
> >> > -    (version "2.0.2")
> >> > +    (version "3.1.0")
> >> >     (home-page "https://github.com/libcgroup/libcgroup")
> >> >     (source
> >> >      (origin
> >> > @@ -8806,14 +8806,15 @@ (define-public libcgroup
> >> >        (uri (string-append home-page "/releases/download/v"
> >> >                            version "/" name "-" version ".tar.gz"))
> >>
> >> Can we switch to git-fetch?
> >
> > Is there any good reason?
>
> if use git-fetch, allow `guix build libcgroup
> --with-{branch,commit,git-url} ...` work.


Yes, that makes sense, but we still have ‘--with-version’, right?  It seems that
libcgroup's release tarball is created by ‘make dist’ and for this specific case
these options are of less use, I'd prefer not switching to git-fetch.

Thanks
Information forwarded to hako <at> ultrarare.space, zhengjunjie <at> yandex.com, zhengjunjie <at> iscas.ac.cn, leo <at> famulari.name, me <at> tobias.gr, guix-patches <at> gnu.org:
bug#67903; Package guix-patches. (Sat, 13 Jan 2024 08:10:02 GMT) Full text and rfc822 format available.

Message #20 received at 67903 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 67903 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH v2 1/2] gnu: libcgroup: Adjust package style.
Date: Sat, 13 Jan 2024 16:08:46 +0800

* gnu/packages/linux.scm (libcgroup)[source]<uri>: Remove use of ‘home-page’.

Change-Id: I93f22223a01b253b8b1cd7deea90e7f05736862f
---
 gnu/packages/linux.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index a96c817729..4eee3c4af3 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8804,8 +8804,9 @@ (define-public libcgroup
     (source
      (origin
        (method url-fetch)
-       (uri (string-append home-page "/releases/download/v"
-                           version "/" name "-" version ".tar.gz"))
+       (uri (string-append
+             "https://github.com/libcgroup/libcgroup/releases/download/v"
+             version "/" name "-" version ".tar.gz"))
        (sha256
         (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
     (build-system gnu-build-system)

base-commit: c0b303aaa3d6154acbe054120d11467eb98e6d33
--
2.41.0
Information forwarded to hako <at> ultrarare.space, zhengjunjie <at> yandex.com, zhengjunjie <at> iscas.ac.cn, leo <at> famulari.name, me <at> tobias.gr, guix-patches <at> gnu.org:
bug#67903; Package guix-patches. (Sat, 13 Jan 2024 08:10:02 GMT) Full text and rfc822 format available.

Message #23 received at 67903 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 67903 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH v2 2/2] gnu: libcgroup: Update to 3.1.0.
Date: Sat, 13 Jan 2024 16:08:47 +0800

* gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
[arguments]<#:configure-flags>: Disable systemd.

Change-Id: Iabd8577243b741380fa0d69811fcbf8ad551ddb2
---
 gnu/packages/linux.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 4eee3c4af3..8979e3b7cc 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8799,7 +8799,7 @@ (define-public fbgrab
 (define-public libcgroup
   (package
     (name "libcgroup")
-    (version "2.0.2")
+    (version "3.1.0")
     (home-page "https://github.com/libcgroup/libcgroup")
     (source
      (origin
@@ -8808,14 +8808,16 @@ (define-public libcgroup
              "https://github.com/libcgroup/libcgroup/releases/download/v"
              version "/" name "-" version ".tar.gz"))
        (sha256
-        (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
+        (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp"))))
     (build-system gnu-build-system)
     (arguments
      ;; Tests are virtualized with lxc, it is not very feasible
      ;; to make them executable under guix build. Also, note that
      ;; origin is using source tarball release which is prepared
      ;; after testing.
-     `(#:tests? #f))
+     (list #:tests? #f
+           #:configure-flags
+           #~'("--disable-systemd")))
     (native-inputs
      (list bison flex))
     (inputs
-- 
2.41.0
Reply sent to Hilton Chain <hako <at> ultrarare.space>:
You have taken responsibility. (Thu, 25 Jan 2024 16:38:02 GMT) Full text and rfc822 format available.
Notification sent to Hilton Chain <hako <at> ultrarare.space>:
bug acknowledged by developer. (Thu, 25 Jan 2024 16:38:02 GMT) Full text and rfc822 format available.

Message #28 received at 67903-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 67903-done <at> debbugs.gnu.org
Subject: Re: [bug#67903] [PATCH v2 2/2] gnu: libcgroup: Update to 3.1.0.
Date: Fri, 26 Jan 2024 00:37:01 +0800

Applied as 0252d69f911a5726a32695e6e57f3922c3414980 and
ed7eb108e5ba38135db99aa3b162f88797c372f9.  Closing.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 23 Feb 2024 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 113 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.