GNU bug report logs - #67895
[PATCH] build-system/composer: Do not try to delete-duplicates.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: jgart <jgart <at> dismail.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#67895: closed ([PATCH] build-system/composer: Do not try to
 delete-duplicates.)
Date: Fri, 12 Jul 2024 16:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 12 Jul 2024 11:10:35 -0500
with message-id <87seweeglg.fsf <at> dismail.de>
and subject line Re: [PATCH] build-system/composer: Do not try to delete-duplicates.
has caused the debbugs.gnu.org bug report #67895,
regarding [PATCH] build-system/composer: Do not try to delete-duplicates.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
67895: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67895
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ludo <at> gnu.org, ngraves <at> ngraves.fr
Subject: [PATCH] build-system/composer: Do not try to delete-duplicates.
Date: Tue, 19 Dec 2023 10:08:47 +0100

* guix/build-system/composer.scm (create-autoload):
Do not use the delete-duplicates function, stale code that should have
been removed in an earlier cleanup.

Change-Id: I778c1cfba7ef8de16a1ba297b583595b391b7e00
---
 guix/build/composer-build-system.scm | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/guix/build/composer-build-system.scm b/guix/build/composer-build-system.scm
index 8896384e0a..8d7d43236e 100644
--- a/guix/build/composer-build-system.scm
+++ b/guix/build/composer-build-system.scm
@@ -191,13 +191,11 @@ (define* (create-autoload vendor composer-file inputs #:key dev-dependencies?)
                (cons* (string-join (string-split key #\\) "\\\\")
                       (append-map (lambda (v) (list vendor v)) vals)))))
            (_ (format #t "")))
-         (delete-duplicates
-          (append
-           (composer-autoload-psr-4 autoload)
-           (if (and dev-dependencies? (not (null? autoload-dev)))
-               (composer-autoload-psr-4 autoload-dev)
-               '()))
-          '()))
+         (append
+          (composer-autoload-psr-4 autoload)
+          (if (and dev-dependencies? (not (null? autoload-dev)))
+              (composer-autoload-psr-4 autoload-dev)
+              '())))
         (for-each
          (lambda (psr0)
            (match psr0
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: 67895-done <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [PATCH] build-system/composer: Do not try to delete-duplicates.
Date: Fri, 12 Jul 2024 11:10:35 -0500

Applied and tested here:

https://issues.guix.gnu.org/72067

Thanks!
-- 
all the best,
jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.