From unknown Mon Jun 23 11:28:03 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#67895] [PATCH] build-system/composer: Do not try to delete-duplicates. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Dec 2023 09:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67895 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67895@debbugs.gnu.org Cc: ludo@gnu.org, ngraves@ngraves.fr X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170297695019304 (code B ref -1); Tue, 19 Dec 2023 09:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2023 09:09:10 +0000 Received: from localhost ([127.0.0.1]:34399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFW6A-00051H-4r for submit@debbugs.gnu.org; Tue, 19 Dec 2023 04:09:10 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFW67-00050j-NK for submit@debbugs.gnu.org; Tue, 19 Dec 2023 04:09:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFW5z-0003mj-MM for guix-patches@gnu.org; Tue, 19 Dec 2023 04:08:59 -0500 Received: from 7.mo560.mail-out.ovh.net ([188.165.48.182]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFW5y-0006Pd-2Y for guix-patches@gnu.org; Tue, 19 Dec 2023 04:08:59 -0500 Received: from director4.ghost.mail-out.ovh.net (unknown [10.108.17.154]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 2CCF52C233 for ; Tue, 19 Dec 2023 09:08:54 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-zpf47 (unknown [10.110.178.126]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id DBF301FE64; Tue, 19 Dec 2023 09:08:53 +0000 (UTC) Received: from ngraves.fr ([37.59.142.106]) by ghost-submission-6684bf9d7b-zpf47 with ESMTPSA id yvz2MqVdgWXtMgAAom12ow (envelope-from ); Tue, 19 Dec 2023 09:08:53 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-106R006b74640e5-b7ef-4115-acf3-9b2997a8e00c, 0A183DEDD9F7D7733B4F13041BD52F66DC821FED) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 81.67.140.142 From: Nicolas Graves Date: Tue, 19 Dec 2023 10:08:47 +0100 Message-ID: <20231219090848.13042-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6748081093695824605 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrvddutddgtdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepkeffgeetfffgffejgeejvdffgfdtvdeuueetgfefuedvjeegvdegjeejveeuueevnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugedtrddugedvpdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehguhhigidqphgrthgthhgvshesghhnuhdrohhrghdpoffvtefjohhsthepmhhoheeitddpmhhouggvpehsmhhtphhouhht Received-SPF: pass client-ip=188.165.48.182; envelope-from=ngraves@ngraves.fr; helo=7.mo560.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * guix/build-system/composer.scm (create-autoload): Do not use the delete-duplicates function, stale code that should have been removed in an earlier cleanup. Change-Id: I778c1cfba7ef8de16a1ba297b583595b391b7e00 --- guix/build/composer-build-system.scm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/guix/build/composer-build-system.scm b/guix/build/composer-build-system.scm index 8896384e0a..8d7d43236e 100644 --- a/guix/build/composer-build-system.scm +++ b/guix/build/composer-build-system.scm @@ -191,13 +191,11 @@ (define* (create-autoload vendor composer-file inputs #:key dev-dependencies?) (cons* (string-join (string-split key #\\) "\\\\") (append-map (lambda (v) (list vendor v)) vals))))) (_ (format #t ""))) - (delete-duplicates - (append - (composer-autoload-psr-4 autoload) - (if (and dev-dependencies? (not (null? autoload-dev))) - (composer-autoload-psr-4 autoload-dev) - '())) - '())) + (append + (composer-autoload-psr-4 autoload) + (if (and dev-dependencies? (not (null? autoload-dev))) + (composer-autoload-psr-4 autoload-dev) + '()))) (for-each (lambda (psr0) (match psr0 -- 2.41.0 From unknown Mon Jun 23 11:28:03 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicolas Graves Subject: bug#67895: closed (Re: [PATCH] build-system/composer: Do not try to delete-duplicates.) Message-ID: References: <87seweeglg.fsf@dismail.de> <20231219090848.13042-1-ngraves@ngraves.fr> X-Gnu-PR-Message: they-closed 67895 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 67895@debbugs.gnu.org Date: Fri, 12 Jul 2024 16:11:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1720800662-21243-1" This is a multi-part message in MIME format... ------------=_1720800662-21243-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #67895: [PATCH] build-system/composer: Do not try to delete-duplicates. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 67895@debbugs.gnu.org. --=20 67895: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67895 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1720800662-21243-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 67895-done) by debbugs.gnu.org; 12 Jul 2024 16:10:47 +0000 Received: from localhost ([127.0.0.1]:54668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSIr9-0005W8-HV for submit@debbugs.gnu.org; Fri, 12 Jul 2024 12:10:47 -0400 Received: from mx1.dismail.de ([78.46.223.134]:36362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSIr8-0005Vu-2n for 67895-done@debbugs.gnu.org; Fri, 12 Jul 2024 12:10:46 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 0bbcc955; Fri, 12 Jul 2024 18:10:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type; s=20190914; bh=cAsxw+XFai/M4ax4bDhFRxvLxOApOFhRx/vSPhI6nGs=; b= WRKrRt9w9JiOlgZUYc3INWxQTHxTDrhZE9nCWkfTf74568VWT2d18E6A+RySBD21 eVJHDCx6RWybUCXf9IHKxJSfdaTp370TJ/BrXqGUF9ZSrrNEfR+tMldBibNBvh3L qcU175nQxOztahXNco7UWs+5d5Cu1WnFomjOABB2pc+eUQKQoo/zln4t31i2bA1E dYJQcAuqlC3OLtXaq6+NLYyJuitBJvFSXcAXmu7j4goN53df8YUk9F0wVnUfSpsq C7SP8fbCDyo2wODrSBW4hn+iwgznDuN+eMi2esa1Ls1te+WjUDMHbA0vE0p6n/Jq lg15qW3DWvzAtw0EwKyf+w== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 7db96cc3; Fri, 12 Jul 2024 18:10:39 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id 040a91d5; Fri, 12 Jul 2024 18:10:39 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id dc2f298b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 12 Jul 2024 18:10:38 +0200 (CEST) From: jgart To: 67895-done@debbugs.gnu.org Subject: Re: [PATCH] build-system/composer: Do not try to delete-duplicates. In-Reply-To: <20231219090848.13042-1-ngraves@ngraves.fr> Date: Fri, 12 Jul 2024 11:10:35 -0500 Message-ID: <87seweeglg.fsf@dismail.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67895-done Cc: Nicolas Graves X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Applied and tested here: https://issues.guix.gnu.org/72067 Thanks! -- all the best, jgart ------------=_1720800662-21243-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Dec 2023 09:09:10 +0000 Received: from localhost ([127.0.0.1]:34399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFW6A-00051H-4r for submit@debbugs.gnu.org; Tue, 19 Dec 2023 04:09:10 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFW67-00050j-NK for submit@debbugs.gnu.org; Tue, 19 Dec 2023 04:09:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFW5z-0003mj-MM for guix-patches@gnu.org; Tue, 19 Dec 2023 04:08:59 -0500 Received: from 7.mo560.mail-out.ovh.net ([188.165.48.182]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFW5y-0006Pd-2Y for guix-patches@gnu.org; Tue, 19 Dec 2023 04:08:59 -0500 Received: from director4.ghost.mail-out.ovh.net (unknown [10.108.17.154]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 2CCF52C233 for ; Tue, 19 Dec 2023 09:08:54 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-zpf47 (unknown [10.110.178.126]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id DBF301FE64; Tue, 19 Dec 2023 09:08:53 +0000 (UTC) Received: from ngraves.fr ([37.59.142.106]) by ghost-submission-6684bf9d7b-zpf47 with ESMTPSA id yvz2MqVdgWXtMgAAom12ow (envelope-from ); Tue, 19 Dec 2023 09:08:53 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-106R006b74640e5-b7ef-4115-acf3-9b2997a8e00c, 0A183DEDD9F7D7733B4F13041BD52F66DC821FED) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 81.67.140.142 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH] build-system/composer: Do not try to delete-duplicates. Date: Tue, 19 Dec 2023 10:08:47 +0100 Message-ID: <20231219090848.13042-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6748081093695824605 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrvddutddgtdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepkeffgeetfffgffejgeejvdffgfdtvdeuueetgfefuedvjeegvdegjeejveeuueevnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugedtrddugedvpdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehguhhigidqphgrthgthhgvshesghhnuhdrohhrghdpoffvtefjohhsthepmhhoheeitddpmhhouggvpehsmhhtphhouhht Received-SPF: pass client-ip=188.165.48.182; envelope-from=ngraves@ngraves.fr; helo=7.mo560.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: ludo@gnu.org, ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * guix/build-system/composer.scm (create-autoload): Do not use the delete-duplicates function, stale code that should have been removed in an earlier cleanup. Change-Id: I778c1cfba7ef8de16a1ba297b583595b391b7e00 --- guix/build/composer-build-system.scm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/guix/build/composer-build-system.scm b/guix/build/composer-build-system.scm index 8896384e0a..8d7d43236e 100644 --- a/guix/build/composer-build-system.scm +++ b/guix/build/composer-build-system.scm @@ -191,13 +191,11 @@ (define* (create-autoload vendor composer-file inputs #:key dev-dependencies?) (cons* (string-join (string-split key #\\) "\\\\") (append-map (lambda (v) (list vendor v)) vals))))) (_ (format #t ""))) - (delete-duplicates - (append - (composer-autoload-psr-4 autoload) - (if (and dev-dependencies? (not (null? autoload-dev))) - (composer-autoload-psr-4 autoload-dev) - '())) - '())) + (append + (composer-autoload-psr-4 autoload) + (if (and dev-dependencies? (not (null? autoload-dev))) + (composer-autoload-psr-4 autoload-dev) + '()))) (for-each (lambda (psr0) (match psr0 -- 2.41.0 ------------=_1720800662-21243-1--