GNU bug report logs - #67882
29.1.90; Registers' preview can delete existing window when finishing

Previous Next

To reply to this bug, email your comments to 67882 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1.90; Registers' preview can delete existing window when finishing
Date: Mon, 18 Dec 2023 20:18:55 +0200

Set up:

(defun split-window-prefer-side-by-side (&optional window)
  (let ((split-height-threshold (and (< (window-width window)
                                        split-width-threshold)
                                     split-height-threshold)))
    (split-window-sensibly window)))

(setq split-window-preferred-function 'split-window-prefer-side-by-side)

Split the frame, e.g. 'C-x 3'.

Then create some register (e.g. using 'C-x r C-@') and then invoke
another command reading it. E.g. 'C-x r j'.

Wait the necessary 1 second for the preview to appear - it will use one
of the existing windows to show the list of registers.

Then, whether you choose the register, or C-g out of the choice, the
window used to display the list will be deleted.

Previously mentioned in bug#66394.

Not a regression on master, just reproduced it in 29.

Message #8 received at 67882 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 67882 <at> debbugs.gnu.org
Subject: Re: bug#67882: 29.1.90; Registers' preview can delete existing
 window when finishing
Date: Mon, 08 Jan 2024 14:36:37 +0000

[Message part 1 (text/plain, inline)]

Hello Dmitry,

is the attached patch fix this issue for you?

Thanks.

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> Set up:
>
> (defun split-window-prefer-side-by-side (&optional window)
>   (let ((split-height-threshold (and (< (window-width window)
>                                         split-width-threshold)
>                                      split-height-threshold)))
>     (split-window-sensibly window)))
>
> (setq split-window-preferred-function 'split-window-prefer-side-by-side)
>
> Split the frame, e.g. 'C-x 3'.
>
> Then create some register (e.g. using 'C-x r C-@') and then invoke
> another command reading it. E.g. 'C-x r j'.
>
> Wait the necessary 1 second for the preview to appear - it will use one
> of the existing windows to show the list of registers.
>
> Then, whether you choose the register, or C-g out of the choice, the
> window used to display the list will be deleted.
>
> Previously mentioned in bug#66394.
>
> Not a regression on master, just reproduced it in 29.
>
>
>
>

-- 
Thierry

[0001-Fix-window-setting-in-register-preview-bug-67882.patch (text/x-diff, attachment)]

Message #11 received at 67882 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Thierry Volpiatto <thievol <at> posteo.net>
Cc: 67882 <at> debbugs.gnu.org
Subject: Re: bug#67882: 29.1.90; Registers' preview can delete existing window
 when finishing
Date: Wed, 10 Jan 2024 03:46:58 +0200

Hi Thierry,

On 08/01/2024 16:36, Thierry Volpiatto wrote:
> Hello Dmitry,
> 
> is the attached patch fix this issue for you?

That seems to do it. Thanks!

Message #14 received at 67882 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 67882 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#67882: 29.1.90; Registers' preview can delete existing
 window when finishing
Date: Wed, 10 Jan 2024 10:08:49 +0000

[Message part 1 (text/plain, inline)]

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> Hi Thierry,
>
> On 08/01/2024 16:36, Thierry Volpiatto wrote:
>> Hello Dmitry,
>> is the attached patch fix this issue for you?
>
> That seems to do it. Thanks!

Great! Eli no objections to merge this patch in master?

-- 
Thierry

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 67882 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Thierry Volpiatto <thievol <at> posteo.net>
Cc: dmitry <at> gutov.dev, 67882 <at> debbugs.gnu.org
Subject: Re: bug#67882: 29.1.90; Registers' preview can delete existing
 window when finishing
Date: Wed, 10 Jan 2024 15:26:25 +0200

> From: Thierry Volpiatto <thievol <at> posteo.net>
> Cc: 67882 <at> debbugs.gnu.org,eliz <at> gnu.org
> Date: Wed, 10 Jan 2024 10:08:49 +0000
> 
> Dmitry Gutov <dmitry <at> gutov.dev> writes:
> 
> > Hi Thierry,
> >
> > On 08/01/2024 16:36, Thierry Volpiatto wrote:
> >> Hello Dmitry,
> >> is the attached patch fix this issue for you?
> >
> > That seems to do it. Thanks!
> 
> Great! Eli no objections to merge this patch in master?

No objections, please go ahead, and thanks.

Message #20 received at 67882 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: dmitry <at> gutov.dev, 67882 <at> debbugs.gnu.org
Subject: Re: bug#67882: 29.1.90; Registers' preview can delete existing
 window when finishing
Date: Wed, 10 Jan 2024 16:05:27 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Thierry Volpiatto <thievol <at> posteo.net>
>> Cc: 67882 <at> debbugs.gnu.org,eliz <at> gnu.org
>> Date: Wed, 10 Jan 2024 10:08:49 +0000
>> 
>> Dmitry Gutov <dmitry <at> gutov.dev> writes:
>> 
>> > Hi Thierry,
>> >
>> > On 08/01/2024 16:36, Thierry Volpiatto wrote:
>> >> Hello Dmitry,
>> >> is the attached patch fix this issue for you?
>> >
>> > That seems to do it. Thanks!
>> 
>> Great! Eli no objections to merge this patch in master?
>
> No objections, please go ahead, and thanks.

Done, thanks.

-- 
Thierry

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.