GNU bug report logs - #67867
[PATCH shepherd] service: fix ownership+permissions on Unix sockets

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ulrich Baum <ulrich.baum <at> ubaum.de>
Subject: bug#67867: closed (Re: bug#67867: [PATCH shepherd] service: fix
 ownership+permissions on Unix sockets)
Date: Tue, 19 Dec 2023 22:40:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#67867: [PATCH shepherd] service: fix ownership+permissions on Unix sockets

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67867 <at> debbugs.gnu.org.

-- 
67867: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67867
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ulrich Baum <ulrich.baum <at> ubaum.de>
Cc: 67867-done <at> debbugs.gnu.org
Subject: Re: bug#67867: [PATCH shepherd] service: fix ownership+permissions
 on Unix sockets
Date: Tue, 19 Dec 2023 23:38:57 +0100

Hi Ulrich,

Ulrich Baum <ulrich.baum <at> ubaum.de> skribis:

> Previously, ownership and permissions of AF_UNIX sockets created by
> make-inetd-constructor and make-systemd-constructor were not set,
> leaving the socket with root:root and 755 permissions.
>
> modules/shepherd/service.scm (endpoint->listening-socket): fix chown and
> chmod calls

[...]

>         (when (= AF_UNIX (sockaddr:fam address))
> -         (chown sock owner group)
> -         (chmod sock #o666))
> +         (chown (sockaddr:path address) owner group)
> +         (chmod (sockaddr:path address) #o666))

Good catch!  I was surprised that fchown(2) and fchmod(2) silently did
nothing, but that’s how it is.

Pushed together with a test, which allowed me to find a related bug
(more serious, because it’s about permissions on the socket’s
directory):

  9dfeb4e support: ‘mkdir-p’ sets permissions when directory already exists.
  f5b7411 service: Really set ownership and permissions on Unix sockets.

(BTW, I have just renamed ‘master’ to ‘main’, but ‘master’ hasn’t been
deleted yet from the server; make sure to pick ‘main’ and adjust your
Git config.)

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Ulrich Baum <ulrich.baum <at> ubaum.de>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH shepherd] service: fix ownership+permissions on Unix sockets
Date: Sun, 17 Dec 2023 14:38:12 +0100 (CET)

Previously, ownership and permissions of AF_UNIX sockets created by
make-inetd-constructor and make-systemd-constructor were not set,
leaving the socket with root:root and 755 permissions.

modules/shepherd/service.scm (endpoint->listening-socket): fix chown and
chmod calls
---
 modules/shepherd/service.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm
index 41c6248..f22aaaf 100644
--- a/modules/shepherd/service.scm
+++ b/modules/shepherd/service.scm
@@ -1867,8 +1867,8 @@ retrying to bind it in one second.")
        (listen sock backlog)

        (when (= AF_UNIX (sockaddr:fam address))
-         (chown sock owner group)
-         (chmod sock #o666))
+         (chown (sockaddr:path address) owner group)
+         (chmod (sockaddr:path address) #o666))

        sock))))

--
2.43.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.